commit 5de9c50b0353f10b2fd7b1a6980c37bd7cb1b4dc
Author: Alexander Akulich <akulichalexander@gmail.com>
Date: 2019-09-15 13:24:47 +0300
5.16.5
commit e3eb6c5a7a374667b2a57f517d449a7d48f56c0a
Author: Alexander Akulich <akulichalexander@gmail.com>
Date: 2019-09-15 15:46:16 +0300
Port make-release-mail.py to Python 3
commit dcfefa39427f433d7ea499d25be6bd242ee0b1b5
Author: Alexander Akulich <akulichalexander@gmail.com>
Date: 2019-09-15 15:35:44 +0300
Tools: Remove unused gquark-gen.py
commit f44db86a6619f4c97b7b8e5819c885ac9f8893b0
Author: Alexander Akulich <akulichalexander@gmail.com>
Date: 2019-09-15 02:33:58 +0300
Tools: Remove glib-signals-marshal-gen
See commit d70ba9ba46ea037b8003efc27de7f8c2d067befa in telepathy-glib.
See also: https://bugs.freedesktop.org/show_bug.cgi?id=46523
commit 23a212f0b3201e34e7a4f3b3ba3b916e1e379bcc
Author: Alexander Akulich <akulichalexander@gmail.com>
Date: 2019-09-15 14:37:53 +0300
Sync tools from telepathy-glib
commit 825aa93ea15a24fe6f0ac2c2da0d0b6b1cc2abab
Author: Alexander Akulich <akulichalexander@gmail.com>
Date: 2019-09-15 14:26:33 +0300
Update telepathy.am from telepathy-glib
maintainer-prepare-release: do "git tag" in srcdir
commit 8d2b3cc9c978b079f74032717532165c65b321cb
Author: Alexander Akulich <akulichalexander@gmail.com>
Date: 2019-07-06 15:38:31 +0300
McdAccount: Fix memory leak in get_parameter_of_known_type()
Based on a commit by Slava Monich <slava.monich@jolla.com>
commit 31268fec582776593e54c10c862d9f7af7b3153c
Author: Martin Klapetek <martin.klapetek@gmail.com>
Date: 2015-07-08 20:04:57 +0000
Fix autoconnection of accounts with always_dispatch=true
https://bugs.freedesktop.org/show_bug.cgi?id=91272
commit 19f10ec2a59cadd4c59d6bc3147c612007c1c615
Author: Tiago Salem Herrmann <tiagosh@gmail.com>
Date: 2017-01-25 15:30:04 -0200
Fix string max size calculation.
Reviewed-by: George Kiagiadakis <gkiagia@tolabaki.gr>
https://github.com/TelepathyIM/telepathy-mission-control/pull/1
commit 6077a834bab2c725d7f55378e7f39c1f1d409eaa
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-09-02 22:53:49 +0300
nano flag
commit 74d553d4125224f0a95c9d2843d38861b42eae9f
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-09-02 22:27:30 +0300
5.16.4
commit f576a9e8a125c16e3a562e3bb820707c1041af5c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2014-03-20 12:53:39 +0000
dispatcher_delegate_channels: initialize am
Otherwise, if we "goto error" too soon, we'll try to g_object_unref
uninitialized memory. gcc doesn't spot that because we're using
tp_clear_object, which uses an intermediate variable, and it doesn't
propagate "uninitializedness" through assignments.
commit 43afd2866bc38efe1b2cf27989df4e36ddd21201
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2014-03-20 12:51:18 +0000
fix memory leaks: dbus_g_method_get_sender returns a copy
We were semi-consistently using it wrong.
commit e49b61b4e0f94f2e740ff5a0d231b43f37ab7d1b
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-09-01 21:50:50 +0300
Update NEWS
commit 6a93bfeab23d64216cb5084f2d63c18f12ab6844
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-09-01 21:19:34 +0300
tests: fix race condition in account-manager/avatar.py test
It seems that the order of the dbus signals is unpredictable,
so requiring it in the test sometimes makes it fail. It also
seems that the other checks above in the same unit test have
the same logic of not expecting a certain order in signal emission,
so this is probably the right thing to do.
commit 78d8c53b930323455bb7c4031903f46717b8a174
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-08-15 11:37:24 +0300
tests: make tests work again when NM support is enabled
Apparently the nm library also tries to access the /.../Settings
object of NM, which was not available in our fake NM implementation.
This commit implements the basic properties of the Settings object,
which allows the tests to continue past this point.
https://bugs.freedesktop.org/show_bug.cgi?id=96917
commit c5589bdc4ded0382adf6ba9ffc5c27f8a6e0568d
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date: 2016-01-11 15:07:56 +0800
mc-wait-for-name: Call setlocale in main function
It is required to correctly show translated messages on some locales.
https://bugs.freedesktop.org/show_bug.cgi?id=93661
commit cbe4ec1a4e1167ce8231849bcbbdec44d48422f2
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-07-13 17:34:39 +0300
configure: do not enable upower support if upower is >=0.99
The code doesn't compile anymore, the features used have been removed.
The replacement is logind, for which support exists in MC since 5.15.1.
https://bugs.freedesktop.org/show_bug.cgi?id=70458
commit e732563380bda697c468b591ed126932b022d97f
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-07-01 18:43:28 +0300
configure: bump glib version requirement to 2.46
required for the fake-network-monitor in the unit tests
https://bugs.freedesktop.org/show_bug.cgi?id=96763
Reviewed-by: Diane Trout <diane@ghic.org>
commit d3e011a2dfaf6ecb41651de7ccc0d2bb520f3208
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-07-01 18:31:21 +0300
tests/twisted/fake-network-monitor: implement the "network-metered" and "connectivity" properties of GNetworkMonitor
"connectivity" is required since glib 2.44
"network-metered" is required since glib 2.46
https://bugs.freedesktop.org/show_bug.cgi?id=96763
Reviewed-by: Diane Trout <diane@ghic.org>
commit 20dc94875afecacf086e57f67447e9384fb85d90
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date: 2016-02-26 22:32:28 +0800
Don't initialize function pointers with G_TYPE_INVALID
https://bugs.freedesktop.org/show_bug.cgi?id=94310
Reviewed-by: George Kiagiadakis
commit 497e26593446d343105f594997ef0689aac4be4f
Author: George Kiagiadakis <gkiagia@tolabaki.gr>
Date: 2016-07-01 16:04:36 +0300
connectivity-monitor.c: fix unused variable warning when compiling without nm support
This GError variable is not used anywhere else in this function.
commit 91499340222a563bacce7994f32275c38ff55ff0
Author: Diane Trout <diane@ghic.org>
Date: 2016-06-29 22:37:24 -0700
libnm-glib is deprecated and may not be available.
This patch switches to use th enew libnm API, also snice nm_client_new
now takes a GError, I thought I'd report the error message if mission
control can't connect to the network manager.
Additionally we can remove a definition of the NM_CHECK_VERSION
macro for old versions of NM, as well as a guard for the
NM_STATE_DISCONNECTING constant.
commit 3d3a13c561e858853af5c601373be3ea0746f58c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2014-08-28 14:19:30 +0200
server: exit early if we failed to create McdService
mcd_service_new() can return NULL if we didn't manage to connect to D-Bus.
Best to handle this gracefully rather than crashing horribly.
This is the top crasher on Ubuntu btw.
https://errors.ubuntu.com/problem/7e2a5f9a379f34a347895782ae948177926a1932
commit 8f5a4fb823c1334e6d845aaa0c57f0fcffa42635
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2014-08-25 14:47:50 +0200
nano flag
commit 84dc7d0fd952a9ef3d200ac5557cdf2daccca145
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2014-08-25 14:34:18 +0200
5.16.3
commit ab29ae42f751bf7e4ecc9a601e09cafab499fd14
Author: Steffen Kieß <Steffen.Kiess@ipvs.uni-stuttgart.de>
Date: 2014-08-25 14:11:35 +0200
mcd-connection: use tp_asv_new() properly
The second argument has to be the type of the value.
https://bugs.freedesktop.org/show_bug.cgi?id=81751
commit 810b32e92f2896a1ad8ee204bf6b8d5456a5db08
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2014-06-11 15:50:37 +0200
nano flag
commit fb8000842e0b20f4aa4928edd62736b5cea2e8d5
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2014-06-11 15:44:01 +0200
5.16.2
commit 42c485ff56f5425cd592ae73c1c0e6c0f1de2b13
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2014-06-11 10:15:05 +0200
mcd_account_delete: make sure that the account stays alive
Fix a regression introduced when backporting fix for
https://bugs.freedesktop.org/show_bug.cgi?id=79827
commit 224443c1843ab0df7ef8ee1eda0409c35a4745a9
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2014-06-09 15:39:23 +0200
mcd-account: unregister the account once we're done deleting it
The McdAccount object may still be alive for a short while because of pending
async operations. We want to get rid of the D-Bus object as soon as possible
and so, for example, a new Account object replacing the deleted one can be
created.
Fix https://bugs.freedesktop.org/show_bug.cgi?id=79827
commit 9c8e148e3ba00e53d0323aa75bdf6a5528968554
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2014-06-09 15:34:13 +0200
use G_STRFUNC in mission-control-plugins's DEBUG macro
It's more useful when reading logs than G_STRLOC and that's what we already
use in src/mcd-debug.h
commit c86536f3b5fcc21eac60a836954d1aa002b67cc0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2014-01-30 13:04:56 +0000
codegen: avoid generating more than one thing in the same command
As with telepathy-glib commit 36c2a545c9, a rule like this:
_gen/x.c _gen/x.h: prerequisites
$(AM_V_GEN)x-generator
doesn't consider x.c and x.h together. Instead, it expands to two rules,
one to generate x.c and one to generate x.h, which happen to run the
same commands.
This means that in the worst case, you can end up running x-generator
twice in parallel, and they'll race with each other and overwrite or
delete each other's output.
Updated version of a patch from Ross Burton, taking into account that
we now generate a separate header for the gtk-doc. I use the gtk-doc
header as the one that "matters", because it's the last to be generated.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69446
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit d4471ccad3163ee33fe5b5bd5947ca47ad01158a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2014-01-29 19:24:54 +0000
NEWS
commit a4bcc16f16f72d7a2b8fe74e715183b7b6985427
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2014-01-28 16:28:16 +0000
mc-tool: fix setting automatic presence
We were using the wrong finish-function.
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=74187
commit 84f1f56a114738c622bcd926868f5c232b3e6d8c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2014-01-28 11:08:33 +0000
start 5.16.2
commit 53f6d1cf3fecd6667591a43bf511518f5a4b345f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2014-01-27 14:51:36 +0000
forgot a NEWS entry
commit 4eb0184ff5c7020cfcbada0ee66e4336158fc49e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2014-01-27 12:25:18 +0000
5.16.1
commit 4d107b2c4b2a5161b6e113fb60e283017b700255
Author: Michael Kuhn <suraia@ikkoku.de>
Date: 2014-01-22 09:56:02 +0100
Release inhibitor on sleep and shutdown.
Also fix a memory leak in login1_inhibit_cb.
[The intention was to hold one "ref" to the inhibit fd for each
connection that was waiting to disconnect, plus one "ref" for the
idle state of "waiting to be notified by logind". We correctly took
one "ref" per connection, but did not release the extra one. -smcv]
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=73599
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 07955827bba3ed6a6426ca4f2cb32efef2dc04c0
Author: John Brooks <john.brooks@jollamobile.com>
Date: 2013-12-12 15:46:27 -0700
Prevent assert for offline accounts with power saving
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=72652
commit 0932dba29fa9de8e7268a924c4c93ccebb7dc65c
Author: Sebastien Bacher <seb128@ubuntu.com>
Date: 2013-12-04 18:34:30 +0100
reset the error to NULL, so the next call is working
[fixed argument type -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=72138
commit 51eb9027ec1b72591166ecde65793c9f5877ac16
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2013-11-26 10:19:54 +0100
connectivity-monitor: start watching 'use-conn' key in constructed
We have to wait for the default GObject properties to be set before calling
g_settings_bind(). If we don't, they override the value fetched from
GSettings.
commit f1de10a0f71638da502a77cae189b5fa6a047be6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 18:48:17 +0100
5.16.0+
commit 739b5414ec3fe1fc7896d34f09f510a9e8029473
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 17:54:18 +0100
5.16.0
commit 52a6ac31f6d3b52332f6678c67c0c6013adf4c17
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 17:40:58 +0100
Upload documentation to the 5.16.x location
commit 9d74acccde6b41a9e06c115def43bbea77efacf9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 17:40:57 +0100
Don't warn on deprecated declarations, this is a stable branch.
commit 41f675da7cd97b9a3771881c22788e73eb99f99a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 17:41:55 +0100
Don't check documentation completeness in this stable branch
commit 17a5d31769e9da52797df968c8881732f29d0f45
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 16:33:42 +0100
NEWS: adjust note about ServerAuthentication handlers
rishi pointed out on IRC that ServerAuthentication still makes
passwords available to eavesdroppers on the session bus (if LOGIN,
PLAIN or X-TELEPATHY-PASSWORD are used). ServerAuthentication doesn't
allow arbitrary applications to ask MC "what is the password for
account X?", which is what I was thinking of.
The session bus is not generally modelled to be a security
boundary; if yours is, you will need to write a security policy,
then ensure that that policy is applied. Telepathy components are not
designed to be used unmodified on an untrusted session bus. (Starting
points include turning off eavesdropping, applying a "default-deny"
policy, preventing processes other than Mission Control from
calling HandleChannels on your ServerAuthentication client, and
preventing processes from subverting each other with ptrace.)
commit d0af8d654ae439a1a333c33f6e44084d3dad2afb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 13:44:10 +0100
avatar-refresh test: subsume avatar-persist, and test more situations
We have some sort of combinatorial explosion going on here, and it
seems best to test it in a somewhat systematic way:
* is the protocol one where avatars persist on the server (Gabble)
or not (Salut)?
* if it's like Gabble, does it download our own avatar token
before signalling CONNECTED (as I suspect Haze does), or
on-demand after GetKnownAvatarTokens (as Gabble appears to)?
* if it's like Gabble, is the server storing an avatar for us?
* in either case, do we have an avatar stored locally, and has
it previously been uploaded or not?
In addition, the avatar-refresh and avatar-persist tests exercised
migration from ~/.missioncontrol and a low-priority XDG_DATA_DIRS entry
(respectively) to ~/.local/share. I didn't do that in a loop, because
it isn't applicable in all cases and would lead to even more
combinations - testing each case once should be enough.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69885
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
[cherry-picked from master commit d780671 plus the test part of
4f4ed24, adjusted for old constant naming and to replace
unforbid_all() with unforbid_events() -smcv]
Conflicts:
tests/twisted/account-manager/avatar-persist.py
tests/twisted/account-manager/avatar-refresh.py
commit b89f6fe0bcacef9340f633ab09b275122c6db644
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 13:08:45 +0100
Implement Contacts properly on SimulatedConnection, and fix tests
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69885
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
[Cherry-picked from commit 15510bd on master. -smcv]
Conflicts:
tests/twisted/constants.py
tests/twisted/mctest.py
commit 54b9660d32a611100b87fedde559ebb1d4ec35a5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-10-02 12:58:31 +0100
McdAccount: go back to using GetKnownAvatarTokens
Sadly, contact attributes aren't enough to distinguish between
"this protocol doesn't store avatars and you haven't re-sent your
avatar since you last connected", "this protocol stores avatars but
the CM hasn't checked for your current avatar yet", and "this protocol
stores avatars, but there is no avatar on the server for you".
GetKnownAvatarTokens specifically excludes the middle option (blocking
on a server round-trip if it needs to), and uses "avatar token missing"
for the first and "avatar token empty" for the last.
Tested to work with the telepathy-glib 0.20 branch, and with the 0.22
branch when fdo#70010 is fixed.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69885
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
[This is a cherry-pick of commit 4f4ed24 from master, omitting the
regression test change, to make sure the existing tests still pass -smcv]
commit 9fa3c65e038f66dcf4c28bd10a26680229c2843c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-20 12:59:50 +0100
Update extension interfaces to their telepathy-spec 0.27.1 versions
No functional changes.
The remaining interfaces (A.I.Conditions, CD.I.Messages) are still
not in telepathy-spec at all. :-(
commit 6a24c5e5d0a95dd11b82956c1186092bab617701
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-20 12:54:38 +0100
Update CHECK_FOR_UNRELEASED to check the right files
commit 972b515a0294d78c7a34dfe8ebd0f6a8e6f415e7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-20 12:53:28 +0100
Fix a wrong deprecation annotation
commit 439309bfede3afe68469f39bbde332ff5f668ba6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-20 12:49:27 +0100
Document the new test logging arrangement
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585
commit 089c6a1562a74b86f7e60c87d43abc1c7a6cb446
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-19 19:41:27 +0100
connectivity test: make sure we've caught up on GDBus messages
Otherwise, the message from the FakeNetworkMonitor saying we've gone
offline might not be received until after the message from the fake NM
saying we've gone online - which would be a problem. There's no
side-effect we can wait for here, so we just have to make sure the
GDBus queue has been processed.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit eb6a6bf52c1ed476f6dab871cad491d3fff5c8f5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-19 19:39:24 +0100
connectivity_monitor_nm_state_change_cb: if NM says DISCONNECTED, believe it
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 5336208b2848c810c0e9168cc629f9a63593f9ac
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-19 19:44:03 +0100
Log verbose test output and give it the same treatment as MC's log
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 38bbbf49bd1e357d1a4a9e6508c718c5edb9baf7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-19 18:48:38 +0100
run-test.sh.in: dump logfiles to stdout on failure
This is a lot of very spammy output, but the failures are basically
undebuggable without it, so...
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 83d08c87a251824f6f5f52037e1f79587bc9446c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-19 19:43:29 +0100
run-test.sh.in: now that we run under 'set -e', catch failures
If we just let with-session-bus.sh exit nonzero, the script aborts.
We want to catch the nonzero exit status and do some more things
before failing.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 79e1df1b5818e3bb323b040a708f3d91d616d2d6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-19 15:22:25 +0100
Nano version
commit 2bd064c78030932544ceca652510c526f6f001dd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-19 14:37:22 +0100
5.15.1 (5.16 rc1)
commit c3cba937c429b7121270b19734a669211bebba19
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-19 14:22:13 +0100
Put Autoconf, Automake, Libtool droppings in /build-aux
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 04a2f757879caf21d474c03a5728ec5e1ffe7c29
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 19:42:56 +0100
document MC_TEST_KEEP_TEMP
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 3dcc0f4ebb90b80c8ee39794a65e906013d692a5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 19:23:52 +0100
mcd_account_self_contact_upgraded_cb: don't crash on bad timing
If the account is disconnecting, we might get the callback for
upgrading after we've already NULLed out self->priv->self_contact.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit af998be5e6638671d05097176c7405258b30e315
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 19:04:40 +0100
tests: cd into the directory from which we were run
dbus-daemon does a chdir("/") for activated services. We want to
undo that, and put our logs (and core dumps, if any) in a more
obvious place.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit cfb5810baf0b6f28223d2ebf7b9c20eddf2940cf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 17:00:35 +0100
Tests: clean up all built sources
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 545ffc1f455a14bea9f77497a009ec6811bae6c7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 16:00:49 +0100
tests: write logs to MC_TEST_LOG_DIR, with latest log in `pwd`
This makes the logs' location rather more obvious. Not altering MC's
working directory also means the core dump (if any) comes out in
tests/twisted, which makes sense, instead of tests/twisted/tools,
which doesn't.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 30dc2928196aefd112db7047a98900c047f27bae
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 15:07:33 +0100
run-mc.sh.in: set DBUS_SYSTEM_BUS_ADDRESS
This is used in the "installed" case, and this change is necessary to
catch up with exec-with-log.sh.in in the "uninstalled" case. We want
to use the fake NetworkManager, ConnMan etc., not the real ones.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 1978058f83f3bb30196985302fd917cb43473cfa
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 15:27:42 +0100
Always use run-test.sh to run tests
There are three modes here:
- make check: run tests in ${srcdir} against MC in ${builddir}
- make installcheck: run tests in ${srcdir} against MC in
${DESTDIR}${prefix}
- ${mctestsdir}/twisted/run-test.sh: run tests in ${mctestsdir}
against MC in ${prefix}
Also simplify the last of those cases, and avoid a potential symlink
attack, by requiring that the current working directory for run-test.sh
is a directory controlled by us. In practice we already required that,
because with-session-bus.sh creates files in the current directory.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 2d769630290d17c20c0db1e32c61a725c6559fb7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 12:39:04 +0100
installcheck-twisted: test the just-installed MC if using a DESTDIR
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 12ecdbabc19628e19109666d8534ce6d99035a95
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 12:45:29 +0100
Ignore /test-driver, installed by Automake 1.13
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit cc2af09f608511bf316e94e4462ff041406c455b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-18 14:07:57 +0100
Flag printf-ish functions with G_GNUC_PRINTF and fix resulting warnings
In particular, mcd-account-manager-default could crash when migrating
an account, since it would dereference arbitrary stack contents
as a pointer-to-string.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit fe1e8ce4b830f665fbe098b1928969d26c553441
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-10 12:00:14 +0100
_mcd_channel_depart: use tp_channel_leave_async or tp_channel_close_async
This avoids some deprecated APIs, and is considerably simpler.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55392
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 966ca2d58f87f9cfa7b1551885dd2f160971e19b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-09 18:19:58 +0100
Switch from tp_g_key_file_get_[u]int64 to g_key_file_get_[u]int64
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69146
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 9219b4282cc9c6465dc1f9efd9e549c97bc6e3a9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-09 17:21:47 +0100
Service points: use tp_connection_dup_contact_by_id_async
tp_connection_request_handles is deprecated. Ideally, we should drop
this whole chunk of code, but it seems best to save that for
Telepathy 1.0.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 74744b3a1b792895089d5104109e3b56eeedea11
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-09 17:19:58 +0100
McdConnection: use tp_simple_client_factory_ensure_connection
This means we need to pass the client factory through the McdManager
from the McdMaster, so, do.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit a9afabf2a6219f27038b34e29d36cc20dd2965eb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-02-13 15:01:54 +0000
Deprecate mcp_dispatch_operation_leave_channels
It was designed for StreamedMedia, and is the wrong thing for Call.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 9becae7459f2762217f08eadc53ac0f9a85ab693
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-03 19:44:08 +0100
List Service and Hidden in create-time account properties
Also test them.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33127
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 82abc7249f071d86b3ac7b9e5a7f9815372c041b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-05 15:31:29 +0100
Remove further remnants of gnome-keyring support
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32578
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit a7d10e5e24129a608d3d3f00cfdeae67c9f745be
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-05 15:07:10 +0100
NEWS
commit 05fcc81b1684975e9d20a4ecba55f46b11ccd7e8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-05 15:01:02 +0100
drop unused variables
commit b0eedd06b5b9f51de060d91ca6eab0c3d2061d09
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-28 14:44:58 +0100
Remove gnome-keyring support
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32578
Reviewed-by: Marco Barisione <marco.barisione@collabora.co.uk>
commit 0c905a9ad4f3a90ed97e16a360097f17be777887
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-08 19:34:22 +0100
Add a regression test for service-points (matched by identifier)
The side-effect they have within MC is that plugins aren't allowed to
delay or reject channel requests; we ought to test that, really.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55773
Reviewed-by: Marco Barisione <marco.barisione@collabora.co.uk>
commit 8198d1ec4a318338d02800cf6d021734e7590daa
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-08 19:33:15 +0100
McdConnection: build up our sets of emergency numbers over time
To facilitate this, use nicer data structures.
Most importantly, this means we don't critical whenever we get more
than one distinct service point, as Jonny noticed while porting to
Telepathy 1.0. It might slightly defeat the intention of the
ServicePointsChanged signal, but in practice the list is probably
never going to shrink, and if it does, it's probably wise to
keep considering its old members to be an emergency number (the effect
that that has is that plugins aren't allowed to influence channel
requests).
Also, don't leak the sets of emergency numbers when finalized.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55773
Reviewed-by: Marco Barisione <marco.barisione@collabora.co.uk>
commit edf39cf46747c269dcd1470b92185601fb898f99
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-04 13:36:09 +0100
Drop fake-network-monitor.h from SOURCES
It doesn't exist, and breaks distcheck.
commit 2f3f113042ad117f35e2ebb2a26556b2c550e8af
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-28 15:36:14 +0100
Add a regression test for a "no SimplePresence" special case
CurrentPresence should toggle between OFFLINE and UNSET if the account
has no concept of presence.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68905
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 6e88e909f5f1cb4b0f0d33f88b26f5cb6d3fc9c7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-28 15:35:38 +0100
Track presence via TpContact, not McdConnection
Now that McdAccount has a TpContact for the self-contact, this is
really easy.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68905
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit c5e96690fd558b4de8de794bce04fb3937b03799
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-03 19:16:32 +0100
Add CONNECTIVITY_NONE, and make state transitions clearer
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68758
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 425a6cb46cabf35bde272f99c5b8260b29a70201
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-03 19:06:06 +0100
McdConnectivityMonitor: comment how McdInhibit works
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68758
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 3a2a10d424c3033aabd5eb830321cfad852077ae
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-02 15:24:22 +0100
Listen to systemd sleep/shutdown signals, and inhibit until disconnected
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68758
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit d50b659542f829ccd411828a35a53c5f4678c581
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 16:55:06 +0100
Remove unused signal McdAccount::connection-process
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 7220e55986ca13ac14bb56bae51986e21be892af
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 16:53:47 +0100
Remove the remains of McdTransportPlugin
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit ea78c344fce0373188ac5549f664da0a6de1f500
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 16:48:40 +0100
_mcd_master_account_replace_transport: inline into caller and simplify
There's only one transport plugin, it only has one transport, and
its state is basically boolean, so we can delete a lot of code.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 3ec7b1947bf5c595edc1f2329aa6ce7b9feda816
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 16:41:54 +0100
mcd_master_connect_automatic_accounts: move to McdAccountManager
Iterating over all accounts? Looks like a job for the account manager.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit cb99598acaa71edd6efcedadaaff3103acf76571
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 16:41:22 +0100
McdAccount: respond to connectivity status changes
Instead of proxying through the transport plugin and the McdMaster, just
watch the McdConnectivityMonitor. Much simpler!
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 1ed0e969eadfa4a5c9d7e3156413588d6b083d09
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 16:28:45 +0100
Move "waiting for connectivity" functionality into McdAccount
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit e076d7f16e23cd7246a20a45164a71d9e53058af
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-03 18:40:06 +0100
McdAccount: have a reference to the connectivity monitor
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit e2bcc5b94496d755c28490f28925da6f54a4cf4d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-03 18:39:36 +0100
Put the connectivity monitor in the McdAccountManager
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 957795838715b3b95f2bf8bc116b2328bf6a2881
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 15:38:53 +0100
Remove the concept of binding accounts to transports
We only have one transport now, so there are two options: either the
account is a special one that "needs dispatch" and also bypasses the
transport check (in practice this means cellular accounts), or it is
connected via the Internet.
Binding accounts to transports never made a vast amount of sense. If we
have many parallel Internet connections (e.g. wired + wifi + cellular +
VPN), Mission Control can't know which one a Connection is relying on -
only the connection manager can know that - so we have to err on the
side of disconnecting everything on a connectivity change anyway.
A possible refinement in future Tp versions would be a way for a CM
to tell MC "this connection does its own connectivity-monitoring,
so don't kick it when we get disconnected". For now, we assume that
everything needs the Internet, unless it's one of the accounts that
wouldn't previously have been bound to a connection (i.e.
_mcd_account_needs_dispatch() returns FALSE).
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 7c598edf86939a630c9fb51c030bf4d1436e56a6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-28 16:52:04 +0100
mcd_operation_take_mission, _remove_mission: do not be virtual
Nothing overrides them, they're no longer API, and one day I'd like to
get rid of McdOperation entirely.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 0327ccfcf5047aa785f6c127296817d6b7e73c05
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-09-03 18:28:45 +0100
Update NEWS, and note the bug number of an older bug
commit e6974e3dac274982dedcb5451106473dea3294fd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 16:59:08 +0100
McdConnectivityMonitor: take responsibility for monitoring use-conn
I want to get rid of the kludge-transport.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit e9c73ea3f027d2f156bcbcabab722e17221afbed
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-28 17:49:54 +0100
McdMaster: remove support for writing account-manager property
Nothing constructs a McdMaster with a non-default McdAccountManager.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 289c461e9c5020a4da70dc12d066a61af2276b41
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-29 15:22:45 +0100
Remove support for checking conditions on accounts
We no longer have API for external transport providers, and we've never
defined any conditions on the transport provider we do have.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 327f0bd220aacb909e9ecde066121f3ca0f65f35
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-28 16:51:18 +0100
Remove various useless virtual method padding
This part of Mission Control is no longer API.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 3d77940b7b2b7394a695a46efc008dc31e85b45d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-28 16:42:47 +0100
mcd_master_create_manager: unvirtualize
There's no point in this being virtual: there are no subclasses,
and it isn't API any more.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 68f45847f9a3259be4fcb7a8d5647c46109b6c0e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-08-28 16:40:38 +0100
McdMaster: use modern idiom for priv
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 3ad533ac34481c4305a9093687f8042757a6cf96
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-30 17:29:40 +0100
Replace ConnMan connectivity support with GNetworkMonitor
The information we're getting from ConnMan is no more informative
than GNetworkMonitor, and a ConnMan GNetworkMonitor implementation
exists (e.g. <https://github.com/jukkar/connman-network-monitor>),
so we might as well go via that.
On NetworkManager systems, we now use NetworkManager to detect
transient states like DISCONNECTING, but use the GNetworkMonitor
to detect whether the interface is up. If NetworkManager is the only
thing managing an interface, that makes no difference, but if there is
an interface not managed by NetworkManager, the default netlink
GNetworkMonitor will say we're online even while NM is DISCONNECTED,
which is what we want.
On non-NetworkManager, non-ConnMan systems where netlink works,
netlink will tell us at least the basics of what's going on, and we
can avoid trying to connect while there is no Internet route.
On systems without a working GNetworkMonitor, GIO's default
implementation will say "yes, you are online" at all times, which is
no worse than we had previously.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=56635
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 2f94a6529c60cdd01e8418cabfe92fc4bccd6b34
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-30 16:37:28 +0100
Add a fake GNetworkMonitor, using a subset of the ConnMan D-Bus API
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=56635
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit eb0b99097edaa27a381c79733cd121d3ce68565d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-30 16:54:14 +0100
Split connectivity state into the concepts of "up" and "stable"
ConnMan and GNetworkMonitor only give us two states: either we have
some level of Internet connectivity, or we don't. NetworkManager adds
a third category of states (CONNECTING, DISCONNECTING, ASLEEP):
"you might have connectivity, but things are changing, so you might
want to disconnect now". I've represented this as "not stable".
The flag is deliberately "stable", not "unstable", so that all the
boolean flags have the same sense: if they are TRUE, we're
"more connected".
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=56635
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 5dbd8df6bd212ede2075dce3cbf3a6b5ebf4e8d3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-30 17:08:08 +0100
Add a regression test for NetworkManager's "not quite offline" states
We were only testing the intersection of ConnMan and NM functionality,
but NM actually has a bit more.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=56635
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 01ee75652ec19b94681147ec0700d502bafb6e78
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-05-03 15:39:51 +0100
resume development
commit 76c328175300821b1a2554391f0143c4d54fb779
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-05-03 15:02:59 +0100
Prepare 5.15.0
commit 7877d99ed2f9ff2cd0888e8f762ebad932852767
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-05-03 13:01:44 +0100
McdSlacker: don't crash if SessionManager is absent or StatusChanged has no parameters
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=62530
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 1d3403089ab01ff5b5056cd360d5469099d0ff08
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2013-05-02 18:05:50 +0200
McdSlacker: Use org.gnome.SessionManager DBus service
MCE is a long dead Nokia closed source service for Maemo.
This rewrites McdSlacker using GDBus and the much more useful
GNOME SessionManager service. That interface is implemented in
both gnome-shell and unity desktops.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=62530
commit d0419b28aa3ad45fa8f92b477ac65c32012b937b
Merge: d7423ba7 712ddaf9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-05-03 12:28:30 +0100
Merge branch 'telepathy-mission-control-5.14'
Conflicts:
NEWS
configure.ac
commit 712ddaf9b57fdc03e0c6b0b2c45ec04eaf135248
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-05-03 12:25:45 +0100
resume development
commit b613401b8f238ed633e72691d5a6716fdcaf9ee1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-05-03 11:54:47 +0100
Prepare 5.14.1
commit d7423ba7794f57380440ffbf485462653bc060c0
Merge: 7da30dce 57b73f8f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-05-01 20:00:20 +0100
Merge branch 'telepathy-mission-control-5.14'
Conflicts:
NEWS
commit 57b73f8f22f0e7fbc4b37c994ba0c96ec52b8c01
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-05-01 19:55:15 +0100
NEWS for 5.14
commit 9e89a8ed3c54ad4c9ad9cc939c995a7196037889
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-01-16 17:15:01 +0000
Only ignore passwords in gnome-keyring if Empathy has copied them
When passwords are stored in the Parameters by MC and no
SASLAuthentication handler is used, e.g. under Sugar, we currently
save passwords into gnome-keyring, if enabled at compile time; so, we
want to read them back out of gnome-keyring.
This conflicts slightly with wanting to ignore passwords in gnome-keyring
that are left over from an Empathy 3.0 schema migration that failed
due to fd.o #42088. To avoid failure to authenticate/re-prompt if the
password has been changed on the service side, ignore passwords that
are going to be deleted; but to avoid breaking Sugar, don't ignore
any other passwords we might find in gnome-keyring.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=59468
commit 7da30dceb86e3bc38679e18e6deb30e82c877692
Merge: c244460e 07d5735d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-30 13:11:37 +0100
Merge branch 'telepathy-mission-control-5.14'
Conflicts:
NEWS
commit 07d5735d63a0dd1102fcec454159aad36cdbe30a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-30 13:09:05 +0100
NEWS for 5.14
commit 1b45aa774e0869c10275adf5c02b778d48b7a2b7
Author: Nuno Araujo <nuno.araujo@russo79.com>
Date: 2013-01-18 22:47:00 +0100
Fix the build with automake 1.13
In Automake 1.13, the long-deprecated macro AM_CONFIG_HEADER (deprecated
since 2002) has been removed in favour of AC_CONFIG_HEADERS.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=59605
commit c244460e5179ac4089fcb3a2c1c1949fdbf20a35
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-30 12:49:23 +0100
tests: avoid an out-of-range int literal
In this particular test case, the expected result according to the flags
is "it fails", so the second column (expected converted value) is not
relevant.
This apparently causes build warnings (fatal by default) on ILP32
platforms, because 2147483648 is out-of-range for a signed int or
signed long on such platforms. It's certainly also out-of-range for
the struct member it's initializing, which is a gint32.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=64083
commit 305be4e9c3fe0eb04b46ecaee7789935e2445dbd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-30 12:14:03 +0100
NEWS
commit 393d6c8b6e64c487c8a426443d3b285c35093dce
Author: Joshua Lock <joshua.lock@intel.com>
Date: 2013-04-24 16:09:46 -0700
connectivity-monitor: ConnMan Services with ready State are online
A ConnMan Service is connected if it has a State of online or ready.
[This can matter if your only connectivity to the outside world is through
a proxy, in which case the State will remain 'ready' but Telepathy
accounts might be usable anyway. -smcv]
Signed-off-by: Joshua Lock <joshua.lock@intel.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit e7511f28cd233213457f9d712d1441add2500546
Merge: 72cdbb73 cdfea3c5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-04 16:45:46 +0100
Merge branch 'telepathy-mission-control-5.14'
commit cdfea3c5a600a18f2621c6249a374951496685ba
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-04-04 16:43:23 +0100
Merge fd.o #63119 from telepathy-glib
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63119
commit 72cdbb73d092de176fed47508f108fed8d4627c6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-02-13 14:44:51 +0000
More NEWS
commit edd77d23975fabc9a33779cc4011dd84122c9b2e
Merge: 75ce9cdd 0fda3bd4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-02-13 14:36:42 +0000
Merge branch 'altered-one-54780'
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54780
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
[deleted a stray line from a comment as per wjt's review -smcv]
Conflicts:
src/mcd-account.c
commit 75ce9cdd98c102643ff3eddedf4cf328d034d283
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-02-13 14:33:11 +0000
More NEWS for 5.15
commit 16f3e22820de84e7227dee7b85a690bdc1d561e0
Merge: 5aeddb8e 06a09cf7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-02-13 14:20:16 +0000
Merge branch 'mock-account-store-54873'
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54873
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Conflicts:
tests/twisted/account-manager/avatar.py
commit 5aeddb8e0a314780585af7b8f19896a2be9815d4
Merge: 128ceb7d 39759899
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-02-13 14:13:42 +0000
Merge branch 'typed-settings-54872'
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54872
[amended to add GLib 2.32 dependency -smcv]
Conflicts:
src/mcd-account.c
commit 128ceb7d37ff5847a9e79f2bafa6127ae97f585b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-01-09 14:14:01 +0000
NEWS for 5.15
commit 5047dc72737b9fcb2f1310f9b5cf8e5719a6fe52
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-01-09 14:01:57 +0000
Clean all generated files, so we can distcheck successfully
commit 4ab810e7f3d7458bdd02549f631ee402ec6862a3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2013-01-09 12:05:13 +0000
Communicate the detailed error from McdConnection to McdAccount
In particular, this propagates the error from RequestConnection failing
correctly, so add a regression test for that.
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39334
commit d9d0d64c5046668a0e7dc261216672143a699559
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 16:00:48 +0100
Remove McdAccount::connection-status-changed signal
Nothing listens to it.
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39334
commit 9c038fb370c25a2fb87fd80e71b4591cb81c5fa5
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2013-01-07 16:18:09 +0100
account-addressing: fire PropertiesChanged on URISchemes change
commit 4b5ccf8a74f6c80d4a9787fcaec445327d589800
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2013-01-08 13:53:06 +0100
addressing.py: 'mailto' is the proper URI scheme
commit e34842e2101a54dc90d7496999da10f62c392d30
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2013-01-09 09:51:07 +0000
Bump tp-glib dependency for tp_vardict_get_*
a5a5d850 started using these functions, which were introduced in
telepathy-glib 0.20.0.
commit 060e148bd71f3989861ab374dba89cc20278fcec
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date: 2012-11-15 12:04:30 -0500
build: honor NOCONFIGURE in autogen.sh
Like telepathy-glib does already.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=57165
Reviewed-By: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 52485ba01852a0fc7d46cb026adfbde16aa525d6
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date: 2012-11-15 12:04:30 -0500
build: honor NOCONFIGURE in autogen.sh
Like telepathy-glib does already.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=57165
Reviewed-By: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit c3f9cd49aa0238922b5a0e972cf3cbe3a48be6eb
Author: Mike Ruprecht <mike.ruprecht@collabora.co.uk>
Date: 2012-11-01 00:24:35 -0500
Update to current ConnMan API
ConnMan 0.79 removed the GetState method and StateChanged signal.
Use the GetProperties method and PropertyChanged signals as their
replacements.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=56600
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 077ac24ef7d324fded1ebba928ee6150ab583e9c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-10-30 15:17:33 +0100
Add missing config.h includes
g_type_init() has been deprecated in GLib master. By including those files I
can build without raising a deprecation error as we define
GLIB_VERSION_MIN_REQUIRED to 2.30.
commit 2fe37c082b5db56513598beb638b331ccfff9b0b
Merge: 9b04e1ba 61566c4a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 16:53:19 +0100
Merge branch 'aliasing-avatars'
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55668
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 9b04e1ba0a4cfe74345cb6eaa0496b3348e9a24a
Author: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Date: 2011-06-15 12:26:26 +0100
Check for the specific error codes when reconnecting
The NetworkError connection status maps to several TpErrors,
so first check the error codes to decide whether we should
automatically reconnect, and fallback to the connection
status if we don't recognize the error.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37844
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 61566c4ae43f312ed102eb1586e4aeb50dc03e6c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 11:36:28 +0100
mcd_account_self_contact_changed_cb: ignore no-op changes
commit d4eec9aa5baa63fdfc0cf354561044786dfa23b5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 11:29:39 +0100
mcd_account_process_initial_avatar_token: don't take self_contact argument
It can be retrieved from the McdAccount.
commit d2a26f3b1a3d6e0fead0b2885347bb9e0d6d15bd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 11:27:57 +0100
Ignore changes to the avatar of former self-contacts
This is highly theoretical, but in principle it could happen.
commit 90dd8c46e8457629140397d6e6afacfe9f2eea6b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 11:25:55 +0100
Implement Set("Nickname", "") by using the normalized name instead
This is consistent with what we do when we first connect, and ensures
that we always have some sort of nickname.
commit a4355bb2eb2a682a4c1298c01683cffb4e42a666
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 11:10:12 +0100
nickname test: test what happens when we set an empty nickname
commit 97b7748520960cc4cda2f9c9c25eb5c5ad27e326
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 10:55:45 +0100
Downgrade failure to prepare self-contact from WARNING to DEBUG
commit 420ba08af8aa3d2b7300f683725dc8cc52858d51
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-09 10:54:53 +0100
Downgrade failure to set alias/avatar from WARNING to DEBUG
commit e49b1405fd0242c2e28b62905cb0dcfe1b8091d5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 17:54:04 +0100
Track Avatars using McdAccount, and use the self-contact for it
commit 2a1d4dce7e7bfa08e646485d36f4223c46915a33
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 17:53:34 +0100
Emulate the Aliasing interface a little more realistically
commit 51641776d8cb3ac2db46ccf062bbe5aae2588230
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 16:20:20 +0100
Knock out most of the IRC test until fd.o #55666 is fixed
commit b543e87d5fcb65ef61516b4bf6c03cb4f27583b4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 13:45:58 +0100
Add a regression test for an IRC-like protocol
IRC has plenty of oddities, but the one we're interested in here
is that your nickname and your unique identifier are inextricably linked.
commit eb7239987e2cddc1e2388428bf9f01bfc06fbb00
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 16:17:44 +0100
McdAccount: cope with self-contact changes; follow the self-contact
commit f5333aaa31373ffc30bad96fb877b7a5915dd6bf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 12:42:39 +0100
nickname test: verify that a trivial nickname is not set on connect
commit 121688c19cded284257b9e7a3690207d98899f82
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 13:21:16 +0100
enable_fakecm_account: copy parameters and alter the copy
Mutable defaults for arguments are dangerous. If we call
enable_fakecm_account twice with default arguments, when we alter
expect_before_connect/expect_after_connect, we are actually altering
the default! Python doesn't construct a new empty list for us every
time. The C equivalent would be a static GPtrArray * or something.
commit b6d933c6927a8b0b4c60a414ccd7c271fb14e0dd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 12:42:16 +0100
Don't set the nickname to the normalized name on connect
We still allow the nickname to be set to the normalized name by
user action later, because in that case, the intention is unambiguous:
the user really does want their nickname to take that value.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39381
commit 4ab487bfbd4d8a8ed8f4fb6e42afaf2a35e8e59e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 12:04:02 +0100
McdAccount: take responsibility for setting the nickname
As well as being implemented in a more streamlined way (using the
self-contact instead of calling D-Bus methods directly), this reduces
the circular dependencies between McdConnection and McdAccount.
commit 8a27f3df35f58e48547a9d92711df16214edd5a4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-05 14:38:26 +0100
McdAccount: store the self-contact
commit a5a5d85001669af4411d01daa98da0e6d3c3094c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-08 15:46:44 +0100
_mcd_client_match_property: take channel properties as GVariant
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit eee9cebcfe2e583dbb5fd1421b879a7837bc7a2c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 14:45:38 +0100
Generally use GVariant, not GHashTable, for channels' properties
This means we can avoid the deprecated
tp_channel_borrow_immutable_properties().
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 552dcac1ea50fbe0d64e4ec122b40d3d8fb5b391
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-08 15:30:47 +0100
mc-tool: have a TpSimpleClientFactory to manufacture accounts
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 7f8f814ffc232cbfe903b66a418c52d2ce964f5d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 15:21:05 +0100
McpDispatchOperation: use a new factory for each connection
This avoids the deprecated tp_channel_new_from_properties(). It has the
same disadvantages as that function, but is a bit more obvious about it.
Also comment how to change things at the next ABI break.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 4413b17df8a2e7e5df1167e4f3848a98a6395945
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 15:51:04 +0100
McdConnection: use TpWeakRef instead of replicating it
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit a41ad6c876407eeb47fa6ae4dc930d9fdae47c9e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 15:12:00 +0100
McdChannel: use the TpConnection's factory to make TpChannel objects
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit bd19b09f83087cfde65ff5f777b30a07cf07e22b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 15:02:02 +0100
McdAccountManager: have a TpSimpleClientFactory
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit ac8b57c149c9c84dc86427337d0b39999f96da2c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 15:00:20 +0100
McdAccountManager: use tp_dbus_daemon_register_object
dbus_g_connection_register_g_object isn't deprecated, but it's more code.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit e913203ccfe06fbf3435be69b0e6b07d1828ce73
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 14:42:29 +0100
McdChannel: use tp_channel_get_requested instead of reinventing it
MC's reinvention was potentially better if the channel might lack the
Requested property... but that property has been mandatory for years,
so CMs that haven't caught up can just deal with it.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 9f5aaffb018ce166c8181eb98cd13182112ead22
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 14:38:17 +0100
Use tp_channel_get_connection instead of tp_channel_borrow_connection
This requires telepathy-glib 0.19.9, so depend on it.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 8310376a77d8a591d438dd65f5050081430bd5ff
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 13:30:00 +0100
mc-tool: use tp_account_manager_dup_valid_accounts
tp_account_manager_get_valid_accounts has the confusing
(transfer container) transfer-mode, and is deprecated in telepathy-glib
0.19.9.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 534b0ed2fc2ddd4872bca3251025c30037fb3272
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 12:03:11 +0100
Enable TP_DISABLE_SINGLE_INCLUDE
Tested with telepathy-glib 0.20.0.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 5ba8d233c1776da8ab894e744e749b760c94275d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 12:02:59 +0100
Update code generation tools from telepathy-glib 0.20.0
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 553120085c06d90a06f876a12344170b480c3846
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-14 11:58:27 +0100
Enable TP_SEAL_ENABLE
Tested with telepathy-glib 0.20.0.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 2637ab782d2ff562c40e18bae1f86f4d850537ed
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-13 17:57:35 +0100
replace sealed struct members with getters and use TpProtocol
Originally two patches for 'next' by Jonny Lamb.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit caacfe66c11a3c01fd29e935dd7b0ea7b9b474a6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-21 15:42:16 +0100
WARNING, etc. macros: add
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit f694362379baca962247f4b62630866332a969a7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-21 15:37:03 +0100
mc-debug-server: don't self-terminate when disconnected from GDBus
It appears something in MC now connects to D-Bus for a second time,
using GDBus this time. We don't want to exit-on-disconnect for this
one either, again so we free all memory before exiting.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 33328b2b5cf1f8ea54dcadc639e90776544cad2c
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-08-29 18:33:21 +0100
add more telepathy-glib-dbus.h includes where appropriate
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit b265e18157aec3d387b344331fb2aa117f1257bb
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-08-29 18:29:54 +0100
make-valid test: make connection object paths distinct
If these object paths are the same, the factory will use the same
TpConnection (even though they are actually different connections) and
dispatching will happen twice.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit d98add74c5c5b142f4908dffdb6e0bac951d7564
Merge: dae5f166 76c62bcf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-04 16:03:30 +0100
Merge branch 'storage-refactor-54870'
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54870
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit dae5f16617519406eaf9a41bc050d99944805dc2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-03 19:09:59 +0100
Start the 5.15 branch
commit ff2df8e5eab56b0a5b013cb4333fbf41fd367414
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-03 19:09:33 +0100
Revert "Don't check documentation completeness in this stable branch"
This reverts commit 2a0b73c02353a155e473504546a8b7e598da4449.
commit e4b9946e98001d081c0e6bc15c16e27432782a29
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-03 19:08:52 +0100
Revert "Upload documentation to the 5.14.x location"
This reverts commit 5f156149b05e7b5ab9e54eeee729136d9d59128c.
commit 2a1ac0b29220b24a243124639e0bdd8b3c756022
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-03 19:08:48 +0100
Revert "Don't warn on deprecated declarations, this is a stable branch."
This reverts commit 4e5a187773cb34de567e3cf90d62710830bbd876.
commit 847e2b950aa18d530dc0f32b58e8bb11a1658039
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-03 19:08:22 +0100
development version
commit c1fe16e325d1622bea056dbc8679c23e72000386
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-10-03 18:11:25 +0100
fix Makefile syntax
commit a433ba2a46c9fdcd73e365c88639a6e501762893
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-21 15:35:54 +0100
exec-with-log.sh: add gdb wrapper
Based on a patch from Jonny Lamb; changed to use ${abs_top_srcdir} to
work out-of-tree, backtrace all threads, and put the gdb script in /tools.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 91006767d5ce8f95b43c7ff85fc6e5ec90d8895c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-10-03 14:37:26 +0200
prepare 5.14.0
commit 4e5a187773cb34de567e3cf90d62710830bbd876
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 10:50:08 +0100
Don't warn on deprecated declarations, this is a stable branch.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 5f156149b05e7b5ab9e54eeee729136d9d59128c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-10-03 15:05:06 +0200
Upload documentation to the 5.14.x location
To be reverted in the 5.15 branch.
commit 2a0b73c02353a155e473504546a8b7e598da4449
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-10-03 14:57:48 +0200
Don't check documentation completeness in this stable branch
To be reverted in the 5.15 branch.
commit 90a3b33273dd4384ebf653c9ec4c7a5fbc752246
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 16:15:48 +0100
Post-release version bump
commit e80d7797aa038480701c6819bc178c9302d823e7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 15:41:12 +0100
Prepare version 5.13.2
commit d33c6c16abd488f6ec3fae2dbc88ffc6a3514c0b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 15:35:49 +0100
NEWS
commit b6f897048723dab0a1aefaacb969e8026a3d6e4d
Merge: 5b5ee486 7095375b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 15:09:20 +0100
Merge branch 'xdg-keyfile-35896'
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896
Conflicts:
src/mcd-account-manager-default.c
commit 5b5ee4862e11ab2b12d8f652d06b45600dc358af
Merge: 0bb531d7 ef2ea07d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 15:07:13 +0100
Merge branch 'telepathy-mission-control-5.12' into master
Conflicts:
NEWS
configure.ac
commit ef2ea07d1b27dabd87e0ae028396138f78d1970a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 14:58:30 +0100
the obligatory version bump
commit 010ab4ba86f557f89e1ec2045dc9fc5ae71513ad
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 13:21:47 +0100
Prepare version 5.12.3
commit 17965ae51796f93771a6444e90f6846639b68a9b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 13:21:31 +0100
Do not distribute mcp-signals-marshal.h, which is generated at build-time
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit eaefb264316f206186b2ac7f1f36e6a4692deb3d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-20 12:28:59 +0100
Default accounts backend: finish password migrations that Empathy 3.0 started
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
Bug-Debian: http://bugs.debian.org/687933
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 5c89fe0b540eaeecd72379f1f2b9da07883425e9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 16:53:36 +0100
Make the gnome-keyring test work again, with modern gnome-keyring
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
Cherry-picked-from: c21e2b09bf4cdda6fb05d64f9198f6db7b776c76
commit 0fda3bd4b8217460a3c755e8eae8c48ad6478958
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 12:26:16 +0100
Test that an account storage backend can alter AutomaticPresence
AutomaticPresenceType etc. don't work, but AutomaticPresence does.
commit 06cb1df43b9113eb0f202b4ae9d95adc032b5d67
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 12:21:14 +0100
mc-tool: add getter for AutomaticPresence
commit 287f7425b9069fae816f1e2872b5992dffb17074
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 12:21:04 +0100
Use combined AutomaticPresence in tests where either would do
commit 5b21fc3d06fba26dfef4ebd5e4287e57e1a416db
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 12:20:29 +0100
McdAccount: store automatic presence as a single attribute
This will be necessary to make its change-notification work correctly.
Use tests/twisted/account-manager/auto-connect.py to exercise the
automatic migration.
account-storage/default-keyring-storage.py is broken by this change,
because it asserts that keyfiles from a lower-priority XDG location
are not automatically migrated to a higher-priority location until
something actually changes, and the migration of AutomaticPresenceType
is a change. To avoid that, put the automatic presence in lower-priority
keyfiles in that test in the new format already.
commit a90652ddf3103de75c345f198f3c8ce4d797d443
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 11:40:10 +0100
Add a regression test for (un)escaping things in keyfile format
commit 938facb6517d2daecdf60a287f04d0cdf1f3fd66
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 14:28:07 +0100
McdStorage: add support for storing structs (uss) in keyfiles
commit f2cfc78ac1a37cb9a85055602cf7c001045492bf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-11 18:42:22 +0100
McdAccount: consolidate AutomaticPresence setting
commit 20661d5734d5d7c8f1e95b70be7b4f49f7cf4c04
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-11 18:35:16 +0100
TestDBusAccountPlugin: push typed parameters into MC
commit 05d1af08748932319ac5133f716deac4fae9b698
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-11 18:35:01 +0100
Add a way for storage plugins to push typed parameters into MC
commit 0a3f99bb6bb8703777e0060fa378360958a25032
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-11 18:01:04 +0100
McdAccount: add a way to tell property setters that storage has already been updated
This lets us get AccountPropertyChanged signals for more attributes
changed via McpAccountStorage::altered-one, which would previously be
suppressed because altered-one's API is that the storage plugin has
already updated the McdStorage before emitting the signal. The
property setter would then notice that the value was the same as
in McdStorage, and assume that that meant it hadn't actually changed.
commit 2c1a41059fec4657c59078525ca2527a06443b90
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-11 17:22:29 +0100
mcd_account_altered_by_plugin: get the new value from the McdStorage
This means we pick up the new value a little more reliably: in
particular, this fixes processing of URISchemes, ConnectAutomatically
and Supersedes.
commit d62d0742c69c81cd0299f8dc30d6f717bba0493a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 14:27:01 +0100
mcd_storage_init_value_for_attribute, mcd_storage_get_attribute_type: make extern
commit 06a09cf70713999a11ba9227baa00264c95c25e8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-11 17:02:41 +0100
Add a regression test for an account storage plugin altering accounts
commit a851f84c246259a3922b55cb1224ff5224809fd4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-11 17:12:06 +0100
WARNING macro: add
commit 8c2c761e11c389bb243763b59cf3f1d63d94b283
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-11 14:24:16 +0100
Mock accounts service plugin: respond to change signals from service
commit 8ffb3f507c35af24fac0b4fb28438d4af7fb298c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 19:12:10 +0100
Mock accounts service plugin: receive settings from MC as GVariant
commit 8b602c52b9e2007740309ad1c84eaf2966143135
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 19:01:14 +0100
Let storage plugins receive new values as GVariants
commit 4efea11d2ed33a92f6ef05a954acfb180083531d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 15:57:02 +0100
Preload accounts via fake accounts service when required
The only tests left using real account storage are the three tests for
specific plugins: default keyfile/keyring, diverted keyfile and
libaccounts.
commit d6c23d2fc528b3cff92ec78c706a78cd561a2a9b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 15:38:24 +0100
account-manager/avatar test: assert about mock accounts service interactions
commit 2ecab4c8c5109722bbf7c0f2df8d7d2c6aa64c6c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 14:57:21 +0100
account-basics test: assert that the mock accounts service is used correctly
commit 9d952ab91dfa2a87383492d0ad68a286c9236d49
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 14:57:15 +0100
Use the mock accounts service for the majority of our tests
For tests that rely on special behaviour such as "preloading" keyfiles
with specific contents, don't provide the bus name of the mock accounts
service, resulting in fallback to the diverted-keyfile plugin.
commit 73306e67755de2b2b16d3a88d2ac9c8efe40bd99
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 13:21:02 +0100
Add a fake account storage backend which uses a mock D-Bus service
commit 3975989913b12fa1488d00085d8cdb84e5b3f46d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:31:43 +0100
mcp_account_storage_owns: add
At the moment we use get() to see whether a plugin thinks it "owns" a
particular account, but it seems clearer and more self-documenting
to have a dedicated virtual method for this.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit fb470a3a8bde4e2bf07cf93722daa016a6344c2c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 13:19:57 +0100
mcp_account_manager_escape_variant_for_keyfile: add to plugin API
commit 7cf22355325f32bcf9898cfeb253390ed6624923
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:30:11 +0100
Give account storage plugins a way to find out the GType for an attribute
commit 7975d386c95469d2e5aa7626524dc906dfeb64ef
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 10:51:23 +0100
Require Python 2.6 so we can use "except A as b" etc.
commit ee9b43cb446218b3fca3a0a753a4a3a94413c81c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:27:28 +0100
McdStorage: store parameters in-memory as GVariants, with a fallback
We don't necessarily know a parameter's type until we come to use it,
so we can't necessarily decode it from a plugin straight away. However,
if a new value comes in from UpdateParameters, we do know the type for
that one.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 51b984b7cede7c2a2f2ec591846ac41573fd1887
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-12 14:20:13 +0100
McdStorage: store attributes in-memory as GVariants, not keyfile syntax
commit 6cce93320368fb34ab7e13b8eb1e4d6b33634006
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:23:08 +0100
Consistently use the constants from mcd-account-config.h
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 8a264749eabe572c0a41a135281890ae660b2222
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-05 17:55:41 +0100
mcd-account-config.h: list every setting (i.e. all non-parameters)
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 51357aacd99dd5f0057aeb9f743a2e696e10d7b3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-05 17:55:06 +0100
Rename MC_ACCOUNTS_KEY_ALIAS to MC_ACCOUNTS_KEY_NICKNAME
Its value is actually "Nickname" so its name should follow.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 444c32b0de9e97b0046ef613c1c15eb9e8ef5ff8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:21:33 +0100
McdStorage: in update_storage, take the escaped value as a parameter
This saves looking it up again.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit c1152ed446503574f718a1cddaa5fcb80520dfd4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 19:22:57 +0100
McdStorage: change internal storage away from GKeyFiles
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit fd9f5784098d774076a12a5dd0da693f2b417cca
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 12:23:53 +0100
mcd_keyfile_escape_value, mcd_keyfile_unescape_value: add
Also make them available to account storage plugins.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 2a647cbf905ad47a3d597499efc3eaae1397b719
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 19:19:47 +0100
McdStorage: distinguish between parameters and attributes
Parameters are part of the Parameters property, have CM-specified types
and can be secret, whereas "attributes" (everything else) mostly stand
alone, have known types hard-coded into MC, and are all non-secret.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 76c62bcf500acc21ef8db2064ed00d01e51b039d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 10:31:43 +0100
McpAccountStorage: don't double-register signals if implemented twice
The base_init function of a GInterface is called once per implementor.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit d75df979a3cc8fe700197b3d96f5332187c52c2c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:12:39 +0100
McpAccountStorage: improve documentation
commit 9bf797ebf0bac51b3647bd063b47ca8d78c0c84d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:10:52 +0100
Mark McpAccountStorage::altered as deprecated
It would be nice to have, but apparently it doesn't actually work...
so I'm not going to waste any time on it.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=28288
commit f976919e884fd85726b232eab3f76c558c904308
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:07:34 +0100
Deprecate and undocument McpAccountStorage's vtable-filling functions
commit 48ca9d546d08df14cd4f79bc00627206c7a7efb6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 18:07:06 +0100
All account storage plugins: fill the vtable directly
commit 2ce2e402e3325517470480a1734f9b4cda6d19e0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-10 16:37:58 +0100
McpAccountStorage: stop recommending mcp_account_storage_iface_set_desc, etc.
Now that the vtable is public, you can just fill it in.
commit 95ded438d50149b02e2ee36f39e92a19d9770de9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 12:13:02 +0100
mcp_account_manager_set_value: document
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 5ca771a0a76ef6fc41aba893bf3d100cda03a618
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 12:16:36 +0100
Unify loading of new accounts
Rather than having both the AM and McdStorage know how to load a new
account, it's better to give the McdStorage a method to do it. This way,
when it gets more complicated, we only need to change one place.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit bf70a86c39902ccf4fdad8aec1be1bbcc661d148
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-05 14:23:01 +0100
mcd_account_property_changed: rename to mcd_account_altered_by_plugin
The parameter is either "param-" + a parameter, or a setting. It's
not necessarily a property name!
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 0ca9a72ee4285af5c12bd120c66487f09dc3600a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-05 14:21:30 +0100
McdStorage: implement get_string, get_boolean, get_integer in terms of get_value
commit ab6057bbb22d40fdf494aabdb9285a2556ff564c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 17:44:41 +0100
mcd_storage_dup_value: alter signature, rename to mcd_storage_get_value
Its callers become considerably simpler if it takes a pre-initialized
GValue of the appropriate type and fills it, much like
g_object_get_property().
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 76a7c315686a94b7b56c2c5e3cd83de72aed2735
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 17:38:32 +0100
mcd_storage_has_value: remove, no longer needed
Now that mcd_storage_dup_value() doesn't make up a value for parameters
that are missing or can't be parsed, we can just rely on dup_value()
raising an error for missing parameters.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 87b40cf09a3589daca09d9a54b466b0c0572f98b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 17:37:29 +0100
mcd_storage_dup_value: don't return non-NULL with error set
The practical effect of this is:
* addressing_set_uri_scheme_association() needs modification to cope
with a NULL return, which previously never happened (an empty
string-list was returned on error)
* addressing_get_uri_schemes() needs the same change
* mcd_account_get_parameter() treats parameters whose value in the
keyfile cannot be interpreted as the desired type as if they were
unset; previously, it treated them as 0, False, "", [], etc.
The old behaviour of mcd_account_get_parameter() seems undesirable:
we shouldn't just make up parameter values. If the parameter is boolean
"require-tls" and its value gets set to 2 for some reason, we should
invalidate the account, rather than setting it to False and carrying on!
commit 3e08626fafa696290162fb8baafa5bc4cece07fa
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-05 10:07:33 +0100
mcd_storage_set_string: implement in terms of mcd_storage_set_value
commit ed5ec4105052e5e86f7471855a5c234822fc1c74
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-05 10:03:37 +0100
mcd_storage_set_value: unset keys directly instead of via set_string
commit a04220ab092e417f451d8ce55839d60469238ed1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-05 10:02:27 +0100
McdStorage: include flagging-as-secret in update_storage()
This guarantees that we don't forget to flag things as secret, and also
avoids unnecessary indirection through the McpAccountManager vtable.
commit 7095375b51547bea365ed321f06ba6a7c7cd2101
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 13:57:29 +0100
Update documentation of --with-accounts-dir
It used to be where we kept accounts; now it's only the source for
account migration into XDG_DATA_HOME.
Keep its name the same, so that if a user or distribution is configuring
with --with-accounts-dir="~/.mc-accounts" or something, the migration
works as intended as long as they continue to do so. (We don't
recommend doing so, though.)
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit c710e7bc5c302d657184077e0cc5530646efdb5f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 13:54:19 +0100
Default account backend: write accounts to XDG_DATA_HOME, with fallback
If the user has ~/.mission-control/accounts/accounts.cfg we migrate
from there to XDG_DATA_HOME/telepathy/mission-control/accounts.cfg,
and if successful, delete the old name.
If the user has XDG_DATA_DIRS/telepathy/mission-control/accounts.cfg
(in a lower-priority path element than XDG_DATA_HOME), we use it,
with copy-on-write into XDG_DATA_HOME.
(Limitation: the account-store executable used in some tests only reads
from XDG_DATA_HOME, and doesn't understand the XDG_DATA_DIRS and
MC_ACCOUNT_DIR fallback.)
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 8de58594deeff1d26046f17487c5752b6fa0aeeb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 13:06:41 +0100
Default account backend: include directory creation in _commit
Also check for errors - we can at least give a useful warning.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 9a932a687f75be5238c533d928f914292a5e9c43
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 13:11:50 +0100
Default account backend: restructure to be able to look in multiple places
This isolates all file-writing into _commit, and all file-reading into
am_default_load_keyfile.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit bd9334449d2ff1db6158ecfbb41f65327a40a078
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-04 15:43:33 +0100
McdAccount: migrate avatars to a XDG path
This is the easy part of XDGification: there is no plugin involvement or
anything for avatars (yet!), it's just hard-coded.
Changing the avatar location from a single directory to a search path
results in some new corner cases, so test them.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 416486d706a4d717ad5670abca61e333471bfbdc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-04 15:03:12 +0100
mcd_ensure_directory: add
I keep calling g_mkdir_with_parents() and expecting it to return a
boolean (it doesn't, it returns 0 or -1), so it seems worth wrapping
it in something more sensible.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 947aaa3c91f7f286d37f803286d77070f0cc6fb2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-03 19:12:29 +0100
Tests: distinguish between XDG cache/config/data home, and MC_ACCOUNT_DIR
We want to be sure that MC is using the right one in each situation.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 0bb531d7856f4b79edd7d328cef59e58f7f08ac8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-31 19:49:30 +0100
servicetest: don't eavesdrop on method replies or errors
Eavesdropping on method replies breaks libdbus if you call methods using the
same connection. You can get into a situation like this:
* Test calls a method on MC; say the serial number is 42
* At around the same time, MC calls a method on gnome-keyring and also uses
serial number 42
* gnome-keyring replies, labelled "in reply to 42"
* Test is eavesdropping, so it sees the reply going from gnome-keyring to MC
* Test interprets the reply from gnome-keyring to MC as the reply it was
expecting from MC, sees completely the wrong types, and becomes
confused
This seems unlikely - but because serial numbers are sequential and
start from 1 for each connection (as opposed to starting from a random
offset), two connections can quite easily happen to sync up. I saw it
happen most recently in the gnome-keyring test. With the benefit
of hindsight, I think I've seen this before: whenever the tests
made an Introspect() call which returned a type other than 's', that
was probably this bug.
We never actually generated events for messages other than signals and
method calls, so match those ones specifically, and don't eavesdrop on
replies.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54495
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 0675c366c5b326d50a1ad7f368ee47c4219a47bd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 11:29:53 +0100
Don't generate code for Account.I.Addressing, use telepathy-glib's
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
commit 375a55b0bc2f92a0ec6f409695b397aa7f6ec82e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 11:15:52 +0100
Be single-include-compliant when generating service bindings
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
commit 37609dd9849871633f84192a0ce4fe65c40784e6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-07 11:11:23 +0100
Use G_VALUE_INIT instead of { 0 }
We already depend on GLib 2.30, which is new enough.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
commit a729a511399712c4b8fbfbef9d3517aaaa4ad9d7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-29 11:36:37 +0100
mcd_service_new: use tp_dbus_daemon_dup()
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
commit 362ef681dbaea571ccfccc3dbe06f2218780d217
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-29 11:18:11 +0100
mcd-dbusprop: remove support for filtering property setting through an ACL
This provided an asynchronous API for getting and setting properties,
which nothing actually calls into, and nothing in MC supports setting
properties asynchronously anyway. Into the bin it goes!
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
commit d14283c0220d24772372128d534e8e230a3b2088
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-28 17:10:13 +0100
McdMaster: remove unused variable left over from old-style plugins
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
commit 450f485e4e9bb3be2ddb023e42de1fcf1fa2b282
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-28 16:53:17 +0100
McdAccountManager: remove useless virtual method
We no longer allow McdAccountManager or McdAccount to be subclassed.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
commit f1a2718edbe6392e399e4498dc86249ef3f90fac
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-28 16:50:12 +0100
McdAccountManager: move initialization from init to constructed
This lets us use the construct properties, and in particular the
TpDBusDaemon, which means we can make it a construct-time property
on McdStorage.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
commit 9ead40da113ae477439c322d605d9dc35d38e062
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 19:04:42 +0100
Post-release version bump
commit 329a390d283e44c2955e87600428fb7cd86b97bf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 18:23:15 +0100
prepare release
commit 8453cbb099abd8f3ab3992559750297cea7c7ce0
Merge: 2667fa04 dd0eb39c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 18:11:50 +0100
Merge branch 'telepathy-mission-control-5.12'
Conflicts:
NEWS
configure.ac
commit dd0eb39c5da72f5f0fae9bfc28072b001044b7bd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 18:05:24 +0100
tools/Makefile.am: be careful not to create empty files in the builddir
"make distcheck" in an already-out-of-tree build turns out not to
work because of this.
This corresponds to commit beb2d971 in telepathy-glib.
commit 073c5898443755d64752d92b2ac0c1f94581f3e9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 18:00:05 +0100
post-release version bump
commit e37277d17d9c7cbbb519e9e881d1582727b3acb2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 16:59:40 +0100
Prepare release
commit 5e1bbe8f891af4d86cb9dfd2f0b36fdfbbb7b2ef
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 16:40:37 +0100
Butterfly account migration: migrate the password too, if stored
Otherwise the upgrade from Debian 6 to 7 forgets MSN passwords, which
is not the end of the world, but seems less nice than it could be.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 3ae49c706e93d06131cabf5b4a0421869948ec62
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-09-06 16:43:19 +0100
Migrate from Butterfly to Haze even if Butterfly is no longer installed
Mission Control has a bug/design flaw/whatever in which it doesn't
know the types of parameters without looking at the corresponding
connection manager, which doesn't work if that connection manager has
been uninstalled. This turns out to be bad for the upgrade from
Debian 6 to Debian 7, which upgrades MC to a version that will
perform the migration from Butterfly to Haze, but also uninstalls
Butterfly...
Since we know what the type of 'account' is, with a bit of refactoring
we can tell McdAccount that we know it's a string, get its value
anyway, and get on with our lives.
Bug-Debian: http://bugs.debian.org/686835
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
commit 1ce1e32bc7f83b5dfc3b75407e896c7bd7e6cbdb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 18:50:41 +0100
Default account backend: when deleting passwords, delete the same thing we will look for
Deleting secrets with param="param-password" isn't a whole lot of use
when we save, and look up, param="password".
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
Cherry-picked-from: 1d9e8f5cfb9e7b426a99ae6e16c35c1101d55a91
commit bd56ee0e36a681ee50d3e02d4f158bbc5df462f1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 18:12:06 +0100
Default account backend: when deleting from the keyring, remove from secrets
Otherwise we'd just delete it, then (because it's still in secrets)
re-commit it!
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
Cherry-picked-from: 16e4507c5001f6f45158ef3d0b46998fa8c1ca2a
commit efc15381535a2d94eeec2b19651302768f65d0ad
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 16:03:08 +0100
_keyring_commit: perform deletions for keys in removed, not in secrets
'removed' is essentially a set of (account, key) tuples that should
be deleted. What we were doing was:
foreach account in removed
foreach key in secrets[account]
delete (account, key)
which makes little sense - if we have param-password and
param-proxy-password and we want to unset Parameters['password'],
the current implementation would delete both. This commit changes it to:
foreach account in removed
foreach key in removed[account]
delete (account, key)
which has the advantage of actually making sense.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
Cherry-picked-from: d4ca35cffea9d0093e127e0be633501d22ded35f
commit dbba880903def15bc7bb5fdb9d05ee310f1a5bfe
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 18:09:21 +0100
Default account backend: when deleting, always delete from both places
Our tracking of whether something is "secret" (in the gnome-keyring) is
pretty shaky, and in particular, we can forget that things are meant
to be "secret" sometimes (we lose that information when deleting
parameters).
Happily, when we're deleting things, it doesn't actually matter: the
right thing to do is clearly to delete from both locations, regardless
of where we think it ought to be.
Similarly, when we're setting a property to a new value, it's appropriate
to delete it from both locations, then put it in the right location
(only).
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
Cherry-picked-from: 5b4954d2c959c4ba7f6c67b7d8e16eaa5ab272dd
commit 2667fa042934116d06a828767860964f52363943
Merge: 80e392f2 a5fb89ba
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-09-06 11:19:21 +0200
Merge branch 'telepathy-mission-control-5.12'
commit a5fb89bad8b6fc7498cb7056faea1fdaa44de986
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-09-04 13:51:20 +0200
mcd_connectivity_monitor_is_online: check if we are awake as well
To be considered as online, we have to be connected to the network *and* not
in the proccess of sleeping.
Fix a race where an account we just disconnected because we are going to sleep
is put back online because the monitor was considering us online again.
commit 80e392f2253fd9624b7a3862c6faeaf698905118
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-09-05 12:07:56 +0200
McpAccountStorage: add signal to request an account reconnection
commit 81c21ac1e2755dd63ecca892d0dbc65f9c4aa8c6
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-09-05 12:10:12 +0200
McdAccount: factor out code to reconnect
commit 23b91753f3460a0e4b52a1b9c4cec98603ff9c5c
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-09-05 12:02:20 +0200
McpAccountStorage: add functions to emit interface' signals
commit 87001e5b9f5ce3124167766d61fa9993e1fad3f4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-31 15:27:44 +0100
NEWS
commit 2e3360a39c4a9202d3ba473292f90ef5a821b10c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 19:32:19 +0100
Default account backend: test that *all* passwords are deleted
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
commit 825f59e988c8435c5de0899abe45081440991f7b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 17:16:55 +0100
Test deletion of passwords from accounts
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
commit 455d7be6901945117761e697c9e561b4c0165ee7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 18:51:19 +0100
account-store-default: load the same names that MC would
This tool was previously not deleting "param-".
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
commit 1d9e8f5cfb9e7b426a99ae6e16c35c1101d55a91
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 18:50:41 +0100
Default account backend: when deleting passwords, delete the same thing we will look for
Deleting secrets with param="param-password" isn't a whole lot of use
when we save, and look up, param="password".
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
commit 16e4507c5001f6f45158ef3d0b46998fa8c1ca2a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 18:12:06 +0100
Default account backend: when deleting from the keyring, remove from secrets
Otherwise we'd just delete it, then (because it's still in secrets)
re-commit it!
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
commit d4ca35cffea9d0093e127e0be633501d22ded35f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 16:03:08 +0100
_keyring_commit: perform deletions for keys in removed, not in secrets
'removed' is essentially a set of (account, key) tuples that should
be deleted. What we were doing was:
foreach account in removed
foreach key in secrets[account]
delete (account, key)
which makes little sense - if we have param-password and
param-proxy-password and we want to unset Parameters['password'],
the current implementation would delete both. This commit changes it to:
foreach account in removed
foreach key in removed[account]
delete (account, key)
which has the advantage of actually making sense.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
commit 5b4954d2c959c4ba7f6c67b7d8e16eaa5ab272dd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 18:09:21 +0100
Default account backend: when deleting, always delete from both places
Our tracking of whether something is "secret" (in the gnome-keyring) is
pretty shaky, and in particular, we can forget that things are meant
to be "secret" sometimes (we lose that information when deleting
parameters).
Happily, when we're deleting things, it doesn't actually matter: the
right thing to do is clearly to delete from both locations, regardless
of where we think it ought to be.
Similarly, when we're setting a property to a new value, it's appropriate
to delete it from both locations, then put it in the right location
(only).
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
commit c21e2b09bf4cdda6fb05d64f9198f6db7b776c76
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-30 16:53:36 +0100
Make the gnome-keyring test work again, with modern gnome-keyring
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088
commit 548801efb1852a1b0be04992f248adc60123a973
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-06-15 18:15:46 +0100
gitignore: updated
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 1e6577380a651ba28388a4a0d806e64065e48c56
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-28 16:14:34 +0100
NEWS
commit 676be2e38d43dc5dd5cc5507c4bccea159b4d735
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 19:04:16 +0100
plugin-account.c: rename to mcd-storage.c
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54151
commit 019ebd806da9f0b83a1ab2ef60bc03e9e0da5af0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 19:01:35 +0100
McdStorage, McdPluginAccountManager: squash into one class
The Storage name stays, to make the diff more readable. The header
is mcd-storage.h but the implementation is still plugin-account.c,
for the same reason.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54151
commit 61066078763c94ef9ce7d674b7b2e19efe6d709e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 18:02:51 +0100
McdStorage: remove _mcd_storage_store_connections
I'm not sure why this was in McdStorage at all. It's a bit of a layering
violation: AccountManager has a Storage, so Storage shouldn't call into
AccountManager. We can fix the layering violation by adding a signal
to McdAccount.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54151
commit 6d6fe1b3903e1df4714a0fc217f75e9ea1120c19
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 17:05:45 +0100
McdPluginAccountManager: fold interface methods into their implementations
Nothing except McdPluginAccountManager implements McdStorage, and nothing
ever will or should, so we can squash the two together.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54151
commit 448148d83cb488c9909290a8f1ea04e8c490e968
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 16:37:12 +0100
McdMaster: fail to build if umask() is missing
We ought to be able to rely on umask() for files created since 5.2.2,
at least on Unix.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54151
commit 70062e7a10ff62b3e0852001ab93a4bd9375714d
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-08-28 11:18:10 +0200
mc-tool: Display account's supersedes
commit b5e82890de690905cabe24203ecd46ae41075998
Merge: a3cb554f 47f3cb54
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 11:50:59 +0100
Merge branch 'telepathy-mission-control-5.12', rejecting stable-only changes
commit 47f3cb54fcda485e3fbfc9b297dd556a504273b7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 11:49:45 +0100
NEWS
commit 249a3a81704d7af6426cc58732097056ca482c19
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 11:48:04 +0100
Revert "stop using deprecated tp-glib functions"
This wasn't really an appropriate change for a stable branch: it
introduced code churn without actually fixing a bug. We should
ignore deprecation warnings instead.
This reverts commit 88642511bb9c6f66d2fe4aae1550893eb0d781b2.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Acked-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit df7276a652ac3f69e330f1fb8d126c229041ace0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-27 10:50:08 +0100
Don't warn on deprecated declarations, this is a stable branch.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 131248f8e1aec7b47e47e96d33122f4bfbcb66f2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-14 16:41:45 +0100
Disable the connectivity GSetting on Android
There's no immediately obvious way to install GSettings schemas there.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=53497
commit a3cb554fd61cd91aec453052356570602e802475
Merge: af504f1f 09c0b671
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-08 10:36:49 +0100
Merge branch 'telepathy-mission-control-5.12'
Conflicts:
NEWS
configure.ac
commit 09c0b67148873c65d36afd322712a8a6db7eb7a5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-08 10:32:58 +0100
NEWS
commit ad4b94ecd7768bd952cdcba51fd7039f564e6765
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-08-07 19:48:09 +0100
Avoid race between Mission Control's two names by having one wait for the other
If you do:
dbus-send --dest=org.freedesktop.Telepathy.MissionControl5 \
--type=method_call --print-reply / org.freedesktop.DBus.Peer.Ping & \
dbus-send --dest=org.freedesktop.Telepathy.AccountManager \
--type=method_call --print-reply / org.freedesktop.DBus.Peer.Ping
then one or both of the calls will fail because the executable claims
one of its bus names, but can't get the other, and exits 1.
By making one wait for the other, we get the desired behaviour.
I've made activating MissionControl5 wait for AccountManager because
in MC's current implementation AccountManager is taken last.
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=53220
commit af504f1f7db73c71e35f3c3701bfe9e428d02b72
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-08-07 10:36:28 +0200
mc-tool: don't display empty 'Addressing' section
The general behaviour is to only display relevant fields.
https://bugs.freedesktop.org/show_bug.cgi?id=53202
commit e845663d154a94d76131dd3ab3534037a3bb516e
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-08-07 10:24:05 +0200
mc-tool: add 'dump' command
Useful to quickly check all the accounts in one shot.
https://bugs.freedesktop.org/show_bug.cgi?id=53202
commit 548451d9e4ef003dd64714d31850f04911eb7277
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-08-07 10:16:50 +0200
mc-tool: display Account.Storage settings
Don't display StorageSpecificInformation as it requires an extra async call to
be retrieved and it's not that useful anyway.
https://bugs.freedesktop.org/show_bug.cgi?id=53202
commit af6c1ad94a7a677506f10778d426106d8538b428
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-31 11:47:53 +0100
NEWS (also mention removal of obsolete features in 5.13.0)
commit ddd21ba082fd5a90e93052463d00927853a8ecea
Merge: ee34e401 694be3e5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-30 15:41:00 +0100
Merge branch 'one-channel-should-be-enough-for-anyone'
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit ee34e40100294702f9bcde300056f659de4e3ed8
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-23 14:02:13 +0200
Post-release version bump
commit 56a82e1c202ace036885b4a4b04feb64b14fde99
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-23 13:53:43 +0200
Prepare 5.13.0 release
commit fd24dd6521bf9a9bebfcbf0241b3b8129bc90e61
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-19 10:38:20 +0200
McdAccountStorage: fix altered-one signal
https://bugs.freedesktop.org/show_bug.cgi?id=52231
commit 149a95692b98dbeb84f1ce4a6a11447e015f0598
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-19 10:38:20 +0200
McdAccountStorage: fix altered-one signal
https://bugs.freedesktop.org/show_bug.cgi?id=52231
commit 366068c784c7875516a817d480c3ecf244398680
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-17 16:51:41 +0200
CreateAccount: make possible to select a desired storage
https://bugs.freedesktop.org/show_bug.cgi?id=52231
commit 694be3e53cb8523f86afb73f3ecc0f089610375a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 14:03:51 +0100
McdDispatchOperation: only have one lost_channel, too
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 080860028665d9d76bede9c8f96e315af365fb5f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 13:46:52 +0100
McdDispatchOperation: store one McdChannel, not a list
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit d8da0aa2b9144d26da3926a6cf8f6f154cd5729c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-15 20:06:36 -0400
McdDispatchOperation: collect_satisfied_requests: only take one channel
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 01e04709772936a6791330b49c02167b0ea7fafa
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 13:33:08 +0100
Replace iteration over channels with check for having a channel
Now that there can only be one channel, we don't need to iterate.
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 60ee7341921191f2de4ec587eb098fe55488a869
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 13:27:19 +0100
_mcd_dispatch_operation_new: only take one channel
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 80ea4690cef4b6e2e4509df7fc9040b66ff93faf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 12:13:30 +0100
_mcd_dispatch_operation_dup_channels: turn into dup_channel, singular
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit b8427349b001b799b9b0dfd63686cc80c2625722
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 12:12:59 +0100
McdDispatchOperation: use internal list instead of dup_channels()
Now that there can only be at most one channel in the list, it's
pretty easy to do directly.
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 4877199bfb9ac256dc50893adc6462c288c1a36a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 12:04:35 +0100
_mcd_dispatch_operation_peek_channel: adapt from old _peek_channels
Now that the CDO can contain at most one channel, there's no need to
return a list.
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 89aeb1f75cbdb787e2e4df6433fd41f62d6660d8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 13:15:26 +0100
McdDispatchOperation: change channels property to channel (singular)
For now, the variable that implements this property is still a list
of length 1.
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 95eabd3a26fac84405bd79f1dc109f50ed0fba06
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-15 17:12:37 -0400
McdDispatchOperation: remove untrue comment
I dimly remember that _mcd_dispatch_operation_new once had
(transfer container) or possibly even (transfer full) semantics for the
list of channels, but I also dimly remember removing it. The
implementation certainly has (transfer none) semantics, and its one
caller behaves as such too.
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 26817f3a31da1cc1eed75e296c6ec8f769ebb3bc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 13:04:01 +0100
_mcd_dispatcher_enter_state_machine: only take one channel
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit b015e6c79f59bbb8cc78405dc06aa0e9ee27ed80
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-15 11:41:29 +0100
_mcd_client_registry_list_possible_handlers: only take one channel
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit a30524b98da9403099dc303602b432d1b384237e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 11:51:38 +0100
mcd_dispatcher_dup_possible_handlers: only take one TpChannel
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 7b0ebf426f26d9790217f5b14808e2ace1f15de9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 12:43:51 +0100
_mcd_dispatcher_take_channels: make singular, rename to ...add_channel
It was previously (transfer container), now it's (transfer none).
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit 97106c13aa76b29e46a965cf57cfbdf76ea3e767
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-07-20 12:35:57 +0100
McdConnection: dispatch each channel from NewChannels separately
This loses information - you can no longer tell the channels are
related - but in practice nobody handles Text and Tube channels as a
unit anyway, and signalling them together is now deprecated.
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit b7e524b85b37f913431856514310a9e7749fddac
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-14 17:06:00 +0100
McdConnection: remove virtual methods
Now that embedding and old-style plugins have been abolished, nothing
can override them.
https://bugs.freedesktop.org/show_bug.cgi?id=52305
commit c133c5b86a67a70594c6327578f4c7956b0112f0
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-19 11:17:09 +0200
Do not change RequestedPresence when disabling the account
We can keep RequestedPresence to online, in which case the account
will go back online when account gets enabled.
https://bugs.freedesktop.org/show_bug.cgi?id=52259
commit cae1b270732bab16cb3324e912fc2956baa784bc
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-12 11:12:30 +0200
Fix missing includes to build with recent libaccounts-glib
commit c39128f213943b1f6f074a0b617ba7592fc8e846
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-12 11:11:54 +0200
Add missing config.h include to ignore tp-glib 0.20 deprecations
commit dadff3e6147d914522afbde3c47023a5a9d10bf8
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-12 11:10:52 +0200
Do not ignore return valud of write()
commit 329c70f9f63eb25dadeb145225a83d25cecb7eec
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-11 13:03:05 +0200
start working on version 5.12.2
commit e824493e533f7c4ea9ae9066fb29b3298d9a8aa8
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-11 12:49:04 +0200
Prepare 5.12.1 release
commit ac021dcd68cff4cc101c06b3f8abe246c21c6c15
Merge: eff02cf7 57d7c636
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-11 12:15:52 +0200
Merge branch 'telepathy-mission-control-5.12'
commit 57d7c6360f04d8bc65320c42a5d8929fa3e3bc25
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-11 12:14:11 +0200
Copy telepathy.am from telepathy-glib
It make sure "make -j3 maintainer-foo" works
commit 0daa22ca3858138aee10f8bf46a07fd15c1fcf49
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-09 12:35:01 +0200
McdAccountManagerDefault: Fix a possible double free
If the account is already in the hashtable, g_hash_table_insert()
will set @removed as value, but free it since the key already in
the table is kept.
https://bugs.freedesktop.org/show_bug.cgi?id=51842
commit eff02cf76254af6b9169badcfe76cd7890a0df6b
Author: Xavier Claessens <xavier.claessens@collabora.co.uk>
Date: 2012-07-09 12:35:01 +0200
McdAccountManagerDefault: Fix a possible double free
If the account is already in the hashtable, g_hash_table_insert()
will set @removed as value, but free it since the key already in
the table is kept.
https://bugs.freedesktop.org/show_bug.cgi?id=51842
commit 150c89d45c6b7d5a2d10bc36cff5689ea1ca72d8
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2012-04-05 17:10:18 +0100
dispatch test: make sure Ensure-ing channels after delegation/presenting works
commit 54f4fd22c09a342bb58da978b5a055e45f968897
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-07-06 16:50:08 +0100
dispatcher: set channel state back to DISPATCHED after delegating & presenting
_mcd_client_proxy_handle_channels sets the McdChannel state to
HANDLER_INVOKED, but when we were calling this in both delegate and
present operations, the state was not being set back to the DISPATCHED
state afterwards.
The state being wrong meant that dispatching a channel after if had
been delegated or presented would not happen, as MC thought we were
still waiting for a handler response.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit c8ae24ffd03297d097b553997eda3807f1505748
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-07-06 16:49:55 +0100
dispatcher: add more debug output when delegating channels
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 3d35096f9ccc69b8c3067ed85102694eda4a2855
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2012-04-05 16:56:35 +0100
Modernize dispatcher/redispatch-channels.py a little
commit 6e8be05e1c1b5856575bb7d8404d4429824e4981
Merge: ebc338e2 d8c0bf71
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-07-09 18:10:39 +0100
Merge branch 'present-delegate-broken'
commit d8c0bf71670b61a900e788413a9673d01f6ce06c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2012-04-05 17:10:18 +0100
dispatch test: make sure Ensure-ing channels after delegation/presenting works
commit 6397152f8dbec113d46c5cbd2d6d9b936c31481b
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-07-06 16:50:08 +0100
dispatcher: set channel state back to DISPATCHED after delegating & presenting
_mcd_client_proxy_handle_channels sets the McdChannel state to
HANDLER_INVOKED, but when we were calling this in both delegate and
present operations, the state was not being set back to the DISPATCHED
state afterwards.
The state being wrong meant that dispatching a channel after if had
been delegated or presented would not happen, as MC thought we were
still waiting for a handler response.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit f037c639b5a14f94a1ca3fd9f3dcb92e455aabb5
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-07-06 16:49:55 +0100
dispatcher: add more debug output when delegating channels
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit a01a0267e3f90a45b497664758bde0c0cd794ef4
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2012-04-05 16:56:35 +0100
Modernize dispatcher/redispatch-channels.py a little
commit ebc338e2a5bc441879895be28c1c822f3a192157
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-06-22 09:19:21 +0200
use a DEBUG instead of warning if dbus_bus_add_match failed
Also, make the message more explicit to one can check is D-Bus version if he's
wondering why it failed.
https://bugs.freedesktop.org/show_bug.cgi?id=51282
commit 08a7e21ad3d6664e7c2603906d76ca6222d1ac79
Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk>
Date: 2012-05-17 18:01:19 -0300
Android: adjust library name to fit latest changes
commit 2c71a0c2c7a157e017b923cb2e0ed8e08a941b4f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-10 16:37:31 +0100
Use telepathy-glib meta-headers
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49753
commit c5c011b0dc60508790b0410b37f2b6307d9d13d0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-10 16:30:59 +0100
Require telepathy-glib 0.19.0
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49753
commit 48747e5c606d8b641ecff7eb77da163c9730e13e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-10 16:06:27 +0100
McdConnection: don't bother refcounting handles, they're immortal
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49753
commit 7519795ea2a12f45ba8a03b6e9c70407563e97ec
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-10 15:57:54 +0100
mcd_account_connection_ready_cb: use self-contact for normalized name
This saves us a pointless round-trip: the normalized name is part
of CORE now.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49753
commit 336ee3384c5e92003cbf58386db2c3aff3aabdc5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-10 15:34:17 +0100
McdClientProxy, McdClientRegistry: remove now-unused string pool
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49753
commit 3109731e32597d38a358263c7382ad09fcfff667
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-10 15:32:43 +0100
McdClientProxy: store capability tokens as a strv, not a handle set
There aren't *that* many of them, and handles are immortal now.
If g_strdupv'ing the capability tokens ends up taking too much memory,
we should write a generic refcounted string pool instead (but I doubt
it will, in any case).
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49753
commit 42f20c1472f0073b320b860e1f868817cb6c3bb5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-10 15:20:02 +0100
_mcd_client_proxy_add_cap_tokens: switch from "add" to "set" semantics
In both the cases where it's called (when we get a reply to GetAll,
and when we've parsed a .client file), we actually want to take the
new set, not union it with an existing set.
Also, this will be easier to deal with when we stop (ab)using handles
for this.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49753
commit 96b49d683e449841ae4dc0a09aae6223db1a2a90
Merge: 91f85400 3382019e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-10 15:07:37 +0100
Merge branch 'deprecations'
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=24762
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=24899
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=24914
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49648
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 3382019e8ba7772848fa30448ca2addf5346aeef
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 15:30:41 +0100
McdDispatcher: don't be a McdMission
The dispatcher subscribes to the master's abort signal rather than
implementing any of the McdMission virtual methods, so nothing in
McdMission is actually doing anything for it.
This means we can get rid of McdProxy, so, do.
commit 896e81dfee45830c8ab553c7324d8b2190b9775e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 15:02:43 +0100
McdMission: remove placeholders for old signals, methods
We're not supporting out-of-tree plugins any more.
commit 17bef3f25da89629e9a8ca880a0833d6504986cf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 15:00:05 +0100
McdMission: remove parent-set signal and parent property, unused
commit 147b36b2a4c087b230e2fcb735aa5631da045c90
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:48:07 +0100
mcd_transport_plugin_get_name: remove, unused
You can just use g_type_name() anyway.
commit 15d14bf15c3619a9d4ffa3adc5c80a2c6177d543
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:35:17 +0100
Flatten McdPlugin into McdMaster
This older plugin API exposes enough MC internals that there's no point
trying to support it out-of-tree.
commit e92a53b0529ecfdbcdcbc8d9db830919b547abbd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:29:17 +0100
mcd_master_get_dispatcher, mcd_plugin_get_dispatcher: remove
commit 46b86f8fd7584c5f8dbfc247fea25d32c27d4733
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:26:36 +0100
mcd_manager_create_connection: don't be virtual, no subclass exists
commit f4fe5fcdcfab0d00c63f4a2f3349ae8612bb9d5d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:23:02 +0100
mcd_manager_get_dispatcher: remove, unused
commit c420774c0fd30ea25220951145d5c23af25ebf57
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:22:54 +0100
mcd_manager_get_connection: remove, unused
commit ecfcf42a1ef35e45cd617301cd36deb0aeb7e77c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:14:07 +0100
McdDispatcherContext: remove
commit 52a0fc268cc12fe4aa2c3b5c9ae05bf31f11722d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:12:00 +0100
inline McdDispatcherContext's methods
commit 1f3fa4e2322daef9e965e2159c4ebd0b9ae2a9dd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:08:25 +0100
Inline what's left of mcd_dispatcher_context_proceed into its only caller
commit 76f016bdad63f0ea68bc11e64be54e01b61004b3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:05:04 +0100
Remove the concept of old-style filters altogether
commit a22bf24e9189c98a87baef9b7288a37795424d66
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:01:39 +0100
McdDispatcher: remove the ability to add old-style filters
commit 1884b434805173e2d8b4eb6e6f6dc3f0f0b25129
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:59:24 +0100
Remove remaining McdDispatcherContext getters, which are now unused
commit 0a1e2de74466b78f2e99ee4c82e21dfbe4be3715
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:58:31 +0100
Remove various unused getters from McdDispatcherContext
commit c76a8013952a1fa0c85aa80777d765f51fe3f23b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:56:47 +0100
mcd_dispatcher_context_get_channel_by_type: remove, unused
This also means we can drop mcd_channel_get_channel_type_quark.
commit a9f3580a8738260a2db4ebf7237adb389a5521f7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:54:58 +0100
mcd_dispatcher_context_forget_all and friends: remove, unused
commit 5a3a0b3d417423a5fb588b36c65f0c7709556de9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:54:03 +0100
mcd_dispatcher_context_proceed: make private
Ideally it should be inlined into its only caller, but this will do for
now.
commit 8fbc9bb3fc7f0714342dff2fd637824f88c653ac
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:52:25 +0100
mcd_dispatcher_context_process: remove
commit 33987d0226e04381a1bda79bdfeadfc815943e53
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:47:12 +0100
Remove McdController and inline its shutdown method into McdMaster
commit d78e084fbfaaeafc4085284febbc0925cd4b25aa
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:34:38 +0100
McdChannel: remove more unused accessors
commit 2f243467c66a466123cbfa1aa183fd3425bae2f9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:32:49 +0100
mcd_channel_get_name: remove, unused
commit a70fc835f8bfaa3addab1106ff90e2b78b5dc737
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:30:02 +0100
mcd_channel_get_inviter: remove
commit 3b1f2acfbba23112148e367dd2216f6570b308d0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:29:15 +0100
McdChannel: stop tracking group members
All it does now is to emit DEBUG() messages.
commit 6c4526da85db2e963a602776f34de659362d90aa
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:28:07 +0100
mcd_channel_get_members_accepted and members-accepted signal: remove
commit c91020a26d451d44096eea463e393a1b3101e3f1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:25:47 +0100
mcd_channel_is_missed: remove, unused
commit e18c550af9c5c5b16017f458e1080a2736db7160
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:23:36 +0100
mcd_connection_cancel_channel_request: remove, unused
commit 25e12a0978aceccff2ce2a2bea6437404a627e44
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:22:06 +0100
Account, AccountManager: remove various unused methods
commit b647c66404e33db2a9dd473124bb7d566ffeb845
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-18 14:34:05 +0000
mcd_manager_cancel_channel_request: remove
Nothing calls it any more.
commit cb8783c25ac8228ae5248bfa8bc8596fa6968879
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:08:45 +0100
Remove unused support for a magical auto-away flag set by embedders
Less code, fewer bugs. Also, people should have stopped embedding MC by
now, and an earlier patch in this series made it impossible.
commit 0deffb0262f2c33b582df25e06c931f0693ded3e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:05:22 +0100
mcd_dispatcher_get_channel_type_usage: remove
Nothing in-tree calls it, and the modern way to do this would be a MCP
plugin that's a pseudo-observer.
commit e7aea65314998512931f7988bea3babc0a548776
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:03:59 +0100
mcd_debug_ref, mcd_debug_unref: remove
They're officially deprecated and everything!
commit a307cc9bbac1a7943b44a46813df0986731759a2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:40:52 +0100
McdProvisioning: remove, unused
commit e9495b13221eeecfafe9813c69e14f8734ac604c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:39:51 +0100
McdProvisioningFactory: remove, unused
commit 182dae7a10bea7307a16a52d9d1216bf9e38457c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 12:46:51 +0100
Remove deprecated support for old-style (mcd) plugins
Only in-tree code can use mcd_* functions now.
commit 524c5a6e0cf654e092e54870470656bdeba3c408
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 16:59:39 +0100
Remove support for the non-standard Query interface
commit cf819e45d2b0cb5d0f2868a28dea84223692d152
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:12:54 +0100
Remove non-standard Compat interface
commit 31b5eec29cf8e8a0d8ea503d4cc70055d003acfc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 16:54:10 +0100
Remove support for archaic Capabilities interface
No, not ContactCapabilities, Capabilities...
commit ab92d3f1f2775854fbe801023a04df6839d639ac
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:16:29 +0100
_mcd_dispatcher_get_channel_enhanced_capabilities: remove, unused
This was left over from ContactCapabilities.DRAFT1.
commit 959d95db540a3a02ddb3e6fdb88f7b256301bd10
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:36:20 +0100
_mcd_file_set_contents: remove, unused
commit 8256dd642f79c8a35a1ae4f4aa5e9f5f17e1f54d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:31:55 +0100
_mcd_connection_channel_is_urgent: remove, unused
commit b58ba958bdeb7d872ed51eaf74288755b784b8cd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 14:20:21 +0100
_mcd_dispatcher_get_client_registry: remove, unused
commit b5ed6bd05b4482dadae245bb6c36ffbed00aee88
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 13:03:41 +0100
Consistently include config.h in every .c file
This is best-practice, and in particular it stops us from accidentally
redefining GLIB_VERSION_MIN_REQUIRED, GLIB_VERSION_MAX_ALLOWED by
including glib.h before (something that includes) config.h.
commit 4850e3cd729f7a0c8c98e5c1452824abb7c776eb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 12:54:21 +0100
Use the GObject 2.30 generic marshaller
commit 4536ccdd1c187df466a9321ad234293f0563fe19
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-08 12:52:59 +0100
Drop separate GIO check, we now include it in GLIB_LIBS
Also use GLib 2.32 deprecation/availability checking.
commit e0d36e4bb93119d5c23cc437a2fefd40675af034
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-07 19:22:34 +0100
Use TpIntset instead of long-deprecated alias TpIntSet
commit c3d77d670607907451811fe658198ccaffddd7d0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-07 19:21:45 +0100
Use TP_ERROR instead of long-deprecated TP_ERRORS
commit 91f8540057fc4778ce0cc64ae8a86eaa02287168
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-05-07 19:29:57 +0100
Set G_MESSAGES_DEBUG during testing
The same as Gabble commit cbfa9d06.
commit eb71e5aa43b11bb615cec0df0ff15558bcc9f3f8
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-05-07 09:36:39 +0200
_storage_dup_value: add the account to the error debug message
I'm trying to track a bug and having this would have been useful.
commit 45b935c3a47e0dee9965dca00a9acdfc4b5011fa
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2012-05-02 18:45:38 +0100
Update news for fd.o#48646 fix
commit ef2fb6a8e6decde7d225a17e8e894140f0dbefb2
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2012-04-13 14:12:53 +0100
GValue was unset in a code path that needed it to stay set
commit 11ca259567fc7e01bfd88620c1003994af9f8ff1
Merge: 791b4b0d 88642511
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-04-03 11:15:25 -0400
Merge branch 'telepathy-mission-control-5.12'
commit 88642511bb9c6f66d2fe4aae1550893eb0d781b2
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-04-03 11:13:55 -0400
stop using deprecated tp-glib functions
tp_*_call_when_ready were replaced by tp_proxy_prepare_async a while
ago.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 791b4b0dd45aec82447dc3c0ef4f31f90286015c
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-04-02 18:59:27 -0400
start on version 5.13.0
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit edd10ce2948b29859006ca1e149e68097a3bd21b
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-04-02 18:58:07 -0400
start working on version 5.12.1
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit aeba9f785227e07bf26b14822b1b288041297910
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-04-02 18:22:56 -0400
version 5.12.0
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit f185df41b7f514ce28bb121ec4abdc5dc422b7a0
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-04-02 18:07:14 -0400
update NEWS for 5.12.0
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 154f2b42310090f947988df8fd44ee34a6cbb18a
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2012-04-02 18:48:21 -0400
fakeconnectivity: implement GetAll and GetDevices for NM
This is needed for newer libnm-glib. We should start using
nm_client_new_async().
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 853fefbb9663a5d6003cdefbc16c19c67d5bfcc7
Author: Alban Crequy <alban.crequy@collabora.co.uk>
Date: 2012-03-16 15:32:51 +0000
Add mcd_service_stop() and stop the McdService when SIGINT is sent
https://bugs.freedesktop.org/show_bug.cgi?id=47054
commit 72498e161d71b6751d825888a684f62c304a9434
Author: Alban Crequy <alban.crequy@collabora.co.uk>
Date: 2012-03-26 13:33:22 +0100
Update dependency on GLib 2.30
GLib 2.30 is necessary for g_unix_open_pipe().
https://bugs.freedesktop.org/show_bug.cgi?id=47054
commit 370e642d6dc6983fee0ef1fcbedd96ef3a2b3b64
Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk>
Date: 2012-03-22 18:05:04 -0300
On Android, use pkg-config --static
This makes it output the complete dependency chain for each
library, e.g. libffi for GObject. This is necessary because Android
toolchains don't follow shared library interdependencies like
normal GNU toolchains.
commit dcebc508f40abd0eaceb57039e5789638b5297b1
Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk>
Date: 2012-03-22 18:04:31 -0300
Use the correct LD_FLAGS variable for the Android target
commit 90ac4892d9f15756e8fc1266a7b24b65da48a5ef
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-21 21:11:10 +0000
Development version
commit 5027888083a46c97f75a99cdf165195afed929db
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-21 19:44:31 +0000
Update telepathy.am from telepathy-glib 0.17.5 to fix out-of-tree releases
commit 8c8b9e690c94ba4b5a2f461799bc2e97b2104bce
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-21 19:41:39 +0000
Prepare 5.11.0
commit b4e4a0f52f75cabb8d6d60618e2decf72e7961e3
Merge: 16ac32eb 349fa2e0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2012-02-21 15:08:36 +0000
Merge branch 'telepathy-mission-control-5.10'
commit 349fa2e017d7c7caa5a9a4987979fdae64f10d87
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2012-02-21 11:02:42 +0000
Account: don't crash on Get('Parameters') if _dup_parameters fails
If the connection manager is not installed, or is installed but doesn't
have the protocol for the account, then _mcd_account_dup_parameters()
returns %NULL. (As the comment I've added says, I think this is
ridiculous—it's fall-out from MC not storing the types of parameters.)
As a result, Get('Parameters') or GetAll() would crash, because
dbus-glib would try to serialize a NULL GHashTable and blow up. (See
<https://bugs.freedesktop.org/show_bug.cgi?id=44939>.) So with this
patch, we handle NULL as "no parameters" for the sake of D-Bus
properties. (Because this situation should only arise if the account is
invalid, we also warn if _dup_parameters() returns NULL for valid
accounts.)
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 16ac32eb79765d65b46d71b35d5ddbbf9987ec7f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-20 18:41:23 +0000
Depend on a new enough telepathy-glib for Supersedes
commit 8618ecef8930ad39a8bfe8b37a9c854945b9dcb8
Merge: 572d39fb c0dba4b3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-20 18:40:53 +0000
Merge branch 'butterfly-migration-42814'
commit c0dba4b307cbc965bec3a325373e11a706dda7fe
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-14 13:23:11 +0000
Set the Supersedes property on migrated Butterfly accounts
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42814
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit d9a702e8c7dfd80c0f7064824e4bf9498c420cf3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-14 12:08:44 +0000
Test the Supersedes property
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42814
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 4ee0376efd35ce0e06d14633e386c511938e26a3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-14 12:07:04 +0000
Account.Supersedes: add
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42814
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 696ae3716947119ad8f6778f8fb6d3ad684d1bb1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2012-02-14 12:06:33 +0000
McdStorage: add support for 'ao' type
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42814
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 572d39fb51e5d1aecdbaa2329686f5b818ce9897
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-02-02 11:27:20 +0100
Display a string representation of McdTransportStatus in debug message
This will make my life much easier when trying to debug issues from users'
logs.
commit 9a32c79b81e4b5a847fcf34641e398f7c6089bfc
Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk>
Date: 2012-02-01 15:36:25 +0000
Produce DLL files when compiled for windows When we cross-compile telepathy-mission-control for windows with the current flags we end up with a static library and it creates link issues in libraries and applications which uses teleapthy-glib on windows. to solve this -no-undefined LDFLAG is introduced in this commit. This ensures all the symbols are defined when we compile for windows.
see: http://www.gnu.org/software/libtool/manual/libtool.html for
more details about -no-undefined flag
commit 3dcdbc3d14457d4096000f1426129062cb76e313
Author: Will Thompson <will@willthompson.co.uk>
Date: 2012-02-01 10:48:33 +0000
mc-tool: add a 'summary' command.
commit c02db9192bf6233e09252b3d0d189744ea91acb1
Author: Will Thompson <will@willthompson.co.uk>
Date: 2012-02-01 11:00:09 +0000
mc-tool: sort lists of account identifiers.
commit 35053f8fdeddd79c92d7f6ddb9e0ac96a6c0c3f6
Author: Will Thompson <will@willthompson.co.uk>
Date: 2012-02-01 10:16:37 +0000
mc-tool: use tp_account_get_path_suffix()
commit 573700ecb680cc3753a362774214f93373df6936
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2012-01-27 15:39:46 +0100
mc-tool: display Addressing.URISchemes
https://bugs.freedesktop.org/show_bug.cgi?id=45308
commit 39ff98afd91df7c91851a1cedbb9f735dae4e668
Merge: 18209172 1282e4c7
Author: Mikhail Zabaluev <mikhail.zabaluev@nokia.com>
Date: 2012-01-19 13:24:13 +0100
Merge branch 'optionalize-gsettings'
Reviewed-By: Simon McVittie (fd.o #43791)
commit 1282e4c7b8d7e2c3bde3201dacd81dbeb4ca8b1d
Author: Mikhail Zabaluev <mikhail.zabaluev@nokia.com>
Date: 2012-01-13 14:13:15 +0100
Make the usage of "use-conn" GSetting a configure option
commit 18209172f6ff643247c1fe1f09aa20b14ab2f932
Author: Siraj Razick <siraj.razick@collabora.co.uk>
Date: 2011-12-22 19:11:23 -0500
Changes need to cross compile MC for windows
we need to include io.h to make unmask work when cross compiling
commit 2b1944ad4085bc10a324dcea19ba19c901bbe578
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-12-19 15:13:11 +0000
In the [unlikely] event the id key has the wrong type, don't leak the GValue
commit bcdbbe60367d67a602aed52a95e53e0725881e2d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-10-20 01:40:27 +0100
AgManager::enabled-event doesn't have the AgAccount::enabled multi-trigger bug
commit 58ff362a133ec6625f23e89b175f3bc8374218f2
Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk>
Date: 2011-11-14 17:19:51 -0300
Support building for Android, modified from an original patch by Derek Foreman
https://bugs.freedesktop.org/show_bug.cgi?id=42508
commit 652eb046e351d5939998efd97b0b053098ef6ac3
Author: Alvaro Soliverez <alvaro.soliverez@collabora.co.uk>
Date: 2011-11-02 15:55:15 -0300
Build on systems without gettext
Modified from an original patch by Derek Foreman
https://bugs.freedesktop.org/show_bug.cgi?id=42508
commit ee2090321ca1530ada26c5431b9ba3dacfd4ea07
Author: Xavier Claessens <xclaesse@gmail.com>
Date: 2011-11-16 16:07:25 +0100
Use _unref instead of _free _destroy when possible.unref
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
commit 778fa378b0923a43134508de5b36abaed028f2c1
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-11-14 14:15:47 +0100
lock accounts while migrating
commit 83aa8ae7eb6a4b2aa8647f6e5581607e40f4ff4a
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-11-11 16:12:28 +0100
migrate Butterfly accounts to Haze
https://bugs.freedesktop.org/show_bug.cgi?id=42814
commit f052f2424a1a010f95739a59f19b71c4278c8231
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-11-11 16:00:15 +0100
add mcd_account_dup_icon() and mcd_account_dup_nickname()
https://bugs.freedesktop.org/show_bug.cgi?id=42814
commit 1298e52994e0bba55437e7f876c2c6d84a49379d
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-11-11 15:41:29 +0100
export mcd_account_get_parameter()
https://bugs.freedesktop.org/show_bug.cgi?id=42814
commit 5353886fab93ed2efdcd2e2d0f83c64941e43a94
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-11-11 14:51:05 +0100
add mcd_account_dup_display_name()
https://bugs.freedesktop.org/show_bug.cgi?id=42814
commit 3e39bb0e14bcbbefcb98839e730d86864165f28b
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-11-11 13:45:23 +0100
value-is-same: stop testing G_TYPE_CHAR
g_value_set_char() has been deprecated in GLib and, as said in the FIXME, we
don't need to test this as it's not supported by D-Bus.
commit 09206a0eee8ddecbd795155a7e9d8936f4b7e469
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-10 12:53:54 +0000
Put request paths under /org/fd/T/CD
commit 4c3e8544f70c9b949934d741655e0874a1cc86c6
Merge: 8158b3db 18e48707
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-08 10:14:25 +0000
Merge branch 'telepathy-mission-control-5.10'
Conflicts:
configure.ac
commit 18e48707de894057f30936ca86cddd304da4e48f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-08 10:14:03 +0000
Bump version to 5.10.1+
commit 0daca95dab021325bd20bd3a9da4f2e67cc005e5
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-08 10:00:46 +0000
Version 5.10.1
commit 627b82fe813d7852aaefa829cf6359f21fd3da62
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-08 10:00:29 +0000
NEWS for 5.10.1
commit 9822ad7c68969ad43c338f16216581256e321de8
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-08 09:49:52 +0000
Remove stray <enum/> from GSettings schema
I forgot to remove this when duplicating the one key I wanted to steal
from Empathy, and ioni reported that it clashes with the same enum
definition provided by Empathy. (I'm not 100% sure why—I'd've assumed
they'd be namespaced by the GSettings schema, not the DConf path—but
hey.)
commit 8158b3db0272bd604fd17de6b870994877628b65
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-07 17:25:12 +0000
And again to 5.10.999+ for the unstable branch.
commit 3eba6fcbc7e9418f7da101a7a58ff7154e905f48
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-07 17:24:56 +0000
Bump version to 5.10.0+
commit 2ddc68024e66584543aa5c08662b3fbb35109a61
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-07 17:20:36 +0000
Version 5.10.0
commit cf9cf54669685e7127de1e0e555281caa43ba819
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-07 17:16:13 +0000
NEWS for 5.10.0
commit b89a27403d632725504c21c6079b936f9c1c6c9c
Merge: b1970f43 6ea034ad
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-04 18:44:40 +0000
Merge branch 'gsettings'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=42068>
commit 6ea034ad022068c581cdbf675a5be54e30d2e2f0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-04 18:20:34 +0000
exec-with-log.sh.in: export POSIX_ME_HARDER=1
commit 52f223eb1740fe1dd3059a9c71c90de7785180c0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-03 17:14:27 +0000
ConnectivityMonitor: fix debug message
commit dbeb5860f634ed6ebaa2a76ca7e37be7623ea4a1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-03 16:54:20 +0000
.gitignore: ignore connectivity monitor test tool
commit a4bb333ef99e7c64a6b4b63a080c57c5beb1aac7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-03 16:52:10 +0000
Bind use-conn GSettings key to ConnectivityMonitor
This GSettings key does the same thing as the Empathy one it's an alias
for does: if use-conn is False, the network state from NM/ConnMan is
ignored, and MC will allow you to try to sign in even if there is
supposedly no network connection! It's pretty great.
(When I first committed this, it didn't work. Now it does. I don't know
why.)
commit db2ac21ee35f785cb21d7b1e782eb34c9753c4f4
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-03 15:33:02 +0000
Add a GSettings schema with use-conn key
When the NM/ConnMan code lived in Empathy, there was a GSettings key
which could be flipped to false to make Empathy always assume it had a
network connection.
This schema provides one GSettings key,
im.telepathy.MissionControl.FromEmpathy use-conn, which happens to use
the same dconf path as the Empathy key uses. This should make the two
GSettings keys aliases for the same underlying value in dconf; we get a
migration path for free.
commit b1970f4371d3efdf4a385cd6b4eebb6731fadd1c
Author: Alban Crequy <alban.crequy@collabora.co.uk>
Date: 2011-10-10 16:43:10 +0100
tests: add --enable-installed-tests
This configure option makes it possible to install the twisted tests in
/usr/share/telepathy-mission-control-tests and run them without the sources.
https://bugs.freedesktop.org/show_bug.cgi?id=41927
commit 41c5b207f8482182834d7ea05d677316538f358b
Author: Alban Crequy <alban.crequy@collabora.co.uk>
Date: 2011-11-01 17:25:31 +0000
update-parameters.py: fix the cache directory
Use $XDG_CACHE_HOME instead of $MC_ACCOUNT_DIR to find the file
mcp-test-diverted-account-plugin.conf because the test-only plugin
mcp-account-diversion uses g_get_user_cache_dir().
This is a no-op because both variables have the same value, as defined in
tests/twisted/Makefile.am:
BASIC_TESTS_ENVIRONMENT = \
MC_ACCOUNT_DIR=@abs_top_builddir@/tests/twisted/tmp-$(TMPSUFFIX) \
XDG_CACHE_HOME=@abs_top_builddir@/tests/twisted/tmp-$(TMPSUFFIX) \
However, this was not semantically correct, and the two directories could be
different in the future, with installed tests for example.
commit 34b03f910bd8b889f0f71edfa9668b74d8ad8ba6
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-21 22:42:45 +0100
.gitignore: remove obsolete libmcclient references
libmcclient is gone forever, so let's not ignore detritus from it.
commit be2e5c2d899d9542b567983e809caf371ba9be6c
Merge: cc746edd 82f1d4b0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-03 11:53:28 +0000
Merge branch 'ChangingPresence'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=42548>
commit 82f1d4b02a32131b48ea9e461865415070ab7b72
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-03 10:29:09 +0000
Account: only set ChangingPresence if we actually are
Previously, ChangingPresence could become True on accounts which were
not Enabled, which makes no sense: we're not changing our presence in
that case. It happened if you requested an offline presence on a
disabled account whose current RequestedPresence is something online; or
if you disabled an Enabled account whose RequestedPresence (and
CurrentPresence) was offline.
Here we change the implementation of setting RequestedPresence to only
set ChangingPresence to True if it actually takes some action. There are
situations where the presence has "changed" (maybe you changed the
message associated with being offline) but no change actually needs to
be applied.
commit f2e91a1e1305ef78a49dbcc81f2b94a938afd5e1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-03 10:28:55 +0000
account-manager/presence: modernize
commit 33ec45d180708ec8c0be8309e91a29f313f4d2f3
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-11-03 09:46:28 +0000
mc-tool: show ChangingPresence
commit cc746edd95fdc1802cd656eca664a7089de61745
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-10-07 11:34:52 +0100
connectivity-monitor: fix build with UPower but no NM or ConnMan
http://bugs.debian.org/644589
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 85a8950dff6ddf53bb78c780e003561c111a26f8
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-04 18:03:36 +0100
Bump version to 5.9.3+
commit 4110ebd94c33dcc53b867c6c85434903583b6e66
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-04 17:51:30 +0100
Version 5.9.3
commit 097abc38aa684f62002570885798c633a3992ef0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-04 16:48:11 +0100
NEWS for 5.9.3
commit 99fab96fa358f69e688865a81c3afb79508394cc
Merge: b78d26c3 c23ca1a9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-04 16:19:21 +0100
Merge branch 'upower'
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=28370>
commit c23ca1a9ca5275e708326e5db5f762c52479845e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-04 16:16:01 +0100
Connectivity: move upower-specific code inside ifdef
connectivity_monitor_set_awake() is only called by the code paths that
listen to signals from upower, so passing --disable-upower to configure
triggered a defined-but-not-used warning for it.
commit b78d26c3319809e391a6bcda2d2cb7f454084b90
Merge: 25799ee8 33f85c6e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-04 15:28:33 +0100
Merge branch 'telepathy-mission-control-5.8+'
commit 33f85c6ed8818cef4db8e9b1caffe53ad4811456
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-04 14:43:05 +0100
NEWS for 5.8.2
commit 904027787d6ae857e70f29b49f4d131a92e6500e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-10-03 16:53:10 +0100
McdClient: don't allow unique_name to become NULL
_mcd_client_registry_found_name() is called in three situations:
• the initial call to ListNames() has returned;
• the initial call to ListActivatableNames() has returned; and
• NameOwnerChanged has been emitted for a client-shaped well-known name.
In the first two cases, unique_name_if_known is NULL; in the first case,
activatable is FALSE.
I don't really understand what business the McdClientRegistry has
telling the McdClient what its unique name is even when it's non-NULL,
but passing NULL to _mcd_client_proxy_set_active() made McdClient
violate an internal invariant. The first action McdClient takes is to
discover the client's unique name, if any; if the client is not running,
unique_name is set to "" (not NULL). Other parts of the McdClient
internals assume (and assert) that unique_name is not NULL by the time
they run.
I *believe* that the client registry need not ever call
_mcd_client_proxy_set_active(), but I am loathe to make that change
without fully understanding the code and writing some tests.
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=39767>
Reviewed-by: Xavier Claessens <xclaesse@gmail.com>
commit c9907c9e7141acdda3cdf326db387f9c4c1b4abe
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-28 17:57:20 +0100
Connectivity: refactor signalling state changes
As Guillaume pointed out on
<https://bugs.freedesktop.org/show_bug.cgi?id=28370#c5>, previously
McdConnectivityMonitor would signal ::state-change even if the state
hasn't changed in some cases.
This patch reduces duplication and fixes that case.
commit 7ffc20512ac6a81e9465622ec692a622bf7ebf8d
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-27 18:08:57 +0100
Master: Always bind connection to a transport
Previously, when a connection was brought online in response to
an event other than a transport becoming connected, it would always be
bound to a transport (if any transport plugins are loaded, obviously),
regardless of whether the dictionary o' conditions was empty or not.
However, when a transport coming online caused a connection to be
brought up, that connection would not be bound to the transport that
caused it to come online if the conditions were empty (which they
generally are).
For reasons I can't quite fathom, this actually doesn't seem to have
affected anything: it could be because monitor_state_changed_cb in
McdKludgeTransport also binds waiting connections to the transport that
came online. But this seems like a sensible change for sanity and
consistency reasons.
commit 9da0c6c713c9cba1ddef33d599888fce16b79482
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 12:24:36 +0100
Connectivity: go offline when laptop suspends.
Woop woop.
commit 17246cccff176888eae16b8ce673e2c5f0da440f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 12:07:32 +0100
configure: optionally depend on upower-glib
commit 25799ee8f5b02a8893d7bc5c8007e58b9d444bdd
Merge: 66b28358 38d76aa0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-28 11:33:09 +0100
Merge branch 'fd.o-38978-connectivity'
Fixes: <http://bugs.freedesktop.org/show_bug.cgi?id=38978>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 38d76aa0c45d66828c1935b0b7573e7739af45b1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-28 11:28:54 +0100
fakeconnectivity: use constant for NM interface
commit bf06f43306c6717905e5ca9cf16e6f96e2bb95fe
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-27 17:38:08 +0100
KludgeTransport: debug when connections get queued
commit 928fbad1c14cde84758b45dd392eb1e20c150fa0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-27 17:16:31 +0100
Account: reconnect if RequestedPresence is not offline
Previously, when a network connection came back up, only accounts with
ConnectAutomatically set would be re-connected. But if RequestedPresence
is something online-flavoured, I think it makes sense to bring such
accounts back online, too: if the user has asked to be online, a network
blip shouldn't affect that.
commit ca9833b3d208fa4f4f3af333ebca54178c5c62da
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-27 17:15:46 +0100
am/connectivity: extract BillyIdle
commit 855af5f3bb9f70aaa59768dbeaf50edf68198675
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-27 16:53:49 +0100
Account: when reconnecting, use RequestedPresence if possible
Previously, if an account was taken offline due to the internet
connection disappearing, when it was brought back up the
AutomaticPresence would be used, trampling on whatever the user had put
into RequestedPresence.
I guess this was deliberate … but it doesn't seem like very useful
behaviour. If I've explicitly set my presence to ('available', 'you can
talk to me now'), despite my AutomaticPresence being ('busy', 'probably
doing something else'), I don't see why a network connection blip should
cause my lovingly-written presence to be discarded.
commit 68d883e4d7488bd2c692c8bc85e5b8f77950ba01
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-27 16:37:44 +0100
am/connectivity: check for SetPresence call
I'd like to be sure that setting RequestedPresence before the network
connection comes up causes that presence to be applied when it does, as
opposed to just that the account be brought online.
commit fd8b6fe898130d6de44501e83629f188a3f3391a
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-26 20:22:00 +0100
Account: add would_like_to_connect method.
This consolidates logic previously duplicated between two code paths.
commit 4ae0e4fc7cf2d4ffffec1efe8858b95202995333
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-26 19:56:28 +0100
Account: unduplicate get_requested_presence method
_mcd_account_get_requested_presence() is literally identical to
mcd_account_get_requested_presence() except the underscore (okay, and
that the arguments are indented using spaces, not tabs).
Whichever idiot was responsible for introducing the underscored version
removed by this patch should be hunted down and shot on sight.
commit 9d8bd36fa860a5599733c44763fb3aac5fc72b92
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-26 18:54:12 +0100
Account: refactor re-requesting RequestedPresence.
commit d8ed34e08ef5ae4ce87d317663e3467ac76fdabb
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-26 18:46:36 +0100
Account: remove _get_online_requests.
This isn't called anywhere. And since this was the only way that
McdOnlineRequestData structures could escape mcd-account.c, we can now
hide that definition, too.
commit 2d5b1ed417986250417af6a4eb3852e7837ed57b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-26 18:44:23 +0100
Account: static-ify _online_request_completed
This is not called from outside mcd-account.c.
commit df7537103a342b8bd42a69f21010f3fa448e8618
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 16:48:03 +0100
KludgeTransport: explain the one-element list o' transports
'one' was not a useful name for this variable, in retrospect.
commit 0bde9e5973fe306e428ec604d85aaafb0c1a9bd5
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-20 11:29:08 +0100
Add a connectivity test
This test does not run if neither NM nor ConnMan support is available.
It also only runs against the test-specific MC daemon, since it depends
on a backdoor method for synchronisation.
commit dea44b07c708a391a2b6d0935aba1a7789c59f49
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-20 11:26:01 +0100
mctest: split up enable_fakecm_account()
This patch splits out the second half of enable_fakecm_account(),
starting at the point where it expects a RequestConnection call, into a
new function, expect_fakecm_connection(). enable_fakecm_account() calls
it, so its behaviour does not change. But the connectivity-monitoring
tests will want to expect a call to RequestConnection() and let that
part of the standard check run to completion, so will be able to use the
freshly-split-out function.
commit b4cd6e18b0d247ff69c3513e9492d885b954de89
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-14 19:10:10 +0100
Master: instantiate an McdKludgeTransport
commit 101f02c4a73944512984d62c54f2ff18c3c2a2eb
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-14 19:30:01 +0100
KludgeTransport: track McdConnectivityMonitor state
commit 7e0434a6d0c9c87241432a9b2fcd5993389a29fa
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-14 18:54:23 +0100
Add stub McdTransportPlugin implementation
McdKludgeTransport will implement McdTransportPlugin using
McdConnectivityMonitor. Currently it's a no-op though.
commit 90fb7c9e5f8d81b669d4a01c1a9ec1886170b965
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-22 18:13:45 +0100
mctest: resuscitate MC asynchronously
Shortly, MC will start making blocking calls on the test suite's fake NM
implementation (via nm-glib).
Calling bus.get_object service-activated MC as a side-effect of making a
blocking call to Introspect() on it, so it deadlocked. I think it's
clearer to explicitly, asynchronously activate it, and wait for it to
claim its names; which also avoids the deadlock.
commit 95a3fdd9a18b638d3e20df0df5976c2bf41c150d
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-22 18:46:39 +0100
account-manager/create-with-properties: modernize and asyncify
For some reason, the blocking call to Introspect here reliably
deadlocked against the blocking call MC will, in a couple of patches'
time, make to (the fake) Network Manager service implemented by the test
suite. Removing it just made the GetAll() call deadlock instead. If I
render that asynchronous, the deadlock goes away.
I am not overly happy with having to do this kind of ad-hoc kludging of
the test suite to make it run, but we're working around a library bug
and I have no interest in delaying the NM integration while I fix
nm-glib.
commit 8af66a228e79470cde692d3aeaf43e70168f1b86
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-16 11:33:28 +0100
tests: add fake implementations of MC and NM
commit dc460ae72ec2c29f42cf375e7e3366105998d132
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-19 18:21:39 +0100
test service: add a “process idle queue” method
commit d29269cb97cc9d804ca55999487e530c38a12ec6
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-15 15:58:33 +0100
Add a test app for McdConnectivityMonitor
commit 796c6e95ecab316f927092391affe35d6b01e99f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-14 16:24:55 +0100
Import EmpathyConnectivity as McdConnectivityMonitor
I'll wrap this up in the hateful McdTransport[Plugin] API forthwith.
commit 66b28358c295e994c5a3711b6d1e04edb53d423f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-26 12:19:23 +0100
mc-tool: add missing entry for reconnect to help
commit 49c678c5169caea64728206a2f63496cd9e37c36
Merge: a669b925 c6939cec
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 17:01:34 +0100
Merge branch 'mc-tool'
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=41154>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit c6939cec58fe158574f4206a780dffdf74264db4
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 15:19:41 +0100
mc-tool: add a 'reconnect' command
commit af96bbe41f468f6301819b455713359d25efb5d7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 15:00:03 +0100
mc-tool add: use tp_account_manager_create_account_async
commit 871eb58541a95c2f9c015350b4f63aca64c4b785
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 14:40:24 +0100
mc-tool remove: use tp_account_remove_async
commit eda38779c2c3107256a8ef5c5fc32d04e664363f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 14:38:27 +0100
mc-tool: improve 'update' output.
Previously, mc-tool update didn't tell the user whether a reconnection
would be required to apply parameter updates. This patch makes it do so,
and also makes its implementation use
tp_account_update_parameters_async().
commit ab3f0fcf0f700b3ad5c5d905188a3bb8c27994e0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 14:28:54 +0100
mc-tool: set AutomaticPresence using tp-glib method
commit 4bb6ce89cbc9a0dcb429a2bd42ee2c42d0a5c368
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 14:25:39 +0100
mc-tool: always show *some* value for ConnectAutomatically
Previously, if an account had ConnectAutomatically: True, then mc-tool
show would say:
Connects: automatically
But if the property was False, mc-tool show would not mention it. This
patch makes the command produce:
Connects: only when requested
in the latter case.
commit bce94d7b182c05bfde407a6f5cdbb2effdc119a7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 14:24:41 +0100
mc-tool: use accessors from tp-glib 0.13.8
In some historic version of telepathy-glib, TpAccount did not have
accessors for AutomaticPresence or NormalizedName. Since we depend on
telepathy-glib 0.15.0, and these accessors were added in 0.13.8, we can
now just use them.
commit d854d0ecff853a63654229cf59bc2dc129fc45a2
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-14 14:48:05 +0100
configure: check for NM or ConnMan
This is baically cargo-culted right out of Empathy.
commit cc659f64994f71957345b6c9fab1bdb612c30f32
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-13 18:22:38 +0100
McdTransport: add guards to vfunc wrappers
Most of these functions are mandatory-to-implement; check_conditions is,
in practice, optional.
commit 2981787353f9862c076cf1c72484c4d5ea234999
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-22 16:54:50 +0100
Master: poison singleton pointer when disposed
Previously, when the 'default' instance of McdMaster (i.e., the
singleton) was disposed, the 'default_master' variable was left pointing
to it. This is basically fine in practice, since the McdMaster is meant
to survive for the lifetime of the connection. But I hit a weird crash
(caused by the test suite's version of MC waiting 5 seconds after the
McdMaster is destroyed before closing, which interacts badly with the
reconnection timeout being less than 5 seconds) and it would have been
much clearer what was happening if 'default_master' had held a known-bad
address rather than a possibly-valid pointer to a freed object.
This doesn't change the behaviour of the code in any significant way:
we'll still crash in this situation. But as far as I can tell the bug is
harmless.
commit 4695c8fe269d04eff269522dc6a0f67795a07dac
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-16 11:13:22 +0100
tests: replace make_mc with class MC
This will make it easier to glue things onto the side of the proxy for
MC.
commit a669b92559e7017b6381c44959fc077acc72b11f
Merge: 42cef849 c8b1014e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 11:28:08 +0100
Merge branch 'uncontroversial'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 42cef84969d9f0ac32a90cccaaddc57e221d9950
Merge: d3f11533 746c6982
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-23 11:27:52 +0100
Merge branch 'telepathy-mission-control-5.8+'
commit 746c6982d06a124b05b439f11d92ae24fa252a40
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-09-21 19:24:13 +0100
Make the regression tests work with D-Bus >= 1.5.6
The tests rely on being able to eavesdrop. Since D-Bus 1.5.6, normal
match rules do not eavesdrop, even if allowed: you have to specifically
ask for it.
https://bugs.freedesktop.org/show_bug.cgi?id=41090
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
commit c8b1014ebc4ae7ad7fed8810e5ed0a05ebd7d5d9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-19 18:24:50 +0100
tests: make sync_dbus more reliable
This is taken from Gabble.
commit 6417d165242ffeb1899108baee3d38709cc8a5e7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-16 10:50:11 +0100
mctest: remove unused event_func arg from make_mc
commit 6362eedfdc4907592d299bac2fe88cd936b62b94
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-16 10:44:38 +0100
mctest: remove references to parameters
This is cargo-culted from CM tests which actually have connection
parameters.
commit 5461261e185cab9784923683720149490107e0a5
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-19 11:01:30 +0100
with-session-bus: print log file names
commit 4aea67ec672ffbec19d7280bc6cd6b70cccd5607
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-15 16:22:10 +0100
tests: update with-session-bus.sh
This gives us --also-for-system, which will be useful for testing NM
integration.
commit 1e0f118d843d16874969e8d4b8a380a7bdf2bec3
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-21 19:19:07 +0100
tests: run Python with unbuffered output
commit 04008b50c4528bea1956c6bf3cd081f7fa9d6b9d
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-21 19:18:17 +0100
plugin loader: add a missing space to DEBUG output
commit ad37acd51910ddfd172f469ce131d1a8fce08ac1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-14 14:35:20 +0100
configure: add summary
commit d3f11533b226e0ecb0ba4e095732aae882089581
Author: Derek Foreman <derek.foreman@collabora.co.uk>
Date: 2011-08-30 08:09:43 -0500
add gio to the glib dependency check
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 560e18839b1d81da82091e18846a2c5206990da0
Author: Derek Foreman <derek.foreman@collabora.co.uk>
Date: 2011-05-16 13:58:37 -0400
add -uninstalled.pc.in file
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 9175ec5cc754e2f71482750e382407e44846a4cc
Author: Derek Foreman <derek.foreman@collabora.co.uk>
Date: 2011-05-16 13:56:46 -0400
Make debug statement more useful
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 5bb11128eea9daa08491be2feed7f45718deef42
Author: Xavier Claessens <xclaesse@gmail.com>
Date: 2011-09-20 12:32:05 +0200
Add unit tests for the case an approver Claim() a CDO
commit 8e06e3e0e110f5e29af3abf3bdc1febdf49c4980
Author: Xavier Claessens <xclaesse@gmail.com>
Date: 2011-09-20 13:15:13 +0200
Unit tests: SimulatedClient with wants_recovery=true fails to prepare
commit 0bae7095a9e1a10e531d311e993fc1c67438cfd2
Author: Xavier Claessens <xclaesse@gmail.com>
Date: 2011-08-22 13:34:21 +0200
Avoid crash in client recovery if we don't know the handler well-known-name
In the case an Observer/Approver Claims the channel, we don't get the
handler well known name for that process. In that case we need to
fallback to lookup all possible handlers on the same process and
pick the first one that match.
commit 34e8ab1f4b4e35647baab7d2b0ef2cd9fd1fdcc1
Merge: 2c9d469e 1931d4f2
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-13 13:17:36 +0100
Merge branch 'fd.o-40129-set-a-proper-error-if-CM-crashes'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 1931d4f2c71f0574a93cac848e2a1e0b40d6588c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-13 12:32:50 +0100
Test that MC sets reasonable errors when CM crashes
This was intended to be a regression test for
<https://bugs.freedesktop.org/show_bug.cgi?id=40129>, but it turned out
that MC is already pretty well-behaved.
commit ca1f8bfff656a0de8f002eee9d0056bbb93301b1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-13 12:30:26 +0100
OCD: sort tests in Makefile.am
commit 57175d04e0b70a112de89e9d85e0e753915780e1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-13 11:54:34 +0100
mctest: allow running FakeCM on a separate bus connection
This was possible before, but not exactly straightforward: you had to
clone the guts of create_fakecm_account(). By adding an optional
parameter to create_fakecm_account(), and a method to
SimulatedConnection to drop its bus name, it becomes pretty easy to run
the fake CM on a separate bus, and hence simulate it crashing.
commit cb19851532bb95ef18e162fc055dbed8c4d579d9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-13 11:53:38 +0100
servicetest: Implement Event.__str__
This is stolen from Gabble.
commit d9a6c491c2973b3e248de76615e83779ea820586
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-13 11:09:24 +0100
am/recover-from-disconnect: miscellaneous pruning
• 'dbus' was imported twice;
• 'dbus.service' and various symbols were imported but never used;
• a BusName was claimed twice;
• dbus.Interface objects were created unnecessarily;
• dbus_interface='' was explicitly specified unnecessarily.
commit 65fc610a6840258422809fc72f9b22dc34b56504
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-12 18:02:41 +0100
with-session-bus.sh: retain newline when forking dbus-monitor
commit edfd9b291e81bb935054c5ab7102a1b2120d0333
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-16 17:25:17 +0100
Tests: remove stale FIXMEs about closing channels
Since 5dfe2f0, Mission Control has not called Close() on channels when
you disconnect. The test for this incorrect behaviour was commented out
at some point, with a FIXME that the behaviour should be changed.
Well, now the behaviour has been changed. So I replaced one with an
assertion that Close() is not called, and the other I just removed
(since that test doesn't actually have any channels).
commit 2c9d469ec6646a39bd964866b434e0eaafab2b24
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-12 17:15:10 +0100
mcp: fix a bunch of doc warnings
commit 9af88add93e4978056e5ad30741fec790386744c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-12 16:50:41 +0100
configure: remove unused ACCOUNTS_DIR and MANAGERS_DIR
commit 1271aaa387c51c312ae2dd6bd0d7ba51ce6864cb
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-12 16:48:36 +0100
Remove unused CHANDLERS_DIR
I really hated Friends.
commit 3c9f0062919c91887930a197e7240d1e113e7c40
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-07 17:39:18 +0100
Bump version to 5.9.2+
commit 36fec818dd30409637c38eec2b8774d48161408b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 11:21:06 +0100
Version 5.9.2
commit d6d0a8302d3974945daf7a020acf5ec4bccba441
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 11:20:36 +0100
NEWS for 5.9.2
commit a22988411e1f6601980a0cd9a9ecce93e29f7c6b
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-09-01 14:25:44 +0200
mcd-account: use proper gboolean rather than 1 bit to store boolean properties
It doesn't make sense to not use the boolean type provided by our framework
and using 1 bit variable introduces weird corner case when being casted with
gboolean.
https://bugs.freedesktop.org/show_bug.cgi?id=40545
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
commit 4b52bb815739b5e73d028aebde9d22e81dac85dd
Merge: ba3094ed 2394a978
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-07 17:09:13 +0100
Merge branch 'doc-cleanup'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 2394a9782e2739b0fce36349e8e1db957ff0f91e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-07 16:47:37 +0100
configure: remove obsolete OUT_OF_TREE_BUILD check
The gtk-doc stuff doesn't use this any more.
commit 047a42ee82fa0d664d510f0ccbd13a802a98ca90
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-07 16:38:37 +0100
Stop building docs for libmissioncontrol-server
I'm hitting a weird issue in gtk-doc where the handwritten .types file
is overwritten with a generated one during distcheck (but not during
normal out-of-tree builds). Given that we have a newer plugin API we're
keener on, let's just stop building documentation for the old one. (Most
distros do not distribute libmissioncontrol-server as a library anyway.)
The mission-control-plugins documentation doesn't hit this issue because
it doesn't have a handwritten .types file. Instead, it relies on gtk-doc
generating it, and uses IGNORE_HFILES to filter out internal headers.
This seems more maintainable, so if anyone wants to resurrect this old
documentation, I'd do it that way.
commit 6de9a91e02906b1cb8536010a71175e0dafb43e6
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-07 14:34:55 +0100
docs: remove legacy templates
These were all content-free anyway. Removing them, and using --flavour
no-tmpl, makes the build neater and faster.
commit ba3094edb045a74e6bdd7288db47d05aa9c11233
Merge: 9cdb15ef 5bb61305
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-07 12:55:06 +0100
Merge branch 'telepathy-mission-control-5.8+'
Conflicts:
NEWS
configure.ac
commit 9cdb15ef0de942be523f3138c9447dc4ff71f4e9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 19:23:01 +0100
Update NEWS with fixes merged from stable branch
commit e8bacd5739c0a12084c0fc1df13155629bdd68d6
Merge: 1e87b2f7 c2aa0178
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 19:21:41 +0100
Merge branch 'early-connecting-status-semi-hack'
Conflicts:
NEWS
commit 1e87b2f7f5c34ef40b3af87fc29b6a89e7ea7b21
Merge: e116686b b29f2a85
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 19:20:28 +0100
Merge branch 'memory-leak'
Conflicts:
NEWS
commit e116686b7e33474265795025374023e5ceeb4913
Merge: 6152792b f3933967
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 19:18:06 +0100
Merge branch '58-recovery-position'
commit 5bb613053dead289ac11f0330dd99bf5fcf5af39
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 19:05:28 +0100
Nano version
commit 89585a13ec547b18ca70519b4e3a0e53238b2a2b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 19:03:40 +0100
Update doc-comment in configure.ac
commit 5b161bf7b0747858e48fc7adf375cb61ee0df0ad
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 16:31:58 +0100
Version 5.8.1
commit aa85d5b6de865651e8834e173a3873fbec6a0372
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 16:24:21 +0100
Update NEWS
commit c2aa017899facac77648ddbf57cfd50c869a02c0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-08-18 18:35:16 +0100
Set connection status to 'CONNECTING' as soon as we start trying to connect
commit 5008b9578d0d815b87ae6145f122a8cf37671524
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-08-18 18:35:00 +0100
Don't throw a hissy-fit if the account is CONNECTING but the connection is not
commit 91036eb72b06fe28a0a95b7b575cc0593ce76dd0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 15:14:56 +0100
Update NEWS
commit b29f2a8554a0a303fd7dca0ce6aae620423882ad
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-01 18:12:15 +0100
API does not guarantee that the GValue remains unset on failed value retrieval
commit fcaeb1ff9cade6b7451304076d383a01e3559f09
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-01 16:05:32 +0100
Approval contexts must be NULLed out or the free function will assert()
commit 1e6d4cd9d48c5896f79dbea3bdf6ee64fcef1ad9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-08-30 14:11:46 +0100
Approval struct free function did not free a string member
commit 49a2f9434acc3f7649ae0129248cc0f16466ba4f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-08-30 13:53:44 +0100
Approval removed from GQueue should be freed
commit fe5bc872a72a71900ea7116f793c37c9896c0ee6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-08-30 13:48:22 +0100
Approval structs should be freed after removing them from the tracking GQueue
commit 74a3b8ed4ed361602a555d8994f66626588e2873
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-09-06 15:08:21 +0100
Log fix introduced by 58-recovery-position in NEWS
commit f3933967a7a1573ccaac8c6a52814e388cf7cb98
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-19 18:16:26 +0100
undispatchable test: assert that observers are invoked, but approvers are not
Also assert that MC doesn't close the channel as undispatchable until
the Observer has had a look at it.
commit 372ad259fdd87182f4d3bcadd053c4fafc443016
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-19 18:14:24 +0100
fd.o #29022: if a channel can't be handled, dispatch it anyway, to run observers
Arguably, we should have some way that approvers can opt-in to being told
about undispatchable channels that they might want to Claim, but that
requires spec, whereas we can fix this straight away.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29022
commit 99d9669a46659ea42635aa5013e6a07e6c21e64b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-19 17:30:25 +0100
McdHandlerMap: add brief documentation
commit adf270a5a0382b0345fa7ee43904409c3157c96e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-19 17:30:12 +0100
fd.o #34025 (ish): if we handle a channel internally, record that fact
This means we'll include it in the set of handled channels when we invoke
Observers with Recover=TRUE.
We don't do this when calling _mcd_request_handle_internally (., ., FALSE)
since we're not really behaving like a Handler in that case - more like
an Observer or something.
commit 6152792b0fc8ebd5daf3be1b743950f8b0698730
Merge: 1e95507c 98785b8f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-01 13:17:17 +0100
Merge branch 'gtk-doc'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 1e95507c3b45c8c3196850fc78db5a130ddcbc33
Merge: 1c24940a 755fc0fe
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-09-01 13:16:58 +0100
Merge branch 'bin-mcclient'
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=24913>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 98785b8fa89cf2f03526de4af44e735af476976c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 17:15:05 +0100
Depend on gtk-doc ≥ 1.17
commit b39cdb342b78e0e40b9e92af4a6135bf5a05c18f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 17:14:21 +0100
docs: fix out-of-tree doc checks with gtk-doc 1.17
gtk-doc 1.17 runs in the builddir, not the sourcedir. So these files end
up in the builddir, which is where we're running.
Unfortunately this breaks doc checks with gtk-doc ≤ 1.16, which I can't
find the strength to care about.
(This is akin to 3ab0d76 in tp-glib.)
commit e0bc7368527fa5d2509a251d33e4d5e3dcf6dc34
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 17:12:59 +0100
docs: sync Makefiles with tp-glib's
This shouldn't change any behaviour. It just adds some defaults and
comments from tp-glib's copy (which in turn are synced with the sample
file shipped by gtk-doc) to make diffing the two easier.
commit 8fbf0cfbee2ff547ad1a9cc331ad07243cfb2fdd
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 17:06:23 +0100
docs: use GTKDOC_CFLAGS not INCLUDES
Going by the examples provided by gtk-doc, this is preferred. It's been
supported approximately forever.
This is based on 019e84e6 in tp-glib.
commit 99a3539a3c5bd1c0bc79062bc00e3520d91a392d
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 17:00:28 +0100
docs: correctly scan source dirs
This is taken from e3dcc31 in tp-glib. gtk-doc 1.17 now runs in the
build dir, not in the source dir, so using relative paths here stopped
working.
commit a5ecb8ddb9cc1d7f2431425efe27cef6a2f239ec
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 16:24:53 +0100
Silent-rules-ify some code generation
commit 755fc0fed40b967c99ffb60c1bad06828c589325
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 14:59:14 +0100
Remove stale code-gen for stable interfaces.
commit 773b790254aa89b914aeac8d144be2afa8916b4b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 14:53:03 +0100
Remove Account.Interface.ChannelRequests
This is a predecessor to the current channel-requesting API, and is
obsolete.
commit 7cdacf5f4950af85714a838e2aba4256b2238918
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 14:57:44 +0100
Remove libmcclient
This entails doing a little more code generation for the daemon: some
bits depended on generated code from libmcclient, and there was an error
enum used in exactly one place. But broadly speaking this just deletes a
tonne of code and documentation.
commit 7e0173a046b381856992faef292ade59cef31cad
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 14:45:51 +0100
Remove local copies of ContactCaps and PowerSaving
These have been in tp-glib for ages.
commit 576fdc7e1657e42f4411123124d7b8dd651e883d
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 14:37:41 +0100
Remove Compat.Profile support
commit b614b7a40260f2c3baf9f4835b25bc6ca06993b6
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 14:26:47 +0100
Use D-Bus GType constants from tp-glib
commit f6bb84c370ca350757f27ec486713376186f89a4
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 14:24:56 +0100
tests: don't test Compat.Profile property.
This is slated for removal.
commit 2c82847081b8c28ff18adc1ab3c6a49de2b6b151
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 14:18:15 +0100
tests: stop using non-standard channel request API
I would like to remove this API. It was only used by libmcclient, which
I would also like to remove. :)
Most of these tests don't actually use the non-standard API: they just
reference the interface for no good reason.
commit 09c862d4fcf8b15a9fd92b5112d5dc7cdf6e8929
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 13:33:45 +0100
tests: move all of make_mc to mctest
I have no idea why part of it was in servicetest.
commit 1c24940a5f2e38ba4027b6b48a2166deeab91219
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 15:35:34 +0100
NEWS for 37861
(Before I forget.)
commit ebe91108748249950d3aeb363e8bfc5e0428c222
Merge: fc84cd8e 52e9df56
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 15:31:46 +0100
Merge branch 'telepathy-mission-control-5.8+'
Now master is a superset of all known releases. ;)
Conflicts:
NEWS
configure.ac
commit fc84cd8e9eb88478d3da7b663fc649c560ac4f0e
Merge: 547b3ba9 b8d92d6b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-31 11:06:46 +0100
Merge branch 'telepathy-mission-control-5.8'
commit 547b3ba96d7f8f5fbdc09c3ecae5ce8badf21791
Merge: dd986906 8dbecc0a
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-25 12:46:23 +0100
Merge branch '40337-invalid-account-error-reporting'
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=40337>
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 8dbecc0ae4083ac8c83507084c36ad2ca536f499
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-25 12:30:02 +0100
bad-cm: break 'password's type.
Jonny pointed out that, given that the method name contains "account",
it's perhaps not the right parameter to check is in the error message
returned when an incorrect type is passed.
commit a01b090c4b289a50ba022852a3a93f1bfd8727b9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-25 12:17:42 +0100
account-manager/bad-cm: clean up test.
This reduces duplication and modernizes the test a bit.
commit d771a4cff23130c34471fce3eb7236dc851e55ae
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-25 12:09:54 +0100
Test invalid or ill-typed parameters for new accounts
commit 4aad882bcec0a476adbbeab47dee4833c3e053a3
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-25 11:13:08 +0100
Include CM name when protocol doesn't exist
This is not really ideal—the real error is that the CM doesn't exist but
due to the current design of this part of MC, it's actually not easy to
determine that.
So at least including the name of the CM might make the error more
obvious.
commit 7ee4434e8049c170f9ee9766bd9b26913fc6e0cd
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-24 18:42:47 +0100
AccountManager: use _mcd_account_set_parameters error verbatim
commit 5a37fb49c80cb89c27925a410d4a1056e88bba3e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-24 18:41:13 +0100
Account: use NotImplemented for nonexistant cm/protocols
The spec is actually pretty clear on this point.
commit 289c02177b461bb1fb2f4487e5eed59d9c177db4
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-24 17:53:02 +0100
mcd_account_check_validity: report a GError for invalid accounts
This corrects the specific case of poor error reporting mentioned on
<https://bugs.freedesktop.org/show_bug.cgi?id=40337>, where MC
previously said “The supplied CM parameters were not valid” but now
actually says which one.
There are a couple of other account-creation cases (namely “CM doesn't
exist” and “CM doesn't have that protocol”) which don't give the correct
errors. And the test doesn't test the “Protocol doesn't have one of the
specified parameters” case.
commit fc543c3ee4ae0235876a7f22deaad0e19b2b1242
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-24 17:40:58 +0100
Account: internally track validity as a GError
commit 976a3f1cebe4d2b8e4e22398a130ef4a181db8d9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-24 17:21:11 +0100
mcd_account_check_parameters: give callback a GError
commit c130b10a7c5d3453cbad163f68b968b538f356f9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-23 18:51:31 +0100
McdAccount: use mcd_account_is_valid internally too
This will make it simpler to change how validity is represented (from a
boolean to a GError).
commit dd9869068914125e80956531446eb297fa128784
Author: Frédéric Péters <fpeters@0d.be>
Date: 2011-08-21 11:08:36 +0200
mission-control-plugins: Link against gio
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit bcc9373ff79d996767bca3efe1b4cafef0b9a525
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-07-25 16:01:43 +0100
Remove ContactCaps.DRAFT1 support
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=24911>
Reviewed-by: Xavier Claessens <xclaesse@gmail.com>
commit c64e52dc46a040b69b37100525bbf4698cca854f
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-08-03 14:28:47 +0200
Avoid a warning when trying to store a NULL value
e17b83fec8f01ca6977cb4fe259a83634aa90b26 only fixed the !ENABLE_GNOME_KEYRING
case.
https://bugs.freedesktop.org/show_bug.cgi?id=39796
commit 5999d678c2156e04b9c1db3cf1a406adb467810c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-08-03 12:52:08 +0200
account-manager-default: always delete secret keys from both locations
This ensures that the key is actually removed even it has been tagged as
secret after is removal.
https://bugs.freedesktop.org/show_bug.cgi?id=39796
commit f2a78001ab99b7a8109121873bf14095b4c6fe19
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-01 16:10:13 +0100
mc-tool: allow localized strings for booleans
commit 7a37f1c767ace97a1dafa258198ca6ca0c9c1830
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-08-01 16:02:09 +0100
mc-tool: make bool parsing sane.
Previously, mc-tool update acct bool:foo=true would set foo to False!
Particularly ridiculous given that mc-tool show produces 'true' and
'false', not '1' and '0'.
I'm *sure* I've fixed this before.
commit 52e9df56a40d027e0972158a600c1b7695820113
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-22 14:52:06 +0100
Nano version
commit 597ed3fd7605bce7b06f6d127c1a90b7fc14f8de
Merge: cb92278f 149523e8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-22 13:25:16 +0100
Merge branch 'unconditional-accounts-skip-too-many-transport-checks' into telepathy-mission-control-5.8+
commit cb92278fc5f001e5330e6d0e6deb410379ff809c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-24 16:37:52 +0100
Update NEWS for Aegis ACL plugin
commit 1191b793e3c445cc836194c63c2d52b8dc42e56b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-24 16:36:12 +0100
The Aegis ACL plugin must activate handlers to check their credentials
commit aae2f108921f4a8eedd861f76e8650c128e2d0cc
Merge: 26071988 07e875ab
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-22 12:24:34 +0100
Merge branch 'cdo-satisfied-requests-hash-leak' into telepathy-mission-control-5.8+
Conflicts:
NEWS
commit 260719888571da3c2e0ebcdc9fc5f45f298c02cb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-22 12:18:04 +0100
Version 5.8.0
commit a6bb447eabb95bf91d5f0121ce0e8cdfa6eabead
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-19 15:29:56 +0100
Fix unbalanced *_DECL macros
commit a29cf172aca42414af59e634a78833e947886d25
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-19 15:24:48 +0100
Checks for unbalanced G_BEGIN/END_DECLS macros
commit b8d92d6bef16a176fb2403957a645aa9510579c5
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-21 14:47:01 +0100
Nano version
commit 3f847e56997ada402bba06344d8de81e13812eac
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-21 14:31:32 +0100
Version 5.9.1
commit ffeee1fe4c6572d54f052608d30163f71ff05562
Merge: 0d2d3718 b7e44e64
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-21 13:02:43 +0100
Merge branch 'unbalanced-header-macros' into telepathy-mission-control-5.8
commit 0d2d3718faf22255a575b44c6184435cd16b4027
Merge: da359cb5 149523e8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-21 13:02:21 +0100
Merge branch 'unconditional-accounts-skip-too-many-transport-checks' into telepathy-mission-control-5.8
commit 149523e89c42cea1cb61c1baa682c623a44e4893
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-20 18:36:55 +0100
If there are no transport plugins, the decision always has to be "Yes"
commit da359cb5b2c3d640c58bd5d777186561244cddf8
Merge: cebbd258 894f722b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-20 17:07:14 +0100
Merge branch 'telepathy-mission-control-5.8' of git+ssh://git.freedesktop.org/git/telepathy/telepathy-mission-control into telepathy-mission-control-5.8
commit b7e44e64922a59795a2720939261b9e8bdc5057b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-19 15:29:56 +0100
Fix unbalanced *_DECL macros
commit 3e753cbb5b442c1a1dfce84c816cef3df8e6afc0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-07-19 15:24:48 +0100
Checks for unbalanced G_BEGIN/END_DECLS macros
commit 894f722b50712ed9ac2f241691fcecdee560fa3f
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date: 2011-07-18 09:46:37 +0000
Let cc find dbus, dbus-glib headers
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39324
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit cebbd25840976d134c373b901df27ad3e76db8c0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-24 16:37:52 +0100
Update NEWS for Aegis ACL plugin
commit 78f3189898d07bb7aa9702bc149066a455f0066a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-24 16:36:12 +0100
The Aegis ACL plugin must activate handlers to check their credentials
commit 6153c0bf1fbe9132059597ec3b5ac9fe0446d7c1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-24 16:33:28 +0100
Update NEWS
commit 8876752c9274e1fd885e1a51f24c22369a6ec94b
Merge: 98c15e81 575e87ff
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-24 16:27:58 +0100
Merge branch 'unconditional-accounts-skip-too-many-transport-checks' into telepathy-mission-control-5.8
commit 07e875ab4a41add247b4127470be6e45a3530e82
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-08 18:40:25 +0100
Unref wrapper not required if we set the free func
commit 575e87ff463a2b654bd7c921a6c900b1f9da9006
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-08 18:16:32 +0100
Accounts flagged as always-dispatch don't need a transport.
commit feed5e78989b49983bb9231e5340ec021fc09dc8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-02 19:11:06 +0100
The 'set' GHashTable in collect_satisfied_requests was leaked
commit 993f3648b2d11598901e92e81606dea6fcc50adc
Merge: 80cca13c 98c15e81
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-01 18:03:20 +0100
Merge branch 'telepathy-mission-control-5.8'
commit 98c15e812a24112a8276fa4a62e208a5f008d135
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-01 18:01:42 +0100
Update NEWS
commit 0cfe51094842b0b05d70e83b83f9cf677bc7e7ac
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-06-01 17:37:10 +0100
Minor header include cleanup
commit 792507ee78a5a2b44bcd98b407c4d2b34bf4a986
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-27 12:24:03 +0100
Hook up the built-in plugins to the new plugin debug infrastructure
commit fd85965e16c3c31bd7370c730d120c0b37d2da21
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-27 11:46:32 +0100
plugin debug header should be included via the main plugin header
commit 5a8b31db634408f9fc93fd551a2fe04e4cc1c661
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-26 16:59:30 +0100
Initialise new plugin debug at the same time as reguar daemon debugging
commit 3fc48b4258f44812722772873c647a90759d31d1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-26 16:58:29 +0100
Expose new header file to out-of-tree plugins
commit c7929ee79943f8c0408207c37895d4bc03aed094
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-26 16:58:01 +0100
define MCP_DEBUG for plugins to use
commit cb25b3900d439e8a998e948c588d16a7888027a1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-19 21:26:58 +0100
Use the new environment-driven debug control mechanism in MCP
commit eaae4ff6dab43a52584487eec5d8d39b74209db5
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-30 11:10:08 +0100
New debug control for mission-control-plugins
commit b2b8407b4c41b1bc2074882c199984bf77ade554
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-31 19:35:04 +0100
_mcd_master_account_replace_transport would accept "no connection" as a successful replacement if no account conditions were specified, forcing unwanted reconnections
commit e17b83fec8f01ca6977cb4fe259a83634aa90b26
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-19 15:26:13 +0100
Call g_key_file_remove... rather than ...set_value when new value is NULL
commit 34a28b406627f4452807b27ee87760b7b93d4bad
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-19 15:25:43 +0100
Don't call tp_intset_size on unset intset
commit 80cca13c3f19829b646c68a3b2eebf25ab9ae732
Merge: 478a087a 9a0990b4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-24 19:09:25 +0100
Merge branch 'telepathy-mission-control-5.8'
commit 9a0990b433fe9a90b1373c8aacaa5501d905f817
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-24 18:50:31 +0100
Update NEWS
commit 0c3f44720632f76c5b4f90799314fb45fdd54c41
Merge: 964891e7 232cc604
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-24 18:44:33 +0100
Merge branch 'cd-message-api-fixes' into telepathy-mission-control-5.8
commit 232cc604d7827c51456534976cf8c69446b3418b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-20 20:33:58 +0100
Catch the case where there's a hole in our logic and an internal request hasn't been cleaned up properly
commit 0285a8ce6940868d91b86c9de23b141a85ff47a1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-20 20:32:05 +0100
Log the actual call to internal request handling
commit 761b4310d351396c14d27e08b78e4badf58c8387
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-20 20:30:26 +0100
If we're failing an internal request, clear the handler immediately
commit 0c7cb7baad42bf7be3415403bb6610680e3c2c36
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-20 20:29:30 +0100
Internal requests should be handled in _both_ paths through _add_channel_request
commit 478a087af9805219dad7c5288516f5f4c3891306
Merge: 272c1d13 964891e7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-20 13:52:10 +0100
Merge branch 'telepathy-mission-control-5.8'
commit 964891e770dd1ca66c7c9a51ae03cc71dba8fe1a
Merge: a0cd2205 12230d1e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-20 13:52:02 +0100
Merge branch '58-user-initiated' into telepathy-mission-control-5.8
commit 272c1d13fdb704b2c5e6da849355b5453eca035c
Merge: e4ccbd3a a0cd2205
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-20 12:17:58 +0100
Merge branch 'telepathy-mission-control-5.8'
Conflicts:
NEWS
commit a0cd22059631972a7d89aa0bc8644544e122cf35
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-20 12:15:49 +0100
NEWS
commit 615aae42cf533e02feb08eeabcad2f6ae16ea6ac
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-06 17:22:25 +0100
We need to propagate nickname changes that occurred "behind our back" too
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit e6cd84b0d147f24fc7e2dbcec99e6b494af3c032
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-08 13:02:36 +0100
Storage has stabilised after the Big Rewrite: turn off debug by default
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit c4a70827351fc7e658c60d13e1b258aaa2fdfee0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-08 12:59:30 +0100
The param hash is reffed by the ACL framework, we can drop our ref to it
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit f44ca2fc586c08d72e09a03f287567b85f7a05a8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-08 12:58:51 +0100
Don't leak copies of the new stored setting values on update
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit da98340c7262c56ab9e38f9159783db746c1bd0b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-08 12:55:55 +0100
Don't leak the initial "offline" account status name
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 2656c26edc53ac75a9e3fb1da19b5f4f6135bcf3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-08 12:55:15 +0100
Don't leak the key list when accounts are updated by libaccounts/SSO
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 12230d1e93a5c428618a0815146ba00138f2cbb2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-18 19:04:41 +0100
Add mcd_account_connection_is_user_initiated
commit dc5ea0a5e8072cd6abcaa4b636f4395db54e26ac
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-18 19:01:45 +0100
_mcd_account_connection_begin: take a flag for user-initiatedness
commit 03a86b79018b2c7ac0b8d1e7a2bf7ae54249da06
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-18 19:01:22 +0100
mcd_account_request_presence_int: take a flag for user-initiatedness
commit 82ff5c401a7e57ec62fea591c071a0644be1828f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-18 19:21:58 +0100
mcd_account_request_presence_int: emit RequestedPresence directly
commit 7517ff1489872b68e35f8536f552377726c5b190
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-18 19:13:25 +0100
_mcd_account_connect_with_auto_presence: take a parameter for user-initiated or not
commit e4ccbd3a80d4ea8cf2d527b54c662b4c41dad21a
Merge: a43df074 2cdf0bd3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-19 16:39:47 +0100
Merge branch 'telepathy-mission-control-5.8'
commit 2cdf0bd3efa2550c91f41f3fd2426365942e2878
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-19 13:38:45 +0100
update autogenerated gtk-doc goo
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 7d4041666674515fd601faaa20e804aeab98cb92
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-19 13:21:34 +0100
Regression test for passing unapproved channels to recovering observers
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34025
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit dcc858d02c6c3671028d9e677b5d0a6bb36e0321
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-19 13:38:20 +0100
fd.o #34025: call ObserveChannels for channels waiting in CDOs when recovering
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34025
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit a43df074d4bd9355420a200707be626ad71266dd
Merge: ad0753f2 7209f390
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-18 19:26:30 +0100
Merge branch 'telepathy-mission-control-5.8'
commit 7209f3901a41ea0abacfb201aeef90a7abb0e76a
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-05-18 11:10:27 +0100
tests: when creating multiple simulated connections use different object paths
This was causing test failures when testing using a better tp-glib.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 3f771dceff1cfd03f21f3cc44eb326f3299d2270
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-05-18 11:07:33 +0100
dispatcher/already-has-channel.py: don't test for calls done by tp-glib
We previously checked makes sure GetInterfaces was called but this is
actually a call that tp-glib does. Newer versions of tp-glib don't do
this as they call GetAll on the connection beforehand so this test
failed.
We don't really need this q.expect.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit ad0753f240b4064c41fd7914449da4ae1638292a
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-05-18 13:47:09 +0100
start on 5.9.1
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit cc9acec9c7e8fcbeb92271783f43e8311b7a3176
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-05-18 12:50:07 +0100
version 5.9.0
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit f64b04c3eb487e7df44836c2572260efcf9cc1dd
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-05-18 11:10:27 +0100
tests: when creating multiple simulated connections use different object paths
This was causing test failures when testing using a better tp-glib.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 6c6ecf5152af67885f947bed5d9a00ad5da151f7
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-05-18 11:07:33 +0100
dispatcher/already-has-channel.py: don't test for calls done by tp-glib
We previously checked makes sure GetInterfaces was called but this is
actually a call that tp-glib does. Newer versions of tp-glib don't do
this as they call GetAll on the connection beforehand so this test
failed.
We don't really need this q.expect.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit db2a49fc4270a43dead300b9c5faa8100a9a277a
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-05-17 10:34:24 +0100
service-points: don't depend on there being any interfaces
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 7133b0e580815d6c25321bf213f5c61b75300e32
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-05-17 10:34:24 +0100
service-points: don't depend on there being any interfaces
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit c167d23e3a9da532e98a99351c996b1fc2e99730
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-17 10:44:08 +0100
Nano version "almost 5.9"
commit 8176880328f8a7107117ccc4fe5279910796c2bd
Merge: 9b03ad06 c12764d3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-17 10:41:42 +0100
Merge branch 'telepathy-mission-control-5.8'
Commit c12764d3b "Don't warn about deprecated declarations" rejected,
since this is the development branch.
commit c12764d3b42f40736f315c320b929f756405bf80
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-16 16:49:57 +0100
Don't warn about deprecated declarations
The usual stable-branch change, to be rejected when merging to master.
commit 9b03ad06401983c5126be107fac5c1c2f91df41b
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-16 08:54:14 +0200
clean up indentation
It's supposed to be 4 spaces identated.
commit e8eb58e1890e05f242b059dcbcee633b96157df6
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-12 14:06:03 +0200
Implement new version of DelegateChannels()
commit d86266ef7539e4ecaeb77fcb0a88e6dd289a1602
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-11 16:19:58 +0200
bump glib dep to 2.28
We need it for g_list_free_full().
commit 09f403c21aa2d598d8f1c1a6c375b91be57a950f
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-11 13:27:57 +0200
Use non-fatal assertions for more subtile checks
commit 9ef991c4d33b985ce61aca0a98304c637a0abba7
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-10 10:56:58 +0200
stop generating DelegateChannels and PresentChannel
commit 6dcd8266c6d91be75ac76d49614d609f9e0e1ab0
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-10 11:13:03 +0200
DelegateChannels and PresentChannel are now stable
commit b88dac1b0f0f95a05210a9a7f7dac442730b76a4
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-17 11:12:00 +0200
Bump tp-glib to 0.15.0
We need it for CD.RedispatchChannels() and PresentChannel() generated code.
commit e5a15f51ef6473f5fa90eb5d7c86b8bba8b835a6
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-10 10:40:07 +0200
Implement CD.PresentChannel()
commit 97df23d0640470efff1a4959999b7aae5bec7d49
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-05-10 10:10:56 +0200
Update to latest DelegateChannels WIP API
Changes:
- RedispatchChannels has been renamed to DelegateChannels()
- It's now documented when we should raise NotCapable but our implementation
was already doing it.
- The Account argument has been removed
- The Hints argument has been removed
commit e90b58ca31a394bbdf94726288e66a643f709905
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-11 16:03:03 +0100
Start 5.7.12 development
commit ab65263abdb9270d27177ed04ef919deb5b542a6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-11 15:55:21 +0100
Prepare version 5.7.11
commit 88b5baf1db86614acff4ec8fca94667c7a55b49f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 10:58:22 +0100
McpAccountManager: add brief documentation
commit f43ca7dae697528d26941874236c9f9dc7f8c36b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 10:57:56 +0100
McpDBusAclIface: note some API-breaking changes for later
commit f0e6772fea09f90f180dec328828b8128b889db6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 10:57:23 +0100
McpDBusAclIface: make the vtable public and improve documentation
commit 2d0564737c9efd42e05749aadbbc0c451109d115
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 10:55:59 +0100
McpRequestPolicyIface: make the vtable public
commit 44f3db606ec3f2d9e73fd53ad4a4609cee93eb3b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 10:53:17 +0100
mcp: change all @include lines to the mission-control-plugins.h meta-header
You're not meant to include the sub-headers directly.
commit 344347320a75465ae35dc8ffdf715299ce5b14af
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-11 10:43:17 +0000
Publicise McpAccountStorageIface
All the existing fill-in-the-vtable functions still exist, of course.
This struct is undocumented. But so were all the _implement_ functions,
so that's okay then, or something.
commit 58254dfccd39293e9c041a2276b260481053eda8
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-10 19:28:59 +0000
Storage: improve grouping in the header
commit 4a7c8e9486b75dc23cbc1cd2812a65ee8b3fe7de
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-10 19:27:25 +0000
Storage: Add typedefs for method signatures
commit 68e48c0950397f15d0d7fb647a0175e5018efa2f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 11:14:32 +0100
tests/account-store-default: if secret is not found, return NULL, not uninitialized
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
commit a819a505f597097fd2aba2e83b456e6280847140
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 10:25:16 +0100
NEWS for builtin-aegis-acls
commit a4eb1c2b1403a84f593c3e5bad4622ff89f54496
Merge: e9d5be63 a0799181
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 10:12:57 +0100
Merge branch 'builtin-aegis-acls'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=36845
commit a07991817ceb17c5a48e674ef14bf112b247638b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-11 10:12:05 +0100
Fix caller_creds_are_enough() debug output so it will actually terminate
commit 1d224057ae7c1be1c438070db3469b1047921603
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 15:15:51 +0100
put Claim attempts through the handler suitability check, too
These get a NULL TpClient, since it's non-obvious.
commit 9ac3c5f4c5c4147734f0529bd43bdf1e13dd3f60
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 15:02:46 +0100
include Handler's unique name in suitability checks if available
commit e9d5be63b54acfd7515dbf527238e97b17fbf8b2
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-06 15:09:51 +0100
Nano version
commit bb27105b6c79721ce266582abb920c9642744cdb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 14:58:22 +0100
Add a test for handler-suitability checking
commit 7a54c4538058c35f77e11c3999a03a35fb53fea8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 12:45:41 +0100
Add a no-op plugin to check that NULL pointers are OK
commit b3ad0c11e2b3977c655116a8c2dc28221df17bee
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 12:45:06 +0100
McpDBusAcl: make it OK to not set a name or description
commit 035973d3593c40db2535f1f6323d14e9863d92fa
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 12:35:29 +0100
mcp_dbus_acl_authorised_async_step: skip plugins not implementing authorised_async
commit e041b7aa87f4a925a6fd8f9aab47e2cc5ae3356c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 12:33:12 +0100
mcp_dbus_acl_authorised: if a plugin doesn't implement authorised(), assume TRUE
commit 67eacd530568185c61499a67ba35f5c3562f4659
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-06 14:46:16 +0100
Prepare version 5.7.10
commit 29296083a036d84f6a39f0c543a56913ecd16d76
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 12:16:35 +0100
make Handler suitability-checking asynchronous
In the general case, when we do the check the Handler won't be running
yet, so we can't check its group ID, Aegis credentials or any other
process parameters; so plugins may need to be able to activate it and
wait for it to start, and MC should be able to do other work in the
meantime.
commit a17f762c4fd03256a962636c4c2019b7fa26e7c2
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-06 12:14:38 +0100
Make an extra round trip to re-store the value, as this will trigger any important side effects like propagating values to the CM
commit 4ee6a19dcc186400d0d4b7a49ccbf9b70918561f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-21 15:47:06 +0100
Deleted parameters aren't stored, so there's no meaningful test to be done here
commit 69c388ba4df48f46a73296ffb54a17db93a8f1a0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-06 10:40:58 +0100
mcd_dispatch_operation_handle_channels: move the handler check here
When we make it asynchronous, it'll have to be in a context where we can
call callbacks for the result. Also, this removes some duplication.
commit d6fcf20ef7a39504a819fa8f43b2c38905a40f1c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 18:47:50 +0100
pid_is_permitted(): remove
commit ea3fad6237fff58362cd6b2c0cb97bd44b48d1a6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 18:45:24 +0100
Use GetConnectionCredentials() when checking credentials asynchronously
Again, this avoids a time of check / time of use vulnerability.
commit d2f40c4995911d3583794297f6a76b4570453c44
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 18:44:39 +0100
Use GetConnectionCredentials() when checking credentials synchronously
This avoids a time of check / time of use vulnerability.
Also, don't crash if the D-Bus call fails.
commit ebef3a3d1fedf07edd75cf8cdf924df6e8958444
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 18:02:50 +0100
Remove McpDBusChannelAcl
commit 7b857fe79d268b0ff8cf919c8785a5a686f3c351
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 18:00:45 +0100
AegisAcl: implement McpDispatchOperationPolicy, not McpDBusChannelAcl
commit 698dbc6a8a55d3732c7b52ef00f38c9a24c79889
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 17:56:47 +0100
McpDispatchOperationPolicyIface: add handler_is_suitable()
commit 08a09215bfd734bb797661822000d4dce36e1b23
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 17:44:49 +0100
McpDispatchOperationPolicyIface: make the GInterface into public API
We can stay compatible as long as we don't change or reorder methods:
adding methods to the end of a GInterface is considered to be a
compatible change.
commit 53bbd7de157f869d36edc40f73a317467e88df29
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 17:13:20 +0100
Revert "Util to prepare a GPtrArray of TpChannel for the new DBus handler ACL framework"
This reverts commit cbd280e9d768df7e4e1c69b0c0b49648a0219a10.
Now that we're using McpDispatchOperation, this function isn't needed.
commit c895b0414278dc79d749cd5a13974ff6d6d4b80a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 17:13:00 +0100
mcp_dbus_channel_acl_authorised: redo API in terms of McpDispatchOperation
This vastly simplifies both the caller (McdDispatchOperation) and the
plugin.
commit 8f2a8cbc424d6ac6bb0b55d3a973b568aaf9ccf4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 16:48:01 +0100
Move channel ACL traversal to McdDispatchOperation
This is a helper for MC itself and isn't needed by plugins, so it
shouldn't be in the mission-control-plugins library.
commit bf612767b4a5500f8271d689353d4bb661eb45c0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 16:46:25 +0100
Flatten AegisChannelAcl into AegisAcl, which now implements both interfaces
This means we don't need any extra glue to hook it into MC as a
pseudo-plugin.
commit c4bec580469f1a6b43cfbf6058a09849eb367c51
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 16:38:34 +0100
aegis_acl_class_init: only initialize once
commit f82a9d29645bddfe6e5d5bdebfa9527c1744192f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 16:35:35 +0100
AegisAcl: remove unused struct members
commit f3a03b48f1529a4f84eafec62bcb459fd597d626
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 16:34:27 +0100
AegisAcl: hide the concrete type completely
commit 190f905a44edac89bb0ce6a60fb19ac11a38c7f3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 16:33:49 +0100
AegisAcl: move struct contents and Aegis internals into the .c file
commit a1004d8a10fe0caa153a595e5648dda8d916534a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 16:27:53 +0100
Move mcp-dbus-aegis-acl plugin back to plugins and load it via plugin-loader
commit ddc03c7002412e9c5e144b665fed249842cd338a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 14:34:50 +0100
_mcd_manager_constructor: remove unused variable spotted by gcc-4.6
commit 77df7a3165cd881eedba2296f116b495c5a626c6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 14:34:12 +0100
plugin-account: sort_and_cache_plugins: only initialize once
A potential bug spotted by gcc-4.6, which warns about this unused variable.
commit b2500c50db739e21ebbde25b94e6384c1cc8e477
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 14:33:08 +0100
_mcd_dispatch_operation_try_next_handler: don't leak error if Aegis rejects a handler
commit 1915c72985971988737653698d86acc753057a10
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 14:18:55 +0100
dbus-acl: if config.h is #include'd, it should be the very first thing
commit d515f38253b6f3b96873773441ad47d8d45413ab
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2011-05-05 14:15:23 +0100
Revert "Filter reinvocation of handlers through the DBus Aegis ACL as well"
This reverts commit a0b6d02c66dc8592455b151d38a3291db545f9a0.
The handler is already handling the channels here, so this can only be a
problem if you already got it wrong; there's no transfer of responsibility.
commit 02fbeb602b7406d5746afbe6e5bbc94dfd10e066
Merge: b7ff6fe1 631b061c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-04 19:53:40 +0100
Merge branch 'telepathy-mission-control-5.7'
commit 631b061c3a431acef9ff16d5b9fa326f08741e6a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-04 19:29:22 +0100
Unused variables
commit b7ff6fe1c3e29d5d74e707fd5fc0ac980d7f0650
Merge: fdc70e2e 3441183e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-04 16:36:49 +0100
Merge branch 'telepathy-mission-control-5.7'
Conflicts:
NEWS
commit 3441183e9e2b1d5c2d0919a922d87252c1278f77
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-04 16:33:36 +0100
Update NEWS
commit c1b3639c61820d47e5f721983a20f37a3cd735b8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-05-03 15:08:51 +0100
Make DEBUG macros in builtin-plugins dependent on ENABLE_DEBUG from config.h
commit d1dd3023db239021b72bf18f9dd2867c6caf57c3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-20 19:38:58 +0100
Misleadingly named argument in header file
commit aa26a5f7c3446904434a4a2510fa81c024502779
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-20 19:38:38 +0100
Clean up the debugging in the DBus access ACL framework a bit
commit a0b6d02c66dc8592455b151d38a3291db545f9a0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-20 19:37:56 +0100
Filter reinvocation of handlers through the DBus Aegis ACL as well
commit db0e652698ae50b14eda3b182e9c5998c6e455c4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-20 19:37:28 +0100
Filter dispatch operations through the DBus Channel/Handler Aegis ACL
commit 17b541a74a2d61062f3f89bd0cd60736ae414613
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-20 19:36:10 +0100
Implement the Aegis DBus Channel/Handler policy as an ACL plugin
commit cbd280e9d768df7e4e1c69b0c0b49648a0219a10
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-20 19:34:45 +0100
Util to prepare a GPtrArray of TpChannel for the new DBus handler ACL framework
commit be065542c28939643f106f9d5f74fd14e37bcd60
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-20 19:34:14 +0100
Implement the DBus Channel/Handler ACL framework
commit 0125537aca079598f37afb7b18cc59c47aeb809c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-20 19:32:01 +0100
Resurrect the DBus access ACL plugin as a builtin pseudo-plugin
commit 142ab4040e5569494a3835bdc29622fc469224f2
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-18 18:48:26 +0100
Remove the old external Aegis ACL plugin
commit cfc09eb5b54fa10485d52db90924cc37a0a7d757
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-21 12:56:27 +0100
Simplify filter-add error checking
commit 94de2830461dd828eff5df31e8bf4e60f78ccf2d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-21 12:45:36 +0100
People mght be interested in an invalid signal, so don't claim it
commit d830cae86f8979bad772e8217b247a3a25c0dfbd
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-21 12:43:26 +0100
Use utility function to check if it's the right signal
commit 9aca7421037b878ce572e4ddc8f2f6200fb463df
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-21 12:38:37 +0100
Don't ref the registry when adding it as the filter data
commit b01dd79df9032460822c3c2eebf3b3cee6cc7103
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-14 19:26:27 +0100
Remove unused callback
commit 90aff1c8afafd4defa2a4059bb36f61307b691fc
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-14 18:43:19 +0100
Fall back to universal name-owner-changed matching if the new approach fails
commit 6c4c4f775808717aedcac74f6784e60ce2ecfcb3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-14 18:30:59 +0100
Remove FIXME now that we have done so
commit fbf0571b85096aa5ee09c0e43c28d79cbeab1411
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-14 01:09:38 +0100
Copyright update
commit 580cb1ad9d9cbdbf426796fb87e81e881bd0926a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-14 00:24:23 +0100
Use an arg0namespace match and a filter instead of all nameownerchanged signals
commit fdc70e2e68b40a0d6616428f5b861ef247fadafa
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-05 17:11:33 +0100
Nano version
commit 6a03fa23d1ce0060e5486b882d2ef0e35af44691
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-05 16:37:12 +0100
Prepare version 5.7.9
commit 8334d2fe4ec2b867200906a362a3dad0bbdb260b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-05 16:33:40 +0100
Merge HEAD, branch 'master' into telepathy-mission-control-5.7
commit 691dcf70772574340b4532813da42c741fe8446a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-05 16:30:58 +0100
bogus const in declaration
commit bd9ce873e74ecdfb347ededa94e1903fd1d7fc28
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-05 15:02:22 +0100
Nano version
commit fa41a9cf0b4f336efeea3848bffbf26de5a66cc7
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-05 14:50:40 +0100
Prepare version 5.7.8
commit 63bd914321360851f30b30eea51d903563b927e4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-01 19:20:05 +0100
Use tp_clear_object for GObjects rather than tp_clear_pointer
commit 3fd08dd03d89e2e4d4923db84a598a09bc1ba571
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-01 19:18:25 +0100
Put the right value in the SEND_MESSAGE #define
commit 1d22bf4561985c4f2e3a5f70757d537186aab59d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-01 14:35:53 +0100
Debugging & whitespace trivia
commit 6060526c748a8829444e1d108dc6547b6c4622e7
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-01 14:35:26 +0100
Restart request if the channel owner closed it before we could send our message
commit 46fd73820ee21652c815205d6e3d6f6538c538b6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-01 14:34:28 +0100
Update the libcreds/cellular ACL to include the new message API call
commit 409f6fa7427b51aed3ebbe9c349f5799de493928
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-01 14:33:24 +0100
Plug the send message API implementation into the ACL framework
commit aabea2ce4023cbdd92c29e32235207c897b4031d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-01 14:30:31 +0100
Use the new message context allocators/dellocators
commit c8e942ff87811a59e4e4ddafc1c2c61f23c903b1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-01 14:23:43 +0100
Helper to steal message ontext back from the ACL framework
commit cd9aeb1e53c4026adcba4361fb238ebbf63c548e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-30 18:16:24 +0100
Helpers for dbus error return and message dbus-context setting/unsetting
commit 3f7e0ca90a52edf6141f9beabf5b62d082d898e4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-30 18:11:01 +0100
Extend message context struct + allocator & free func so we can allow retries
commit 02c76ce59f1bb8ef11630cd5f0c21d3cf79c9246
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-28 19:28:33 +0100
Force Account.Removed to be emitted when the account is, well, removed.
commit 297c55b3e7d4c16cc2af8ee07f14879bd4f7c310
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-24 20:12:53 +0000
Squash some warnings
commit 07a391599e392755170b23c15c6301178e6d3961
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-24 19:59:42 +0000
Dispatch internal operations after the observers have finished.
commit 9cf8902965acc2d258e3c71448ce9ce05ed202b1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-24 19:52:15 +0000
Internal requests ARE subject to policy, and shouldn't be dispatched here
commit 5ac48ff9079881f4796a70787bb222a3f06603c1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-24 19:51:17 +0000
Internal dispatch operations are NOT subject to approval
commit 5dcb0986d3473033491fd06f944c9e3b64ec4f09
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-24 19:48:47 +0000
Tidy up the code used to set/check whether a dispatch operation is internal
commit 1e23d9051b6f001e2ae77557783248ae1d7f5c33
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-22 20:28:26 +0000
The service properties shouldn't get deleted when the account is updated
commit d1e2989bf0eae978f2eb20c1791d858d0720c059
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-22 17:28:06 +0000
Use clear-handler function in finalize instead of dupping the code
commit ee4d8c3a42e918cbbf4d22b555dde6541c7116d6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-22 17:27:31 +0000
Alter _mcd_request_handle_internally per review
commit 757337b6c1db87aa1beedc287fb9e2fb17dc6c91
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-21 18:11:30 +0000
Copyright updates
commit cb7e7dce7104f1503e854736f86f539d07507880
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-21 18:11:17 +0000
Implement the draft CD.Messages interface using the internal-request framework
commit 66c6dcfbc51a541da10e07d306b6ba300fd9fc7e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-21 18:08:45 +0000
If a new channel results from an internal request, invoke its callback
The usual approvers/observers logic is followed, to preserve as much
normal channel behaviour as possible.
commit f5dc7b9af212d5a4e495ebd5c433ea9d12e4e2d4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-21 18:07:31 +0000
If a pre-existing channel results from an internal request, invoke its callback
commit ae0c259b89424a6190ebd3e5df0b3de0d73257d3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-21 18:04:44 +0000
use tp_clear_pointer
commit e210d32c340fef61c0f2477d67f03360cbdbfece
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-21 18:04:31 +0000
Allow requests to be blocked/unblocked on a per-account basis
This allows internally generated requests which require external
interaction to be atomic from the point of view of the caller,
and prevents MC and "real" handlers from treadin on one-another's
toes.
commit a53807c9d8dc3b0d4e745a5e01be2ed64bd65adb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-21 18:02:32 +0000
Allow MC to set callbacks for internally generated requests
These requests will typically be handled by MC itself rather than being
dispatched to a "real" handler.
commit f83fbe87848689edc028837de829b8f0748c9eaa
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-21 17:59:45 +0000
Draft messages interface for the channel dispatcher
commit 71940213008b3c46ffb66af68ff4ae17c6fa72cd
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-16 15:26:08 +0000
Use the new always dispatchable info to bypass checks where necessary
commit 43a84a875c4ef570af89b2eb7acbdd302539a07b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-16 15:25:37 +0000
Expose the new always-dispatchable info to internal callers
commit 7db085c8b25aec2f8a34d1896765be62f217f36a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-16 15:25:02 +0000
New flag for accounts to indicate their channels must always be dispatched
commit 88d047f975a13eca5bc29e69b9cdd10a0845e217
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-10 17:54:04 +0000
Free creds handle when we are done with it
commit 9e6b4103c02806d40f78cd67344237713af49f4e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-05 14:15:50 +0100
Merge HEAD, branch 'master' into telepathy-mission-control-5.7
commit 29c120696de8118f56fef69284486c1ed6acf06e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-04-05 14:12:36 +0100
Merge HEAD, branch 'master' of git+ssh://git.freedesktop.org/git/telepathy/telepathy-mission-control
commit d6f8af95d4645f212054f1500b6fc7d7feb2353a
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-03-30 16:33:24 +1100
Remove reference to mc_cli_account_interface_stats_connect_to_stats_changed
Makes MC master actually compilable!
commit 054d9162eac73bc218277bb8d2723080ea629662
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-03-18 14:35:21 +0000
ChannelDispatcher: implement SupportsRequestHints
commit 60cabc58f4a23a9494f875fc5bc8536f6da06f10
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-03-18 14:35:11 +0000
mctest: add a pretty ChannelDispatcher class
commit 411f14de0bc018ae5f596257f20295413524f445
Merge: 7e9c06d5 33e3c159
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-03-10 08:45:17 +0000
Merge remote branch 'stefw/path-in-pc'
commit 7e9c06d5ad6d512ea46ad27115731cf457434dc2
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date: 2011-03-09 19:44:37 +0000
The account is passed as the object, not the user_data
commit ef9a69832487e9d44843f4d2b9e3b84a571c9c40
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-09 17:47:14 +0000
Update news for cull-stats-interface branch merge
commit 117136db5ded4aaf456b04fbae84ae8d77c568ea
Merge: dc44d1b0 e91e385d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-09 17:44:12 +0000
Merge branch 'cull-stats-interface'
Conflicts:
src/mcd.xml
commit dc44d1b037fd4659a663cfbc98c2e153fe8fd3fc
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-09 17:08:32 +0000
Nano version bump
commit c0d71ba28997b2747a41066cc587eadd6d63afae
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-09 17:06:27 +0000
Prepare version 5.7.7
commit fd655e2cacf00ecb0db057c2f889a48a3e863850
Merge: ee5e5587 18cb5680
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-09 16:13:42 +0000
Merge branch 'master' into telepathy-mission-control-5.7
commit 18cb5680bb82bf03cbd41e6044d4f6cd2ece125a
Merge: 3bf21d6d 61e74f63
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-09 16:13:19 +0000
Merge branch 'sso-handle-non-atomic-updates'
commit 61e74f631a08dc695072662e93ed43b478407026
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-09 13:52:00 +0000
Whitespace
commit a0eb2e6eacae40f3ca87b735fde243409b22104a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-09 13:51:48 +0000
Fall back to the secondary setting for account naming if username is unset.
commit 33e3c159c928f9881866d8be79eb5224865f8d49
Author: Stef Walter <stefw@collabora.co.uk>
Date: 2011-03-09 12:58:07 +0100
Add missoncontrolpath variable to mission-control-plugins.pc
This is for testing so plugins can lookup where the mission control
executable is.
https://bugs.freedesktop.org/show_bug.cgi?id=35140
commit ee5e5587eedf191b586a9ca780ef67916b16744c
Merge: 08fa4d72 1a2e1b9a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-07 16:58:21 +0000
Merge branch 'master' into telepathy-mission-control-5.7
commit 3bf21d6d6151700970f8a191599da66536132759
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-03-07 16:32:34 +0100
start dev of next version
commit 1a2e1b9a0718c34098951a50dad51e94f7462187
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-03-04 10:26:55 +0100
prepare 5.7.6 release
commit d9e84e6a974968e85afb41b496712dcf5bf6b2f0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 20:21:09 +0000
Typo in debug message
commit ceba817848dc9d988dc8ecb14863968bafe666fb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 20:20:51 +0000
We actually need to watch the account twice, globally and for the service.
commit 0783ceb306446d31e7222b44f7933408f7ae3f5b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 20:20:22 +0000
Explain how _sso_updated works; Rename 'key' to 'unused' to avoid confusion.
commit 64b3054d3de4bcef9d0f5d6d81fe6fdfcf21c511
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:56:53 +0000
Rewrite the _sso_updated function: we no longer receive key-specific updates
commit bf7751f352477c37047255ba4ae3ed4f90cde8d8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:50:38 +0000
It is possible for the AG API to pass us duff account ids. Check for these.
commit 03b1e1d3ebe2a9c48948eef41814e6db6eda45c6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:48:48 +0000
Update the initial account loader to use the new watch-for-updates helper
commit 21df44e6daff7d30e6aef2e3a440f1735d2b8340
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:48:01 +0000
Update _sso_created to use the new watch-for-updates helpers
commit 69a89f369a79e6a838cc947a2cc6d36c13d052ea
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:45:33 +0000
Update watch/unwatch functions and tracking hash to the new setup
commit ae8e6e74bb7e94b03d5c21239f0b1a93612ab8e4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:42:58 +0000
Alter the watch data struct and helpers to drop the key, which is going away
commit 45b87d988829536ed03106e47b44b505c90e9cf0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:40:48 +0000
Forward declarations for static functions so they can be referred to freely
commit 024c428d90c999fd0bade3e8fe46d8bf36102770
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:34:04 +0000
Copyright update
commit e09ac5ad2d3df2812d91ba8284aec7abe3031dc1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-03 19:33:39 +0000
Accounts will be queued up for a delayed-create in _list, not here
commit 12fd8163c225f4832bffee4f46a749f4fefdcfdd
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-03-03 13:16:29 +0100
move delay approvers tests to tests/
commit 55f1a0545ede0d54ce65c2a32bb87bda62a9f5b5
Merge: ca1e743e 4371e5e4
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-03-03 13:15:47 +0100
Merge remote branch 'jonny/delay-approvers'
commit ca1e743e3f5ff6726981d0b61f763629d42866d1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-01 17:39:15 +0000
Nano version 5.7.5+
commit 08fa4d72819bb13686c5e6caa3b9fd4f1cf3185a
Merge: 07bc3de7 69102bee
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-01 17:36:01 +0000
Merge branch 'master' into telepathy-mission-control-5.7
commit 69102beed05d7e2eec1d087b74c218f731f4bbd1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-01 17:23:25 +0000
Version 5.7.5
commit ff0847e2dea8848c76d6f965014a1d1869d2d710
Merge: 28c11afb 28581cc8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-01 16:57:09 +0000
Merge branch 'master' of git+ssh://git.freedesktop.org/git/telepathy/telepathy-mission-control
commit 28c11afb58a9809e648b6de8fadda6a9c2308773
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-01 16:31:21 +0000
update LIBS for gtk-doc scanner
commit d5d40f83aa1e92cc374b3483259516187997f79f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-01 16:31:05 +0000
update LDADD for mission-control-5
commit bb9e6d06935400dbe599a158cf1d4a6122f5bcc2
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-03-01 16:30:44 +0000
update LDADD for mc-tool
commit 28581cc816dd6082916db86d68200a439d64934a
Merge: 6933fb35 4e69beff
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-03-01 15:45:33 +0000
Merge branch 'misc'
Reviewed-by: Marco Barisione <marco.barisione@collabora.co.uk>
commit 4e69beff3dd97487a6aff5b934a09c5123b82f22
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-03-01 15:13:04 +0000
mc-tool: remove support for þe olde profiles
commit 41dec7ea5438f44068318fb4c69f28e5a13fa241
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-24 17:56:35 +0000
Be more robust against cataclysmic test failures
Previously, if MC never claimed its bus names (because it was crashing
on startup, for instance), the exception in the test initialization code
wasn't caught. This means nothing would ever quit the Twisted mainloop,
and the (failed) test would sit there forever.
This patch ensures that the test exits uncleanly if this happens.
commit 6933fb3526029c61c3078177f8bc3cd3bb9e0358
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-24 20:10:17 +0000
Checking the wrong struct member before clearing - spurious g_critical
commit 07bc3de779b128a3d3071724542ef1b9b450dfbf
Merge: a7a97dc6 5339401d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-24 14:27:57 +0000
Merge tag 'telepathy-mission-control-5.7.4' of git+ssh://git.collabora.co.uk/git/telepathy-mission-control into telepathy-mission-control-5.7
commit 8fa0deffe7d07e2ffb1a19125f2a166c2d5830fc
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-24 14:13:08 +0000
Bump to 5.7.4+
commit 5339401da8010e205f6688eb1bb74bdf4355fffc
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-23 23:29:41 +0000
Version 5.7.4
commit b33885b5c94e0f6fc7c3773cc295747709ca61cf
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-23 23:32:56 +0000
Update telepathy.am to moan about gtk-doc.
commit aa0797f88ca2662d39e865bd85f72b73a891a077
Merge: bb001a64 c3be05c7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-23 23:28:42 +0000
Merge branch 'external-password-storage-34416'
Signed-off-by: Will Thompson <will.thompson@collabora.co.uk>
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=34416>
commit c3be05c7c44f0645ff919f6832dc1f744c4b6c8b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-23 23:04:38 +0000
Depend on telepathy-glib 0.13.14.
We need this for emitting and connecting to PropertiesChanged
commit 84aa24868fb5b2fac5d683116006950667dead51
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-23 22:46:55 +0000
Preserve deleted account while calling Identify
When an account is deleted, we'd expect that the McdAccount object will
die shortly afterwards. However, we need to ensure that RemoveAccount is
called on connection managers that implement AccountStorage. Previously,
the account object was used as the weak_object for the callback to
IdentifyAccount; this could mean that the callback would never fire, and
thus we'd never get around to calling RemoveAccount.
So this patch holds a reference for that callback.
commit 78221c62bf02313e76947d3f6872de7e4322a548
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-23 16:47:45 +1100
Emit PropertiesChanged for PasswordSaved signal
commit 42c90a1d3e230919c10dda20d7d5fdf5e58074cd
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-23 16:40:59 +1100
Implement PasswordSaved
commit 6eb2ab4e6c23c828db78d0c8d1dd933aa0baea87
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-23 15:47:46 +1100
Call CM.I.AS.RemoveAccount() when the account is deleted
commit 54fa2a2190c7f8f57d12e63f488e4f425380866b
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-22 15:22:46 +1100
Implement ForgetPassword()
commit acbf3a967441f1202fb4fa15858ad6a4e71baf04
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-22 15:22:24 +1100
Build client bindings for CM.I.AS
commit 2e0e96d8a183cb0d18cf2754b94e91751f89d518
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-22 13:56:44 +1100
Hook up skeleton Acct.I.EPS in McdAccount
Currently activates the interface when the CM.I.AS is present on the CM. Needs
the methods and properties implemented.
commit 696c6f6ae82cb478247b9921b28a5e3b17579cbf
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-22 13:56:05 +1100
Add CM.I.AccountStorage.DRAFT from tp-spec
commit 711ab5b25fe5d9108802cdc52ff02fcf8cf3f05f
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-22 13:41:58 +1100
Add Acct.I.ExternalPasswordStorage.DRAFT from tp-spec
commit 7365dde12d91eade4039fdb28cb79c3e3e14dfa4
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2011-02-22 13:36:29 +1100
Make it possible to optionally implement interfaces on a MC object
Defining an interface as MCD_IMPLEMENT_OPTIONAL_IFACE() indicates it should
not be included in an object's Interface property by default. Instead the
interface is activated by calling mcd_dbus_activate_optional_interface() on
an individual object instance.
This makes it possible to implement interfaces such as
Acct.I.ExternalPasswordStorage only on accounts whose Connection Manager
supports it.
commit bb001a6497ec414594ad5221eaad42a015a478b2
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-21 19:13:07 +0000
check_one_parameter_unset: fix conditional's indentation
commit 9c8d9765ec0af9f82dbece22b4729a25bb8f320f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-21 17:25:43 +0000
UpdateParameters(): allow unsetting nonexistant parameters
I missed the spec's decree that literally anything be permitted in the
list of parameters to unset, and since there was no test for this nuance
I made it regress. Here's a fix and a test.
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
commit a11e1d23c3a292aba89ad8f7863bf3a5d2c14933
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-21 17:16:12 +0000
Here is some news.
commit a4ca0e65fc908d499ff14582477fc9a99e65eda1
Merge: 5df9ab23 718d297e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-21 16:14:17 +0000
Merge branch 'fd.o-34316-UpdateParameters-fixes'
Reviewed-by: Danielle Madeley <danielle.madeley@collabora.co.uk>
commit 718d297eabac88364ffc35ad076987b564dd5ef1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-21 15:52:12 +0000
UpdateParameters(): clarify releasing memory.
On fd.o#34316, Danni sez:
> It might be nice to have goto finally; and then error: then finally:
> so that all the memory is released in one location -- since my first
> question was whether or not the error path free'd @protocol.
She's right, it's not clear. Nicolas suggested this even clearer
implementation. (It would be even even clearer and shorter if this
function returned a value rather than calling a callback
(synchronously), but oh well.)
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
commit 63c636e2f5f3149c792ce048e380a0ee9f376c22
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-18 17:30:59 +0000
Update copyright for files touched by this branch
commit 0774476cae8f4f0336dc6913307b3d66871e58c9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-18 17:23:28 +0000
UpdateParameters: break apart check_parameter_update()
I had thought that the logic for setting and clearing parameters was
similar enough that combining them would be a net win, but it seems that
that was not the case. This patch rearranges check_one_parameter()
check_parameter_update() into check_one_parameter_update() for parameter
updates, and check_one_parameter_unset() for unset parameters. There is
a little duplication, but these are much easier to follow.
Dear reviewer, I'm sorry for the many false starts in this branch. I
did try to rebase them out of existence, but…
commit 5961487b0ec321b72e58ab9823ccd6f0a0097c95
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-18 16:42:52 +0000
UpdateParameters: check for setting parameters to their default
A few patches ago, we made MC smarter about unsetting parameters which
have default values. Here, we make the symmetrical case work: explicitly
setting a previously-unset parameter to its default value should not
need a reconnect to take effect.
I really don't like how complicated check_parameter_update() has become,
but this does actually seem to need to be this complicated to get every
case right. Perhaps check_one_parameter() should be split into 'set' and
'unset' cases.
commit 43523d6c224129aaeb64f55ceed3c6719c3e2919
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-18 14:33:40 +0000
UpdateParameters: consolidate post-validation code
commit bb8a5fdfc607f4d01688884dcd3886fa004cb61b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-18 13:38:38 +0000
UpdateParameters: clean up freeing Not_Yet array
commit 6173858addc6fa15072776e780298779972cfa2c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-18 12:58:49 +0000
UpdateParameters: apply Unset parameters immediately, if possible.
If a parameter in the Unset list was previously set to its default
value, there's no need to reconnect to apply the change. Also, if its
default value is different, but it's got the DBus_Property flag, we can
apply it to the running connection.
Distressingly, fixing this does not actually make this code much
simpler.
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=34316>
commit 0120affac05efd57f5eca2582a925df3ccec3f46
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-18 11:17:33 +0000
UpdateParameters: keep a{sv} of DBus_Property parameters
This will make it easier to support unsetting DBus_Property parameters
with the Has_Default flag.
commit c4a4b83959e537a66ca0845e73136d7985e5f29e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-18 10:18:57 +0000
UpdateParameters: Extract checking params to a function
commit 192c653f1df8a44a18d3c03895009592dc5ab904
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-17 19:02:42 +0000
UpdateParameters: expunge SetParametersData completely.
I left some FIXMEs in for places which leak (not a regression!) or don't
leak but look like they do. Clean-up comes next...
commit af017acef7b4e4a296aa4b1ab3464d040626b75f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-17 18:47:14 +0000
UpdateParameters: move things out of SetParametersData
This struct makes it much harder to see which functions actually use
which data, and I think we leak some of it on some code paths. So I'm
gonna get rid of it, piece by piece.
commit 152022957ddf4b5bfdfbbd778e84f03b2522db88
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-17 18:27:01 +0000
UpdateParameters: Use a GQueue for DBus_Properties list
I'm a GQueue addict, I know.
commit 079546c39ca0d994320d415ca6f694afbf693e99
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-17 17:59:01 +0000
_mcd_account_set_parameters: remove stray 'return'
commit 42c9023fd739142cd19500b7fa95e20f1bf85169
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-17 17:54:56 +0000
Test UpdateParameters with invalid parameters
commit be6c320406c5574bfb58dc735d2885892539df6e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-02-17 17:39:50 +0000
UpdateParameters: linearize setting and unsetting params
I love continuation passing style as much as the next guy, but this
doesn't add anything.
commit e91e385dfb4578ba93d19648536eecd2e7a3a0fe
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-16 15:26:51 +0000
Delete the account stats interface, we don't need it any more
commit 5df9ab23a8489a0ccd9e8563a4388c54cc677078
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-01-20 14:28:29 +0100
add redispatch-channels.py testing RedispatchChannels()
commit bffe11ea92d8910c689f80a365f4343b5f52cab8
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-01-20 14:28:07 +0100
implement ChannelDispatcher.RedispatchChannels() (fdo #33271)
commit 3124576fa649683e61718329d0c5ab3277405db3
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-01-20 14:27:36 +0100
expose mcd_connection_find_channel_by_path()
commit 79b67507da3abec9a493f1f5780e2ab1535cfe30
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-01-20 12:18:48 +0100
factor out check_preferred_handler()
commit 8c76ddb3661c73855a43f67da4eb023c2edbad23
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-01-19 14:49:40 +0100
generate ChannelDispatcher.Redispatch_Channels has a DRAFT
commit c5e7ddbc3866fae72bf7a41ffe90fa0787862f13
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2011-01-20 10:01:53 +0100
mctest: silence the queue if we hit an error
This a backport of the Gabble commit ee177cfb2a13a8374e2f1037e806b7bc58aa708b
commit 1f7e0162173a0db91f7bda37eef45de84279cad9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-15 16:02:53 +0000
version 5.7.3+
commit 0b7bd4c8bbddd39b72d27423add2ba3adbacab58
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-15 16:02:15 +0000
'UNRELEASED' checks activated
commit a7a97dc694bb41922f0ce7e38291a7582f7ed373
Merge: 4cca7b6e 181b72b6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-15 15:24:06 +0000
Merge HEAD, branch 'master' into telepathy-mission-control-5.7
commit 181b72b62e7c908268d09ae7ed8388c820e28d04
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-15 15:00:34 +0000
Prepare version 5.7.3
commit 9b5e028ed37d3b7ed6d95ffb02d1a9661ef12564
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-15 14:51:14 +0000
Update copyright notices, prefer AUTHORS to per-file Contact: entries
commit c0d77221030db1c2959a5f4427d5e1471c1c1a45
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-11 14:53:43 +0000
Clear the emergency data (and emit a critical warning) when setting
They should always be empty when they are set, but cope if they aren't
commit 3ce692fb7a14eab86021de9b3fa8cf06055dec1a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-08 14:52:04 +0000
Use predefined dbus property constants instead of rolling our own.
commit a3bf09f24da81e0a2e894c91f23b8bd753cfb881
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-08 14:40:15 +0000
Missing call to clear the emergency data in parse_services_list
commit 5a78285c5134bb37585a4775388fadabd1693ebe
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-08 14:19:16 +0000
Rename _set_emergency_* to _take_emergency_* to indicate change of ownership
commit 9d501e530d92ab5b39745fbe7c7eafd51c43b946
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-08 14:07:37 +0000
Change asserts in emergency data helpers to warnings
commit 73d357732aa4088ff3c9a648d8c054b51a5208f3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-08 14:04:10 +0000
Added emergency number helper functions should follow same style as file
commit 28ee310ee78e09efea8c47d9085f8f4791729410
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-03 20:06:02 +0000
Bypass request policy delays for urgent channel requests
commit 87c96d3ea28780955ab78f9feb74c527cc709e40
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-03 20:05:09 +0000
Cache the request policy plugins the first time we need them
commit 12cb4e4be79067edb7013683856936de45424a8a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-28 04:43:12 +0000
Use service point data to check if a connection is urgent (eg an emergency call)
commit 1906a3c4228bc7182a89058ef71468612998cfb2
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-28 04:37:32 +0000
Start watching a connection for service point data the first time it becomes connected
commit 0f7484069b3cda5a362353067b0f46fd74a47ee9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-28 04:35:49 +0000
Support watching for service point/emergency data and updating the connection
commit bcd72e3363d246adc0b9c50e963813c4a0b7b9e0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-28 04:30:53 +0000
Helper function to set emergency handles data
commit c03b89519ab8522f6c457290e6512d0a88a87025
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-28 04:30:06 +0000
Helper function to set emergency number data
commit 9e9e3b49987778d7ed3df9757ca302c75cac2d22
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-28 04:29:16 +0000
helper function to clear current emergency number/handle data
commit e42743b23c38e309c0c2f0c53b610bd596643b2b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-28 04:28:02 +0000
Add struct entries to hold emergeny number (service point) data and state
commit 485607b16534ed9ea9b9bd643cbbf9fff2672557
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-14 19:02:45 +0000
Update libtelepathy-glib0 dependency for debug_sender updates
commit 3321165f24740d0d2b5947e3353fc78ddc4e85ab
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-02-14 17:53:11 +0000
Be parsimonious with printf ops in the mcd_debug path.
commit 52d53425d4dfb2c65ec4e640c42004318f19074f
Author: Marco Barisione <marco@barisione.org>
Date: 2011-01-28 14:56:39 +0000
McdAccountManager: don't leak if mcd_master_get_default() returns NULL
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=33651>
commit 0d69567e4d0d94e6018c10f528b177195c75b958
Author: Marco Barisione <marco@barisione.org>
Date: 2011-01-27 19:02:27 +0000
Aegis plugin: fix a leak of DBus proxies
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=33612>
commit fa4de0d15ea4f2184e76f935ff79708fcee11eb4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-19 17:55:24 +0000
version 5.7.2+
commit 4cca7b6ebb02353a0066a9180e9521724d0e0a8c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-19 15:27:55 +0000
Merge HEAD, branch 'master' into telepathy-mission-control-5.7
commit 833f5e87182e5053381bdd1502fe93b49c4cd347
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-19 15:10:38 +0000
Prepare version 5.7.2
commit c6114d74c265e77944968c46dd7afd0b09839ef7
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-19 15:10:21 +0000
Tests using the debug API must be in the special section to work in distcheck
commit df58b39efd5db4c8cf2ad85a75377fde48191439
Merge: b7b9ffc4 730dcebb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-18 16:54:29 +0000
Merge branch 'hidden-for-accounts-glib' of git+ssh://git.collabora.co.uk/git/user/wjt/telepathy-mission-control-wjt
commit b7b9ffc40cd0feadb37d735af97232355d4472dc
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-11 18:54:31 +0000
Explanation of map had drifted away from same (in terms of location & accuracy)
Updated text to reflect what's actualy going on now, relocated it so it is
next to the structure it explains.
commit 90f793ae18e049aa93d1cd0a1afc6154ec19ac5c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-11 18:01:05 +0000
Commit delay now #defined and logged explicitly
commit f698e3371d4dd5fd3922f26c4217d71fd4315ad4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2011-01-11 18:00:09 +0000
Add comment explaining _commit, remove obsolete FIXME comment
commit d40546d1c6aa6cceae3330e614d95f67492681b2
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2011-01-01 19:12:10 -0800
Delay actual commit() in sso backend.
commit 730dcebb085d9fc3be97a8a9a240c5f23983de2e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-11 16:47:01 +0000
Set a plugin name and description for ag hidden backend
commit a4115f4dc452905c4cfdfbbc5b1b989f79558080
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-11 16:22:38 +0000
Add a configure flag for hidden accounts-glib backend
This is a pretty niche use case; it's not worth building it unless
explicitly requested.
commit 744fdc63357fe815c1894a9cd5cfafe75791bfb3
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-08 15:22:30 +0000
Set Hidden on accounts from hidden accounts-glib backend
commit e929ec07702c77dc00e2e8962ea8e4865d33cc9d
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-11 10:44:27 +0000
mc-tool: show Service (if present)
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 22f6152262224c5868e24c00200e6af9df4fc5d0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 20:05:58 +0000
Add an accounts-glib backend for hidden accounts.
Currently this doesn't hide accounts; it just looks for accounts of a
different service type. But hey, this is a start.
commit dc3b9deaf8a6f46e40297af555be40cfcee706ba
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-10 18:56:34 +0000
account-glib: Remove spurious newlines in DEBUG messages
commit 0363a3de3c94a78f5ed9e8df20ca28f05324d5f3
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-08 22:18:38 +0000
accounts-glib: remove unused list of services.
This was used in an earlier incarnation of this backend, but now is just
leaked.
commit 60e1c9fe201e0ddca8bb0881f7cdd00bc8f753f6
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-08 14:58:19 +0000
accounts-glib: expose _get implemenation for subclasses
This is only needed because McpAccountStorageIface is hidden. See
<https://bugs.freedesktop.org//show_bug.cgi?id=32914>. This is a
workaround for now.
commit 3373220c555262955684732e02716e688ccfd3b6
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 21:49:08 +0000
accounts-glib: split up gargantuan _get implementation
commit 43555b2311992a2668441c87f98c20411c34a02f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 20:03:18 +0000
Clean up loading account storage plugins.
The duplication of g_list_insert_sorted() was getting me down.
commit 2858bbac87eeaa96814996ead4cc64db3b75c4b8
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 19:57:32 +0000
Correct MCD_ACCOUNT_MANAGER_SSO_CLASS() macro
commit 508c59b67c7a19cb32108dc562ad9b16b52264a8
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 19:18:06 +0000
accounts-glib: make service type parametrizable
Rather than hard-coding the "IM" string everywhere, we now call a
private method which looks up the accounts-glib service type from a
field in the class structure. The default implementation is of course
"IM", but this will allow a subclass which looks for a different type of
accounts.
commit 88df5c5e996b6886d3854a2c643d1f288e2f4f4d
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 18:55:45 +0000
accounts-glib: List services in constructed, not init
I'm about to replace the hard-coded AG_SERVICE constant with a field in
the class (so that a subclass can look for other services and set Hidden
to True for those accounts). However, as we discovered way back in
f7b7aa8e477abe03c1340c2b200ddcf9c9792c2c, when _init runs for class T,
G_OBJECT_TYPE() always returns T even if we're constructing a subclass.
So we're going to need to wait until constructed() to get at the desired
service name.
commit 972883acdc5f11e247b807477199fd5cf029d4b4
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 17:58:49 +0000
accounts-glib: declutter class_init
commit 425a2bb4aa78a3184239e4b7e2d9f32c7ea7f9db
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 16:12:15 +0000
accounts-glib: make null termination clearer
commit 9799ff9a74700115f8eb3c7bd08f71e0b0440971
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-31 00:34:55 +0000
Add a smoke test for Account[Manager].I.Hidden
This doesn't really test all that much, but it's better than nothing.
commit 183be5735a3f15c2543a0059e234a8c386c49427
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-31 00:32:39 +0000
Implement AccountManager.Interface.Hidden
commit c2ffc90b046a03942bc137db6b0f33d117763060
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-30 22:39:47 +0000
Implement Account.Interface.Hidden
commit 02e3aed21485b375fda2d1c632074592b13263a8
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-01 19:47:01 +0000
Generate code for hidden account interfaces.
commit 8e011b287da8f1b2319c8c947f636e87fda9f5c7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 14:34:58 +0000
mctest: improve error messages from post-test cleanup
commit 1eac316750a070612a24249063ba992602acd03a
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-07 15:31:03 +0000
AM: Remove a stray paren from a debug message
commit f5cef05a9d4b76c78045dcb6642964939e063698
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-06 19:07:05 +0000
tests: extract common mc-slaying and keyfile-reading code
commit 4c99fea93bcc5a29f642fefad6b32329877117a5
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-06 17:23:47 +0000
mctest: tidy up create_fakecm_account()
I think it needs a better docstring: I keep forgetting what it returns.
Plus it's full of unnecessary comments and no-op code. So let's tidy it
up a bit.
commit e90cfdcf5f8991457f631cecef227e0b0ae0af21
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-06 16:32:57 +0000
mctest: support passing properties to create_fakecm_account()
commit 081fdd53678d5579f90c1f5d753274284b439063
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-10 19:03:33 +0000
account_check_parameters: assert callback is non-NULL
This function was already actually assuming this in two of the three
places it calls the callback, so let's assume it properly.
commit 4c79dba8a2fbdceb5460a6b124ca9a7790fa7731
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-10 18:56:45 +0000
Log why we're declaring accounts invalid.
If the CM is flat-out missing, then we get debug output to that effect.
But in the cases where the CM exists but lacks the relevant protocol, or
the account is missing required parameters, no useful information was
given.
commit 12be4b8cfc2f4fc9a46a03a3c3a1149f089cbab6
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-06 11:11:26 +0000
Preliminary news for 5.7.2
commit 50454504ed1036f383deebeafd4b675da741f75f
Merge: 4e08c426 b30dfb18
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-06 11:04:05 +0000
Merge branch 'misc'
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit b30dfb18026448d25c699ba77a484c0ab11e6451
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-05 18:06:39 +0000
Simplify mcd_account_set_string_val()
Hey, there's already a function that sets a string and returns TRUE or
FALSE depending on whether or not it's actually changed.
commit db50713152f6154b0a42c3f8ef23e25ff73987d7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-05 17:40:47 +0000
Storage: allow backends to implement only one of commit/commit_one
This mostly reverts 0d914e13cc4a6e84cebb840c0be4d32abaacaddc, except
that it preserves the fix for the bug which could cause a NULL ->commit
implementation to be called. I do not believe this interdependency is
“irrational”: it reduces the boilerplate that backend implementations
need. Plus, this makes the implementation match the documentation again.
This also improves the debugging messages logged by
mcp_account_storage_commit() and mcp_account_storage_commit_all().
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=32153>
commit 53d38f675dd389f6d04fff5855094362c7e49aac
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2011-01-05 17:27:20 +0000
Account: ensure updated string properties are committed.
Properties whose setters were implemented using
mcd_account_set_string_val() were actually not committed to disk
unless/until some later property whose implementation is correct was
updated.
I noticed this in passing, not while checking out any particular bug.
However, I think it may be responsible for the issue where people's
aliases are re-set to their JID for no apparent reason. I don't really
have any evidence to back this up. I did tweak one of the storage tests
to expose this bug, though.
I've checked a whole bunch of other properties, and I think the ones not
implemented using mcd_account_set_string_val() were all already okay.
commit d80eb01daa3fda0b3153a8ab1fa382c0dc6fd38b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-31 00:54:49 +0000
Accounts-GLib backend: fix shadowing warnings
acct() is a function defined in unistd.h, which something winds up
including in this file.
Sometimes 'acct' was an AgAccount, and other times it was the
"cm/protocol/foo" identifier. I changed the former to 'account' and the
latter to 'account_suffix' where needed, as a first step towards
coherency.
commit e01643fdc290a668e5a532da7f8eccd9bf0856ca
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-30 23:47:02 +0000
tests: improve assertion when forbidden events occur
This makes the backtraces prettier; it doesn't have any functional
effect.
commit 2730cf23367fb0d2198b402c2bf4cb98a82cef42
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-30 23:36:37 +0000
Tests: handle more exceptions during cleanup
Previously, if a non-DBusException was thrown while the test harness
deletes any accounts left kicking around, the reactor would just hang;
killing it would make Automake think the test passed!
This does a better job.
commit 4371e5e46ebd8d6537c9d6ba5106ee8bc703c1b8
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-01-04 11:22:48 +0000
mcd-dispatch-operation: explicitly cancel calling approvers instead of accidentally
Previously, the "run approvers in an idle" function would be called
when an observer returned even if he or she called
HandleWith{,Time}. The idle function would set
invoked_approvers_if_needed to TRUE and try and run the approvers if
needed, followed by checking the client locks again. This made
non-interactive approvers implemented as delaying observers work
because it wouldn't actually call ADO on approvers due to
mcd_dispatch_operation_is_approved returning TRUE, but this way makes
the process a little more clear to understand.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 36eeb9164dbb631c35efb1405bc6efb1c23c5e77
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-01-04 10:16:33 +0000
delay-then-call-handle-with.py: add test
This test creates an observer and approver/handler. The observer has
DelayApprovers=TRUE. The test makes sure that AddDispatchOperation is
never called on the approver when the observer steals the CDO and
calls HandleWith.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit bb5ea0cb107b80933d886e17059f9662058db2d0
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-01-03 15:27:35 +0000
delay-then-dont-call-approvers.py: test non-interactive approvers
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 8ef108d09cba245f71cdb6dc2a18cfc4ed2d7025
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2011-01-03 15:25:08 +0000
mcd-dispatch-operation: stop calling ADO if a delaying observer called Claim
Previously, the Claim call would be handled as usual, but an idle was
already added to call ADO so when it was reached it asserted as the
dispatch operation had finished.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit ec6666d0b0edd70644498773f2cfa83ee21d57d9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-24 17:37:15 +0000
tests: simplify holding the name for fakecm
commit 48b13f6fc212b50118a7672b196b14b2bd96298f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-24 16:03:15 +0000
mctest: use ProxyWrapper for Account/AM proxies
ProxyWrapper's a nice class that deals better with multiple interfaces
on a remote object than bare python-dbus proxies do. So this reduces
some of the boilerplate in mctest.
I didn't go around changing all the tests to use this, because life is
too short.
commit 4e08c42659381c315feda5f3ba7250925c499869
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-22 16:10:40 +0000
tests: add a tests/README symlink
I always get confused as to how to run the tests as I look for a
tests/README and it's not there.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 5b34520e25c014377a27f22d35b958ded994a2dd
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-22 15:54:58 +0000
tests: move from test/ to tests/
So so annoying.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 1d9f17613ac2ce1dc3928ab0848d7b9b987b6330
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-22 11:04:25 +0000
create-with-properties: remove unsound signal expectation
When this test creates a new account, it expects four events to occur:
• A.AccountPropertyChanged, to say the new account is valid;
• AM.AccountValidityChanged, to say the new account is valid;
• CreateAccount returning successfully;
• RequestConnection on the fake CM, because ConnectAutomatically was
set to True and RequestedPresence was set to non-offline in
CreateAccount.
However, if the account's not yet been announced by
AccountValidityChanged, MC has no reason to emit AccountPropertyChanged
on it. It happens that, in some cases, it does; but this depends on
whether or not MC has already introspected the fake CM by the time the
account is created. So the test is wrong to expect
AccountPropertyChanged. Instead, we check that Account.Valid is in sync
with what AccountValidityChanged said.
This fixes an issue where this test would only pass if it was run after
account-manager/create-twice, but not if it was run individually.
commit 9ad89fea078ea23178a99608fc18b753bd6f2005
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-22 11:01:31 +0000
create-twice.py: use a different 'account' parameter
This test runs right before a test which passed or failed depending
on whether this test was run. The logs were made much harder to read by
them both creating accounts with very similar names.
commit 4afb8eb6314395eae3e3c4a905062183c2dcc090
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-12-22 10:14:40 +0100
stop generating Hints interfaces
commit c2f15753fd5d3f874f4ef2d06c43bdcfeb0b492e
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-12-22 09:59:16 +0100
SucceededWithChannel signal is now stable
commit aa56027c9de02c8db28071548f2c96f059ac0fed
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-12-22 09:48:28 +0100
ChannelRequest's Hints property is now stable
commit 15c262255cbe130ad731358b1182a5e3457d05bd
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-12-21 15:41:32 +0100
{Create,Ensure}ChannelWithHints is now stable
commit cbffe9b899c1da6e7188685bc3bf5995a49eebce
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-12-21 15:36:23 +0100
depends on tp-glib having request hints stable API
commit 2401aebf11aaf5cc4478dc80c2b5c958308df5ed
Merge: e33f8946 7f16c518
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-21 18:56:39 +0000
Merge branch 'remove-MinimumPresence'
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=29812>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit e33f8946ac20e0a85a075e837b6318ac2974829e
Merge: 359d1c55 cfe36847
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-21 18:56:03 +0000
Merge branch 'simplify-getting-parameters'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=32414>
commit e2432e19fdab9412209096844b90eb68fcdf0cde
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 17:45:48 +0000
tests: test having >1 observers where only some of them have DelayApprovers=True
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 1b7156299d4124f9216d2584f8476244b90f208e
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 17:45:12 +0000
dispatch-operation: only delay ADO if there exist DelayApprovers=True observers
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 8cd1e11c37f575e804acf7b3f9a2fe1fddb5805a
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 17:09:43 +0000
delay-approvers.py: fix typo in comment
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit d43e3a50ace82ad1b4603f6ee08709bd53b7a507
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 15:59:30 +0000
tests: add a test for DelayApprovers observers
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 6d6b34b49171602e9bf47039b991d0376dd2c457
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 15:58:22 +0000
mcd-dispatch-operation: don't call ADO if DelayApprover Observers haven't returned
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 6ef602298271ae2741e6e75245002684fb2ff9a6
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 15:56:57 +0000
mcd-client: pick up Observer.DelayApprovers
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 359d1c553b7135dcceebf5c80d49a81dd3521362
Merge: 41316649 9e4ddfb9
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 14:13:26 +0000
Merge branch 'test-fixes'
commit 9e4ddfb989f05fb7a4c6c8f5c435e4319c7abd0d
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 14:06:42 +0000
create-at-startup: don't expect ObserveChannels calls so close together
Now that preparing the connection takes one more step, it can take
longer before ObserveChannels is called with the channel that just
appeared on connecting, so let's allow that to appear earlier.
This only relaxes the test assumptions a little. Although it currently
fails on 0.13.9 and this fixes it, it'll still work on tp-glib <
0.13.9.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 95e56df4a2a0acc89c86fd85eb25ae0e7cdb603d
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 13:20:41 +0000
mctest: implement GetContactAttributes and GetAll on Contacts
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit e3e955d792db4328ff026a7c1c48c13dc8028826
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 13:20:30 +0000
mctest: implement HoldHandles
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 41baccd21db1ffc14d694b9d631b3385178894f6
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-12-21 13:19:56 +0000
mctest: implement GetAll on Connection
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 7f16c518a48a964f94d6b211bd224e7a29219910
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-01 18:48:15 +0000
Remove MinimumPresence implementation.
I feel kind of bad doing this, but it turned out not to be needed. I
think it's better to take dead code out, rather than leaving it kicking
around to potentially complicate matters later.
commit cfe36847c8afec4277ea042465917fc2d8e9631b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-03 00:44:44 +0000
McdDBusProp: remove get_async
The only property that was implemented in an async fashion was
Account.Parameters. Since that's now synchronous, we can bin this code
for getting properties asynchronously.
commit 94d62e8d68ec1d657b8af36f467b1520703632e5
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-02 18:21:58 +0000
Make _mcd_account_dup_parameters() synchronous
This is a really massive patch, and I'm very sorry.
Previously _mcd_account_dup_parameters() took a callback parameter. This
was because mcd_account_get_parameter() took a callback parameter. The
latter used to actually be asychronous in the gnome-keyring case, but it
is not any more, thanks to the harmonious account backend API.
So we can remove a *lot* of unnecessary complexity if we make the latter
return the parameter's value synchronously, and hence make the former
return a GHashTable synchronously. In particular, this means we can make
retrieving the Parameters D-Bus property synchronous, which means we can
port to TpDBusPropertiesMixin.
I did try to split this patch up, but as you, dear reader, will be able
to see from what I ended up with, this code was all really entangled
with itself. This is the best I could do.
commit 8cbdbdb68311f7df76e99b87257d256975fedb5c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-02 15:19:25 +0000
McdAccount: Remove un-overridden virtual methods
No known subclass of McdAccount overrides get_parameter, set_parameter,
delete or load these days. People should be, and are, using the new
pluggable storage backends API. So it's safe to remove these methods
from the vtable. This will simplify refactoring their (default)
implementations.
commit 08ba772275f1d5d87041e665afdad3216bf81df7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-15 14:35:02 +0000
Account.Service: remove unnecessary explicit fallback.
dbus-glib treats a GValue containing a NULL string as equivalent to a
GValue containing "", at least in this context. Many other properties
rely on this behaviour; so let's just rely on it here too.
commit 8bd702c5c15afc24e4ab64847650a512fac37858
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-15 16:51:14 +0000
Tests: correct name of Conditions.Condition property
The property's actually called Condition, not Conditions. But because
McdDBusProp returns the same error for “unknown property” and “wrong
type”, the test passed.
commit f4b1a6175634948e376bf9047d88d81d5b2b2fa4
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-01 19:36:27 +0000
Remove redundant object path/bus name constants.
These have been in tp-glib approximately forever.
commit baeaade204481e7bd400d419ebc2ccb2084c5fed
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-01 19:19:47 +0000
Remove long-obsolete mcd-presence-frame.h
commit 413166490899fa583a8193197e2b62310a3e5d37
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-12-10 17:39:47 +0000
Update telepathy.am from telepathy-glib
commit cdb289c8d0f9cb96d90e287d526d408590b9e145
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-07 17:14:32 +0000
Start 5.7.2 development
commit 52840f8f8aa13f1d91fe5eaad93cf888e52c1497
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-12-06 18:55:50 +0000
Prepare version 5.7.1
commit 3a320720d744f6a0d61bc0ae8bc95b5a52bb7a04
Merge: b4bafff4 24722235
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-12-06 17:14:46 +0000
Merge branch 'master' of git+ssh://git.collabora.co.uk/git/telepathy-mission-control
commit 24722235b4a0cf6ebca4a08980afa6514de03c05
Merge: 1164508b 3a63c47f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-01 19:01:04 +0000
Merge branch 'telepathy-mission-control-5.6'
commit 3a63c47fa84a7a3d20e2274cd8c8c94771c02736
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-01 19:00:50 +0000
NEWS for fd.o #24779.
commit fc8258409337a777b5249d37df5bc6b88573165c
Merge: 4a2f68a1 438826eb
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-12-01 18:59:57 +0000
Merge branch 'fd.o-24779-CurrentPresence-incorrect' into telepathy-mission-control-5.6
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=24779>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 1164508b9633b352440c880ccccda20f904adf3c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-11-30 18:05:29 +0000
mc-tool: Improve error message for nonexistant accounts.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit b4bafff4c224fc66c592be844ea9daeba2b4334c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-19 17:25:35 +0000
Undo the telepathy to mission control error mapping special case: It's Obsolete
commit 7a7837cf62c9350e3a1b6cc714b15acee6d67363
Merge: 555cb061 4d21b5f5
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-19 17:17:08 +0000
Merge branch 'master' of git+ssh://git.collabora.co.uk/git/telepathy-mission-control
commit 555cb06119523427c5814bc6e13bcbea2e7011f7
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-19 17:06:02 +0000
Nano version
commit 4d21b5f58a8ce6f5ec4685ec298548c9b83ba37b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-19 13:00:55 +0000
Update telepathy.am from tp-glib and add make-release-mail.py
Also only ship the changelog since 5.4, which should be plenty.
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
commit df17fb16b8c26b255ca6fad5a2f6010520b7a7bd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-19 11:15:34 +0000
Start 5.7.1 development
commit 77826308a3ca7c92d0e71aff77e99ebb45f88516
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-19 11:15:07 +0000
Retroactively add more NEWS
commit bf40bc1481782d96d85135c58823a8bf414ef89f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-18 18:45:35 +0000
Header file no longer exists
commit 9fa087c98eb75ec31f71dda787c5661ea3f2110f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-18 17:40:58 +0000
Prepare for 5.7.0
commit c221ef54e7a3d52f379945304cc2d406dccf1212
Merge: e4700732 7a9ee6b4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-18 16:20:17 +0000
Merge branch 'account-interface-addressing'
commit 7a9ee6b457755f93e2273b286cbe51f9ed1e0036
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-18 15:57:39 +0000
mcd-account-addressing.h contains no API, move from mc-headers to *_la_SOURCES
commit e47007323c3983ef207a3f2f03b78d858e3395d1
Merge: fdd9048d c57e8e15
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-18 15:51:45 +0000
Merge branch 'missing-am-account-removed-signal'
commit fdd9048df1f385c0ccc431422ab7585078a40ee4
Merge: 93d4f79d 98d2148d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-18 15:51:32 +0000
Merge branch 'keep-calm-but-do-not-carry-on'
commit 93d4f79d5d7aac0f80ca53a065c72e9df44e0683
Merge: 37c6ea25 39f8f20f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-17 16:01:04 +0000
Merge branch 'hints'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 39f8f20f74252fccbc4e09f3f66a16a9a8bcf3f6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-17 15:00:16 +0000
Switch from CD.Future, CR.Future to CD.I.Hints, CR.I.Hints from my branch
commit 50a6bb2bbd0343d1c8e849e1efcbb964b4dc4545
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-17 14:48:37 +0000
src: generate extensions per "class", not per interface, for dispatcher/request
commit bc5c448d4c798146322ed5637eab7c31ad5d7025
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-17 14:47:47 +0000
mcd-account-requests: remove obsolete inclusion
commit 98d2148d313c928f88a5c588bf0fa60041998e97
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-17 14:07:10 +0000
abort()'s from inside g_error get trapped as core dumps by test suites
We get a lot of noise in the form of bug reports as a result of these
three because g_error ends in an abort() - we exit(1) anyway, so
hopefully downgrading the error to a warning will calm things down.
commit 37c6ea25e0dcbfa7ec50a04f3929011d698e8461
Merge: 0e41f320 4a2f68a1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-17 13:18:39 +0000
Merge branch 'telepathy-mission-control-5.6'
Conflicts:
NEWS
configure.ac
commit 4a2f68a1b2c84940b844652566710ca2706cfc63
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-17 13:16:59 +0000
Nano version
commit c57e8e157c255735c5b1434b278d04919be0b381
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-17 12:29:15 +0000
Missing AM.AccountRemoved signal when a storage plugin removes an account
Only affects the disabled-in-5.6 SSO plugin which is why the tests didn't
pick it up.
commit 7df3310b088a0187b60c8ba1992ceac4a93026b1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-17 11:45:17 +0000
Version 5.6.1
commit 03937b7ef60e12468e3f661af943edb24ce8eecc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-17 10:56:51 +0000
Update NEWS
commit 0e41f320e6644951a0a22428cab22f0e4adcd90e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-10 14:23:30 +0000
Update PowerSaving to the stable spec that will be in 0.21.5
Reviewed-by: Eitan Isaacson <eitan.isaacson@collabora.co.uk>
commit cd1886ad0ecfef4bdb3d5c3c7c76f2876a7562a7
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-10 15:09:41 +0000
Undraft Account.Interface.Addressing
commit e89e4769683d51970e17854660592dce06c6de5d
Merge: 3cf24b0b 01c4a865
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-11-10 14:15:40 +0000
Merge branch 'handler-request-props'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=30000
commit 36112f9e9b9d5be41318ca2e61b37c7e9deb4a1e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-10 13:53:21 +0000
Unnecessary calls to set() in tests removed
commit cac5fb9a3bb460ac4456d2f5322c51af769937ea
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-10 13:50:12 +0000
Spec change: Acccount.I.Addressing method no longer has a return value
commit 6919f27a0fcd052c9a2c9061a954f9b055a4fddd
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-05 17:21:57 +0000
Test tidy proposed by wjt (cf gabble tests)
commit 7027006f2ec8f559b7e9432d9faf0c7ab644a26e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-11-05 17:01:15 +0000
old_association and association are booleans, don't need to cast with !!
commit 3cf24b0b4feb57ed42fc1894996e42de7cd87732
Merge: d3a26922 60403c99
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-03 11:15:31 -0700
Merge branch 'power-save'
commit 60403c991191511b1840882a64f629bf12aadbdf
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-03 11:14:29 -0700
Maked device idle test a seperate test.
We need the MCE service available from the start.
commit b1d9b8d2048d8bbe254c5ad7236c42a8950df169
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-03 08:59:23 -0700
Report error if inactivity retrieval failed.
commit d3a2692288e1494f48cbcb1085f69c4fa799a87d
Merge: bdb25723 40834b2e
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-03 08:05:14 -0700
Merge branch 'build-fixes'
commit 9ba931f1ded9aadffc6e69000d402424fc25b621
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-02 22:37:20 -0700
Make device idle test conditional on no native MCE.
commit fdc7058497096d15874a466fae35f5670942b029
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-02 21:27:26 -0700
New device idle power saving test.
commit 649a41e1d81ab1f481f33eca1615577e54db2d15
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-01 11:22:32 -0700
Integrated McdSlacker into McdConnection.
commit fc882c78ab5bbf35201048941d13fabc1dff1ae4
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-01 11:22:32 -0700
Moved GabbleSlacker to MissionControl as McdSlacker.
commit 73f5d61f2e9bfd7003c54dc3df28e89f7aa2c7dc
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-01 18:23:49 -0700
Added Conn.I.PowerSaving as extension.
commit 40834b2e9281c0fe3273d6a0368ebd132bd6014f
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-11-01 11:46:35 -0700
Purge Account_Manager_Interface_SSO.*
commit 0b9464ee78eb063e1ee8bf7b833a6bd378f1fa90
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-27 16:18:51 +0100
Use the new AG_SERVICE macro instead of hardiwring "IM" everywhere.
commit 1798389710ce878298598c9ffc4b156abc708e00
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-27 16:18:13 +0100
Register for the IM service type specifically: no wakeups for non-IM changes
commit 1b1908504a2127ee4e60ec6a0eda851cc817e48f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-25 18:34:50 +0100
Simplify SetURISchemeAssociation.
commit 28382eae7df8725a69d437a9a6a5f9b64ae581a9
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-25 18:33:50 +0100
Add mcd_storage_set_strv
This is more convenient than requiring callers to box up their strvs
manually.
commit 2078e4cf3fee9d9dafe60e3403e61d043d9daa86
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-25 16:34:11 +0100
Silence a warning
commit cf6fa689d74aac0a177425e66d64f8a0864a9913
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-25 16:33:57 +0100
Tests need to use .DRAFT
commit 2f059cc44bc6d05730d486a97f9a72c5d1922b49
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-25 16:33:34 +0100
Sync with spec branch
commit 0d7d20201eab3f04d860bbfaaa00dfc36500974d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-22 17:54:50 +0100
Test the Accounts.I.Addressing interface
commit 6edb77db1e8cb11cae196b24ea855580e641e208
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-22 17:54:50 +0100
Pull Account.I.Addressing into the mcd-account implementation
commit c8b31e2ca7a8433293a0d604eb068a69326888a3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-22 17:54:50 +0100
Implement Account.I.Addressing
commit 23bcffad520e6c5356dc9df8f894006393cd3e71
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-22 17:54:49 +0100
Introduce new interface Account.Interface.Addressing
commit bdb25723743291ca50b1b8cbdeb2dab051554066
Merge: 2e71d81b cfaa5ffd
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-12 17:35:14 +0100
Merge branch 'mcd-account-get-cm'
Reviewed-by: Senko Rašić <senko.rasic@collabora.co.uk>
commit cfaa5ffdcee7069d92d882791882311e44d97e15
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-08 18:22:59 +0100
Add TpConnectionManager accessor to McdAccount
commit 420325c1e1261c37c02f0790030a1f316c6bb128
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-12 11:14:57 +0100
Tweak .gitignore
commit 782aa7c3bdd580c3e9ab4a0bde366815c2919f95
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-12 11:11:32 +0100
Remove obsolete AM.Interface.SSO
This is superseded by Account.Interface.Storage.
commit a710cd0f9abe2b756864928c65ba798e556198b0
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-11 14:55:06 +0100
Delete mcd_master_add_connection_parameter()
This is not used anywhere, which is good, because it doesn't work.
commit 41aeef1c314c60b12d394403d1552ed7bd964203
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 15:38:48 +0100
Implement the "list" operation in the libaccounts backend
commit d8179b677aeeee0394840f330275bb956a459e84
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 15:38:12 +0100
Obsolete functions no longer used by the libaccounts get/set implementations
commit 4f43ef635decd263783bcde5db7ac56e6e9a4297
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 15:37:03 +0100
Update the libaccounts "set" implementation to use the new helpers
commit 3cd7559e500d1b5ac7b442ce61eef72337014feb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 15:36:34 +0100
Update libaccounts "get" implementation to use the new helper functions
commit 3c1fefe21ebc9603bc0a0b4ff56cae9a369d59ef
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 15:35:10 +0100
Helper function to save settings in the SSO
commit 08e39a3aa4003b2a31c6a548610cf5fa32bf3b9d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 15:33:58 +0100
Helper functions to map the enabled flag to the enabled tri-state in SSO
commit 8f2a2ccc5fd7e860581ffcbe2709f975cbc90856
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 15:27:10 +0100
Implement the same AG <-> MC setting mapping functions as the SSO storage plugin
commit 6d6ab7387c99df31b071b7cce8d617ff46d87cf8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 15:24:40 +0100
Fix up g_log related helpers so they build (bad comparison, bad func signature)
commit 4c9c8f48f1b3b86ea46c46055d4c2e5ef926cb5a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 14:19:06 +0100
Implement the "list" operation in the default account store tool backend
commit deb56f64ff9dc03f682e09561dfaad14bd3083d4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 14:18:35 +0100
Implement the "list" operation in tha account store tool
commit 2fc6e063fc591f2eba6dc51678ad5c527d9d2e4c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-12 13:31:56 +0100
Missing includes
commit 2e71d81b3f9d04fc4f2a856d9de19cd1e6a92b12
Merge: 6b6156f6 068185bd
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-10-12 14:19:03 +0200
Merge branch 'bypass-observer'
commit 068185bd5be0f113c1785a07e9da029ecd8e7cf0
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-31 14:50:01 +0200
updated copyrights
commit bddeef350dba5d90023f1f21d7d7664c46059ada
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-31 14:48:40 +0200
add dispatcher/bypass-observers.py test
commit b6ea54b2cc93b3547d647e9ab4ceda58440c995b
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-31 14:43:56 +0200
mctest.SimulatedClient: optionally support BypassObservers
commit 201d5af64004c1542c09b446c3046c6f1ad38425
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-31 14:42:17 +0200
McdDispatcher: when respawning observers, skip notifying them about unobservable channels
commit 8d8db2ffa52049d0ee39da7d7b75dfadac1bda34
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-31 11:59:00 +0200
McdDispatchOperation: bypass observers if first channel handler requests it
commit a892185dfbea0897b7b3ea1d541501fe8da9053a
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-31 11:58:10 +0200
McdClient: add BypassObservers boolean flag
commit 01c4a86570f6772809c02b947c04822bf8ed57e8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-10-11 18:45:27 +0100
while we're using GObject-Introspection notation for docs, get it fully right
commit 16d4d59d32b4acd6d35d28fafc1cf4899d2fa27c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-10-11 14:27:51 +0100
Let ag parameters/account shadow the ag 'username'/mc 'param-account' mapping
New convention introduced to meet the requirements of a libaccounts platform:
Normally the account parameter is mapped from the global 'username' setting.
commit bd6ee840804ed95fea2511565932fdff84640e5e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-08 18:07:53 +0100
Remove unused mcd_manager_get_parameters()
commit 6b6156f6ea921e50ef8b9bb15d7c2ba289ec2e66
Merge: a7b17cd8 fb5ea015
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-07 16:34:01 +0100
Merge branch 'telepathy-mission-control-5.6'
commit fb5ea0159ec8a5d96a266530b401f788c0e293ca
Merge: f03e38c0 144d6e15
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-10-07 16:33:17 +0100
Merge branch 'mc-tool-types' into telepathy-mission-control-5.6
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 144d6e15d9cd5bd8a8c17ffc50a0ba5078319d98
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-08-03 18:09:42 +0100
mc-tool: support object path parameters
commit fcc72fea419a1eb5abb4fcb173a0a57dbaeee87e
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-08-03 17:02:16 +0100
mc-tool: make help consistent about supported types
Also, make it a bit more readable, and avoid the lines wrapping.
commit a7b17cd87d76038a8448a515a4a9f2e439faff3b
Merge: 750932c5 ea4d52a9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-10-06 15:20:56 +0100
Merge branch 'requests-30092'
Conflicts:
src/mcd-account-requests.c
commit 750932c509c39e887b3be40d98593a0d9a5ebd9d
Merge: 22e2a9f6 f03e38c0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-10-06 15:17:19 +0100
Merge branch 'telepathy-mission-control-5.6'
commit f03e38c057a3d38537bc585dabc78ed0dc8cda24
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-29 11:10:16 +0100
fd.o #30448: make type of mcp_account_storage_get_restrictions consistent with the header
It seems we changed the implementation but not the header, and Solaris CC
is stricter about this than gcc. Since the header defines our API, it
seems better to fix this in the implementation for the moment.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=30448
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 22e2a9f61969a96a54d3f7aba1b550219fa4efac
Merge: 02eff78a 793cc900
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-29 10:57:14 +0100
Merge branch 'telepathy-mission-control-5.6'
Conflicts:
NEWS
configure.ac
commit 793cc900f08c0cc1efacc33d997c943fa1893086
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-29 10:55:37 +0100
mcd-manager.c: don't define _POSIX_C_SOURCE for strtok_r, which we don't use
commit 5e8d727e37c31f487bce840c755f66d66fa259d8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-29 10:55:18 +0100
fd.o #30447: don't use "return x()", where x returns void, in void functions
Solaris CC doesn't allow this.
[In fact, neither does ISO C99 --smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=30447
commit 760fe45393bda94cebc9192595e34eed906a3d89
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-20 13:46:12 +0100
Must include config.h when using AC_DEFINE'd macros
commit 02eff78a581f84ee9174a112df854c57026fda17
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-20 13:46:12 +0100
Must include config.h when using AC_DEFINE'd macros
commit 438826eb7970d706a8bcb6c6ed79590a885ff761
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-09-16 18:48:55 +0100
Clean up SimplePresence-building code.
commit 1e93089a8d05c2a60da177d0025dec1f031d3dbe
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-09-16 18:23:05 +0100
Set CurrentPresence to Unset if online without SimplePresence
The spec says:
If the connection is online but does not support the SimplePresence
interface, this should be (Connection_Presence_Type_Unset, "", "").
But previously we only updated CurrentPresence in response to
PresencesChanged being emitted for our self handle, which it obviously
never is by connections which don't implement SimplePresence.
(Actually, this was right by accident until my previous commit, because
CurrentPresence was initialized to (0, NULL, NULL).)
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=24779>
commit f02defd4f8053c62aafc867954474b4c97bae178
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-09-16 18:21:32 +0100
Correctly initialize Account.CurrentPresence
The spec says that CurrentPresence being 'Unset' (which is value 0,
hence the default if we don't change it) means that the connection is
online, but doesn't support SimplePresence.
commit 1cdaa58630098d66e0f76dcc06ce2cc0c3633597
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-16 17:34:06 +0100
Nano version for master
commit 62eba1c3202bcf165a3e975c9469c373dcad30cc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-16 17:33:23 +0100
Revert "Don't warn about deprecated declarations"
This reverts commit 50f936b83a8a5970f981bbe2a6b318b3d51adebe.
commit 6cf2e11f2019cdbf0c2068362444e23663d55132
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-16 17:33:13 +0100
Nano version 5.6.0+
commit 02023109462143bba05b169ecc1c690038c357c9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-16 16:51:22 +0100
Prepare MC 5.6.0
commit 50f936b83a8a5970f981bbe2a6b318b3d51adebe
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-16 16:49:57 +0100
Don't warn about deprecated declarations
This is about to be a stable branch, so we're not going to fix any
uses of newly-deprecated functions in future.
(To be reverted in master after branching for 5.6.)
commit 3433a7b4ae90f0f61d4fef130631e88f066fd26a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-16 16:30:56 +0100
Update NEWS
commit be83db16e4cba060da074a1c4e2db22596310d37
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-16 15:52:46 +0100
If keyring support is off, we define stubroutines, we dn't #if them out
The unused definition warning -> error will bite us if we both define
a noop stubroutine _and_ #if the use of that name out as well.
commit 51b5efe07c8c14f5d54183561aed95c2cb7926ee
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-16 15:28:13 +0100
Superfluous include
commit 9c8eb6ae0a8ed6809d944f534e21a5740702c558
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-16 15:27:56 +0100
Install mcd-storage.h [needed by mcd-account-manager.h]
commit d563ead8cff191753d95d19bb0655db254e77c6e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-15 13:12:42 +0100
test/account-store: fix one more build warning
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 9c5a4e350ae324316297db4ca3af175cbc32a702
Author: Vincent Untz <vuntz@gnome.org>
Date: 2010-09-15 13:08:19 +0100
Fix various build warnings
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit db4960f191d5b1d091dd76537d50194ae579e773
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 19:11:05 +0100
Nano version
commit 4c2b540e103cd87b296190ac4bdc72cfb40a3900
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 18:25:10 +0100
Prepare version 5.5.4
commit 4f67eab634aa4d91d4841b3f3bdfa6d7ee52b2f0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 18:06:54 +0100
test/Makefile.am: simplify CFLAGS
commit 3790a84acb18bf61d85a5a79b4ea4a30b1649986
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 17:58:58 +0100
Knock out the account-storage/libaccounts-sso-storage test for 5.6
I'm unable to test it and it looks unfinished.
commit c68547b12b3371eb1c67e2640e7d0f270f5890ef
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 17:28:59 +0100
Run account storage tests in their own session, and not in installcheck
The gnome-keyring test assumes that it's talking to a MC instance
configured to use the temporary keyring, which won't be true unless we
run it in its own instance; the diverted-storage test makes assumptions
about account naming that aren't necessarily true in a non-new MC
instance.
Similarly, these tests use Abort() which isn't in the real MC.
commit 0bf6ed698102011576327856e16161cd19e1034d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 17:37:40 +0100
Move keyfile_read() to mctest, fixing distcheck in a simple way
There seems little point in separating out such a small utility function.
commit a478b211eab9224f84a471bfbc1cf80d8ad2f094
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 17:25:02 +0100
Add keyring-manipulation stuff to .gitignore
commit 2b9f4f1aad25a77710d0a53c80e72c6ccca520bc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 17:24:20 +0100
Compile test/. before test/twisted
Otherwise, 'make check' in a clean tree won't work: account-store and
keyring-command won't have been compiled yet when test/twisted is entered.
commit 85e35b0b8e4501ac4eb35fb2fc210eedf0282e3d
Merge: 3116079d 9ac2c099
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-14 16:00:12 +0100
Merge branch 'master' into storage-tests
commit 9ac2c09945c69c32ca4a6e15a30048c58add2782
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-14 14:52:52 +0100
Generate a GError in the "unsupported type" case of the dup_value method
commit 631e2cafc2e45e89ee3cfc9f47dd0582c14c40bf
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-14 14:46:08 +0100
Tidy up the GError logic in dup_value, and document the value+error behaviour
commit 84adc5d2a14b19f42c06cabbe4cb807ba7a0e274
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-14 14:31:57 +0100
Make sure the type of the passed in value matches the type from McdStorage
commit d79c76c46d7c88b31ad865c2c25109a87f5591c5
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-14 14:24:01 +0100
Unused struct type declaration deleted
commit 38bf72ea3dc67cbe9aadf72de61bbbb8ec0c06d1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-14 14:23:19 +0100
Use typed key file set helpers in store_value McdStorage method implementation
commit 50d0d448c136987956c73a86269faba22d0fa9b0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-14 13:57:30 +0100
Reverse the decision about which layer does escaping/unescaping
We now do the escaping/unescaping in the plugin-account layer
(McdStorage interface), while the storage plugins just accept
whatever they're given.
commit 3116079d37cd389b10525a0f9d799e7fadb16e60
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:29:12 +0200
add SSO storage backend test
commit 320c153d13869fd3e5531948095fa18803e4ad1d
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:26:34 +0200
added default/keyring and diverted storage tests
commit 58e7725455b8724d0eaab1c8da89b00d521a9e35
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:24:44 +0200
test diversion storage plugin: have an exception for a special account
So we can use that account to test default storage
commit cf5af66a60fa318e4233d73a9f1c286dca4ec3b8
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:23:26 +0200
set proper environment flags when testing with gnome-keyring
commit 23320b621c85ed0984cfa0a628cfaf34c1ebf206
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:21:38 +0200
mc-debug-server.c: use temporary keyring from env, don't create one
commit 9cf19f452d0a068c9f4a96a86fa5bb3378b1709c
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:20:54 +0200
added tests/keyring-command helper for creating/destroying test keyring
commit 2adf4f67d6503a44bca106baf5e8a0a32c90a70a
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:18:02 +0200
account-store.c: take temporary keyring name from environment
commit 23d0a837431d1f7fc4e8f385a7777f8a8f6d3fbf
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:14:39 +0200
mctest.py: refactored code into new get_fakecm_account() and connect_to_mc() methods
commit e67044de0f3a5468d56d8e491e37251737608bba
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-06-21 11:13:12 +0200
mc-debug-server.c: added org.freedesktop.Telepathy.MissionControl5.RegressionTests.Abort
commit 4caef8e9a00ea506809934aaf21095f985381b9d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 16:45:08 +0100
return success on writing a param, only flush to store if we did so
commit 94c683f4feb9010a8521e2f97f2fab90dd416368
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 16:44:29 +0100
Remove old debugging
commit 61c753769cedc2bc0311f0d7417d61b0dcaf2e81
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 16:44:14 +0100
Don't call into libaccounts until we've muted its chatty debug output
commit 9b04e4bf6149f5b51a1616e695b59689d1d4136f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 16:43:29 +0100
Suppress AG debug for ag_manager creation
commit 39b95c9374b05af851d869ac0b1001ceb7a94aa4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 16:42:44 +0100
g_type_init called, some backends need it
commit f03cd76003142ca231d8cb2278a4ed61eda51d70
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 15:39:38 +0100
Fix delete method for dafault storage backend
commit 162ed592fa8ff57c9a263b4bee02219baf919927
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 15:39:15 +0100
Whitespace trivia.
commit 6249b7cc13d8f201f08a9ef8fa346486d00ca5ad
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 15:38:56 +0100
Update usage/dcstrings.
commit 68b240c151953179bebc0e02598e53bf255e0a4b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 15:38:10 +0100
Modify op name for account removal.
commit ad7b90913ad23c37697dc8d0b60555a468212c49
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-03 15:37:31 +0100
Remove some old debugging
commit 0c3f075b1a4b00c3467855ce51efbd6f61b26ffc
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-02 19:57:39 +0100
account storage inspectors for default (keyfile + keyring) & libaccounts (SSO)
commit 54404bcf80722c6a875cdeabc851ade29d59ef80
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-14 13:03:31 +0100
Documentation fix (misnamed funciton in docstring)
commit f447f4004c915208b9f9e1434564e684d8d79ed2
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:31:06 +0100
Use McdStorage instead of direct private structure access in mcd-account-compat
commit 84dea39154f663bac8d81fd30736d30f7cbca5c8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:29:41 +0100
Use the McdStorage interface in the soon-to-be-deleted conditions code
commit ff641a8dcb117f63fccff66bb2f8d5e83106bcf9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:28:44 +0100
Use McdStorage instead of private structures in match_account_parameter
commit 0f5556352746303cbe3ee7f923120526f9a68c29
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:27:43 +0100
DBus daemon is directly available via the account now, account manager is not
commit 42f48a6d53390dd7ef798b637ff7ef5af9c13a65
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:26:44 +0100
The McdStorage layer uses get/set _value, the actual plugins need to use _string
This way the layer closest to actual storage in a real actually-on-disc
keyfile make sure escaping is handled, while all layers above them can
simply treat the values as "data" without caring how or where they
are stored.
commit 18504cb01f8403ffcc904773d77a2731eb32b895
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:24:42 +0100
Make sure the sso-services property is cached when we load the account
Doing this means we don't need to special-case sso-services in generic
code later.
commit e17c526c56ce5fe72ddd4ab3501d1779e564fbb6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:23:29 +0100
Use the McdStorage interface to find the plugin claiming ownership of an account
commit 3aae65a96489779109dcff2df48c3d261420d3c8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:22:52 +0100
Stray debug message
commit 49004b163bcd79225fb7fe6bb638526279622e4e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:22:40 +0100
No longer have direct access to account manager: use helper to store connections
commit 6b53756ded5bbee92d0cafd6d0f50c78664cf252
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:21:45 +0100
mcd_account_get_alias update to use McdStorage
commit 99424caa96dfe653098584dea550f12eeb0db961
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:20:53 +0100
get/set avatar methods update to use McdStorage interface
commit b0d1c020c8115f8449082ebb308288f4ef07398d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:20:01 +0100
get/set avatar token updated to McdStorage interface
commit 1f0cf66f58724f6c302bf1bb5f2cb2ea6cce6a47
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:19:24 +0100
get/set normalised name functions updated to McdStorage interface
commit ce33ae1f42d6929ca92464ce5731ed7c9de55cc4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:18:13 +0100
update_parameters_dup_params_cb updated to McdStorage interface
commit 0ea08db42ff6d8171cc8e812dc4a1fe11784c672
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:17:13 +0100
clear_register_dup_params_cb updated to McdStorage interface
commit ad1d2de0fd0e0c3efc599e325dee5bbc9c3f17f6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:16:20 +0100
has_been_online updated to use McdStorage interface
commit a2fbe50aba07795db0fd775d3b6119c5cd73a991
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:14:51 +0100
set_connect_automatically updated to use McdStorage interface
commit f1f618d6fee47e7d46f4422b70c86f2d65b92ff6
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:14:22 +0100
set_automatic_presence updated to use McdStorage interface
commit f9ae977dfb5b7479343fadb4f6a3b9dc59b11e0e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:09:53 +0100
_mcd_account_set_enabled upated to use McdStorage interface
commit 8ab75eab9ffcffd9948391765d01c18b96115948
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:08:51 +0100
mcd_account_get_string_val updated to new McdStorage interface
commit 7e862140fe946241a840cfab16f3c6ac050c9358
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:08:20 +0100
mcd_account_set_string_val updated to new McdStorage interface
commit 3fd92771734ad5ad3820972e6dcb36c0d9c13c7b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:05:39 +0100
Delete account method updated to use new McdStorage interface
commit efe36be000112b7d72b216e0946bec9fde6c5ff1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:04:45 +0100
get/set parameter internal functions updated to use McdStorage interface
commit 0f5a38efb6e1764da6123495519f7493b52fc8f9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 21:03:46 +0100
keyfile_get_value and keyfile_set_value no longer exist (no more keyfile)
commit d6fba82ec292e0c5a9cc94fdf05ed8a05479f3e7
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:51:03 +0100
McdAccount no longer holds an account manager
It has a McdStorage object and a DBus daemon instead - updated
constructors/destructors/accessors to reflect this change
commit 0046407863d5f61ea1102e78d05d9aae5cc007d3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:36:45 +0100
Implement method to find the McpAccountStorage plugin holding an account
commit 01a0a82fce092b598370bac4d02c7db0f0cda076
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:35:57 +0100
Typo, missing return signature
commit b594c4f37ea7e7be392683b27cc158c1148ebf77
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:35:36 +0100
Hook up the actual McdStorage method implmentations to the interface
commit 76f68b35e71a35856ad2aec7206727fb0b8e7346
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:34:56 +0100
Implement setting store values from GValues
commit 1d0ed399604c64ddf506eb5026b8b04da5c8681d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:33:46 +0100
Implement getting integers from the store
commit 4a1ef90e2016b631dd606facb12096b7b8b9dec0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:31:04 +0100
Implement getting booleans from the store
commit 01fd9a07d6aaccaabeac572584858e489f1506bc
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:30:42 +0100
Implement fetching GValues from the store
commit 5667b21d7659b89bf2fb5e4e6787e90653230270
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:29:03 +0100
Implement the has_value method of the storage interface
commit b29db1c3a2d7e9f0b72f178f2844a1938a430715
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:28:03 +0100
Make the McdStorage interface object available vie the account manager.
commit 2e9de4ecf03a042ca75bbefac32be6674003c042
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:21:41 +0100
Unused 'update one account' operation removed
Since _all_ operations now know the account involved, this operation
sort of drops out of the logic.
commit afc6b1cdaa1b8a133e6e49f3a46fd26029d83e62
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:17:42 +0100
Move commit operation (flushing to long term storage) into plugin-account
commit d1ff9303f0501a65c9f18afb4d0418b506434c8f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:14:42 +0100
Move account creation and get/set value ops needed by same into plugin-account
commit 33cc0a6a4d7df42b924e5b6bb66c0da7015768c0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:07:31 +0100
Move account deletion (from storage) into plugin-account
commit 5942a7827a3fe8719e8258aa14b34a17f7af78c3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:04:54 +0100
Comments - we no longer have direct access to (or knowledge of) any keyfiles
commit 3d5b5e7a248d29a7fce28604e03aba60c816a5ba
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 20:01:36 +0100
Move account load + initialisation into plugin-account
commit 991789066584f8be0afd1be4de1692b71d16f0ab
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 19:42:57 +0100
Begin moving the storage plugin cache & management into plugin-account.c
commit a925bdb89cd69a1f20374dde7887c01a2138473f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-09-13 17:33:16 +0100
New McdStorage interface for storing/retrieving account settings + params
The McpAccountStorage interface used to communicate with the storage plugins
The McdStorage interface is what MC in general should use to store/inspect/
update/whatever account details, and is responsible for managing the storage
plugins. It replaces the old method of stealing the account manager's
internal data structures via the McdAccount and changing them behind
the account manager's back.
commit 5906616c918a0206fb128590359c349895a27987
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 14:38:51 +0100
Test request-properties in HandleChannels calls
commit 6bae7bdbb2472dac2b280a675e9e06ac6af809f1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 14:28:11 +0100
mcd_dispatch_operation_handle_channels: include request-properties
commit 2fca4d99a30fa4b4bac670806068cee2741ef40b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 14:23:45 +0100
collect_satisfied_requests: go straight from channels to D-Bus info
commit c36969dc58f99bbe35c2802b39729cc21c536d11
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 14:06:43 +0100
_mcd_dispatcher_reinvoke_handler: include request-properties in Handler_Info
commit ea4d52a990863cfe94662f92137406e7fe4f579c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 18:27:45 +0100
_mcd_channel_new_request: take a pre-constructed McdRequest
commit 58d1913c86b3b26017b2bb1efb68e43bd37fc567
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 18:21:50 +0100
_mcd_request_predict_handler: take responsibility for guessing the handler
commit e562ec8eda0b3116111998be60f7f51b7b0fe87a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 13:45:29 +0100
Give each McdRequest a ref to the client registry
commit a093c3c86b4978a6353dad70c8eaadc6f7c832a1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 18:11:29 +0100
_mcd_dispatcher_get_client_registry: add
commit 015c2290185b610a9cf5fab205c6ba8094d9fe35
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 18:09:58 +0100
_mcd_client_registry_get_dbus_daemon: add
commit 8e9adf673d62abaf4e915ec00387c384fe956530
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 18:06:08 +0100
McdClientRegistry: choose handlers in terms of properties, not McdRequest
This means McdRequest can have a McdClientRegistry without circular
dependencies.
commit 3d9854432bacc5491f1e73b61dfa54d29a457827
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 16:07:13 +0100
McdClientRegistry: re-indent recently moved code in Telepathy style
commit 466bd0f2b380ca940f3bfeac3919c79311c1e85e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 16:04:28 +0100
Move listing possible handlers from McdDispatcher to McdClientRegistry
commit 60ca5963c9c13106ba52abc59844795fc3d6751b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 16:03:59 +0100
McdChannel: remove disused implementations of the ChannelRequest API
Space for a TpDBusPropertiesMixinClass is still reserved in the
McdChannelClass, since subclasses might exist.
commit 04f5815c5bd52ec5504b5cd81d6dfca700c84b1d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 15:51:24 +0100
mcd-account-requests: call _mcd_request_proceed instead of a thin wrapper
commit 0785e1d6235dd6c9ddc2803432f7f3df23ee3ca6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 15:49:56 +0100
Export McdRequest, not McdChannel, on D-Bus
commit ec129a7446887e77bed82ad12b1e0d0aef105b5c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 13:13:27 +0100
Inline _mcd_account_proceed_with_request() into its caller, and simplify
commit 3808e0b8a9ce61b7fd80addfa44a1f71df9378d8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 13:10:46 +0100
McdRequest: take on responsibility for calling into Client.I.Requests
commit 0a519167dd1f9c69a6a74951ff14040bb87171ec
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 15:03:50 +0100
McdRequest: implement the early stages of Proceed()
For the moment it calls into mcd-account-requests for the next bit.
commit 98a613e28a4b146b2df7b7a3b58365a013e5f327
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 15:00:46 +0100
_mcd_channel_request_proceed: don't allow for absent accounts
In earlier versions, this could possibly have happened if the code was
tangled enough. However, McdRequest holds a reference to the account,
so there's no way a McdRequest can not have an account.
commit 40af99632c8c30e11468335bef6f12352bb2b25a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 13:08:47 +0100
_mcd_account_proceed_with_request: remove dependence on McdChannel
commit a2d0ea012a69cda374214cbe19a094045832e75b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 14:48:56 +0100
mcd-account-requests: connect to ready-to-request earlier
It can't actually be emitted until Proceed() is called, but if we connect
to it ahead of time, _mcd_account_proceed_with_request doesn't actually
need the McdChannel.
commit 4204b3d2f8405e2b625abdbaf122980647d648a1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 13:53:05 +0100
mcd-account-requests: defer Proceed() until the dispatcher has been told
This matches the order of events in the modern API, and means that the
implementation of Proceed() can safely assume that the dispatcher knows
about the channel request.
This does break the expectations of the old-API tests: previously, we
incorrectly asserted that AddRequest happened after calling CreateChannel
on the connection manager, but either order would be valid, and in fact
the new order makes more sense.
commit f3a153356399ce2f8bcd3a231d13eba60bb262e4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 13:22:42 +0100
Move a stub version of Cancel() to McdRequest
commit a6fbb7f242c49d722f6ee41e555e7e46d849f224
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 12:38:42 +0100
Remove the concept of creating a channel request that is already proceeding
Instead, in the Account.ChannelRequests code paths, just create one and
then tell it to proceed.
commit d2591a6eab3c08f01187b9835f3ddb5e2388cb89
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 18:40:34 +0100
McdRequest: remove the "completed" signal
commit 207eff860950fdeb263381952b11cc9aa66785a4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 18:39:40 +0100
Listen for McdRequest:succeeded[-with-channel] and McdRequest:failed
commit d574ad8e275d2843de5441164b75763974ddedbb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 18:12:41 +0100
McdRequest: emit succeeded, succeeded-with-channel and failed
For now, these signals do nothing. They'll soon supersede completed, and
when McdRequest is exported on D-Bus, they'll be mirrored onto D-Bus too.
commit 669b0d56c8f7ed497ce27f75ed37cdb8fc035461
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 16:39:49 +0100
_mcd_channel_get_request_user_action_time: remove, unused
commit fce9d2674a549fa1a95c421ad5aa56e8b9367033
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 16:37:13 +0100
McdDispatcher: work out possible handlers from McdRequest and/or TpChannels
This avoids ambiguities caused by McdChannel being a (request or channel
or both).
As a bonus, assume_requested can go away, since it's inferred from the
presence or absence of @request.
This relies on some previously implicit assumptions, which are now
assertions:
- the McdChannel in _mcd_dispatcher_reinvoke_handler has both a McdRequest
and a TpChannel
- each McdChannel in _mcd_dispatcher_take_channels has a TpChannel
commit 78fb02770ed53fbec5ef943a156d5f422aec61be
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:46:11 +0100
_mcd_channel_get_request_path: remove
commit 2b76b5f06305696b80ee084e9ce44979344d577e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:44:34 +0100
_mcd_account_create_request: return the McdRequest as well as the McdChannel
commit 037c5dfccd2c37729be7193601d6a8856a496e92
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:37:44 +0100
_mcd_channel_dup_request_properties: remove
commit 19d30ad814181f99621eb8a72d53e11d9ccbe03e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:37:15 +0100
mcd-account-requests: use McdRequest in easy cases
commit 8ba71d6e31d5a1b867d0d1c042f6336d78413832
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:27:14 +0100
McdChannel: track satisfied requests as a list of McdRequest, not McdChannel
commit 263c83db750a71d8630853a55e7d0fb56bd6853e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:17:28 +0100
_mcd_dispatcher_add_request: work in terms of the McdRequest
commit 15792b20a88ae5a0ea35d178b8a4498a8ef54b24
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:09:40 +0100
Make mcd_channel_new_request internal
We already broke its API, and nobody outside MC should be calling it.
commit 8e48fcec643c6a40f944902e133d8413780c0853
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:05:11 +0100
_mcd_request_set_success: take a TpChannel, currently unused
commit 04096146c5bf983430d519e116e89380f71bed5a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:04:49 +0100
mcd_channel_status_changed: assert that we do/don't have a channel
commit 4b905986fba354b0fff08c3bfdbd3b60bdeb3f16
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 15:05:52 +0100
Check all references to user action time and update for current telepathy-spec
This requires telepathy-glib 0.11.13 for the constants, but does not cause
any functional changes.
commit 584676015d63d14478388e2715730edfae69aa66
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 14:35:54 +0100
McdRequest: implement the interfaces and properties of a ChannelRequest
The methods are not yet implemented, the signals are not emitted, and the
object isn't actually exported on D-Bus.
commit 13aa404a2061f74d43d2c7f85067c9f18dea29eb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 14:19:18 +0100
McdRequest: add Requests and Interfaces properties
These will be exported from here when responsibility for exporting a
ChannelRequest moves from McdChannel to McdRequest.
commit 220fd673b7788fd3a986668a5e8ac3ddf034b7e3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 12:47:51 +0100
_mcd_dispatch_operation_run_observers: don't leak the request properties twice
observer_info didn't have a value destructor, but the value inserted into
it was copied with tp_asv_set_boxed; in addition, the original value
wasn't freed either.
Reviewed-by: Senko Rasic <senko.rasic@collabora.co.uk>
commit 39c99f03d6a99b52e884d46a009d8137f74a755b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 12:18:23 +0100
Update NEWS
commit 619d9d92ada8da156e00bc2a43ef34346050a060
Merge: 09956287 7f1635c1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 12:32:58 +0100
Merge branch 'clear-pointers'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 7f1635c1f92752e68f68282d3092256705bac4d9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 11:59:04 +0100
various shared classes: use tp_clear_object, tp_clear_pointer
commit a9a63aa9db1ab49fc9b1f204ca4c24a81bc92bed
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 11:58:02 +0100
various dispatch-related classes: use tp_clear_object, tp_clear_pointer
commit 49011e5e13fd24d20037a7ae41d873caaa5854bf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 11:56:09 +0100
various account-related classes: use tp_clear_object, tp_clear_pointer
commit f121342b30aff60a601d25f3ce836ee88c4c5bf3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 11:54:22 +0100
server, test, util: use tp_clear_object
commit 023fdb490cb9d323b416f3f88fbb346c7b9f8e79
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 11:53:56 +0100
mcp: use tp_clear_object, tp_clear_pointer
commit 09956287fa1cb9a9b179010ea8324bc896aa9df6
Merge: a926c6a0 9a5ecade
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 11:48:30 +0100
Merge branch 'just-what-are-refs'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 9a5ecadeea057bded61f52cc8abeb621d5807a46
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 10:32:48 +0100
_mcd_account_proceed_with_request: don't leak the McpRequest
This resulted in leaking the McdRequest, and hence compensated for the bug
fixed in the previous commit. However, because the McpRequest is created
lazily, it didn't prevent the crash when used without new-style request
plugins.
commit a635ef53eaa6ecd2925d413baf36a0de1c0af917
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-09 10:31:46 +0100
McdRequest: take one extra ref when constructed, to match the Proceed() delay
This caused crashes when MC master was run without a new-style plugin,
but did not crash the regression tests due to a compensating error (a
reference leak whenever there are new-style request plugins).
commit a926c6a01b819c5b6cfb4dd138227fe2520a1f90
Merge: 65cc5ecf 2a7602a8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 14:52:21 +0100
Merge branch 'easy'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 2a7602a8c3aeb7fdead8635e6401ab972c261f9f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-24 12:39:29 +0100
McdChannel: remove unused DEPRECATED_PROPERTY_WARNING macro
commit 5d602d4aa7b1697a2a454ba639b2ae450776cd08
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-08 12:19:13 +0100
channel_request_proceed: don't crash if already proceeding
commit 65cc5ecf8dfa1dc922dfbf6720aefa5ccbf1f814
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-31 19:09:00 +0100
Skip new accounts created after startup that are completely invalid
commit 758adac959bbeac537efd980e483e5dae86dd3e3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-31 19:08:38 +0100
Skip pre-existing accounts which are completely invalid (no manager/protocol)
commit b09749b7f8c5cb7c2f5e40cfcce915316d4aeb01
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-31 19:07:07 +0100
NULL out the pointers when finalising an McdAccount
commit 2ae2cdfe81f31d42c2be42a45cfb5566ce90711a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 12:57:05 +0100
Delete missioncontrol.log, as well as missioncontrol-*.log, in clean
commit a477f91c212c8b9516ef2e4665a92fe3fb8503f9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 12:56:44 +0100
Re-auto-generate mcd-channel.sgml
commit 2482316729a6a0a4b2074988e312721d7df6d8e1
Merge: adb9504b bf9d7f9d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-07 12:52:07 +0100
Merge branch 'hints-30000'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit bf9d7f9db952d432ceda6bf3ca8bf2d5901ecf6e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-06 17:20:58 +0100
exec-with-log.sh.in: keep a copy of the last log under a predictable name
This is convenient if you keep it open in an editor between test runs :-)
commit 3fa584f64014c92f93bcc0ac00bb5b184d686d59
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-06 17:19:58 +0100
dispatcher/ensure-rapidly.py: test with all possible event orders
Before tracking down the bug fixed by the previous commit, I thought it
was caused by subtleties of event ordering; it wasn't, but the extra
coverage is good to have anyway.
commit af5207af0ab7578765f24fff9f1cbe40f3f22d08
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-06 17:18:05 +0100
Copy the TpChannel to a proxy McdChannel when setting it up
This fixes an assertion failure when emitting SucceededWithChannel for a
proxy (secondary) representation of a channel (i.e. the second and
subsequent EnsureChannel requests that returned a particular channel).
To do this without putting a non-primary representation of a channel
into the dispatching machinery (which breaks tracking which requests
where satisfied) it's necessary to add _mcd_channel_is_primary_for_path;
see that function's doc-comment for the definition of "primary" and
"proxy" in this context.
commit 6ba590895025f9fffda2511f43df2fdbaaacc616
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-06 15:27:04 +0100
Move SucceededWithChannel and Hints into .FUTURE pseudo-interfaces
Also rename RequestMetadata to Hints as per the spec draft that was
merged.
commit 21dac454cfb16ca927012ab980ab4978167e68c4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-06 15:24:07 +0100
Update xml/generic-types.xml for Object_Immutable_Properties_Map
commit d7185b434e1bb44ce9bce11dd3a4087a550f7ef1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-06 15:22:50 +0100
Generate src/_gen/interfaces.h
commit 7176e558e7b34c558432022ccb6372ee99f02a58
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-09-01 11:55:39 +0200
no need for free_req_properties
commit e796d8b8546b58671132633ed9af0e863b73eb3c
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-09-01 11:53:13 +0200
rename _mcd_channel_dup_properties to _mcd_channel_dup_request_properties
commit cc8cd72bb2af3f82c39b449f5bd9ff333ee23c2a
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-20 14:41:31 +0200
add 'request-properties' key to Observer_Info
commit 8bb446b3efb3a8c7bde6310b3afdc39b5d1afbe2
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-20 14:23:25 +0200
collect_satisfied_requests: return an hash table
commit a082fbd99ee0259296dae232cf4d8f6b7b9779d8
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-20 14:11:42 +0200
_mcd_channel_get_satisfied_requests: return an hash table mapping the path to the channel request
commit 70a344b08828833c22d5d85428f745cfd0a499e7
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-20 11:54:33 +0200
mcd-channel: store the channel request object in satisfied_requests instead of just its path
commit 6ad21f0931ff901c215528cef134771889dc9a0d
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-20 11:47:33 +0200
_mcd_channel_dup_properties: add TP_PROP_CHANNEL_REQUEST_REQUEST_METADATA
commit 47c33ecfd5343ff9697b9c5aa5a72a33934d8d38
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-19 16:14:04 +0200
factor out _mcd_channel_dup_properties
commit b20bd391295e48faec2556b5c2fc27af338a12bf
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-19 16:03:53 +0200
_mcd_dispatcher_add_request: use tp_asv_new()
commit 246685f9b1ff6b484e3370a9e718cadbd5122273
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-19 15:10:38 +0200
test {Create,Ensure}ChannelWithMetadata
commit 653f4236330d254195e2ca2a371f2f0c7eba8aac
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-19 15:10:14 +0200
Implement {Create,Ensure}ChannelWithMetadata
commit c706103d81437bf5ecb7e43aaaa6dd2b71d7c4e7
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-19 15:09:54 +0200
add API to set the metadata from the dispatcher
commit dc32b6cd2d99f00a081736717f745fa1e47ff401
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-19 15:07:04 +0200
ChannelRequest: add RequestMetadata D-Bus property
commit 96503c4f984141695b0cfb235f7b7a060c7f3a4d
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-19 12:55:51 +0200
test SucceededWithChannel
commit 6b7e006feff927815984996ea59f3975ae5d3e03
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-08-19 12:55:37 +0200
implement SucceededWithChannel
commit adb9504b2944b60eba79e2a73a70186bfb5d4283
Merge: 85d73966 1aed923e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-09-01 15:31:05 +0100
Merge branch 'requests'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 85d739665ef17fcb9f5accd733792520593d90ae
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-26 21:18:12 +0200
add Account_Interface_Minimum_Presence.xml to SPECS
commit a582ad14a29c20c007d01197d8dd08d3afdc8dab
Merge: 341e2522 70702c31
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-26 15:29:23 +0200
Merge branch 'minimum-presence'
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=29812>
commit 70702c31f1d667a4a2f925f220b8e732bc779826
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-26 15:26:13 +0200
use slice allocator for McdAccountPresencePriv
commit b7ee51406a0d4645aa6f8b83c462af53c839ac24
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-26 10:55:41 +0200
mcd-account-presence: stop watching for any remaining clients when we get disposed
commit ab23622bde22556bc4cd691dc630914457278bc3
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-26 10:47:02 +0200
mcd-account-presence.c: simplify presence setting
commit ad4ebd4fb41462a1ae1632e40e496f46560648db
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-26 10:41:28 +0200
cancel MinimumPresence requests for clients that fall off the bus
commit d82e70ce063ccad0f72ff5af7994dcc28538df25
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-26 10:17:21 +0200
moved internal minimum presence data to McdAccountPresencePrivate
commit 7c58468d80f344996c8d9bf02a83a282dbef6e66
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-26 09:28:44 +0200
corrected copyrights
commit eade94fdf9affc055efdc7be44b1bdf6ba7cac6c
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-25 12:57:49 +0200
add account/minimum-presence.py test
commit 67b3060de8e98a1f07a6a8b4d742bdd68255c927
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-25 12:57:14 +0200
SimulatedConnection: optionally support "hidden" presence
commit 7a6b1d91104ec79f47d920d5241a3a6749d4da36
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-25 12:56:50 +0200
updated copyrights
commit 91448bb75a0e58a2622f52d364b438ae48a99aa0
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-25 12:56:10 +0200
combine RequestedPresence and MinimumPresence
commit 53d46b1a1dd6f14e1aeda03c9d249078694f8ec0
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-25 12:53:49 +0200
implement Account.Interface.MinimumPresence in mcd-account-presence.[ch]
commit 8d0698bb98b5b087fa80bbeb722d5e151c10093c
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-25 12:50:16 +0200
make (_mcd_account_)presence_type_is_settable into internally-visible method
commit 0d421a714551f2a336f895a9b1073b0cf5206840
Author: Senko Rasic <senko.rasic@collabora.co.uk>
Date: 2010-08-25 11:49:18 +0200
add Account_Interface_Minimum_Presence.xml
commit 1aed923e59e5a3c7d11c2a4529f9b13daadadb80
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-24 12:16:36 +0100
Fix some typos that Vivek noticed
commit a3f611843e1c27d6a838d1dbbb49e655c7839519
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-24 12:14:28 +0100
Update copyright dates for files touched by the requests branch
commit b80cc1470a1833049bbac99dc7c11838a17baff2
Merge: 989e2048 341e2522
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-24 12:11:47 +0100
Merge branch 'master' into requests
commit 341e252241769f8e55eba57661e9e12814526870
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-24 12:02:19 +0100
mcd_account_manager_get_storage_plugin: don't shadow acct(2) from unistd.h
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit fc1609946119e4c08c75b8a19c7c5222c4dd1ed5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-24 12:05:12 +0100
Bump version to 5.5.3+ to enable -Werror again
commit 9b2aa99a6ff54538dcf6296e6df97254dd395b60
Merge: 0d914e13 ab8dbf1d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-19 14:55:13 +0100
Merge branch 'telepathy-mission-control-5.4' of git+ssh://git.collabora.co.uk/git/telepathy-mission-control
commit ab8dbf1d6d5527a79bef37316cb7f895870d62e7
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-19 13:41:49 +0100
Drop the McdConnection probation timer when the TpConnection is released
Also: Check that we haven't accidentally called the timer callback after
releasing the TpConnection, as this avoids a SEGV (and g_warn if we find
ourselves in this situation)
commit 0d914e13cc4a6e84cebb840c0be4d32abaacaddc
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-16 15:57:42 +0100
Irrational co-dependency of commit and commit_one eliminated.
There's no point calling commit_one from commit if commit isn't
implemented, as commit can only solve this by trying to call commit.
Also fixes a logic-loophole which allowed a NULL commit implementation
to be deref'd and called.
commit 92c5bbdcd9cedbc876f8f6a06c6ff3fc179ec210
Merge: 92c4501a 0fc5bed2
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-19 13:25:23 +0100
Merge branch 'telepathy-mission-control-5.4' of git+ssh://git.collabora.co.uk/git/telepathy-mission-control
commit 0fc5bed249202727b7eb034ab37502e4a024afb1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-19 13:10:12 +0100
More checks on built strings (from coverity report)
commit b4463ae864beab551262778868c60104da572216
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-19 13:08:18 +0100
Unused variable
commit 92c4501acdc358a63df43420c871152b01332d41
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-08-18 19:09:54 +0100
McdAccount: Correctly chain up to constructed
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 7a9bd3f12197c5d85ad3c2741d1481f0303cafee
Merge: 4e75c43e f44d79ed
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-11 16:27:52 +0100
Merge branch 'trivia'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit f44d79edc8be2a35f133f29a557cd0e652fc877b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-11 16:19:38 +0100
Delete old examples
These are no longer exemplary; people should use telepathy-glib or
telepathy-qt4 instead of libmcclient.
commit fb865d918fa135d03451ccc56cd7bc6ea127c639
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-08-11 16:17:09 +0100
server, util: fix CPPFLAGS/LDADD for recent ld versions
- use AM_CPPFLAGS instead of the deprecated equivalent INCLUDES
- use GLIB_CFLAGS but not DBUS_CFLAGS (mc-server.c doesn't actually use
any dbus-glib functionality directly; neither do the utils)
- put our own include directories first, then everything else in stack
order, lowest first
- explicitly link against telepathy-glib and GLib, since we use their
symbols (fixes linking with gold(1))
commit 4e75c43eca3737f2501e46bda0b74e9478637ac5
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-09 18:48:04 +0100
Only honour scheduled saves when we have actual differences to commit.
commit dce04726ee40004fc0688d7ccc52ab4ef3833382
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-09 18:48:04 +0100
Don't flush unchanged settings to SSO
commit 600c5c17cf040bcc3d17a8f9ef776b070d270b4a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-08-09 18:48:03 +0100
Don't flush the enabled state if the SSO state is functionally equivalent
The state is a pair of booleans in SSO, but a single flag in MC, so we
lose information if we unconditionally write to SSO - only flush the
state to SSO if their configuration would result in a different status
from the one we require.
commit 8e70faef11543709c24db9d4bea4d1512072aeb8
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-08-04 12:11:16 -0700
Make McpStoragePlugin retrieval in McdAccount safer.
Don't do a g_return_if_fail, instead return empty results in external storage API calls.
commit b23cd067fce751f820ae70a03c39613ca0180795
Merge: c48e35ea 8c0b868f
Author: Eitan Isaacson <eitan.isaacson@collabora.co.uk>
Date: 2010-08-04 10:02:52 -0700
Merge branch 'account-storage'
commit 8c0b868f5ee65bd3e120186071f8e9aa250b94b6
Author: Eitan Isaacson <eitan.isaacson@collabora.co.uk>
Date: 2010-08-02 17:09:30 -0700
Retrieve the account storage plugin lazily.
Apparently mcd_account_manager_get_storage_plugin can be called too early when
the account is created, before it is written to the storage plugin.
This patch makes it reference the account storage plugin lazily when needed,
and to fail when it can't retrieve it.
I tried to have it retrieve the storage plugin consistently at a later stage,
but there is no way of knowing when the account is written to the storage
plugin since there are multiple code paths. So this seemed like the safest
choice.
commit 49e5b5fd70eb7bcd110171b8562697ce99bb7cd3
Author: Eitan Isaacson <eitan.isaacson@collabora.co.uk>
Date: 2010-07-18 22:52:21 -0700
Remove references to McSvcAccountInterfaceStorage
commit d7569ccc7fa071790afa2de54fb34605b857963e
Author: Eitan Isaacson <eitan.isaacson@collabora.co.uk>
Date: 2010-07-05 12:05:26 -0700
Added maemo accounts support for Account.Storage API.
commit a15d2973a136b81c4268e0f2463507d9b6bbb7d6
Author: Eitan Isaacson <eitan.isaacson@collabora.co.uk>
Date: 2010-06-15 14:55:02 -0700
Implented default Account.Storage API.
commit 39faeb93baf6c3d5cd0c23ab086621a4169af928
Author: Eitan Isaacson <eitan.isaacson@collabora.co.uk>
Date: 2010-06-08 10:40:20 -0700
Remove warnings.
commit c48e35ea2c9ae79f36884123f93344bd15ea0adb
Merge: bfd0469b 929dc974
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-30 13:17:15 +0100
Merge branch 'telepathy-mission-control-5.4'
commit 929dc974509a172d9a0ad6c3bd9931171e75ba9d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-27 20:01:35 +0100
Can't use the AvatarRetrieved signal to find out if an avatar has been removed
The signal only fired for those contacts that had an avatar, so if the
connection signals that the avatar has been updated, and we then try to
fetch the avatar via this signal, we simply never receive any data and
the avatar we have never gets erased.
commit ced3e32094b11970653227e78dbe7c3bd8515c8f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-29 17:11:07 +0100
Implement a test for a remote client unsetting our avatar
commit bfd0469b8f260dd23070ebbd2420197380c13331
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-22 16:19:00 +0100
ABI has been added, update configure.ac variables
commit 37c810c38c3d65f559c3b8a4654c913cfca4e5e9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-22 16:01:10 +0100
Prepare NEWS and configure.ac for a release
commit decbf7cd61cf44d8134c02aa55a7c74b0e9fcf91
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-22 14:10:49 +0100
freed GStrv may not be set, so should be initialised to NULL
commit a1e401dc5e0fcb48022a53e0603ccdeb38927b61
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-21 16:56:31 +0100
SSO plugin should claim all setting for accounts it knows about
commit 97bf09dd1dcfc6923288c4d54cad37b24bc795a0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-21 16:56:31 +0100
Make the debugging of account storage plugins in the AM clearer
commit 027a1ce8e7b2b2840941acc8e54c0b01020e5db7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-19 12:43:39 +0100
Update NEWS
commit 27120189211ad52fba7d9870f6eed6d39cb28d7a
Merge: d57126d7 479174b6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-19 12:33:17 +0100
Merge branch 'rescue-mission'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 479174b603f1ac2cd871a07125fd18dbc0eeabf8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-19 10:54:55 +0100
Fix over-zealous search/replace in ensure-and-redispatch.py
commit 97a0efa95f0e80b6658a9a38021f7765f7d67d28
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-19 10:53:13 +0100
plugin-account: unique_name: move g_free into the loop to avoid leaking
We now allocate once per loop, so we need to free once per loop.
Also narrow the scope of some local variables to make their usage clearer.
commit 0360f89686f4f52fe2f2aea674e71f4897f88b34
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 13:06:35 +0100
dispatcher/ensure-and-redispatch.py: test fd.o #24645
commit 70e1416243ed8bd88353e0e052aa9f8b241b9af0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 13:05:39 +0100
fd.o #24645: _mcd_dispatcher_reinvoke_handler: try to use the same Handler
If a process has Handler well-known names A and B, and a channel
that was already passed to A's HandleChannels implementation is returned
by EnsureChannels, we want to call HandleChannels on A if it still exists,
or failing that, B if its filter matches the channel.
This is particularly useful if A was a PreferredHandler with an empty
list of filters, as used by the proposed
tp_account_create_channel_and_handle_async().
commit 88106ea7b1557c453fc9af3083505de5e98d4157
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 13:01:51 +0100
McdHandlerMap: remember which Handler well-known name is responsible for each channel
commit 0ebc29a5c62be843090f09f488876ec6ca8bd521
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 12:09:42 +0100
dispatcher/ensure-and-redispatch.py: give the better handler a valid filter
The channel's immutable properties contain Interfaces, an 'as', which isn't
valid in a filter.
commit 4631b0a4f1878a0d8b8f542319f6b99c96abcdc0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 12:04:16 +0100
mcp-dbus-caller-permission: don't shadow link(2)
commit ad4312f564cfd5adbec9e73eee3c92c69b9750fb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 12:00:51 +0100
mcd-account-manager-default: don't shadow acct(3)
Also rename a GHashTableIter from account to iter, for least-astonishment.
commit 286307447f8977a4fddf3dbee0b7374b88c3e57d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 11:57:42 +0100
plugin-account: avoid sprintf, and remove limit of 1024 colliding accounts
Re-using the same buffer saves one g_malloc per colliding account. Given
that colliding accounts are a highly unusual case, it's just not worth it;
let's have clearer and less error-prone code instead.
commit fbf163fb378a10a439b48cbb25a628a364c2fbf1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 11:54:46 +0100
plugin-account.c: unique_name(): don't crash if 'account' is not a string
commit 47541d798fc98ce4d2fd974a4e307bd61c56f9b8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-07-16 11:48:15 +0100
Don't shadow BSD acct(3) from unistd.h
commit d57126d74cdf12f231575199cfea0ff8e9c7f3a9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-15 13:47:04 +0100
Typo in comment.
commit 1fcef50dd654ec93a021b430c0f32af496ae89bb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-15 13:43:15 +0100
Typo in header guard #define symbol name
commit 650aaccdfa1f388909593f429b54cb3599ecb0c0
Merge: 7f1a3f00 99a0c91b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-15 12:57:07 +0100
Merge branch 'libcreds-demo'
commit 7f1a3f00afefd38d9b86127ceeee2c009a5814ee
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-07-07 17:55:42 +0100
Document mc-tool service in the manpage.
commit 68424b9c018c4b61d260589bcc122e3c37f52711
Merge: a4f85455 f0c43a27
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-07 15:45:56 +0100
Merge branch 'sso-updates+service-property'
commit f0c43a27d926ffbabc3594bd93f22018f7716ae9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-05 18:48:19 +0100
Fix braino in comment
commit cde89a1ea59cbb3e5eca5b2a46cafbf4f5a5d73c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-07-04 11:41:22 +0100
Add 'service' support to mc-tool
mc-tool still can't create accounts with a particular service up-front,
but it can (try to) set it on existing accounts.
(We need to bump the tp-glib dependency to get
tp_account_set_service_async().)
commit a1f7cc8ab56c4f3158ff4ad914f27c33342c6d32
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-02 18:47:01 +0100
Implement Service property for SSO accounts
commit 3eebea2b5e1141e6710158b25619f949fd7d1608
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-02 18:46:44 +0100
Implement new Service property on account interface
commit 0a04ccfc2b93210f79d53288012e7f606956e217
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-02 18:45:26 +0100
Tests for new Service account property
commit b0368acc4ba16a83cbc70183caf1a53952a50808
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-07 14:53:40 +0100
clear_setting_data() should always be called on a Setting * from setting_data()
commit 12aebc76aa8ddacf08905bf02357a13b2e893735
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-07 14:38:50 +0100
Explain what's going on with the new internal-property-changed method+callbacks
commit 73f16c5844184fa6a88dd3cc858a436bfbfdcace
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-07 14:11:06 +0100
Can't remove the watch hash entry until the individual watches have been removed
commit 143885cfa7d023800551820fb3253649469697bf
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-02 12:59:12 +0100
Haul all the parameter name mapping/global/service/etc logic into one place.
The handling of settings between MC and AG (which each have their own
naming conventions and semantics) had grown organically and empirically
and needed to be re-worked (now that we have a better idea of what needs
to be done to get it right).
commit a4f8545516b5e7dedc1d9b05d2ec34e584e651a5
Merge: d51a8aec 66680dac
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-07-02 11:16:04 +0100
Merge branch 'telepathy-mission-control-5.4'
commit 66680dac767c5ae06abe306ce4e000041c105751
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-07-02 10:36:22 +0100
Treat calls ended locally with No_Answer as missed
If the actor is the self handle, and the reason is No_Answer, then
something on our side (either the CM or some client) decided we weren't
going to answer and gave up. From the user's PoV, these calls are
missed, so mark them as such.
commit b9efeff6d131946b18f50584ad69341c01d7a5d9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-07-01 20:57:40 +0100
property_changed_cb now only passed as a callback once, fix signature & warnings
commit 8560edb3620021e4e69a9e03d26e6753bed13db0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-30 12:36:06 +0100
Handle the single changed property signal from storage backends
commit 746ad961203ee9d4ddeccf50d80b8a1f96739153
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-30 12:30:54 +0100
Method to let the AM notify the account that an account property has changed
commit 8a5413806eaacbda841563180f21608ef15a4001
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-30 12:36:47 +0100
Emit the single changed property signal instead of the whole-account one
commit 3e7daa0d6c52c1fde1b5f17486f02d25adbd4759
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-30 12:35:35 +0100
New signal - flags a single changed property from a backend to the AM
commit 1bfdbd5b2310682852a6c264929a299da7e2ab96
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-25 16:31:14 +0100
Signal emitted on wrong object
commit fdaead7365cc3b39606417970278da25df543650
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-25 16:30:54 +0100
Filter some keys from the watch list (immutable or monitored elsewhere)
commit b3c4d999d3bfc3f0a744fbf3cf5a70f0da8f408a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-25 14:14:37 +0100
Watch SSO keys for updates originating from other processes
commit d51a8aec93a05d8e8d66f96a50be993481494cd0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-29 12:17:50 +0100
Disable deleted accounts so we don't leave connections holding refs to them
This resulted in accounts that were online when deleted silently vanishing
from the store without the account removal signals and so forth happening,
leaving an online account in an orphaned CM.
commit 2956b90df826ed716d99ea8589b33355b1fa7f14
Merge: 5dd81e2d 386accfd
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-06-16 16:23:55 +0100
Merge branch 'telepathy-mission-control-5.4'
commit 386accfd4645ede0743dc5500fe09a350d3dff68
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-06-16 15:59:50 +0100
Reduce INITIAL_RECONNECTION_TIME to 3 seconds
This gives us pretty much the same progression, but with the first
reconnection happening fast enough for the test suite.
commit b84bb07cc573169028224c3d9958750f20acfa73
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-06-16 15:44:13 +0100
Add a #define for the reconnect interval cap
commit 0884d14b2be3dc6b2c992bd63bdfd76c3d6fcca1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-06-16 15:38:48 +0100
Attempt to reconnect less frequently.
The previous constants made MC really keen. Trying again after 1 second
is fine if the CM crashed, but the normal situation is that the server
fell over, or the network is broken, in which case 10 seconds, 30
seconds, 1½ minutes, 4½ minutes, 13½ minutes, then every half hour seems
a lot more reasonable.
commit 0692f156df434142231f53f37dd03d87eab38ff1
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-06-16 15:36:34 +0100
Include reconnection time in debug message
commit 1e7a95255453b727079e68f7077b311cb40fc570
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-06-16 15:35:59 +0100
Add a #define for reconnection timeout multiplier
commit 5dd81e2d0cbd3523704e71d6ad679c5d18c07c73
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 15:10:09 +0100
Nano version
commit b02718b8d943a65b16e7fea1cbdafceb6574a5bb
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 14:32:00 +0100
Prepare version 5.5.2
commit 2776ff74b764ac348260aa8d42a4cfdafad6cc50
Merge: c786e7ca a14a4317
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 13:59:02 +0100
Merge branch 'telepathy-mission-control-5.4'
commit a14a43178eddc5e199abecc1d665a41e45bf772f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 13:54:47 +0100
Nano version
commit 3aa2164dc85d66bde3033bdc3e77bf399260214f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 12:23:39 +0100
Prepare version 5.4.3
commit 92fc828a2f64900cb427869dc42210cae8d9b1b9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:44:23 +0100
Enable ERROR_CFLAGS in every Makefile.am that compiles C
commit f30c6e3cb84fb67b097e3fc84761078ede4c090e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:43:07 +0100
configure.ac: remove alleged AM_CFLAGS that were never actually used for anything
commit 66e75a56da3ef41eae076104e149687f704d7a7c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 13:08:11 +0100
Remove obsolete datadir_expanded check from configure.ac
We use g_get_system_data_dirs() etc. now.
commit 4719e9a639e53f96699ccbd475f08b1d9d7c5e38
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 12:01:40 +0100
Add code to a couple of existing tests to verify that serialization in key files is as intended
(Backported from master to not expect account storage to be diverted)
commit d398ad3a7468d8e9950374735411ac9e7f49c532
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 19:01:26 +0100
_mcd_account_dup_parameters: if unable, explain why
commit bc1b5f1ceea27dbe713217d2dd3e159ad0445b4d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 18:29:36 +0100
McdAccount: clear_register_dup_params_cb: survive if params is NULL
It can be NULL in crash-recovery.py, apparently. Unfortunately, the
async implementation doesn't tell us why it failed, only that it did.
commit 42555e448cfdd8b191ccbe952ff1e91b6994341b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 18:01:52 +0100
account-manager/recover-from-disconnect.py: comment why register=True
commit 704f30899161c124e16ef084289794e51cc85d37
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 17:52:54 +0100
Remove duplicate call to _mcd_account_set_parameter()
commit 549147aadbabcd86464e9cf924c95d8433f6ef34
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 19:37:39 +0100
fd.o #28118: clear the 'register' flag when an account goes to CONNECTED
commit c786e7caf31fe178d9c8252857068deb3bb3c81c
Merge: b5ba07f2 cac2333a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 11:57:11 +0100
Merge branch 'unregister'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit b5ba07f2e899ca1263a3f9f20371a57eaaa65467
Merge: 54c1c8f6 3a3389f9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 11:40:12 +0100
Merge branch 'only-flush-changed-accounts'
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
commit 54c1c8f6d4f3daac868197b807fe64041486cbe1
Merge: 5d52cfe2 cdd0f4fe
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 11:15:11 +0100
Merge branch 'backslash'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 3a3389f92858c6b0870f5593202c1d14237d8a30
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 11:13:15 +0100
mcd_account_manager_write_conf_async: pass the intended account to update_one_account
commit bd37e72ef995e023522fcd94a2265bf61028a608
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 11:12:56 +0100
McdAccountManager: update_one_account: document that @account may be NULL
commit 110206d8fb4ad86f5b89811ae38080a21c06d505
Merge: 5d52cfe2 b1569da8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-16 11:03:57 +0100
Merge branch 'only-flush-changed-accounts'
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
commit cdd0f4fe73d5e593e7d3806983ad47296777976f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 19:54:18 +0100
Add code to a couple of existing tests to verify that serialization in key files is as intended
commit dd4f741a4b1ddd9152173336fc9360ad25d26407
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 19:53:50 +0100
default and diversion plugins: don't escape values from MC as strings again
MC gives us a string that has been serialized into something .desktop
compatible. If we escape it again, we'll double the number of backslashes
compared with MC < 5.4.
commit 84a3808905f2e87ffca975db8a055d8d3b33d405
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 19:52:30 +0100
fd.o #28557: McdPluginAccountManager: use g_key_file_set_value when receiving a value from plugins
When we give plugins something to store, it comes from
g_key_file_get_value, so it's already been escaped according to .desktop
syntax. When we get it back from the plugin, if we escape it again, we'll
double the number of backslashes every time.
commit cac2333a7956cc97a5acab8cfd3d30187e46a98c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 19:01:26 +0100
_mcd_account_dup_parameters: if unable, explain why
commit f4de0b512bef298c16079b08f3e83b112294d63c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 18:29:36 +0100
McdAccount: clear_register_dup_params_cb: survive if params is NULL
It can be NULL in crash-recovery.py, apparently. Unfortunately, the
async implementation doesn't tell us why it failed, only that it did.
commit 92b715d217e5a5bcf2718cb910958168b6f182b9
Merge: e261ac07 5d52cfe2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 18:05:02 +0100
Merge branch 'master' into unregister
Conflicts:
src/mcd-account.c
test/twisted/account-manager/recover-from-disconnect.py
commit e261ac07a489f68a45d82fc73a082dcde1c4efc1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 18:01:52 +0100
account-manager/recover-from-disconnect.py: comment why register=True
commit d60519d0da47b422cfcd0e1fa3df05cb1179b96c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 17:52:54 +0100
Remove duplicate call to _mcd_account_set_parameter()
commit 5d52cfe22b8643959d0dd64d8ef5c715a437639b
Merge: b4b67252 a2b55cb7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 17:40:25 +0100
Merge branch 'connection-error'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit b1569da8b42049f67bb00bc8377b9cfa05821865
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-15 17:36:22 +0100
Revert AccountStorage commit() method to commit all accounts, and add optional-to-implement commit_one()
We don't need to break API straight away to get this bug fixed.
commit a2b55cb75d0bf5865effdfd62b7b12204a45a023
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-14 16:48:44 +0100
Check that the ConnectionError[Details] properties work
commit 3988709dcc9022c254f4cf3f276ff8b3a88eab3f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-14 16:48:29 +0100
Implement ConnectionError, ConnectionErrorDetails properties fully
This requires telepathy-glib 0.11.7, so require that in configure.ac.
commit aaaa6e1277ff5f2407855cdca526af8681fdeb93
Merge: c47409a2 b4b67252
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-14 16:43:11 +0100
Merge branch 'master' into connection-error
commit b4b672525723f1555aab1a31f84ef19c52cf1bee
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-11 16:24:09 +0100
Unused/shadowed variable declaration
commit b83b65230d45f4c3caf38ce908fad45fec161f6e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-11 16:17:40 +0100
Global enabled flag must be turned on when the local one is
If we don't do this, any account ettempting to make the transition from
disabled → enabled will simply bounce back to disabled immediately.
commit 3a0f11b7b93ead7e187ca6b820389302dd5a7d82
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-10 16:43:23 +0100
Don't call tp_svc_account_emit_removed, gets handled by McdAccount disposal
commit 2d31eaeb1d96841a2d8d1fc6323fbb85366fa1e3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 19:11:44 +0100
The label key (name, DisplayName) must be flagged as global so it gets fetched
commit bc59fcb18c9c46e850de3b5b8243b114420374c4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 18:27:41 +0100
The global service has no type: we are always interested in its enabled flag
commit 70b2dff9c505381cd979320615d4ee5594c236e3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 16:39:47 +0100
Warnings promoted to errors after rebase to master, misc tweaks to fix same
commit 526277cb2e0aa9a01855170c903427872aae1d7f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 16:38:25 +0100
Remove temporarily disabled callback, unused definitions forbidden after rebase
commit bc4d0f4adc65c0325e0231bea825c394d12fdd10
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 16:37:16 +0100
Missing header included
commit 4f0bfe3e7397cbf37df7ee6dc15dd032d2ceab45
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:41:21 +0100
Implement account-updated signal handler (not connected up yet)
Seems to do the right thing when connected, but the signal itself is not
firing when I expect it to (this may be a bug in libaccounts or a
misunderstanding on my part): Have disabled the code that connects the
signal for now for this reason.
commit 481e610ae31ff356210da10b70074443a5b0561a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:36:32 +0100
Hook up the account enabled/disabled signal when we cach an SSO account
commit bdf7c5110df10a790df5f6ff9f8897ff6954bad4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:33:49 +0100
The SSO "name" key maps to the MC "DisplayName" key
commit 4a70382a58f7b3b7a7fa75600aba8216e5f1c226
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:32:38 +0100
Use the new helper functions to get/set the enabled state in SSO
commit 0d86aeed97c00d9e3a8351f0a4552c2a8785849e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:28:37 +0100
Helper functions to get/set the enabled state of SSO accounts
SSO accounts have a global enabled flag (the master enabled flag)
as well as per service enabled flags: Both flags must be true to
enable an SSO account, but either being off disables it.
commit 7e556e7b4fac1b6dbaca933593edd4a2573ddf8e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:17:45 +0100
Fix data transmitted with deleted signal (name was prematurely freed before)
commit 855d672de1469eacc96223b1f2feac7585871807
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:10:07 +0100
Callback chain to handle account-altered signals from backends
commit cef2bb472058c36fd5a47cd6b9b3793bf6f01ba9
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:05:00 +0100
Tidy up debugging for backend account enabled/disabled signal handler
commit e3de2cb8b3272d8d346749b59f824e6ef3d5342b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 15:04:04 +0100
Finish handling account deletion events from backends
Cleanup refs to account, emit Tp signals.
commit 3c277cf94f1466aeadb7e4445df30dd528040f21
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 14:55:52 +0100
Implement new list_keys method in shim object for account manager/plugins
commit db2c574585ef2d2ec7e0dda982b57efa40005681
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-06-09 14:55:28 +0100
new account manager/plugin shim object method - list_keys
commit 2b9b455c97949741edabacfa897f1adb245d6fbf
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-06-09 12:53:13 +0100
Only flush changed account details to disk.
Previously every time any property of any account changed, every account
was flushed to storage. This is really, really bad if you use
gnome-keyring, because it meant a pair of calls to Unlock()/CreateItem()
for each secret on each account, every time anything changes. On my
machine, signing in 6 accounts entailed 384 pairs of calls — 64 per
account! Furthermore,
it seems that the implementation of CreateItem() calls fsync(), so my
hard disk would thrash for about thirty seconds.
This patch adds an optional argument to
mcd_account_manager_write_conf_async() and mcp_account_storage_commit(),
indicating which account changed. If NULL, everything is flushed; if
non-NULL, only that account is flushed. In my testing this reduced
logging in to 9 Unlock()/CreateItem() pairs, which is still more than
zero, but stops the disk thrashing quite so badly.
Removing accounts doesn't cause the secrets to be removed from the
keyring... but that's not a new bug. Everything else seems to work as
expected.
I didn't update the libaccounts-glib backend to benefit from this, but
given that all it does is iterate across all accounts and call two
methods on each, it should be easy enough.
Mitigates: http://bugs.freedesktop.org/show_bug.cgi?id=28390
commit 23342ff5da50650e8336aace80b545f5cc001331
Merge: 82662dbe 92f8ba0c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 19:47:46 +0100
Merge branch 'trivia'
commit 92f8ba0c6472696d906340407854470e24fbce44
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 19:43:27 +0100
Make AM_CFLAGS matter in src/ again
Setting libmcd_convenience_la_CFLAGS to any value, ever, disables use
of AM_CFLAGS for those source files. INCLUDES is what we want here.
commit e12b12bb7b442f21ef5e5e76277dc2db3b6bf6b4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 19:43:23 +0100
Fix an assortment of compiler warnings
commit 1a60034da6845195948d720dbb9481b2373fd35b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 19:37:39 +0100
fd.o #28118: clear the 'register' flag when an account goes to CONNECTED
commit c47409a249a59c980f87f4e320217f0045758589
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 18:38:32 +0100
recover-from-disconnect.py: test detailed D-Bus errors
commit a0f67dee25d9a97220c736467297393415ae6637
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 18:33:43 +0100
mctest: add the ability to emit ConnectionError
commit 96f555be20529cd91a1d0f4c50a52fd61570f3e4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 19:02:41 +0100
account-manager/auto-connect.py: test connection details being emitted together
commit d05e9d029244e1e789b5e77d9f9f9e031dc7579f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 18:07:34 +0100
McdAccount: keep track of ConnectionError[Details], and emit them in signals
telepathy-glib support will be needed to have them as properties too.
commit ac9d2eaffc1cc0ddf7dfa2d68181646abf50734a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 17:52:07 +0100
_mcd_account_set_connection_status: emit change notifications for all related properties
If the ConnectionStatus changes, we should put the Connection in the
signal too, even if its value hasn't actually changed - it makes the
signal easier to interpret.
commit 4788d069be838ecc290114d098c394f3275b28e4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 18:33:33 +0100
account-manager tests: don't assume the next ConnectionStatus change will be to CONNECTED
This is about to become untrue.
commit 4a3304105563bbe8ff27f54fffa2232625738599
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 17:48:10 +0100
_mcd_account_set_connection_status: only emit a change to Connection if something changed
commit 50043605991025a0359233a61346e621b988388f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 17:46:03 +0100
_mcd_account_set_connection_status: take a detailed error
commit 7fe075cae4a60580e54091423561e413cfd1774e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 17:45:25 +0100
McdConnection: emit TpConnection in CONNECTION_STATUS_CHANGED even when invalidated
It's still referenced at this point, and emitting it here will let the
McdAccount interrogate it to get the detailed connection error.
commit 3f0403f0a871d1991098c0b8d50ca13d30dcdebe
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-06-07 17:44:24 +0100
_mcd_account_set_connection_status: only save the TpConnection if it's trying to connect
commit d879726fea2fe55c33057ecf87901c48f8d180d2
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-06-06 16:57:13 +0100
Remove deprecated-and-unused mcd_account_manager_write_conf()
commit 82662dbe3347109d2621c15a15a02dd4855f869b
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-06-03 22:24:51 +1000
Nano version
commit 9e2634a1cc47a9cc52c8bdf62cac2691a0d9ee43
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-06-03 22:15:32 +1000
Prepare release 5.5.1
commit 8674090dffeae2a9a6dc029afd133fdda2eed860
Merge: 5c3568a2 e5093465
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-06-03 22:07:23 +1000
Merge remote branch 'smcv/plugin-doc'
commit 5c3568a2a91420a27120612ef0730ec968dfc6a6
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-05-28 12:59:53 +1000
Implement ::toggled for McpAccountStorage plugins
This allows an McpAccountStorage plugin to enable/disable an account.
commit be025b57f399050908e228cc05828d82f66dbc34
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-05-27 20:54:04 +1000
Change startswith() to strip_prefix() to be clearer about what it does
Make it return const, because it doesn't allocate a string.
Change prefix() to ensure_prefix()
Change strip() to skip_prefix() and make it return const
commit e990954870d791e2623a927f85cc120d3a51a51d
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-05-27 15:45:35 +1000
Update copyright for mc-tool
commit 57cf63d319353fe860df91dfe9886d39ac1d9b3d
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-05-27 14:40:05 +1000
Port from McAccount to TpAccount - Part 2
This reenables NormalizedName and AutomaticPresence by requesting those
properties directly from the Account Manager, since they are not exposed
via TpAccount.
commit c54b2ee9384a902ff1488ce3f4027484439fc115
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-05-27 14:13:36 +1000
Port from McAccount to TpAccount - Part 1
This ports all features that use TpAccount and disables features that are
not available through TpAccount (AutomaticPresence and NormalizedName).
commit 062d2ea9dc1a1cd8dcd478d4243473f26354feaf
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-05-27 12:32:33 +1000
Port from McAccountManager to TpAccountManager
commit 58b12e4a39f8bd1c6c77e41b75d038c73db572d3
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-05-27 12:12:44 +1000
Replace account_prefix with TP_ACCOUNT_OBJECT_PATH_BASE
commit fe2d061111a346f6c730286f8a8b7be620bd135d
Author: Danielle Madeley <danielle.madeley@collabora.co.uk>
Date: 2010-05-27 11:59:01 +1000
Change names of variables that shadow global functions
Allows compilation with -Wshadow
Changes:
'acct' -> 'account'
'daemon' -> 'dbus'
commit 0398ea62880803d2ec68b088e6a4e0ec21f41c78
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 19:25:03 +0100
Nano version
commit 57ef8f9c6762ab0fc1d15991a15781e52ddff68d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 19:04:43 +0100
Prepare release 5.5.0
commit 69d44b7e012282fe8a0d54c9828edd87c41a0304
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:50:24 +0100
Update NEWS
commit 65d3d66a1e739b1670997b1d91ad0c62e4d67916
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:44:23 +0100
Enable ERROR_CFLAGS in every Makefile.am that compiles C
commit eba54b4d4bfdb2132a224c3ce6b5c9aa594022f4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:44:08 +0100
Include "plugin-loader.h" where needed
commit 9104ba032d388ef036aa3dc8eeb40bcbc1b5823b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:43:57 +0100
McdAccountManager: delete unused variable
commit 902be44973e3a03ebaf54ae193faa1c9cca7b597
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:43:40 +0100
libmcclient/mc-dispatch-operation.c: add missing header for tp_g_hash_table_update
commit a882183f60dea827efe6add35567379de5c6257d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:43:07 +0100
configure.ac: remove alleged AM_CFLAGS that were never actually used for anything
commit 00c1c83ccc1516eb08908657cba5d950f08cfdc1
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:39:44 +0100
Now that GModule is mandatory, just include it in GLIB_LIBS
commit 079136b04ad5dbb680272a681c73a435eca6da13
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 18:19:41 +0100
Only install libmcclient.pc if we'll be installing libmcclient
commit e53abee95629697235e2abd55583814b8936891c
Merge: 72e39254 c7d292c8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:56:54 +0100
Merge branch 'plugin-doc-minimal'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 72e392545e630ef8bd4b8cda0766162b053f1335
Merge: b4a17274 f120b06c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:56:26 +0100
Merge branch 'will-this-release-ever-happen'
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit f120b06cf7b81739b27984bbbad7a27650c8a81f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:53:00 +0100
McProfile: don't dereference a NULL pointer and crash on malformed profiles
commit 960369ba77533f8f1d0c351a94593b62735c4c0a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:52:33 +0100
Make it more obvious that g_key_file_get_keys() returning NULL is handled
commit 183bd3ba76ab9ba9e661ffa85b85e5db4c725556
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:51:24 +0100
mcp-account-diversion demo plugin: also guard against an error return here
See previous commit.
commit 917cd7469b3cda60e1b0844267965e735c0f1c3f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:50:13 +0100
Default account storage plugin: guard against g_key_file_get_keys returning NULL
If the group in question doesn't exist in the keyfile (typically because
an account didn't exist in the GNOME keyring, in the last patch band),
the @length argument isn't initialized.
We could initialize @length to 0, but that's not very obvious.
commit 989e2048934cc5822488524d3813e0d230dc4c5a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-18 11:00:15 +0000
McdChannel: when cancelling requests we no longer need to abort REQUEST-state channels
Also explicitly close the TpChannel, if we have one.
commit 393cb6e272d8178162d38f945069aa0dfe6fe687
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-18 10:58:47 +0000
mcd_connection_request_channel: if the channel (request) has failed or been cancelled already, close and discard it
commit c95ec5c7c16139fa264ea775ff39a81aa45b74fc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 19:48:32 +0000
McdRequest: track whether we can safely be cancelled
commit a21aa22763cb5e15cb88fb11fba46d00b68a9bed
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 19:35:05 +0000
McdDispatcher, mcd-account-requests: let the McdRequest tell us its status
commit 3545baa31aeed9067cc7ad1de3ab65b3a1fc15b3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 19:24:14 +0000
McdRequest: signal completion
commit dcbdea0f4555dac463f3fc39d217a3857aaafcb9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 19:20:42 +0000
McdChannel: propagate our own status to our request, if any
commit a75673f34add70162e2fd41f5ddf6d17323e5017
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 19:20:30 +0000
McdRequest: add a concept of having finished
commit 3fff4f5496223e0e1042114f308a77022cbcdc61
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 19:05:35 +0000
McdRequest: rename denial to failure
We can use this as a more general indication of failure.
commit 26cb82a134b9e182f162effc9ebb5a171e76cdf0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 18:47:21 +0000
mcd_channel_init: make it explicit that the initial status is UNDISPATCHED
commit fe85f2dea2a78574e02ebde71fc4ff056df52d01
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 17:44:00 +0000
Add a regression test for delaying channel creation in a plugin
commit 7aaa5b54ca27ab51de3e2b8bd322a31cab7b2318
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 17:43:08 +0000
McdRequest: support delaying requests while waiting for a plugin
commit 6171032b1d982e07662d977a6d56c402d275d940
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 15:08:05 +0100
McdPluginRequest: implement in terms of McdRequest, not McdChannel
commit cf977ecc4a4bf83d199cb0e8864259865d85fb90
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 16:22:58 +0000
McdChannel, McdPluginRequest: add stub support for delaying requests
commit 6d8a535d13e96a68c8ed329dccdbf66c7cd9ba14
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 15:06:50 +0100
mission-control-plugins: add support for delaying requests
commit 7f1fbd6c841ffdcbc685fd19748ce284a09dad9a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 14:19:15 +0000
McdRequest: store the request's properties
commit 92a1b4297b71b136f55f1dd2a797cd2426ee3b04
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 14:03:44 +0000
mcd_channel_get_channel_type: reimplement in terms of mcd_channel_get_channel_type_quark
This prevents any string-lifetime concerns.
commit bc7c22cc62c220f0a8aad334fea2bb9d8a0e2aa7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 13:58:56 +0000
McdRequest: store the proceeding flag
commit 7392a143fdad5499d50c80bda6f4b22ee5b41bcd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 13:52:52 +0000
McdRequest: store use_existing
commit eda1c51c0552e540cfaf2f65e59962b1439abe0f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 13:47:20 +0000
McdRequest: store the object path
commit 91d8f19f7895cf3f738c62b4efea89cc8e300d10
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 13:45:52 +0000
McdRequest: store the preferred handler
commit 109ad4f0414b081d18189aa52f2670cc2cef0c30
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 15:06:12 +0100
_mcd_channel_get_target_id: remove
Nothing called this method, and misleadingly, it only worked on channels
that were requests.
commit 60e37da24c70f0961d0a2281ffa490dc0811243e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 13:28:03 +0000
McdChannel: use the McdRequest for the account and user-time
There's no longer any need to weak-ref the account, since the request
strongly references it.
commit adcf6df535ca3b31bd8fdcb3afcfc8730e525f05
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-16 13:27:06 +0000
McdRequest: add properties for the account path and the user action time
commit e2178d20dc34101acdf3bf53e3b537aaf44745b4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-18 14:13:45 +0000
McdChannel: have an McdRequest if this channel is, in fact, a request
commit 1dd4d15647e2e5989bac5c2d11ff625aae49f7af
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-16 16:38:32 +0000
Add stub McdRequest class
commit b36093176f5165f5df8d91401cce9787bfdf8e36
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-15 17:47:25 +0000
McdAccount: make the default implementation of check_request just be "let it through"
If a specialized version of MC (like OMC) wants to reject channel creation
on low memory, it can do that by overriding this method, or by using the
new, smaller plugin API.
commit e5093465d4fd96973d4b1ee59716db1b8e75a076
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-01-21 20:25:03 +0000
Document the API provided to plugins for dispatch operations
commit 3c48d5ddb33e057fe0016b107aede03f5e19569e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-01-21 20:24:44 +0000
Document how to be a dispatch operation policy plugin
commit ad536935616e515e5ac181e83b88862cb01bd1a7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-01-21 20:24:29 +0000
Add stub documentation for McpRequest
I'm not documenting this class until the smcv/requests branch lands, since
its API gets more capable in that branch.
commit a85d7dabe7c88df9bb50c591b241b145c586b367
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-01-21 20:23:54 +0000
Document how to be a request policy
Not all of this is strictly true until the smcv/requests branch, which
makes request policy plugins able to delay dispatching, is merged.
commit efac58c9a03aecb120db3cc25fb1137e383fe35a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-01-21 20:22:48 +0000
Document global functions for plugins
commit c7d292c87b26e5ec9cbf0f9559049ec2ebc75876
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:02:13 +0100
Makefile.am: when doing `make maintainer-upload-release`, upload MCP docs
commit cf57e89de87b1e8fcc14671a5d191c7a51d2d8e0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-01-21 20:22:26 +0000
Move MCP_PLUGIN_REF_NTH_OBJECT_SYMBOL, mcp_plugin_ref_nth_object to loader.h
This will mean all the loader.h stuff gets documented together in gtk-doc.
commit 1b5d0af55ede724f9e5bff7e2e8bf98b22eeb6da
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:27:20 +0100
Add infrastructure for documentation completeness checking, but leave it disabled
commit 0285cf42d28d2af0aa727ed11cbfdb57eb50faed
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 17:26:54 +0100
Add gtk-doc infrastructure for mission-control-plugins
commit 61b7a526279b205476bb649cd47be85feb83b661
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-01-21 20:20:16 +0000
mission-control-plugins: use an internal macro that won't confuse gtk-doc
commit b4a17274e0bf622deb710b87206a15e7322dded9
Merge: 447a2252 f00511ef
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:58:22 +0100
Merge branch 'telepathy-mission-control-5.4'
Conflicts:
NEWS
configure.ac
commit f00511ef405f7bccd18029576bf3f65e53504e70
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:57:05 +0100
Nano version
commit 00d01ea64a02ccbc2c13d58e4f7d7e85e5b73367
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:36:03 +0100
Prepare version 5.4.2
commit d708686824f2ba70cf7c867752e9e52cb95f461b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-20 15:43:15 +0100
Coverity 7707 REVERSE_INULL two gchar ** deref'd w/o check in set_param
Also gchar ** strv_type_key potentially leaked in the 'clear' and 'unset' cases
(cherry picked from commit c4b90bf71b14da5a6c11bd7ef1898cd2734ffbab)
commit cd48b089e962c9842c97545ad3cb91336a4be675
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-20 15:43:15 +0100
Coverity 21106 RESOURCE_LEAK in dispatch_operation_claim
(cherry picked from commit 07599a7ab74d654d50bc4dd8493f6f4cef5459df)
commit c773108d1729d00ed832d93c2246e14cb81ec12a
Merge: 6cf8ed22 80b75c38
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:22:04 +0100
Merge branch '54-unsafe-param-reuse' into telepathy-mission-control-5.4
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit 447a22525c59429d910cf68061649295e6f4ce1f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:17:30 +0100
Remove protocol-copying code that was duplicated from telepathy-glib
The stable branch needed this, but in this branch we can just depend on
a good enough telepathy-glib.
commit ec8e84c00493aa9e46b8e4513a005c8d079405a9
Merge: bf1963ae 80b75c38
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:15:33 +0100
Merge branch '54-unsafe-param-reuse' into unsafe-param-reuse
Conflicts:
src/mcd-account.c
commit 80b75c38c6147eee494e8bf0d63309f4555d8d03
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:09:06 +0100
_mcd_account_dup_parameters: don't assume that borrowed parameters remain valid
commit 603f1fb47b08fc329868d6284022e9e397fd73d8
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:08:32 +0100
_mcd_account_set_parameters: don't assume that borrowed parameters remain valid
commit d408af59e2e5066ee87a6ef9c718500b335f704c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:08:10 +0100
mcd_account_check_parameters: don't assume that borrowed parameters remain valid
commit fd0180aeca1b266bf4212ce63ca01c36bd151762
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:07:33 +0100
_mcd_account_migrate_secrets: don't assume that a borrowed string remains valid
commit e183be2acb77ebd9117723ff3eb8da874aa8ab16
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 16:06:45 +0100
_mcd_manager_dup_protocol, _mcd_manager_protocol_free: add
Copied from telepathy-glib 0.11.6 to avoid a dependency on that version
in this stable branch; in git master, they should be replaced by calls
to the newer telepathy-glib API.
commit bf1963ae9d03b9de9f20cfc41c5c42fe22d93682
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-19 19:38:30 +0100
Remove the independent keyring plugin
commit 68f540a5e4f64bac4fe5eabeac1118eb05824b89
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-19 19:38:08 +0100
Remove references to/use of keyring plugin from account manager
commit 76ae29581db982feea0069151c4f3baedbff8d1f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-19 15:31:14 +0100
Move keyring support from independent plugin to keyfile plugin.
commit c4b90bf71b14da5a6c11bd7ef1898cd2734ffbab
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-20 15:43:15 +0100
Coverity 7707 REVERSE_INULL two gchar ** deref'd w/o check in set_param
Also gchar ** strv_type_key potentially leaked in the 'clear' and 'unset' cases
commit 5e6f1c7c8722a660eced18fe88fcd1626ca1d5ef
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-20 15:43:15 +0100
Coverity 11054 UNUSED_VALUE DBusConnection pointer in register_dbus_service
commit e1ce16433e74c775d81589a6bd6fe28425343dde
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-20 15:43:15 +0100
Coverity 11729 DEADCODE - message cannot be NULL after g_return_if_fail check
commit b26ccfced1d7d6caf7e513f89d208784899bc795
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-20 15:43:15 +0100
Coverity 21104 REVERSE_INULL make mc_param_type consume NULL safely
commit 07599a7ab74d654d50bc4dd8493f6f4cef5459df
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-20 15:43:15 +0100
Coverity 21106 RESOURCE_LEAK in dispatch_operation_claim
commit e7af1f7b919cad4443588ab7d1d710768aa923dc
Merge: 5d4bc3cd fc8c19ba
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 14:05:54 +0100
Merge branch 'build'
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
commit fc8c19bac53368a36170ae5a2501da566dab1c56
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 13:25:11 +0100
Only install documentation for the old libraries if plugins are enabled
commit 7958edf73362b03362e551c7a48ddbe0484ad32d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 13:12:07 +0100
Always check for GModule, which we need for the new plugin API too
commit 17bf9dce72ab82f08fd9e4b1ea493df5e4520a17
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 13:10:39 +0100
Always build examples: they're not installed, and cheap to compile
commit c7f56da57ed50073ed8604ec5f635a1b3830ed89
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 13:10:02 +0100
Always build tests; remove --disable-tests option
commit 0441d12aa7256747af7d510b288231dac31ddb15
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 13:08:11 +0100
Remove obsolete datadir_expanded check from configure.ac
We use g_get_system_data_dirs() etc. now.
commit a8085fc622c922362f7c27ec6ecef59522688edf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 13:05:15 +0100
fd.o #26634: remove obsolete utility for migration from Mission Control 4
commit 152fc26baec675dd72a685ce0c76616da7705081
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 12:57:59 +0100
Explicitly disable MCD plugins when doing distcheck
This helps to verify that the configuration we'll be using in
distributions (static libmcclient and libmissioncontrol-server, and
shared libmission-control-plugins) works correctly.
commit d13fa422bdfdda5d6c040fd63f5b5fcb187b0857
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 12:55:08 +0100
Update README
commit 795ce3b4c1d3fecdad026edc4a8dc3999c7cdfa7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 12:27:12 +0100
libmcclient: only build as a shared library and install headers if MCD plugins are enabled
Only Maemo, and MC tools like mc-tool, use this library; the latter can
safely be statically linked to it, and the former already enables MCD
plugins.
commit 3efc0b2e69fda63390a03aebfa18a20b8379bcbc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-26 12:04:09 +0100
src: re-namespace marshallers to avoid clashing with libmcclient if it's static
commit 95a3e0e6d44e6c4178fa6b506be44f9d1180f5cd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 19:56:59 +0100
Use a more obvious API version for the plugin headers
commit a069613261c7c27fd4f4dbb844ab3081df07f1a5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 19:49:03 +0100
Distribute Account_Manager_Interface_SSO
commit d5a34a06d764a72da1f7b5c845506f775d06802d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 19:48:57 +0100
Remove stale reference to Creation interface, which no longer exists
commit 5d4bc3cd9a3775f41a92850a8a1ba69e9d6a2e9d
Merge: 02b3518c 6cf8ed22
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 19:44:19 +0100
Merge branch 'telepathy-mission-control-5.4'
Conflicts:
NEWS
configure.ac
src/mcd-connection.c
commit 02b3518c046921abe98e0027b870a1fccc5be8e8
Merge: 8474ddfa 6698e407
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 19:40:46 +0100
Merge branch 'trivia'
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
commit 6698e407c41f78ed7a40cd578d599849ec161500
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 18:51:31 +0100
biggest NEWS ever?
commit 6cf8ed2299d4e473550c1f828ac9af596c607721
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 19:38:36 +0100
Nano version
commit 91bb48a26e0dc7a9abab8d36b46e887c988a6279
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 19:16:05 +0100
Prepare version 5.4.1
commit 7a24d56cd283cfeea0d29cab157f2498453a24a9
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 18:55:08 +0100
update NEWS
commit 5574043e9291e983e52848ab1b4c89d9a1bb44cd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 18:29:09 +0100
Revert "fd.o #24875: reimplement g_error_new_valist to avoid a GLib 2.22 dependency"
This reverts commit 29abb230abaf890d33751d5da232b9a69434f0e5.
commit e4e4775f29576e5cf5b0e13b531c1ae2f73cb827
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 18:28:53 +0100
Depend on sane versions of GLib, D-Bus and dbus-glib
commit dc20989d8526005004a9825faa5fc9c2fa506b56
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 17:06:13 +0100
Add a regression test for fd.o #25684
commit 73181507d5320d1f53bf79724f48e355d5e70c5a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 17:05:09 +0100
fd.o #25684: fix detection of accounts that already exist
Based on a patch from Jani Monoses <jani@ubuntu.com>.
commit 39ce98e1be9739a4cd1b2139725a57e84a7eeb8f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 16:39:37 +0100
fd.o #27129: update and simplify test/twisted/README
Based on a patch from Tomeu Vizoso.
commit 4e713cc04ca8a59ecef6fc0c055594456ff95220
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 16:36:34 +0100
Add silent rules support
commit 0edd9f9222bf7706a749fd3563dfab1a752108e4
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-04-15 19:58:25 +0100
Update servicetest from Gabble to display better diagnostics
commit 8474ddfa4435a53a13abe5103cd8828aa4431bfa
Merge: 90a613bd aedf8114
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 18:25:32 +0100
Merge remote branch 'cassidy/handle-time'
commit 90a613bdb97f751dcf5d33dd3e156002ff817a7f
Merge: cc5ddd9d 7ecb1e63
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 18:24:41 +0100
Merge remote branch 'andrunko/account-changing-presence'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit cc5ddd9d50e7469d88d45a59360789013d4bde35
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 18:23:16 +0100
Depend on telepathy-glib 0.11.6 for ChangingPresence, HandleWithTime
commit 1dedb276b857276562ec4b007387e856ee8d5bfc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 17:53:49 +0100
Don't cache whether we have the requests interface
One use of the caching (in _mcd_connection_request_channel) was subtly
incorrect: before using the cached variable we checked whether the
TpConnection was ready, but that's not the same thing as checking whether
our on_connection_ready() callback (which caches it) has actually been
called yet.
This fixes a regression in dispatcher/connect-for-request.py.
commit fcfe135a45329d25cd8886b3861f68ee736e672e
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-05-25 17:06:13 +0100
Add a regression test for fd.o #25684
This turns out to be a regression in the 5.5 branch, but adding a test
in the stable branch seems a good way to avoid introducing this bug.
commit aedf81146c7a36c3f7f876b97aac845e9490913e
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-05-25 13:53:15 +0200
implement Approver.HandleWithTime()
commit 99a0c91b2e2d455eb3ac2001b132ff731843d12a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-24 17:54:36 +0100
Correct some comments.
commit 0dd2f6fcb551e41a05b00d1aecbf94f6951d4c1e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-24 17:46:41 +0100
Aegis/libcreds based DBus caller ACL plugin
commit f1696f20cd1442942283a0aba0a18136ec998da3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-24 17:45:51 +0100
Wrap dispatcher ensure and create channel calls in DBus caller ACL checks
commit be1d2579a4141d66324cdc5c1b9020dd6c4498cc
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-24 17:44:46 +0100
Implement demo DBus caller permission ACL plugin (not used yet)
commit 8a2752bf7a9af0dca7c8cfecd012d67438fa401b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-24 17:43:38 +0100
Provide ACL wrapped DBus property get/set/get_all helpers
commit 5fbaaa0c09fe1fda85f2e48e5ee035e991ede62a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-24 17:42:10 +0100
DBus caller ACL plugin interface + docs added
commit 194b14e3e614ccf8fff2c3087cc528285daf8b06
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-24 17:40:11 +0100
Improved debugging when g_module_open fails to load a plugin
commit a6d16a6a0fdd7971406d935490a578f93bb7a70b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-24 17:39:48 +0100
Improved debug for malformed (missing manager) accounts
commit f64a3c798ce77a5b67f54f6a03b22f28c58241d1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-19 15:44:05 +0100
Signature of mcd_manager_call_when_ready callback wants a const before GError *
commit 6131c21e87ea4ba1601012c58e9acedf8b725426
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-18 19:10:51 +0100
Drop support for unused create parameter from get_ag_account()
commit ffeaeb5b6e7618d9926d19defe1e21279634370e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-18 18:43:18 +0100
Dead code removed.
commit 33077472f156d3658354f13fea48b7c78d71b892
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-18 18:43:07 +0100
Dangerous call to g_free dropped
commit 014994d7128e43e996a0533bcec58e0ae8eeb383
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-18 18:42:24 +0100
Minor comment.
commit b308d60d6ddb3d0a94e69dd361e575bc7a4b76b0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-18 18:42:00 +0100
Account verification calls shouldn't happen until after the manager is ready.
This meant that the first account for any given manager might not have been
announced over dbus depending on a race between the CM becoming ready and
the account verification callback being invoked (for accounts created by
storage backends like libaccounts-glib/SSO at any rate).
commit faac87f2b3dff316b4cf65b6c7afacb495cbd2db
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-18 18:39:24 +0100
Typo in debug message (valid/invalid switched).
commit d66e10badab7b6e777b5722d446eff25982ad679
Merge: 575e003e b864a277
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-05-19 15:37:46 +0200
Merge branch 'telepathy-mission-control-5.4'
commit b864a277d76c54a803e9259cd65abe1dfdc624d3
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-05-19 14:45:29 +0200
set '0' as UserActionTime when HandleWith() is called
'0' means 'no user action' which is the safer choice to prevent focus
stealing. User should use a futur variant of HandleWith() allowing him to pass
a UserActionTime when needed.
commit 575e003ecd88ed5ed07612b1f54cc4cb5698d7fe
Merge: dfdc4d82 506f1645
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-05-19 15:35:05 +0200
Merge branch 'telepathy-mission-control-5.4'
commit 506f164532b3a2fc5b8b232b42414e7bc79c17b4
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-05-19 15:33:43 +0200
account-manager/presence.py: GetInterfaces can be called twice
commit c758ce6dd21a56641b78b36137274a13d8270488
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date: 2010-05-19 15:23:10 +0200
mctest.py: no need to import 'sha'
commit dfdc4d82c654dad67c89b8a37951f5a079b37a8b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-10 14:15:48 +0100
Document likely error of an SSO ID account -> MC account dbus call.
commit 56e186485d768b66190d6f1802e6178e7e50a8b0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-26 14:50:14 +0100
xmlns typo
commit 45a415ec7ae312a86d848d5cd2215e1300324032
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-26 14:04:12 +0100
Tweak the SSO ID comparison based on review
commit 9d487bab8db34c2e117062178cd9342648a0120d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-26 14:03:41 +0100
Class, method and variable renaming from review.
commit a676a8ef98b69eb3f62b1467dd776fad75bf9346
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-26 14:00:41 +0100
Remove account interface (dropped from requirements)
commit 0357b99db643b1e7e30a9f7487468f880af1e3ba
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-19 13:57:08 +0100
Implement the new SSO related utility methods.
commit c78decfb9156e20fe423e0121ca3ae2400d82005
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-19 13:55:17 +0100
Generate headers and code for the new SSO properties interface.
commit fde2102e92081645bcb71a88ae0d4aaee061e47b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-19 13:54:08 +0100
SSO accounts can have multiple services, but this is not exposed as a property.
Instead, expose it as a special property which is not covered by the standard
iterator but will be returned if you ask for it.
Also, exclude the property from being saved, since the list of services can
change and should not be cached in the SSO storage for the account itself.
commit 3773279f3f783646aefa23978bff102358823399
Merge: c9ca4ea5 156a6b76
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-10 13:27:11 +0100
Merge branch 'sso-tmc-uid-is-service-specific'
commit c9ca4ea5f5fdb4cd735aeef816cc53694a518ddb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-10 12:59:02 +0100
mcd_account_check_validity after async account creation to prepare/announce it
commit 156a6b76770aed18fc8c39af430f10dcf9e90219
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-07 16:03:25 +0100
MC_IDENTITY_KEY wasn't treated as a service local value everywhere, fixed
commit 2d4a8c7ccfd56ceefe254db813b1b8348f6bc2c1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-07 14:19:36 +0100
More explanatory comments.
commit 8843d84ca628c928647bc10fbdaefe46dd5b9707
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-07 14:19:22 +0100
SSO values (as opposed to params) can now be local (they were all global before)
commit e0ff2d813712bf5655f1899391e0b765516d674a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-07 13:47:44 +0100
Explanatory comment
commit c83e332c1738e08dc28f818dfc9e006d81971d3a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-07 13:47:30 +0100
Change name of get_mc_key to indicate it deals with MC parameters, add comments
commit 00f6eae530a14e2f99cb3896816af43f06f136cd
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-07 13:41:00 +0100
Update implementors-note comment to be both true and more useful
commit 7ecb1e63ca5e93449b5669a81fb80f0889514c09
Author: Andre Moreira Magalhaes (andrunko) <andre.magalhaes@collabora.co.uk>
Date: 2010-04-29 03:49:46 -0300
Added test case for Account.ChangingPresence.
commit e5f0b40c879c92b2a59944decada5c2c4b1720fb
Author: Andre Moreira Magalhaes (andrunko) <andre.magalhaes@collabora.co.uk>
Date: 2010-04-29 03:49:11 -0300
Proper emit AccountPropertyChanged(ChangingPresence) when the presence is changing.
commit 282064d6b7758ad83815c8b63ff4cc6d9cf5b806
Author: Andre Moreira Magalhaes (andrunko) <andre.magalhaes@collabora.co.uk>
Date: 2010-04-29 03:48:41 -0300
Added Account.ChangingPresence property definition.
commit 5dcd6cd2011e9b0477493cc7618388f4317cd341
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-07 13:40:24 +0100
Rename get_ag_key to indicate it applies to params specifically.
commit d06aa5990e57b55ee03d5ea0d25f0f6895a094b5
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-05 18:18:52 +0100
Variable moved to a more localised scope
commit 377f5cc874d5e784c6295d3220f4adfdc6092f8c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-05 18:18:32 +0100
Unused account name removed
commit 36a87b5cd1377f820326d85320879e3dd6b7f2ea
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-05 18:18:11 +0100
Unnecessary GList removed
commit d96203693dbb764ccfe93e0f0f6dc307f62ce5fe
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-05 16:22:18 +0100
Extra debugging to help diagnose a reported but as-yet unverified new-account bug
commit b1105ba4a7c5fdd225a2b3b9d0938970db1599fc
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-05-05 16:21:02 +0100
Revisit the SSO account storage plugin now we have some concrete examples
The following points are addressed:
* The hardwired SSO service selection is gone
* We now very carefully pick an IM service where necessary
* We un-set the service where necessary to get global settings
* We are careful to leave the selected service in the same state
on function exit as it was on entry.
commit c8a3f6a72e84e876154b44b595ae2f6ce03b0f74
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-30 17:55:48 +0100
Don't try to register the account-manager's dbus name again.
This was triggered by asynchronous back-end account creation, which is
a new code path required by SSO.
commit 3465fec353fe5af219039da520d56409ac150a60
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-04-15 20:59:14 +0100
The next release from this branch will be 5.5
commit c8db874b6bf27dead411d6f83c504f2bb40fd1fd
Merge: 0901a0a6 c4bb262c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-04-15 20:57:50 +0100
Merge branch 'telepathy-mission-control-5.4'
Conflicts:
src/mcd-account-manager.c
commit c4bb262c3209c172bf0ab2455a1cc4f8a14a1583
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-04-15 20:54:43 +0100
Start 5.4.1 development
commit 0901a0a6c90e24621e35ac35e5cd88fa20c2a205
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-04-14 13:58:28 +0100
Set the right environment variable to run tests with a temporary version of ~/.cache
commit 65f032693ee065ea6353fe8d18b77d84ccde61ab
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-04-07 16:06:29 +0100
Gnome keyring code reintroduced at old location by a merge resolution, removed.
commit 0a31a457851ca7c88d106e4379bcf5b96561e92f
Merge: 4dc67bf5 412a7a98
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-04-06 19:47:21 +0100
Merge branch 'account-atomicity'
Conflicts:
src/mcd-account.c
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
commit 4dc67bf5422609dc6c054e5373a083a4f311feb4
Author: Tomeu Vizoso <tomeu@sugarlabs.org>
Date: 2010-03-26 11:12:40 +0100
Fix error propagation in CreateAccount
Fixes fdo#27021
commit 9ce5ed091566fac76159f22bd0bb09d8be297dfd
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-24 18:02:01 +0000
Move the plugin loader init in the master to its _init function
commit dfef1220b713bbbfdda4ae1d0e8c973afd1ed880
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-24 17:56:18 +0000
Make another belt-and-braces plugin loader initialisation call.
commit acdadc00a8919115ceb63b2cd0c786b0fbabc00d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-24 17:10:55 +0000
Make sure the plugin loader has been initialised in libmissioncontrol-server.
commit 4161863e9f376790c850ef67d27b4afcb9abe69b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-24 17:10:22 +0000
Make _mcd_plugin_loader_init idempotent.
commit b1d43671069402ccca45e388a2d1d57c9c29b027
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-24 15:36:07 +0000
Incomplete accounts resulted in account manager load locks never being released.
This meant that the account manager's dbus name was never claimed, as it
sat around forever waiting for the account's manager to become ready,
(or fail) but this could never happen as the incomplete account didn't
have a manager at all.
commit cebd5b7cce4011f8ea231162b6c10cdbee338905
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-15 16:11:22 +0000
Don't poke the keyring plugin into the list if it is disabled.
(cherry picked from commit 3767b4a3df5a736857fec2b7852f71e695bafc75)
commit aa441c4150ac472d264a6142d3265ebe55c46c20
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-18 20:35:56 +0000
Consider NULL self to _mcd_plugin_request_dup_denial to be an error.
(cherry picked from commit f74dc67f0dd7547c8d60127ac4c823de1865592b)
commit 23e1c6ceec44bd0002db04a7624d0ca0dc57d00d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-23 17:21:17 +0000
Explain why we don't invoke the plugin_api shim ahen there are no plugins.
(cherry picked from commit e6caebf7c4332145f99a0f70f73596c0c61fa754)
commit 679e396a9e30a32abea5d87ace227591d6021047
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-03-16 11:52:28 +0000
Avoid unsetting uninitialized GValues
The 'cleanup' block calls g_value_unset(&protocol); if we 'goto
cleanup;' before initializing it, we'll critical.
(cherry picked from commit e2bf8cb962db707e146db611a09000e1fe5e349d)
commit f87936da0484f2b2c20c70884cd44b2cfdcbab1b
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-15 13:55:41 +0000
Don't save the manager and protocol keys, they're magic immutables.
(cherry picked from commit 1cb84576b8d0ac20282d8062c6359858321186c6)
commit c3665f28230481e8827dcb329e13840fa1766589
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-15 13:37:54 +0000
Correctly handle global settings vs service settings, in a uniform manner.
(cherry picked from commit 1aca87caf2e83dcaccd0007046f66299fa10a7df)
commit b9c9b0f3bc9795466f20f1fc63d7d1d873b4bec5
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-13 18:40:05 +0000
Some settings were found in the global rather than the service section. Cope.
It's not clear that they should be in the global section, the tests
seem to put them into the service section, but as we don't have a
working a-ui at this end, look in both places when fetching, service
section first, falling balc to global.
(cherry picked from commit 3f0c6915c660171d9dd1b38988e5ce90adc8ee06)
commit 449db2c78d4a79e8f30ca7e76300a651d2f5e3ae
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-13 16:34:58 +0000
_provider_get_service isn't working reliably: hardwire the service for now
We know we only need to support 1 service for now, google-talk - hard wire
it as the account to select for now, as we need this for the demo, we can
figure out what's wrong witrh it later when we're not hard up against a
deadline.
(cherry picked from commit edccb1b9846f504d0b621543512b8877acbe868f)
commit 9f0dca248a3212dcb825bdbb013d5064449a88a5
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-13 14:45:21 +0000
MC param-account, param-password map to AG bare settings username, password.
These were mapped to the parameters/ namespace in AG, but that's not
where the maemo UI code seems to put them.
(cherry picked from commit 805544ba366ab4067de645f415010fff7b6560e6)
commit bd537555a2f1d41af7604c5fa3a7b5aec70f2273
Merge: 08296270 5e218138
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-03-17 11:32:48 -0700
Merge branch 'dispatch-early'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 5e21813877d46912424a7abff5e21a023ce860ca
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-03-17 11:23:31 -0700
Expect Connect from mc instead of StatusChanged from SimulatedConnection.
commit 082962702c1db6e08038920916b0c612b65c2d4c
Merge: 148c7209 d09690f0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-03-15 14:00:00 +0000
Merge remote branch 'tomeu/MC_LOGFILE'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 148c7209a55cd196f063e6d43f23fcbfc85ae4f6
Merge: 31e4e228 27a15d80
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-03-15 13:59:49 +0000
Merge remote branch 'tomeu/bug-27038'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 31e4e22855aa5d0bddc8268b23ec426d9be1cd61
Merge: 5e8f91cc f028fbed
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-03-13 12:45:30 +0000
Merge branch 'account-storage-plugins'
Conflicts:
src/mcd-account-manager.c
commit f028fbed67bb92088a10b2474839f3b9e426bf5b
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-13 11:47:11 +0000
Removed stray debug message.
commit e92541b13d1093b36377b3b03858aa0e5848607c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-03-13 11:24:40 +0000
Don't re-create objects for accounts we already have
It seems that accounts from the accounts-glib loader pop up twice, once
from the GKeyFile and once from the 'created' signal. Until we figure
out why it's happening, let's add a cheesy hack that prevents the
instance from the GKeyFile being created.
Also add extra debugging to add_account() so we can see when accounts
are added and where they've come from.
commit 50ace3c347dfb1692d684f266a4248463208d534
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-13 03:13:09 +0000
Flush new async-created accounts to the SSO store to save new+derived settings.
commit f77ddc8d02ca3a867a6127da8377edc1c20850d8
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-03-12 22:12:01 +0000
Uncork storage plugins after reading from GKeyFile
commit ad08f3b4468a5d05f3e0451d10947affa7ee856b
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-03-12 21:33:26 +0000
Add a FIXME for plugin_account_manager_set_dbus_daemon()
commit a606766773c3945240628d3a508b3423022a8cf7
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-03-12 21:29:10 +0000
Uncork account stores when master calls _setup()
This ensures that the McdMaster actually exists before we start creating
accounts all over the place, and prevents a loop where instantiating an
McdAccountManager instantiates an McdAccount which instantiates an
McdMaster which instantiates an McdAccountManager...
commit e260cc94562a992b20196efc3347f06ed2456ce6
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-03-12 21:23:06 +0000
Correctly retrieve CM and protocol from libaccounts
You need to initialize GValues before you hand them to
ag_account_get_value(). Also, 'c' was unused.
commit f7b7aa8e477abe03c1340c2b200ddcf9c9792c2c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-03-12 21:03:22 +0000
AM: initialize D-Bus property interfaces in _init()
It turns out that it is unsafe to do this at any later point, due to a
series of surprising facts:
• mcd_dbus_init_interfaces_instances (obj) is implemented in terms of
g_type_get_qdata (G_OBJECT_TYPE (obj), ...).
• osso-mission-control subclasses McdAccountManager.
• This code:
GType s, t; // s is a subtype of t;
g_type_set_qdata (t, FOO, BAR);
gpointer data = g_type_get_qdata (s, FOO);
sets data to NULL because g_type_get_qdata() does not consider
superclasses.
• Remarkably, calling mcd_dbus_init_interfaces_instances() from the
_init() function works because the code that runs each instance_init()
function in the hierarchy in turn sets the object under construction's
GTypeClass to be the particular type whose init() is running, rather
than the final type of the object!
This was a fun debugging session.
commit 20bcefab890201dce263d21833dfbfeacc88c8b4
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-12 19:31:36 +0000
Put a fake create signal on the queue when new accounts are found during init.
commit 632889e639e44f76745dc96eac5f70782e825f61
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-12 15:24:39 +0000
Log + hook up signals for _all_ plugins, pseudo and real.
commit f1b4a26c5cc8b31c0b208b4629f1eed0b76ebea9
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-12 13:52:51 +0000
Move some setup to _constructed so that properties are available to the code.
commit 6558c7a0f902ef0539e96f0eaf3eea4c3c66a0bb
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-12 13:41:42 +0000
The dbus daemon isn't available at the point we need to construct the shim.
Make the dbus-daemon a non-construct-only property, and provide a convenience
method for setting it.
Re-order the class_init so glib/gobject actually accepts the property.
Implement property getter and setter for same reason.
commit 27a15d80e090d4b84ff67d95c9bf283de7b97888
Author: Tomeu Vizoso <tomeu@sugarlabs.org>
Date: 2010-03-12 10:13:55 +0100
Don't try to propagate a denial if there are no plugins installed.
Fixes fdo#27038
commit 236b156892b3b31f2331b62489150485045d8468
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 19:28:07 +0000
Forward declaration of prototype to keep the compiler happy.
commit 15924b732c89cbb5bd5c5965b40e139e33349136
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 19:27:45 +0000
Only iterate over parameters, they're the only oones we want.
commit a8dd436c66b42ab8c78c915da2a343887df10d10
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 19:27:12 +0000
More type errors.
commit 3fe0325fe95272bb73b0b4508aac3f8d08df30cd
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 19:26:44 +0000
Type error.
commit 532291a3d299dd970b8774fbc045567c75af048c
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 19:26:18 +0000
Type, 3 param function called w 2 params.
commit 5be4467bcd28189cc4d8ef76269956f356fdc8fe
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 19:25:50 +0000
Stash the McpAccountManager for use in signal handlers when _ready is called.
Tweak the calling of signal handlers for delayed signals + handler data free
operation to be correct (wrong type errors, param reordering typo)
commit 4b8b72c968b8928386189a5709debb8d1b04d580
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 19:22:33 +0000
Typo.
commit 8b6c50917d4c7b8294bec21402537a99a4b5ae7c
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 17:53:36 +0000
Initialise the list of libaccounts services.
commit 32edda37b998906ed33dbbccc829bb9cef591157
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 17:45:56 +0000
Accounts not created via libaccounts are not claimed by the sso plugin anymore.
commit 359ca41ed4cc362d589f76aae4e5b1e404cbecb5
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 17:32:29 +0000
Doc typo fixes.
commit 5b7e023a99002962eca9420b86ebbcd3adc29cbc
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 17:32:17 +0000
Delay account creation signals until ready, use the new unique-name interface.
commit 79054f1e316edc61394281af7401829214d6d8a9
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 17:30:22 +0000
Drop the old copy of the unique-name code and use it via the shim interface.
commit 2cc024fafe82f61264d829c289d8d8326721335d
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 17:29:08 +0000
Copy the unique-name logic into the plugin shim interface and expose it there.
commit 660edddc2530e797b7d92cf512a162ac2e0610d6
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 17:27:04 +0000
Define interface to allow plugins to get the unique account name via the shim.
commit b221338fbbd712e4105a38e5a7407d02898b525b
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-11 17:24:40 +0000
Define interface to allow plugins to be told that aync account ops are now valid
In other words, we're done with basic startup and listing of accounts that
we had seen before, new accounts can now be created, and async notifications
from the plugin backend may now be transmitted onwards by the standard
signals defined in the interface.
commit d09690f086ee4ba4edf4cbd6aa34fa088681d2e8
Author: Tomeu Vizoso <tomeu@sugarlabs.org>
Date: 2010-03-11 16:50:48 +0100
Add support for MC_LOGFILE
commit 5e8f91cc75916c8768a05130b15f062dded11f4c
Merge: 34eabb17 1abaae51
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2010-03-11 15:41:42 +0000
Merge remote branch 'tomeu/bug-27015'
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 1abaae519d56caf2478a7af24e5084d2c2476871
Author: Tomeu Vizoso <tomeu@sugarlabs.org>
Date: 2010-03-11 12:29:50 +0100
Remove misleading reference to GConf
commit 2e6d574ef1faf1f88fa0e9e18a86ca1114ffefd9
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 19:19:41 +0000
Remove generated marshaller file(s) when a clean target is invoked.
commit 901159ab234d78e24c00f98a76ea71363cfc3b42
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 18:26:56 +0000
Dropped noop dispose instance vtable entry.
commit 9ce38fa3d5deead66d5185e95459feda033fe75e
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 18:07:47 +0000
Replace strcmp et al with g_str_equal instead in boolean contexts.
commit c5b2f19a62091752295a3fa36b00d0bc8d8bf06a
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 18:01:36 +0000
g_int_equal was a braino - should have been g_direct_equal
commit 34de0a64fba030a8a11905093137910faaa2ad1f
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 17:46:33 +0000
Style trivia.
commit 0a897ae7e9aedbf8d758b5acedeecacf7b7fa0f6
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 17:41:26 +0000
Move the ref/unref of the user data pointer completely out of write_conf.
commit e71beba432935d3f06c9f2547f06a67bf7302fb0
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 17:12:09 +0000
Drop implementation of noop instance method for set_property.
commit ed51ecb1ccf94ed89cf730358920fdfc77801a81
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 16:53:30 +0000
Free up the keyfiles in the finalisation stage, not the disposal.
commit 8888f7f1f1955f5cdc765dc2990b1cbdcac21928
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 16:35:11 +0000
Makefile dependency/nodist fix.
commit ca9a4fe535cf71a8e0ef3176c0c952c32d73c0b0
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-09 16:20:18 +0000
Use g_cclosure_marshal_VOID__STRING instead of _mcp_marshal_VOID__STRING.
commit 88e1c55d37c7f3b993e7a1c335b3a718e65acd9b
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-08 19:19:49 +0000
Implement and connect up handlers for SSO 3rd party account creation/deletion.
commit 3e995b79683c92b74bbc0084da0e63e2e03e8060
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-08 19:19:10 +0000
Explanatory comment.
commit 09f74c6a547574818a5029f5ac098819e7d9c0b7
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-08 19:18:52 +0000
Callback for mcd_account_delete in the account manager.
commit d363fa0c54eb58aae790f1c3d969b2168c56a115
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-08 19:17:48 +0000
Type typo fix and explanatory comments for plugin account deleted callback.
commit 7e443f93903574f8d0b37721fe60be8041c6c8cf
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-08 19:15:18 +0000
"Enabled" setting is a special case in SSO, handle it as such.
commit dee3cf66397c8d43ab8c0ae2658d7a6ce7653cf0
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-08 19:14:06 +0000
Forward declarations to keep compiler happy when we add the sso callbacks.
commit 29ca669296c8f2afd6858e2452e098c6ea05dd67
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-08 16:02:24 +0000
Remember the ag id -> mc name mapping for use in deletion.
Also forget the name and drop our ref to the ag account object when deleting.
commit 7c6a00ac2ed87e354832f014e9c698ccf88c276b
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-08 15:00:20 +0000
Remove old debug code.
commit 283961d700fbc95ecc6cba314d2b62325feba356
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-05 19:18:16 +0000
Make the libaccounts-support conditional on the current config.
commit 19e889489b6047cb743f79f660ea9057e6823aed
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-05 19:17:38 +0000
Make libaccounts support optional via configure, update Makefile.am accordingly.
commit 56bb654c974b42f936e79eaabb7730937a44f258
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-05 19:16:42 +0000
hash-include fixes
commit 03dbe99b13454ab2c41200f2a49294e800c30bee
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-05 19:15:15 +0000
libaccounts-glib pseudo-plugin for accounts storage.
commit e75bd719fbb50cbaf955f01c5ba325fa2126479e
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-05 14:48:02 +0000
Dependency to make sure the mcp marshaller(s) are generated in time.
commit 9b84e17c141fbfe96c7ace4885307ae42ca07964
Author: Vivek Dasmohapatra <vivek@noise.cbg.collabora.co.uk>
Date: 2010-03-05 14:47:29 +0000
debug message emitted when signals we don't process (yet) are received.
commit b5cdf7cf5e502bd9c57991a91a9185acadec2764
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-03 03:52:44 +0000
Handle setting deletion in McdPluginAccountManager.
commit 25bc3a8fe7d2d6635a4f71d0ae6cc83a4bb6186a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-03 03:51:44 +0000
refs/unrefs of the McdPluginAccountManager instance were unbalanced.
commit 1049d59b4c87928a0726424b718ea979c1b7e6c8
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-02 18:44:34 +0000
Set the loaded flag after a successful keyring read.
commit 985c5076811073159e8a4f5d9beaa09d7b73b583
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-02 18:44:13 +0000
Style trivia.
commit 494aa78683273a89761ff65584a6f9962415ddf4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-02 18:38:48 +0000
Style trivia.
commit 257b1761ff7e1275347695f4d2c9ed68a6f6d40d
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 21:08:30 +0000
Style trivia.
commit 785429022cacc75ba5750fd2631fff4dc32cd40b
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 21:07:26 +0000
Use g_get_user_cache_dir to locate the target for the account dicersion plugin.
commit b5b9d676b96294987a2c82a81201ed4d9080f6cd
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 20:53:15 +0000
Rename plugin prio #defines and provide _NORMAL and _READONLY constants.
commit 1c3500945ad2549a96743d51cc5e8d17eaf875ba
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 20:52:23 +0000
Allow low priority (readonly) account storage plugins to be sorted correctly.
commit ac9da0ef2e6508849d3d293c4540e355aa903ff3
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 20:29:08 +0000
Remove old debug instrumentation.
commit df78e0e4f8a7305fbc950bddd194fbff87f390d0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 20:27:48 +0000
Change transplanted code from existing style to preferred style.
commit 543e9080b214c04b72b7d5e4733b19b711be1e4e
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 20:25:04 +0000
Use same #defined noop code as elsewhere.
commit 97b805d6e5d5cb909d165fb99d39a4c9dc7ac256
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 20:24:35 +0000
Style trivia.
commit bf3c12f3d79774225582207fe66cbf8bc7502ca1
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 20:24:07 +0000
Style trivia.
commit 3496d2bf29688b3e2d5d88abe33e7b0491fdef19
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 20:13:26 +0000
Plugin priority is signed.
commit 4e2ce3fd358c29e201fe29b88454ff7180106712
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 19:45:18 +0000
Unnecessary include removed.
commit 06a57ed5d2f149949dd8de470b09287041ef03b0
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 19:11:46 +0000
Minor style issues (variable renaming) and explanatory comments.
commit 53cbba20640f28ae9275f8b29725d6916cc68a85
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 18:48:27 +0000
Rename account storage plugin comparison function.
commit 91e6af087af9e57aa4d3424e2cb48a956ba137c4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 18:43:46 +0000
Document the McpAccountManager interface.
commit 54fb5116e33f5c3e6ba472e5348884eef50d8249
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 18:43:31 +0000
Document the McpAccountStorage interface.
commit 70cbc38802864e4859ebc64f4d7f516c5a2bdc06
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 17:17:16 +0000
Don't include glib subheaders, only the main glib header.
Note: This was existing code transplanted from elsewhere. There are lots
of other subheader includes in the codebase but I have not addressed those
cases here.
commit c45a55d151decc332294adfd443c72ae4acb3170
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-03-01 17:12:22 +0000
Don't rely on mcd-debug in the plugin interface implementation.
commit fbcd0cb4df51529f039d884fabcef4f4d1ac7163
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-26 19:26:27 +0000
Keep one long lived McdPluginAccountManager around and use its keyfile etc.
commit 5558750baac59696fd9045a4b5280362d392b4f4
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-26 19:25:31 +0000
Make the McdPluginAccountManager the owner of the keyfile and secrets GKeyFiles.
commit d095c537198a619ce26eeb0b0622cabce208aedd
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-26 18:34:27 +0000
Class rename McdPluginAccount -> McdPluginAccountManager
commit e02509b21e7757ba188dc652aea3c44b1f264441
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-26 18:26:57 +0000
Class/Interface rename - McpAccount[Iface] -> McpAccountManager[Iface]
commit c67c292dbc22b90d64b9acee221cd8811cc79478
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-26 18:02:16 +0000
Typo: dead variable no longer used.
commit 950c800befd43fcb2745d29908b3a5d16bf675db
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-26 18:02:00 +0000
Use the plugin marshallers instead of sharing the core marshallers.
commit 7103b41e9a578aa3ce14b3c9d25497706d594d02
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-26 18:01:32 +0000
Generate signal marshallers for plugins separately from the core marshallers.
commit 2b009c68dc8d7b60b335d17369c9259c0ae7b38a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 19:13:33 +0000
Add a dependency and rule for the marshallers header from the src/ directory.
commit 3fb1b91b97128411ca7a2df1849d16327398023a
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 19:12:52 +0000
Load and use the account storage plugins, with two pseudo-plugins by default.
The pseudo-plugins are the keyfile plugin (an oject that implements the
relevant plugin interface, even though it isn't loaded as a plugin) and
the gnome keyring plugin (ditto) which are loaded at advertised priorities.
When no other plugins are loaded, the keyring plugin should transparently
steal all secret parameters from accounts in the mcd-account-manager,
provided that the keyring daemon is accessible.
commit b855e67b2b250fb745f38b5e27dff9fb259aae11
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 19:07:37 +0000
Include the new account shim interface header in the main plugins header.
commit 42a6831e4d47a343dca858c573e2013da0e1ddcb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 18:55:51 +0000
Implement the gnome keyring and gkeyfile storage plugins
These two plugins will always be loaded at known (and exposed) priorities,
this allows plugins that want to steal secrets (eg passwords) to slot
themselves in at a higher priority than the keyring plugin, and those
that should not receive passwords to slot themselves in between the
keyring and keyfile plugins.
commit e061231b0c83ca4537a6c174485cd1cb5bb96dc5
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 18:45:35 +0000
New marshallers for account storage plugins.
commit d3e7cb461a22b24e64d58c725015fad997fd44cb
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 18:44:35 +0000
Header defining the interface for the account storage shim interface.
commit 52c82684e6e1a55e095d0886701bcd4054e87369
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 18:43:46 +0000
Define +implement interface by which account plugins can get/set parameters
The shim interface, and the object implementing it, that get passed to
account storage plugins to allow them to get/set parameters and to check
to see whether they are secret (or flag them as secret).
commit 6431ea7b698c43e9fa28864398000cea1e93e09c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 18:41:05 +0000
Update the account storage plugin interface to the new API
The previous implementation was granular at the account level, new API allows
plugins to grab individual account.key pairs, which means we can relocate
the gnome-keyring support to the account storage layer instead of having it
sit above in the mcd-account object.
commit 95b79aff8de71b22502df6c9fec7910945302a49
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 18:37:45 +0000
Expose whether a parmater is secret (for use by account storage plugins).
commit 6ead3d4396347ec3ae0682809a70ac9daf276ca7
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-25 18:37:04 +0000
Remove keyring support from mcd-account (will be moved to a plugin shortly)
commit a43f6684c21099210debcdcc736ca2aac1efad74
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-14 23:53:06 +0000
Initialise the storage in the class initialiser, not the instance.
commit aaaa63b99f64774a2f00a4c0ceb65220242bbb89
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-10 19:04:02 +0000
Sample implementation of account storage plugin, for use in tests later.
commit 5b49274b33c6a46b06c8ad1422f8fce3e850bf9f
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-10 19:03:29 +0000
New plugin class for account storage.
commit 2fa79a09af19abc64d1d63ae12a76a097c43d93c
Author: Vivek Dasmohapatra <vivek@collabora.co.uk>
Date: 2010-02-10 19:02:30 +0000
Load plugins before any other components are initialised.
commit 34eabb1752fbe705a73339eb0d959f140a63d9cf
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date: 2010-03-01 13:58:58 +0000
Only time out channel requests after many hours
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit 24f58efd43b10ad51757be5b2168d49045d0faa2
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-02-26 08:39:19 -0800
Changed indentation.
commit f05e39e125ebecb04e868c87c237bff3f5e49644
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-02-26 08:38:54 -0800
Remove redundant assertion in test script.
commit ece1f5b90e9cf6ff33327f4911532b89bbcbdaea
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-02-25 14:30:17 -0800
Request unrequested channels when connection is ready.
Fixes dispatcher/connect-for-request.py.
commit 348a68e677c34cc8221e994f7b4a0e8f504229cb
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-02-25 14:05:34 -0800
Move _mcd_dispatcher_add_connection to mcd_connection_done_task_before_connect
from mcd_connection_early_get_interfaces_cb. This guarantees the caps iface has
been retrieved for UpdateCapabilities.
commit a0ae71ebf164b59ba4761d4edf4bb9d738343448
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-02-24 17:45:19 -0800
Regression test adjustments for new connection/dispatcher order.
* mctest.py: Reorder expected GetAll method on requests iface in harness.
* account-manager/reconnect.py:
* account-manager/recover-from-disconnect.py:
* account-manager/request-online.py:
* account-manager/update-parameters.py:
* dispatcher/recover-from-disconnect.py: Expect GetAll on request iface
before connected.
* capabilities/contact-caps.py: Remove UpdateCapabilities expectation after
connection.
commit 1ffce339da1e367104ef6c697c3eb7540dd3e14f
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-02-24 16:30:39 -0800
Added regression test for pre-connected channel dispatching.
commit b47991610a4a9947f262b33e7cc94c923a44897c
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: 2010-02-24 14:38:02 +0000
mc-tool: don't crash on invalid account names
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
commit bee3d1e1c7be2058bfa4eeab9b52477975d577d5
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-02-17 11:59:34 -0800
Move _mcd_dispatcher_add_connection to an earlier stage.
https://bugs.freedesktop.org/show_bug.cgi?id=26583
commit e4d54ce9b9e51291f8c281aa39b28bdf38fb7822
Author: Eitan Isaacson <eitan@monotonous.org>
Date: 2010-02-16 17:34:46 -0800
Use telepathy debug interface
Fixes: fd.o#26597
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 0d7f1f23dd54fb0cd19e93cfe90aa8b82c9d5396
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-02-18 15:59:57 +0000
mc-wait-for-name: link to GLib properly
See Debian bug #556488 for more info.
Fixes: fd.o#25122
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 3601f10e676b424c113b4f7ea061d405e93fc4c2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-15 17:31:20 +0000
mcd-debug: hook up plugins' debug level
commit eef58e645111a18372e69af067cb113ce4e0bc42
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-15 17:30:59 +0000
mission-control-plugins: add debug support
commit a59e1b8e992ae77d45e77ba1221498220a8a7dc5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-15 17:08:53 +0000
Only load plugins that match mcp-*.so (or mcp-*.dll, etc. as appropriate)
commit 782ffa5a6337ff48b81aaf779d510305b6e7f8bd
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-12-15 17:07:43 +0000
Add most of the plugin loader to the mission-control-plugins library
commit 1671391d4984ae5387f1e042a07b01c001bd58e6
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 22:56:10 +0000
dispatcher/create-rejected-by-mini-plugin.py: new test for McpRequestPolicy
commit d87dd4d5913410edc9537e623f3ef223284950dc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 22:55:07 +0000
McdAccount: lazily create a McdPluginRequest and pass it to all McpRequestPolicy objects
commit 969199a78c867cefc5ed33fae740f67bab9531d7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 22:54:32 +0000
McdPluginRequest: add an implementation of McpRequest
commit 684616798642c8c50db326e9c09bfa9bf2d5a94b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 22:53:52 +0000
McdChannel: return from Proceed before possibly signalling Failed
commit 2b11293d9d1e9a5e54a8b8124744c3de007b3d8f
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 16:30:12 +0000
mission-control-plugins: add API for noticing and/or denying requests
commit be415f0f05fe4c7fdee8a78a50f760d2ac36bd79
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 21:02:02 +0000
dispatcher/dispatch-rejected-by-mini-plugin.py: regression test for immediate and deferred rejection by plugins
commit f86a0c4d613dd5ce587d88a27d569b5af35e378a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 12:50:43 +0000
McdDispatchOperation: don't run Approvers early if a plugin has already decided to terminate the channels after observers finish
commit 3fe828a9518f7ede54350052cf2ae53c431609c3
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 12:26:40 +0000
dispatcher/dispatch-delayed-by-mini-plugin.py: regression test for mini plugin API
commit 5290fb2e24d050d89a137fe8b39d3c14f3c80c71
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 20:50:19 +0000
Port the "delayed acceptance" plugin from the old API to the new
commit 6d98902e0e46e95330ed4a5a3630345ff300fccf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 12:26:10 +0000
McdDispatchOperation: have a McdPluginDispatchOperation and use it to call mcp_dispatch_operation_policy_check()
commit e81fab05393db2b89ee37f4bd3559c0fad6f53b0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 20:46:53 +0000
Link MC against libmission-control-plugins.la and implement McpDispatchOperation
commit 4e6d97a4eaad3029d402afa8ea9271870d62f56d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 20:44:34 +0000
Add a simple loader for plugins using mission-control-plugins
commit 58c340fb4c6610690dc996e08c02b5e1943d56a0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 19:44:00 +0000
Rename --enable-plugins (etc.) to --enable-mcd-plugins (etc.)
commit 4935d23ca73f36efa0940c7de2f22311b9fedad2
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 19:42:28 +0000
Add an interface for plugins to implement in order to filter dispatch operations
commit c2b9b191c9e456a4bc4585e4052f9aa3046593dc
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 19:40:25 +0000
Remove mission-control-plugins/dummy.c
commit 0d89a4eac0929241e1a5641476c7447e0b323af7
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 19:39:28 +0000
Add an object to represent dispatch operations for plugins
commit e35c90c145db61e7975ea92c2a30dcdfd53cc8cf
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-03 16:35:18 +0000
Add a skeletal library to contain a minimal plugin API
commit eb5665a6a0104188342b4faa7c566066f3185704
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-02 17:11:28 +0000
_mcd_dispatch_operation_check_client_locks: run Approvers from here, not from _mcd_dispatch_operation_run_clients
When plugins become able to delay dispatching, we want to delay running
Approvers until all plugins have stopped delaying.
commit cd76b68053aacb23e952e5ef48242589a8b7759d
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-10-29 18:05:39 +0000
McdDispatchOperation: add API for plugins to delay dispatching
commit 55d72be29151eeb716f48ca28c770c0c18fc45e0
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-10-29 18:04:35 +0000
McdDispatchOperation: add easy API for various dispatch operation attributes
Plugins will need these.
commit 914b45b46a14e298bb9db75034351570ba74749b
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-10-29 17:47:49 +0000
McdDispatchOperation: add API to close, destroy, leave, forget channels
commit 5867ae9ba1a7e2a0292d9e84a96487f64d542b86
Author: Jonny Lamb <jonny.lamb@collabora.co.uk>
Date: 2010-01-22 13:57:49 +0000
mc-server: give NULL to the new default log handler now that tp-glib has been fixed
fd.o#23843 was fixed in telepathy-glib 0.7.37. MC already depends on
0.7.37, so this is just a matter of replacing the user_data workaround
smcv added with the correct value of NULL.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
commit 412a7a9858bccff14ec8b7c068fea52f0e7152ac
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 19:42:42 +0000
McdAccount: update TpConnection in _mcd_account_set_connection_status
When we receive a new TpConnection, that function is called when it's
ready, which is more useful than having a connection that isn't ready.
commit fdbeb7cf8d8aee7b45f2577f5e49b6fb6ee39924
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 18:20:08 +0000
Correct a slightly misleading debug message
commit 97abf3047e383872e1c7fdfab12937303a1dfe1a
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 18:19:18 +0000
McdAccount: keep a reference to the TpConnection ourselves
commit 6b25231989685a616b3584bde513ce2e63d70794
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 17:06:59 +0000
McdConnection: pass TpConnection to McdAccount in the same signal as the connection status change
commit 0df9c9f7a7992ba75542800b161d295822585b88
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 17:03:26 +0000
McdAccount: guarantee to emit ConnectionStatus and ConnectionStatusReason in the same signal
Previously, we relied on the 10ms delay hack to get them to be in the
same signal, but this way seems better.
This requires a small expectation change in
account-manager/auto-connect.py: previously we were relying on the 10ms
delay hack delaying the emission of
{ ConnectionStatusChanged => CONNECTING } until after Connect() was
called, which doesn't really seem right in any case (conceptually, we're
trying to connect even before we call RequestConnection).
Similarly, avatar-persist and avatar-refresh encode the same faulty
assumption. Since that code is adequately tested in auto-connect.py,
and isn't really the point of the avatar tests, I've just removed the
faulty expectation from them.
commit bed5596778b31ce7ec733943718c12a6d8de1e35
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 15:33:10 +0000
McdAccount: emit_property_changed: don't emit empty signals
commit 31f25cadb091b490630d60068c453a8ce336d77c
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 15:30:10 +0000
McdAccount: preallocate priv->changed_properties in init
In practice, we'll basically always change a property, so there's no point
in delaying this.
commit a0bdfadc35c1f6571a8c01b02a50c72b17489274
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 15:26:01 +0000
McdAccount: remove support for emitting property changes instantly
There's no point in this being configurable.
commit 880110051b779be8435ef99124ef6e97dca8da27
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date: 2009-11-20 16:37:34 +0000
mcd_account_changed_property: ref account while waiting for a deferred AccountPropertiesChanged
Otherwise there's a possible use-after-free (someone changes a property
then deletes the account within 10ms).
Generated by dwww version 1.15 on Wed Jun 26 11:18:55 CEST 2024.