commit 02d03c57cb5f061e374fe375c9b82f3c826cb538 Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 18:57:58 +0300 Update NEWS for 0.2.2 release commit bbcf090b9cb4ca97cbf8875e06e8166fc5322a5c Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 18:19:16 +0300 Meson: Omit twisted_tests arg (make the script read it from file) Meson pass the argument without quotes and the script accept only $1. Just omit the argument to make script read the tests list from file. commit 5b97f9d348c400630a61f8fe47f188f63e5a9b2a Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 18:10:22 +0300 Adjust tests/twisted/tools/exec-with-log.sh to optionally omit libtool commit d47f2fbe9d027ddd6dd45d3bfc8ded06395ba951 Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 18:09:47 +0300 Make .in script files executable (for the sake of Meson) commit ad485b602adb5b07058c27919d6230afc6e9a9a4 Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 16:01:42 +0300 Tests: Omit messages/invalid-utf8.py for now commit 008cd4810ae8857f6527a1fc0923c8d06b21e68e Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 15:37:04 +0300 Port tests to Python 3 commit 07f5b8e2be0d1f1e7838e8ed68c34b7e0e8b8863 Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 15:17:48 +0300 Meson: Fix the build for 0.2 branch commit 3a1ce69b1a316f9547ff2e49a65cf8f501df279b Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 15:06:59 +0300 Meson: Use Python 3 commit a4b0667200ecb4ad5e9bc0cc579f04e35d68aeef Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 15:04:31 +0300 NEWS: Fix 0.2.1 release notes commit 0b32d6601442edc7220819a32b8cd8054cb7d825 Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 15:03:44 +0300 Prepare 0.2.2 release commit b0f139ff63c4d5f9471423422f298443ae222f9a Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 01:20:32 +0300 Prepare 0.2.1 commit 108e30c59bf2c7f96611129c67d060f232ddbaf4 Author: Jan Tojnar <jtojnar@gmail.com> Date: 2018-11-18 16:12:13 +0100 build: Add meson build system commit 71ea7e98a1e68c5a51b0a36e662a95d07a04a3d7 Author: Daniel Landau <daniel@landau.fi> Date: 2016-11-09 21:27:11 +0200 Handle modechars properly Never strip out modechars unless we are explicitly trying to parse a nickname with modechars, i.e., atom 'C' commit c1ae3d2bdc7801cdf60adb6a5cdb6390a0749014 Author: Daniel Landau <daniel@landau.fi> Date: 2016-11-09 00:09:17 +0200 Channel names can start with a '!' According to RFC2811 (https://tools.ietf.org/html/rfc2811#section-3.2) channel names can start with a bang. Without this check the initial bang gets stripped out and Telepathy tries to ensure as a channel without the prefix. That obviously fails, leading to the messages from that channel arriving as "private" messages. commit 07d021e5e1c11e9ecda0907038bb7a6fa7f18c58 Author: David Heidelberg <david@ixit.cz> Date: 2019-10-27 17:25:35 +0100 fix compilation on GCC 9.x, add #pragma Fixes: In function 'strncpy', inlined from 'idle_server_connection_send_async' at idle-server-connection.c:593:2: /usr/include/bits/string_fortified.h:106:10: error: '__builtin_strncpy' specified bound 512 equals destination size [-Werror=stringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Signed-off-by: David Heidelberg <david@ixit.cz> commit c9b6a16206dd25c37ea3fc43f2b8870bfe410e52 Author: Alexander Akulich <akulichalexander@gmail.com> Date: 2020-11-01 01:33:47 +0300 tools/make-release-mail: Update from telepathy-glib (fix for python 3) commit 6967ca8e1f8d8f7948a430fea0bf159e126042be Author: Michael Catanzaro <mcatanzaro@gnome.org> Date: 2020-09-24 07:03:10 -0500 Properly handle long IRC messages IRC messages are delimited by CRLF. When the string passed to idle_parser_receive() doesn't end in \r or \n, the remaining parts get stashed away to be used to form a message on the next call to idle_parser_receive(). But telepathy-idle improperly assumes that the next call to idle_parser_receive() will definitely contain \r or \n, i.e. it assumes that an IRC message cannot be split between three calls to idle_parser_receive(). That assumption is wrong. Fixes polari#147 commit 3f04a0d60fdc653bffd6919cb374a8d496771a8e Author: Michael Catanzaro <mcatanzaro@gnome.org> Date: 2020-09-23 17:25:10 -0500 Fix build with python3 Hello from 2020! Fixes taken from Bastien's Fedora patches. Thanks Bastien! commit 5e5b677173ef64055b4a7073cb5a15066fc03f70 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2014-02-14 12:12:54 +0100 idle-connection: make sure to always reset force_disconnect_id Recent GLib raises a critical when trying to remove an invalid source. (cherry picked from commit 12211654baa75db13a05b5c2b3293d1378fcf7a2) commit acf5fcf4d830ae0b5953d8ded8eba4c17726c6f3 Author: Diane Trout <diane@ghic.org> Date: 2017-11-06 21:46:00 -0800 Returning FALSE from the timer function causes the timeout to be destroyed I asked one of the polari devs and was told that yes it is ok to set the timer id to zero in the timer function. With this patch make check works without changing any of the expected test results and without any coredumps commit 0ce3a8fa2bd3f4e72358bb53ecd0acf8fe448483 Author: Diane Trout <diane@ghic.org> Date: 2017-11-04 23:32:32 -0700 Avoid errors from Python caused by the deliberatly invalid Unicode Because stream.nick is Unicode when sendMessage combines the command, nick, and invalid utf8 python 2.7 ends up converting everything to Unicode. Since this test deliberately includes invalid Unicode, Python notices and throws an exception. In Python 3, network traffic is usually encoded as bytes. So I thought coercing the nick to bytes would be appropriate, and as bytes can contain anything including invalid Unicode, Python doesn't throw an exception. commit 5a2510ddea8f165f0808a8841e1dca311c003e20 Author: Diane Trout <diane@ghic.org> Date: 2017-11-04 23:03:26 -0700 Update self-signed certificate to 2048 bytes with SHA-256 signature Valid for 10 years commit bf6d596e40e5b9426a68dcd22aa62a697457c4f7 Author: Florian Müllner <fmuellner@gnome.org> Date: 2016-02-13 10:08:42 +0100 ctcp: Don't bling the non-bling When stripping color codes, we currently remove any sequence of digits following ^C. As color codes use at most two digits, this means that we also remove any numbers at the start of the colored text - make sure we stop doing that and only remove digits that are actually part of a color code. https://bugs.freedesktop.org/show_bug.cgi?id=94189 commit dc7568986824c07cd841d002ef7f15f65a16846a Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-10-03 14:14:44 +0200 set nano version commit 22371837e080c41343600ca773fd987e5310baf2 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-10-03 11:28:25 +0200 0.2.0 commit 297c9a8ce746f57b22f807ce0478b3fe3d44a49d Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-18 14:13:04 +0200 run-test.sh.in: actually export SSL env variables Fix tests when distchecking. commit 54092d3d917c8fa0a16df07765615090cf0f583f Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-18 14:02:42 +0200 prepare 0.1.17 commit 0e672516fb1c9e932685f17780e733bd63ead903 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-13 12:09:34 +0200 use TP_SEAL_ENABLE https://bugs.freedesktop.org/show_bug.cgi?id=69311 commit d23eabc7369420f401650266b110bb8017e0e09d Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-12 16:25:31 +0200 Use TP_DISABLE_SINGLE_INCLUDE https://bugs.freedesktop.org/show_bug.cgi?id=69311 commit 2b01622f523b7874afa6fb7bbda440d8e05e0e85 Author: Colin Walters <walters@verbum.org> Date: 2013-09-12 23:09:57 -0400 autogen: Honor NOCONFIGURE=1 See http://people.gnome.org/~walters/docs/build-api.txt commit 173ccaa6b90842c62a5ddb3e98cc0392faced69d Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-12 11:40:40 +0200 bump tp-glib min version deprecations to 0.22 We build just fine with it and want to catch new deprecations ASAP. https://bugs.freedesktop.org/show_bug.cgi?id=64122 commit ef7c5194fea6c978e00bcc3637bbdcd4f518aa9b Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-12 11:40:40 +0200 bump tp-glib min version deprecations to 0.20 https://bugs.freedesktop.org/show_bug.cgi?id=64122 commit 1dce8563421364a557749237cc8d5a674199f528 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-12 11:39:44 +0200 connection: use a hash table to store aliases tp_handle_{set,get}_qdata has been deprecated. https://bugs.freedesktop.org/show_bug.cgi?id=64122 commit 510153c716a3b859f4b16671215f0dcf30856f65 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-12 10:54:00 +0200 .gitignore: update with new test files https://bugs.freedesktop.org/show_bug.cgi?id=69258 commit 2613f5c4ad4965845b28b44e974f4527c8736efa Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-12 10:49:10 +0200 Run regression tests under the run-test.sh "driver" As well as making the tests pass under Automake 1.13, this lays the groundwork for OSTree-style "installed tests" later. https://bugs.freedesktop.org/show_bug.cgi?id=69258 commit 5c012a0ca8e8692efbc664e242e414950b38c4fd Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-12 10:33:15 +0200 Import run-test.sh.in from Gabble master https://bugs.freedesktop.org/show_bug.cgi?id=69258 commit 0bf592b27d88758c88ee81cf9d3f94fbbb1da6c8 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2013-09-12 10:22:06 +0200 .gitignore: automake 1.13 copies in /test-driver Gabble commit 2a54c7cd0, where it was reviewed by Xavier. https://bugs.freedesktop.org/show_bug.cgi?id=69258 commit 983603a6db3b01e4a7d117ee35d20b60c0c896a4 Author: Lionel Landwerlin <llandwerlin@gmail.com> Date: 2013-08-29 23:48:36 +0100 ServerConnection: dispose internal objects Bug: https://bugs.freedesktop.org/show_bug.cgi?id=64923 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> commit 42fd234c2336718a93993829c4d55c819b172012 Author: Lionel Landwerlin <llandwerlin@gmail.com> Date: 2013-08-29 23:48:10 +0100 ServerConnection: kill async read when disconnecting GSocket creates GSources to provide GInputStream and GOutputStream objects. Interestingly, it doesn't set the GIOCondition on the GSource to handle G_IO_NVAL (ie. your file descriptor is not valid anymore). It means that if your trying to read asynchronously from the socket while someone else closes the socket, you end with an GInputStream that can never complete its asynchronous read operation because the file descriptor isn't valid anymore but that isn't a condition to dispatch the GSource and end the asynchronous read with an error. Alternatively, this wakes up the gmainloop all the time => 100% cpu consumption. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=64923 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> commit 231b12a7d127f07fc83b1c4486ddba9c65a16f66 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-05-01 17:08:14 +0100 Require a vaguely modern telepathy-glib and GLib We need telepathy-glib 0.20 for telepathy-glib-dbus.h; in Debian I added a patch to fall back to the old headers, but on master we shouldn't bother. telepathy-glib 0.20 needs GLib 2.32, so we might as well require that too. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=64121 Reviewed-by: Will Thompson <will.thompson@collabora.co.uk> commit edb66cf55a57476f549c49830d0add36cb9e02cb Author: Xavier Claessens <xavier.claessens@collabora.co.uk> Date: 2013-06-10 17:38:25 +0200 Add handle-name to RoomList properties Fixes fdo#65614 commit 68f8a01b0d03ddac1cca102283c79fac907fa388 Author: Sjoerd Simons <sjoerd@luon.net> Date: 2013-05-12 11:52:49 +0200 Don't crash when a channel with multiple requests fails The iteration over the channel requests tokens accidentally used the wrong variable, causing the same request token to be passed into tp-glib all the time causing crashes.. commit cc3e137f084147cd39d4621db5b1de88b3e0b82a Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-05-01 17:01:37 +0100 nano version commit 25571e384d054707e5cdfd08ec65672194bcb9a6 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-05-01 15:47:23 +0100 Release 0.1.16 commit 7d43b91b99535b309298592e945ecc28c567e53e Merge: 1ab28c1 92da2de Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-05-01 15:46:49 +0100 Merge branch 'interactive-tls' commit 92da2de2a91348121d85dad99d85e3657a9bf719 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-05-01 14:18:46 +0100 Warn on use of post-2.30 GLib APIs again commit 49920f93164ff3831e64ccfd30d7ecef2c417a99 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-05-01 14:18:13 +0100 Use slightly more concise g_param_spec_object() arguments I haven't fixed all instances, just the one touched by the interactive TLS code. commit b38c0072563c95d9252a7fbde9322b3e928d286a Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-05-01 14:17:13 +0100 Split property/value pairs one-per-line in interactive TLS checking code While we're touching these lines anyway, they might as well be in a slightly more Telepathic style. commit ae30e944677a28573bde3bc1940e329637b003f5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-05-01 12:03:20 +0100 ServerConnection: use GSimpleAsyncResult for connect thread GTask doesn't make the code any smaller, and this way even new Debian stable can have it. commit 18155960b9034f6adfafe67b6c0560ad3ef40252 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-30 19:08:15 +0100 ServerConnection: ensure socket connection is not leaked If we cancel the connect_async cancellable between the call to g_task_return_pointer (which schedules an idle to call the callback) and Connection calling connect_finish(), the socket_connection would previously have leaked. commit adc09f4516414218f9753dfd1c59b1571fd05b6e Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-30 19:06:24 +0100 ServerConnection: don't leak GTask used to connect commit c4d686364337fd8a03ec388c133fce8428bb1a57 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-30 19:04:38 +0100 Connection: fix default for 'charset' property. commit 8858a5712d529453b18e7e1bc24faea98595f468 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-30 17:35:37 +0100 Add tp-glib suppressions file Without this, IDLE_TEST_VALGRIND doesn't work. commit b80deba63f3fafb46cfaa65a661f9929b5c1063b Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-30 16:59:22 +0100 Connection: cancel connect_async when Disconnect() is called commit fd4661d6e05b80536b48fa23566dc3db1f01d7ce Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-30 15:21:13 +0100 Connection: fix a crash on Disconnect() during TLS verification Previously, priv->conn was NULL until the TCP session was established, so _iface_shut_down() would take the "no connection yet; call _finish_shutdown_idle_func in an idle" path. But the TLS channel would get closed (because the TLSManager listens for state changes to Disconnected and closes all channels), causing the ServerConnection to call the connect_async() callback and emit ::disconnected, and hence finish shutting down the connection there. Then the idle would crash, because it doesn't take a ref to the connection. We should really cancel the connect_async() call in the new path in _iface_shut_down() to cope with the case where we're still waiting for the TCP connection to be established for some other reason. That, and a test for that, will follow. commit 97dcd4e6a110c426cfd620dd03fc368e75bb5924 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-30 14:35:11 +0100 Add (failing?) tests commit 1ab28c1c339644304333203196c4d95a92a4e08c Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-04-30 11:31:13 +0100 Reference CVE-2007-6746 in the NEWS for 0.1.15 commit 43f86291262aeb29d81532bd6d11d91d152e5f36 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-29 18:09:31 +0100 Hide IdleServerConnectionState commit 8e4889f1d154b0a483c583e1eedba09f5ca8a2bb Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-29 17:38:12 +0100 Connection: use a boolean for ServerConnection status commit b657b0cd206821cfe9a2c72086fa9240457e2165 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-29 17:34:12 +0100 ServerConnection: replace ::status-changed with ::disconnected It was already weird that the reason was only used in the disconnected case. commit 8e36adc8c429be5f5337fbaba17f4c79b82b9584 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-29 17:05:10 +0100 Start pinging & running message queue after 001 (welcome) Previously, keepalives and unloading messages started as soon as the TCP session is established: before even the PASS/NICK/USER messages have been sent! (IdleServerConnection emits ::status-changed(CONNECTED) before connect_async() finishes.) If a message had got into the queue already, this would break the connection process. commit af34b5de9f32289a73af3e90d68f776d7166f7dd Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-29 16:56:46 +0100 TLSManager: treat unhandled channels as rejected. This was incorrectly adapted from the Gabble code. commit 8be8aa0d8d9b76173de796e6e32ce8eb9d5605fa Author: Sjoerd Simons <sjoerd@luon.net> Date: 2013-04-28 20:55:16 +0200 Don't special-case tls handling in tests Don't let the TLS tests accept errors that wouldn't be accepted when idle runs normally, instead implement minimal ServerTLSConnection in the test which need it and add a minimal test for rejecting certificates. commit adb98f54dfe035c8a58726bdfe706f07c0ae0169 Author: Sjoerd Simons <sjoerd@luon.net> Date: 2013-04-28 20:21:12 +0200 Add support for interactive TLS certificate checking With the pieces now in place, hook up the TLS channnel manager and pass it to the server connection so it can request interactive certificate checking. commit da178c9dbd46c0c067e9d44355687080939678a1 Author: Sjoerd Simons <sjoerd@luon.net> Date: 2013-04-28 15:30:10 +0200 Connect to the server in the non-main thread To do interactive certificate verification with GTls one needs to block in the accept-certificate signal handler, which practically means the connection needs to be done in a seperate check. As a first step, instead using _connect_to_host_async in the main thread use a GTask to synchronously connect in a different thread instead. commit e1291f040d13f205d4bb3c03bca28fef7312ff5e Author: Sjoerd Simons <sjoerd@luon.net> Date: 2013-04-28 19:01:02 +0200 Port to TLS handling code to work in Idle Instead of server-tls-manager being a Wocky TLS manager add async API to start the certificate verification on request and use a GTlsCertificate to get the needed certificate information instead of WockyTLSsession. commit c5d839c2b07eb0e18a1081e06d7055af20014723 Author: Sjoerd Simons <sjoerd@luon.net> Date: 2013-04-28 16:38:58 +0200 Copy TLS channel code from gabble Take the TLS channel handling code from Gabble and s/gabble/idle in the various files, but no other changes commit 37f1b377a786a3122e14e48ce469a40ff658d4ec Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-04-24 17:08:43 +0100 Nano version commit 0e60ce6055608eef143cc47446cdca71bc0f4ccc Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-04-24 15:47:54 +0100 Update telepathy.am from telepathy-gabble to allow out-of-tree distcheck commit 99ee3f66b268cbdf49f7d4624dbe46bed09ba10f Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-04-24 15:45:33 +0100 Prepare version 0.1.15 commit eee0207464d160a0c8b7e430d927beb4d14cde74 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-04-22 18:47:39 +0100 IdleServerConnection: check certificates properly, except in the tests Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63810 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> commit 3e0498048df554bfaa30c42aef1220f2b7135ed3 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-04-22 18:18:30 +0100 messages/invalid-utf8.py: amend test-case to work under GLib 2.36 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> commit b0dc6e3fb9754354b4b29476217c77277d16dd23 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-04-22 15:06:41 +0100 Include config.h in each source file Among other effects, this makes GLIB_VERSION_MIN_REQUIRED effective. Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> commit 5f4d51b512841eaab67f5a2909b726eaf898bdce Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2013-04-22 18:19:14 +0100 with-session-bus.sh: update from telepathy-glib Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63119 commit e76b366aee11a71435f664394d08a1790c82d91d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-22 16:48:41 +0100 HACKING: update a bit. commit 55f8288fe6ae9a158a3a1e4b64ecc9beea3e6534 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2013-04-22 16:44:00 +0100 Drop unused build dependency on OpenSSL Since some time ago, Idle has used GIO's TLS stuff; we should have dropped this back then. Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> commit 9d4854585d1c2eac8a20af3b07952d43cc92cdb5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-16 09:10:03 +0000 Nano-version bump commit 7dd47960410f1ff9370fd933ab04cdb71ee561c2 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-16 09:07:36 +0000 0.1.14 commit 85cea8b53afe6bee15e2a34cafa2f3715cffbd80 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-16 09:00:40 +0000 tests: disable pings by default We don't want to risk some test timing out because it doesn't answer PONGs, and having PINGs cluttering the debug log is not my cup of tea. commit 452284ab9ed546a430cad13aeae4126cfcb616a2 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-16 08:50:43 +0000 Parse PONG more leniently commit 3e3dd269f63f808049b4c7df5c7f1e50b7daedf2 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-14 19:29:55 +0000 nano bump commit 1d00bd95ce88c0c1d28eb1e5561547c2cecd30dc Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-14 19:18:56 +0000 Version 0.1.13 commit b4d42dcab0307f50c3aa488527dd11895604c01e Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-14 17:24:14 +0000 muc-channel: remove content-free/wrong docstrings commit 4fb86fc1be9bdea989fed9a21c5796a1eccba504 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-14 17:03:08 +0000 muc: check that messages are marked as rescued commit 39ee2f08cf4e2d46aae86307f6dfa023fe347248 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-14 16:43:46 +0000 muc-channel: implement Destroy(), make Close() respawn This fixes the issue where empathy-chat crashing means you get kicked out of all your channels. It's technically backwards-incompatible but empathy-chat has been using RemoveMembers() to leave rooms for ages, and it's a pretty destructive and annoying bug, so let's just get on with it. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=24614 commit f51c7b9cd378a561a9926d0860c26b7581dd4dc0 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-14 17:10:24 +0000 idletest: handle PART with no message argument commit 903885187ef029ef6a954f2dd338d5348ef5e307 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-09 15:22:53 +0000 muc-channel: implement get_interfaces vfunc I don't think this new API is a net improvement over making TpBaseChannel do the work of merging ->interfaces (which would involve zero code changes in CMs, and none of this stupid boilerplate for building a list of strings in every CM) but there we go. commit 5c34b7d2f170ff5f9ee9bf3821ececf55608d0df Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-09 14:18:18 +0000 im-channel: chain up in get_interfaces() impl This is a no-op right now, but it's the right thing to do. commit 8a3a8ba64195afd03c291282233d3b28abfd85d2 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-09 14:15:10 +0000 im-manager: use tp_base_channel_is_destroyed() This is equivalent but neater. commit 2a81f262441270e8f5b2bd85c5f783dff03d3547 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-05 19:52:58 +0000 Some more NEWS. commit 27c1ffc5ebcfcb37ad958ef451ca2772bdc4ec01 Merge: ba22cc0 c679fe4 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-02 11:56:29 +0000 Merge branch 'ping' Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=56589 commit c679fe4baaec1c29f7d0fbbed1f6b1d9c7d1266c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-11-02 11:55:53 +0000 Clarify ping timeout comparison Jonny wanted this to be clearer on <https://bugs.freedesktop.org/show_bug.cgi?id=56589#c1>. commit ba22cc02a652a2ccfe6b59b113a87b2fe3761543 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 17:32:56 +0000 connection: cope with send_async() returning synchronously On <https://bugs.freedesktop.org/show_bug.cgi?id=49163>, Alban Browaeys described a situation where idle_server_connection_send_async() would call its callback synchronously, due to a bug in GLib. While I think that bug is fixed, we can be more defensive against this by initializing priv->msg_sending to TRUE before calling idle_server_connection_send_async() rather than after. That way, if the _msg_queue_timeout_ready() callback is called synchronously (due to a bug), Idle won't get stuck thinking it's sending a message. commit f7766957dbb4ea80ac86d65b83f361b8c82aab45 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 16:56:48 +0000 Disable keepalive pings if server doesn't support PING. I don't know which servers don't support PING, but irssi does this, so I figure we may as well do it too. I tested this by making Idle send and check for PNNING, which Freenode doesn't support. It's not obvious how to write a good automated test for this. commit 339c7273dcb604a639ea2b54461b24bd4f252dd6 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 16:30:10 +0000 Fix _force_disconnect to actually forcibly disconnect. Previously, if the network connection had gone away _force_disconnect() would not actually make the connection die any faster, because g_io_stream_close_async() waits for a reply by default. But by pulling the same trick with a cancelled cancellable as is used for ping timeouts, we can fix this. I tested this by: * Connecting to a server (with keepalive-interval=0 to ensure that doesn't interfere). * Pulling out my network cable (breaking the connection) but leaving my wireless connection up. * calling Disconnect() on the connection. Before, the connection would never finish disconnecting; after, the _force_disconnect() timeout actually does something useful and the connection dies properly. commit 67b18831e0ea40dd3f4438426cfb0f703a3fc971 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 16:14:57 +0000 Don't try to ping while we're disconnecting. commit eb437c2f0bbc7061570889a825b131969982cc9a Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 15:52:09 +0000 Connection: disconnect if we get no PONG for our PING Previously we'd just send out a PING into the æther every n seconds, and pay no attention to whether we ever got an answer. So it was perfectly possible for the connection to just sit there until the TCP timeout kicks in, which I think is a matter of hours by default. With this patch, if we haven't heard a PONG 3 keepalive-intervals after sending a PING, Idle throws its toys out of the pram. This has been tested as follows: * Put my laptop on a wired and wireless network simultaneously. * Connect to an IRC server. (The wired network is used.) * Pull the network cable out. Idle is too stupid to realise the link it was using is gone, and because we're still ostensibly online, nothing tells it to disconnect. * Wait keepalive-interval * 4, and watch the connection get disconnected. It works both with a direct connection to Freenode, and with a connection over an SSH tunnel to irssi-proxy. commit 5fc2d07d025fca9a19abd09caa8b7de2ab8911ed Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 14:45:33 +0000 Move comment about message interval to the right place commit 4e0d40f034745f3867def4dfb8290146e95a252c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 14:31:33 +0000 Connection: add priv field to structure commit 2667606678abd63820b321d3d51ebd0efc0c3e24 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 14:20:43 +0000 Make the PONGs sent back by the test more realistic commit 0bbe346a069316f2b4571834791abc6e2ed3e4d7 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 14:12:04 +0000 Parser: spell out prefix vs. non-prefix logic better commit a6e9900f65e250aa1419420708598df23aae0891 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 14:09:51 +0000 Add a stupid test for Idle sending PING commit 39ed6a0d707397fa13ba6d19580d257b7b2df8e2 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 09:00:23 +0000 RoomlistManager: remove redundant check for Handle tp_channel_manager_asv_has_unknown_properties() takes care of excluding extra properties for us. commit 78cd99642e495a0a60c66709d78d9564444779e7 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-30 09:00:01 +0000 Add a debug flag for roomlist code. commit 04b6b070c32e3cd54a9c8c0bb218899fc6208eb4 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-29 12:41:52 +0000 Fix warnings in roomlist code. Whoops. commit 331e6c167d79bc6d98a1b23f2f072a65cfe10a14 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-29 12:39:01 +0000 NEWS for UTF-8 fix and room listing. commit 23602180bd3363a7fb8fd0c7b636b8a90bf77d6c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-29 12:00:18 +0000 idle_roomlist_manager_get_type: fix prototype commit 35047ec5017492132307e184173890d3e416fbae Merge: 79425a0 7b7f61a Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-29 11:57:38 +0000 Merge branch 'room-list' commit 79425a010af79070a6b93c25deb5690cc72daf87 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2010-10-10 00:26:53 +0100 Sanitize incoming messages to remove UTF-8 non-characters. https://bugs.freedesktop.org/show_bug.cgi?id=30741 commit 3dc023fd1a745504ed9035ebba9501bf916f7a9d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-10-28 14:23:05 +0000 Give charset conversion function a more natural type commit dc7677013cf62c8b8e88b24d01cdb53f039b0b69 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-08-28 12:14:17 +0100 NEWS: updated Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit b092172e56393fad70e472afa26df4f886dfdbc0 Author: Dan Winship <danw@gnome.org> Date: 2012-08-24 12:19:45 -0400 build: fix for "make -j" safety A make rule with multiple (non-pattern) targets just says that each of those files can be built by the rule, not that the rule builds all of them at once. So under "make -j", extensions/Makefile would run three copies of glib-ginterface-gen.py at once, which could end up deleting each others' files and causing a make failure. Fix. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit d940d1a912f92d9c486464c3c6ae737fcac70be3 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-08-03 08:29:36 +0100 Bump nano-version commit 81cffc1bd9d0e1e8778a392e23dd4f100e09a761 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-08-02 14:05:41 +0100 Tell Automake about _gen/svc-gtk-doc.h When the codegen was updated, this started being built, but not cleaned up, so distcheck was broken. commit 79d504189a5d8828a9155af016724f0e5aab38ce Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-08-02 14:02:42 +0100 Version 0.1.12 commit 55922907eda82efcbb2b7782c87248290e16d392 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-08-02 13:51:53 +0100 NEWS for 0.1.12 commit 2c5a91e26f4dd098465f0b32013bc0b3d0edeceb Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-07-19 12:13:41 +0100 IMManager: replace constructor with constructed. commit 10696387956845ad0ad764c9de99b909e5dae586 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-07-18 14:23:16 +0100 Reindent idle-im-channel.c commit 2d61fce82d6aeb711ad49adaa0a9ed6fdd6567e5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-07-18 14:20:03 +0100 Make IdleIMChannel use TpBaseChannel https://bugs.freedesktop.org/show_bug.cgi?id=31725 commit 1ce34440c58a9b82cb15711d95e35a8acb512ecd Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-07-18 14:12:07 +0100 servicetest: squash dbus-python deprecation warning commit bf7da882f6f5489e45afa8055616184d6ddaaac4 Author: Thomas Thurman <thomas@thurman.org.uk> Date: 2012-07-09 12:11:12 +0100 Renamed variables to avoid warnings with "-Werror=shadow". idle-parser.c: renamed "link" to "link_". idle-server-connection.c: renamed "socket" to "socket_". https://bugs.freedesktop.org/show_bug.cgi?id=51906 commit 382886e7dacd79b86dc72a38e9ef32d321d8ab95 Merge: f8bec1f f333fe8 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-30 13:08:35 +0100 Merge branch 'catch-up' Conflicts: configure.ac src/idle-muc-channel.c commit f8bec1f34af87c4bc044b022abc69f1176ba1f33 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-16 18:40:59 +0100 room-config: use G_N_ELEMENTS Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit cd6059e686d95fb1d8d9f080abedce6ab95a9c82 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-16 18:37:09 +0100 room-config: simplify password protection validation Yeah okay I might have been calling tp_asv_get_* a little too many times... Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 6ff9e1a08d0a3c24e68cb1b65289eb95e7060359 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-16 18:30:56 +0100 room-config: flicker CanUpdateConfiguration but keep MutableProperties stable I had misunderstood these two properties before, yet again. This is better and easier. I added more tests. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit a66b3c0c7ded54ca407439871d87b7fbd20535e8 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-16 18:08:08 +0100 muc-channel: move RoomConfig stuff into IdleRoomConfig Genius! Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 33f0ab025272f54e613f84c68b09a4c2046b7409 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-16 17:40:02 +0100 muc-channel: validate Password properties to simplify {,un}setting branch This is much better. I should have done this before. I also added some tests to make sure bad args are rejected. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit eb9aa795c7f4047f93f785889955cbf40408c448 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-16 17:08:20 +0100 muc-channel: turn DO_QUICK_BOOLEAN from a macro into a function Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 0ca501e59fcff2279a927535708bf2143169d7fe Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-16 17:01:34 +0100 muc-channel: track op-ness in the channel to mark config properties {,im}mutable I must admit I misunderstood what was going on with this earlier when I removed it. I was just being an idiot. I've brought it back now and it's even tested! Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit ae49f3ee466d8064fe33826233efa68d3e2fbb0a Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-15 14:47:22 +0100 muc-channel: set configuration retrieved when appropriate Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 7456e007f33524239a49f412802aae2d44307849 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-15 14:09:01 +0100 muc-channel: remove the last of the TpProperties code Woo! Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 0ebd6dce95490067aa2af15cd361bacef0d695d6 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-15 14:02:43 +0100 muc-channel: remove last property flags setting Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit b2cffbe9682ee5d9174a13dbe0646026abfb3699 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-15 13:54:52 +0100 muc-channel: start setting RoomConfig properties for mode changes Ignore the indentation; it's all wrong. I hate idle. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit d342dfbab2e8a39f64d9c5d792a4a8fa96eef6cf Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-15 11:17:41 +0100 muc-channel: remove SetProperties implementation Woo, getting closer! Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 65ab1d0ec73dcf83533284ec157b255023edaee1 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-14 21:10:19 +0100 tests: add RoomConfig1 test Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit c718f11c8dc1e8270fb5d101c366df97f074e315 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-14 21:09:39 +0100 muc-channel: add initial RoomConfig1 implementation Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 5430aa1495a9efb0e9b9ad030fc7c66655aac064 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-14 16:00:11 +0100 muc-channel: stop implementing {Get,List}Properties We're porting to RoomConfig now, we don't need this. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 7e1c6dd5060edb917838435193ea1e9601a16a5d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-09 13:29:55 +0100 Implement Channel.I.Room This is really trivial, I'm happy to report. commit 6c79a8d71d16c615b416c7b45b24ed0701e7540d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-09 12:15:40 +0100 MUCManager: use constants for property names commit af091b3540daf716d7cbe080bf903f7c84e3b520 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-09 12:10:06 +0100 MUCManager: simplify foreach_channel commit dbd130225b9aa35b1244efc0ce2ed3c1979a59d7 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-09 12:07:56 +0100 MUCManager: simplify foreach_channel_class commit d8fb9480f7bb452eac31a9b0563d6340be0c226c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-09 12:04:27 +0100 MUCManager: move ChannelType check up There's no reason for us to even look at the rest of the request if it's not a request for a text channel. commit 7c284a169e4441c524432d627c100cee6d7b9923 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-09 11:58:57 +0100 MUCManager: reindent requests code. I think I may have been partly responsible for the abominable formatting before, and I apologise. commit 7f1093771689ffbef577bb245152eb25264ca32e Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-14 21:14:15 +0100 server-connection: fix race when writing to stream when closed Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 84492da380ae2c0453e2c1aae9218e9f7df1909a Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-05-14 21:13:43 +0100 configure: disable newer deprecations and API additions Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit f333fe80d27ded0882b9301ecab957bbe8d79e5e Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 14:35:51 +0100 Fix coding style nits in the tests Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit 2a6ad36e772ec38eb5ad67f2cfa7cf9042fa0b1d Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 14:18:02 +0100 Bring in the compiler/linker warnings from telepathy-glib Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit 263707940384faff5133c322a75ef5036a6362f5 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 14:17:40 +0100 idle_debug_init: don't make a semicolon have side-effects I really don't like that style. gcc didn't warn about it, but IMO it should... Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit 3e6a3e363f6486dc35fb2e1fbf4de04946e60594 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 14:16:54 +0100 Fix some confusing variable-shadowing by just reusing the variables This code is a bit of a mess, and it implements Telepathy 0.x Properties by hand, without even using the (now deprecated!) mixin, but I'm not going to fix that right now. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit c3de9e89b571782e393d0f3b1a8236d34beec9d5 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 14:15:54 +0100 Make some internal functions properly static Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit 33101f04c60d7806b7f77802cc24471ecab9458e Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 14:15:32 +0100 Prototype functions properly: foo() is not a prototype, foo(void) is Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit 05542224e7a75936e13aa066180de0fa7b934f37 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 14:14:17 +0100 Various dull C89-compliance Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit 5b210484408cf7ce82e6cd79e227785cec8eb811 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 13:45:08 +0100 configure.ac: fix some underquoting Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit 9a86956fd150e98bb255a397e0c18a5d9b772ac4 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 13:44:33 +0100 configure.ac: drop redundant AC_SUBSTs and content-free comments Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit 7dd61ce124bed7532ed84112ddda3c3d1387afb9 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-10 13:42:38 +0100 Stop refcounting handles, which have been "immortal" since 0.14 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> commit fdcfc1c8c6764183e3df65f11d0abc463a3a9984 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 20:04:36 +0100 Remove generated marshallers, just use g_cclosure_marshal_generic Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600 commit 752984356467f08c4a61417cc6aafda489251190 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 20:03:06 +0100 Fix codegen to respect changes to the input Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600 commit 32e728c006349fb32f1b470a5c7d44a1f1390d0d Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 20:02:45 +0100 Allow generation of unstable interfaces Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600 commit f8777fb07851b801b75550048d4d95175c887b4d Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 19:59:47 +0100 Update Renaming interface from spec 0.25.2 to satisfy pickier codegen Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600 commit ebacb6f3533ef64a9a18dd597ed299f7584746a0 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 19:56:49 +0100 Update codegen tools from telepathy-glib, requiring GLib 2.30 The updated codegen needs g_cclosure_marshal_generic. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600 commit 418bb2c2958084f5278f9d0c0927c0f81d4d451c Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 19:48:04 +0100 Remove INSTALL from git We have no customizations relative to the one provided by Automake. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600 commit 25480a1a42a227a716ede318deebb506adf9a553 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 19:43:25 +0100 Use TpIntset, not deprecated TpIntSet Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600 commit 48ca05d7fa53b3cf8fd8d85756434c570cc8fd56 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 19:43:08 +0100 Use TP_ERROR, not deprecated TP_ERRORS Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=49600 commit 307faa064970b2830c618d470fe56eec3ac191c6 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2012-05-07 19:37:31 +0100 Set G_MESSAGES_DEBUG during testing The same as Gabble commit cbfa9d06. commit 7b7f61a8dae3f8de7436378ef3ae569a5323fcef Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-04-08 11:01:50 +0100 RoomlistManager: use tp_asv_new() commit 7b95b1c716cb1aea585e4341dfb37592b8b4e433 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-04-08 11:00:28 +0100 Roomlist: modernize private structures. commit 7d8704d1b5a5451f1013039083bd85139d89b6f3 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-04-08 10:54:04 +0100 Roomlist: use Text interface constant commit 9f5d6ceda3e7e01d589ed8e2dd88918707fc444c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-04-08 10:52:23 +0100 Roomlist: use tp_asv_new() commit c50f12f884121dca2081435dea8976de9ac8a8d6 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-04-08 10:49:26 +0100 RoomList: use TpBaseChannel This moves IdleRoomlistChannel over to TpBaseChannel and cleans up the tests a little at the same time. commit dc777537db0f727951d51a09599c108f34b34dcd Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-29 16:34:23 -0600 Fix a bug and add a test for requesting multiple roomlist channels I hadn't really excercised the code for returning an existing roomlist channel if we had already created one. So I added a test for it and in the process discovered a bug, which is also fixed by this patch. (The compiler found this bug when it was introduced while I was rebasing Jonathon's branch, so I fixed it there and then. -Will) commit 5ebe6a7cf1fac6df992cb65ca18cdabf8ece20be Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-29 11:54:24 -0600 Fix the crash on closing the RoomList channel The Act of unreffing the Channel emitted the 'closed' signal, and we were connecting to the closed signal and and unreffing the channel again in the handler. It is necessary to unref the channel in response to the 'closed' signal in order to handle the dbus Close() method, so we store the channel in a temporary variable and then NULL out the priv->channel variable before unreffing so that we don't unref again in the closed handler commit 2e852a3bb80afc785174734cf1c877ffc918df88 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-29 10:41:31 -0600 Initial support for listing IRC channels Added IdleRoomlistManager and IdleRoomlistChannel classes. There is a basic test included as well. Things seem to work ok (e.g. I can display a list of channels in empathy), but it hasn't been extensively tested and I have made some possibly questionable design decisions (e.g. only creating a single RoomlistChannel rather than creating a new one every time one is requested). I don't fully understand the implication of that choice yet, so I need to do some more work to figure out whether that needs to be changed. There seems to be a crash when closing down the channel that also needs to be investigated. commit 2479ef3d6052ec03eb998496cb32f41f54f5799c Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2012-04-03 16:38:03 +0200 use new GLib API checking macros commit 7aba06d98bb844e6af037ee8a8b72bb686725512 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2012-04-03 16:38:27 +0200 config.h has to be the first header included in C files commit 493011ede54f4ff96410118153b76cf8cd8a1001 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-04-03 13:26:20 -0400 muc-channel,parser: fix GLib version check g_value_{get,set}_schar actually appeared in 2.31, so let's check for that instead. Sigh. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit bbe052521053fe370173947b8fec0deb7ce6ef6f Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2012-04-03 10:14:17 -0400 replace calls to g_value_{get,set}_char with _schar versions g_value_{get,set}_char was deprecated and replaced with {get,set}_schar in GLib 2.32. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit e0453c6ea47e1ee1ffe76acf2f0f6e9a94487fcb Merge: 8cba7da 529606d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-04-02 17:40:00 +0100 Merge branch '48084-eats-cpu-on-failed-ssh-forward' commit 529606d547089bd4f6c6e7520fb96af7d1ffe23a Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 13:24:34 +0100 Test server dropping connection after authentication. This has always worked fine, but wasn't tested. commit 461c00a7db16b8473d64dacd2af048b8b3b480b3 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 13:22:27 +0100 Connection: handle ServerConn errors while Connecting Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48084 commit 05fa69e93345351ac193008596b5318afddd9bca Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 13:17:13 +0100 ServerConnection: guard against double-disconnection idle_server_connection_disconnect_full_async() clears priv->io_stream, so calling it twice would previously crash us. commit 232ad6ddef6d4670e78615a83a4db4f554933047 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 12:11:25 +0100 Connection: inline enqueueing messages _add_msg_to_queue() is only called from one place; moving it into _send_with_priority() makes the code marginally smaller and easier to follow. commit ccec1e5c075d2c712dba48b64696cbc6e36f1b3b Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 11:59:27 +0100 Connection: simplify adding queue timeouts So previously there was this special-case in _send_with_priority() which would send out the message immediately rather than enqueueing it if: • it was max priority, or • we're connected, and there's no timeout, and it's been at least timeout seconds since we last sent something. The “max priority doesn't need to wait for the queue” case is dysfunctional: if you call idle_server_connection_send_async() while another call is in flight, then it fails (because g_output_stream_write_async() fails in that case), and so _send_with_max_priority_ready() would just push the message to the top of the queue where it belongs. The “flush immediately” logic is much clearer if added to the code which sets up the timeouts. The “if we're connected” check didn't do anything anyway: _add_msg_to_queue() adds a timeout regardless of whether we're connected (which is good, because it gets used during connection…). commit e605db1cbe3707edf86fc51c4d0f5114c76ae0a3 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 11:49:36 +0100 IdleConnection: remove unused message-batching code This code has been buggy for ages, but it never mattered because it never ran… so let's just remove it. It simplifies the message queue timeout dramatically. commit b0c8cc59b600f117826f3541b86414af2c538229 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 11:46:14 +0100 IdleConnection: don't drop & leak messages on full output buffer In practice this loop is never entered because MSG_QUEUE_UNLOAD_AT_A_TIME is defined to 1. Perhaps we should just remove this loop. commit bbacae0297273ecc9ad556cb9a033fd6e339facc Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 10:46:21 +0100 Connection: delete requeueing logic. If sending a message fails, the connection to the server is hosed and we should give up rather than trying again later. This patch stops us trying again later for the same message, at least… commit 1606e4a28eab2abb140ebddd2f26685e5738c457 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2012-03-30 10:37:54 +0100 ServerConnection: disconnect on end-of-file. commit 8cba7dab98c6e00608b3c5ae3077e2005ab69e18 Author: Danielle Madeley <danielle.madeley@collabora.co.uk> Date: 2011-11-07 22:03:44 +1100 Fix the test broken by the last commit Oh yeah, the tests... commit 9b251d95bf5f0a074226c0948fc59cd4ee4d460d Author: Danielle Madeley <danielle.madeley@collabora.co.uk> Date: 2011-11-07 21:25:46 +1100 Make unknown timestamp a G_MAXINT64 This makes idle compliant with the updated spec. commit a4c98cfc5f89e84628c7ebd4bcaeb431f986917a Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2011-11-01 23:10:00 +0000 Support trailing parameter without a initial : BIP doesn't start the trailing parameter with a : when it's only a single word in various cases. For example when sending the topic. Adjust our parser to accept trailing parameters not starting with : if it's the final word in the string commit 8e80e5fc190d6dc7654f835bdb0467c035a02fa3 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-11-01 13:00:07 +0000 Subject: implement ActorHandle property. Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> commit 9a4964631952846d829fc63d8f4f5299e697908a Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-10-28 18:15:17 +0100 nano version bump commit 872881685ba1b652e8cacee92ae0dbe6c172613f Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-10-28 18:00:57 +0100 Version 0.1.11 commit 634e6b5bc9a5a4cc6ffc29c1fa2869ae9c4f8701 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-10-28 18:07:33 +0100 configure: explicitly depend on gio-2.0 Linkers from the future get upset, with messages like: /usr/bin/ld: ./.libs/libidle-convenience.a(idle-server-connection.o): undefined reference to symbol 'g_io_stream_get_output_stream' /usr/bin/ld: note: 'g_io_stream_get_output_stream' is defined in DSO /usr/lib/libgio-2.0.so.0 so try adding it to the linker command line /usr/lib/libgio-2.0.so.0: could not read symbols: Invalid operation So we need to explicitly depend on it. While we're here: we certainly don't build against glib 2.4. glib 2.28.0 is the version required by the version of telepathy-glib we require. commit f5e2025d90268a0a3c47a1f44b15e38c973652e9 Merge: 0eb472e 17b73fb Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-10-28 17:54:36 +0100 Merge branch 'loyal-subjects' https://bugs.freedesktop.org/show_bug.cgi?id=40734 commit 17b73fb0802b5bd9be9390f6c86c8e69cb755f3c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-10-28 17:52:16 +0100 _network_member_left: indent a declaration Simon noticed <https://bugs.freedesktop.org/show_bug.cgi?id=40734#c2> that I'd forgotten to indent this declaration. commit a7d4abf1f7a45098327a47b39b7ded8505fd82a5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 18:24:34 +0100 MUCChannel: Implement Channel.Interface.Subject This patch pulls the topic-tracking and -setting code out of the Telepathy.Properties implementation, uses it to implement the Subject interface, and stubs out the Telepathy.Properties implementation. Because Subject uses DBus.Properties.PropertiesChanged, which clashes with Telepathy.Properties.PropertiesChanged, we have to remove the GInterface for Telepathy.Properties from the object. The latter is not tested anywhere! So this gives us a commit that compiles, runs and passes all the tests, without having to cut out all the old code which we want to salvage for RoomConfig. commit 5d8fc141966bbaa5be95decd52de70259bb450ed Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-10-12 11:50:56 +0100 Depend on tp-glib 0.15.9 for Subject etc. commit fb76d806bd26aafa0475097494cc33c4d053f3b0 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 17:34:16 +0100 MUCChannel: remove GET_PRIVATE antipattern commit 50af21ee66f25b2434b788df8a1aad1482c2c4cd Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 17:09:39 +0100 MUCChannel: port to TpBaseChannel commit 3de9289de9ddb27477ee78a8cd8653b3e02044cb Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 13:12:46 +0100 MUCChannel: remove obsolete GType defines commit daae39300550e1e4020fb01534c25d5554287025 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 13:01:03 +0100 MUCChannel: remove unused LAST_MODE_FLAG_SHIFT define commit 0eb472e4248690e964ea49ae1b4c73a83d9b44bd Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-29 07:51:51 +0300 idletest: Use handleCommand instead of dataReceived Unlike dataReceived, handleCommand splits the data if it has multiple messages and parses each message. commit 1f25c9c24d37634dcb2ea1ac4f51d6557814f014 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-30 01:06:39 +0300 idletest: The data for an IRC event can be [] too commit 4f43777297880d6deb0509eec2dd8a0ae3d5b88c Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-29 23:06:03 +0300 IdleConnection: Prevent overlapping and duplicate sends If the timeout is low or the underlying network is bad, then successive calls to idle_server_connection_send_async can overlap. ie. a newer operation is started before all the earlier ones have finished. The underlying GOutputStream does not allow this. Therefore, we add a new private member to track whether we are in the middle of sending something or not, and refuse to send anything new in the current timeout interval if that is the case. Similarly, the same message can be submitted more than once if we do not remove from the queue those that have been passed to idle_server_connection_send_async, but has not had their operations finish. In case an error occurs, the messages are restored to the front of the queue for re-submission in the next interval. Fixes: https://bugs.freedesktop.org/37145 commit e58c7fcadaab8af68ecfc911c16d7358649e7952 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-28 00:49:11 +0300 IdleConnection: Remove redundant check idle_connection_add_queue_timeout checks if the timeout is active or not, so no need to check it in the caller. commit 97e7e6f314ae11fbad6d9f2f5a3312fd326cce1a Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-19 01:55:23 +0300 IdleServerConnection: Simplify the dispose method If a connection was successfully made, then the instance will only be disposed if the disconnect method is explicitly called. Otherwise not. Fixes: https://bugs.freedesktop.org/37145 commit b504ed569cf4995fda326215029f6e446ebe4551 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-19 01:38:21 +0300 IdleServerConnection: Cleanup usage of the private GCancellable Fixes: https://bugs.freedesktop.org/37145 commit 051c7f37107650ba9e999c7bf4b956ce3a0fca8b Author: Debarshi Ray <rishi@gnu.org> Date: 2011-08-17 23:15:45 +0300 IdleServerConnection: Async-ify idle_server_connection_disconnect Fixes: https://bugs.freedesktop.org/37145 commit 8c73981434a30adc288480380cd98ade17b8a12b Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-18 22:16:43 +0300 Consolidate tp_base_connection_disconnect_with_dbus_error calls commit e6c53a570d33ad48d8d8b49cc4339092dbf65a8f Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-16 15:45:51 +0300 IdleConnection: Use tp_strdiff and tp_str_empty commit 4879aece088fcf5204e2e72137298735ace8b8e5 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-08-21 15:30:28 +0300 IdleDNSResolver: Not needed anymore Fixes: https://bugs.freedesktop.org/37145 commit eafdad1f3c34cf181df4af944f54653d8c370db4 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-08-17 23:15:45 +0300 IdleServerConnection: Async-ify idle_server_connection_send Fixes: https://bugs.freedesktop.org/37145 commit c4cbc7282aa97965555eec80697ebf2f26a91f71 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-09-10 20:33:50 +0300 IdleConnection: Handle connecting -> disconnected correctly In case an error is encountered while trying to connect, it is reported using tp_base_connection_disconnect_with_dbus_error, which changes the state of the parent TpBaseConnection from TP_CONNECTION_STATUS_CONNECTING to TP_CONNECTION_STATUS_DISCONNECTED. Hence this should not be done again in sconn_status_changed_cb. It is to be noted that when the Disconnect method is called, the parent's status is immediately set to disconnected, and when the underlying network connection finally disconnects and emits "status-changed" we still need to finish shutting down the connection in the callback. This leads to a situation where it may appear that the state is changing from disconnected to disconnected, but it is actually not so. Also, until the underlying network connection is successfully made, priv->conn does not point to a valid IdleServerConnection. Therefore the disconnect method should not be called on the underlying network connection before that. Fixes: https://bugs.freedesktop.org/37145 commit 813c0f00bf70ff5ca6582acf745e4250a529f383 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-08-17 23:15:45 +0300 IdleServerConnection: Async-ify idle_server_connection_connect Fixes: https://bugs.freedesktop.org/37145 commit cc7d61e81bead36adcca5b0be300c17a51b61b64 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-08-13 12:37:40 +0300 IdleServerConnection: Reduce the number of certificate checks The following checks have been disabled: + G_TLS_CERTIFICATE_UNKNOWN_CA + G_TLS_CERTIFICATE_BAD_IDENTITY + G_TLS_CERTIFICATE_EXPIRED The first one allows self-signed certificates, while the other two are needed to satisfy the certificate used in the test suite. Once Channel.Type.ServerTLSConnection is implemented we will see if we can restore these checks. Fixes: https://bugs.freedesktop.org/37145 commit 63e3d9da4046a7c7959c6aa1ea01ed98c00a5b85 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-08-10 15:34:03 +0200 IdleServerConnection: Replace g_signal_emit_by_name with g_signal_emit commit 211cd6aba3a87b3e20d2782c73e5bd5cd54e3359 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-08-10 10:33:44 +0200 Get rid of IdleServerConnectionIface and IdleSSLServerConnection Thanks to GIO IdleServerConnection can now handle both encrypted and unencrypted connections. One can use idle_server_connection_set_tls to choose among the two. Fixes: https://bugs.freedesktop.org/37145 commit 973d2c173af909fa702e63c7d9fbe627512a58f4 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-14 15:41:02 +0300 IdleServerConnection: Replace low level network code with GIO Fixes: https://bugs.freedesktop.org/37145 commit 21b888cdf2bc0ea1e05e521d171480e574182379 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-14 01:56:26 +0300 Use guint16 for port numbers and G_MAXUINT16 instead of 0xffff commit 95dabd4dc53f11bbfb2a89f0ac57c167d88781c3 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-09 09:46:34 +0100 Connection: replace \r and \n with spaces If a message gets as far as _send_with_priority and contains \r or \n, it's almost certainly not what the user anticipated. For instance, before this fix, calling RemoveMembers([self_handle], "bye\r\nJOIN #telepathy") would cause the user to leave the channel with the message "bye", and then accidentally join #telepathy. Rather than trying to strip out \r and \n everywhere, this patch just replaces them with spaces just before sending. https://bugs.freedesktop.org/show_bug.cgi?id=34840 Reviewed-by: Debarshi Ray <rishi@gnu.org> commit 3630e72aa761499ebcf541145e1a683bce61fa93 Merge: f67c104 95d3c8f Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-12 17:32:19 +0100 Merge branch 'testier-better-faster-stronger' Reviewed-by: Debarshi Ray <rishi@gnu.org> commit 95d3c8f88e15f0044060d8f867db340c46939971 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-12 17:30:29 +0100 message-order.py: tidy up commit cea29eb55ece9c94e608c7b46505e12c2ee08fd5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-09 00:02:23 +0100 tests: strip \r\n from stream event data commit 8b44ba9f8d095ea273f4c30cd5a868b22f53c2c3 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 16:13:26 +0100 Add an env var to speed up flushing the queue Idle interprets RFC 2813 very conservatively, and sends at most one message every two seconds, rather than sending an *average* of one message every two seconds. I don't feel like implementing the latter right now, but I'm bored of waiting forever for the test suite to pass. So here's a hack. commit e46d516ff77ca777ed3dee533544f146fa4f2041 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 16:01:42 +0100 Connection: refactor adding queue timeout. Previously, the two-second timeout for sending messages from the queue was set up in two different places, and cleared in more. This is bad for readability: also, it turned out that one place forgot to multiply the number of seconds by a thousand! This commit adds helper functions that do the right thing—including using g_timeout_add_seconds for the sake of your battery. commit 3cbc930cb85b742f6e595336c372e43807d4fd93 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 15:52:27 +0100 tests: print "Core dump exists" in red, like Gabble commit 0a0f05efa5be66ec72ac28d7195b3487e6e9bfcd Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-09-08 12:48:03 +0100 Remove obsolete DBUS_API_SUBJECT_TO_CHANGE commit f67c104b2417ce8221c0e708be119d56b32f5667 Merge: fc9c7c6 95bc73c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-08-03 10:38:44 +0100 Merge branch 'contacts' Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=21168> Reviewed-by: Xavier Claessens <xclaesse@gmail.com> commit 95bc73c6c5dba66d720c3bb5fa8a0c768a06b0d9 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-08-03 10:38:30 +0100 Connection: fix coding style nitpicks commit 18daeb539a5a1adf55fa5c118a82022e4e140255 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-07-20 19:22:21 +0100 Contacts: add stub support for ContactInfo commit 92a8194e918876567b2dc46a4098879e5fe46654 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-07-20 18:56:23 +0100 Contacts: support Aliasing commit 09f8a09a48ff4f15da4977fb45414082503c4a8e Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-07-20 10:58:14 +0100 Add a TpContactsMixin commit ea8181bf64c55fb50946880513008e0b489efe76 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-07-20 18:36:33 +0100 Connection: replace constructor with constructed. commit e463dd2cfab3dd1b012f381785e71fb4549076c2 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-07-20 18:30:56 +0100 Implement GetAliases() This went unimplemented for however long! commit 8f9c4865e4f2743e15fa66ac43e30f6cd3d52822 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-07-20 10:28:13 +0100 Connection: use TP_STRUCT_TYPE_ALIAS_PAIR commit fc9c7c652ec64c46113b3e4d3d95b595dc00757b Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-24 01:06:32 +0530 Remove unused but set variables This is needed to satisfy the new -Wunused-but-set-variable added in GCC 4.6: http://gcc.gnu.org/gcc-4.6/changes.html Fixes: https://bugs.freedesktop.org/37515 commit 4a1ebddd3a69fba828d6e71f4742077cd019b4a4 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-11 22:40:35 +0300 Add the release mail automation script Identical to the one used in Telepathy Gabble, but adds the Git URL. commit b13331b335fb28d1a48b1b4a1cec68dedf91799f Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-11 22:35:48 +0300 Set nano version commit 47d2310e78c3e4bbb440a8b1c572e8f07d85f6aa Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-11 21:44:15 +0300 Prepare 0.1.10 commit 647bf39b88389cf54656d8e03c1c69dec90441d4 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-11 20:29:52 +0300 Put the role played by the target nick in a channel as vCard parameter Fixes: https://bugs.freedesktop.org/34796 commit fc1b8aa331cc84544c5253bcb02729a0a028da17 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-11 21:05:51 +0300 Use idle_muc_channel_is_typechar commit 20f55984143346d4a9939bf4fcc21c0779be4893 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-11 21:00:36 +0300 Add idle_muc_channel_is_typechar as per RFC 2811 commit bbbf55e1c91e6f199b59921a61b3a918e3eabefd Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-11 20:52:45 +0300 contactinfo-request.py: check the x-irc-server and x-host fields Fixes: https://bugs.freedesktop.org/34796 commit c0fc403476a7780bba80181ee849d0fb59422d0c Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-18 18:56:28 +0200 Handle RPL_WHOISSECURE messages in response to RequestContactInfo The RPL_WHOISSECURE message indicates whether the nick against which the WHOIS message was sent is connected securely. This is an extension of RFC 2812 implemented by some IRC daemons. eg., ircd-seven (http://ur1.ca/3khrh), ShadowIRCd (http://ur1.ca/3khsr) and UnrealIRCd (http://ur1.ca/43e4r). Fixes: https://bugs.freedesktop.org/34796 commit cc5e8fa37a958060e3743bc6171c1bf0827fe94e Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-23 13:38:15 +0300 Handle RPL_WHOISOPERATOR messages in response to RequestContactInfo Fixes: https://bugs.freedesktop.org/34796 commit 28c421138d78fd44fb6f1bcc51ca86d4608da79f Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-18 18:56:28 +0200 Handle RPL_WHOISREGNICK messages in response to RequestContactInfo The RPL_WHOISREGNICK message indicates that the nick has identified itself. This is an extension of RFC 2812 implemented by some IRC daemons. eg., IRC-Hispano (http://ur1.ca/43e55) and UnrealIRCd (http://ur1.ca/43e4r). It seems that some daemons also use the same numeric for RPL_USERIP (http://www.alien.net.au/irc/irc2numerics.html) even though I could not find an actual example. However, some of them, like UnrealIRCd, actually use 340 for RPL_USERIP and the message has a format different enough to be detected by our parser. Therefore we should be reasonably safe. Fixes: https://bugs.freedesktop.org/34796 commit 55444640dfa89af4fdbeba97af8626f8c8d2bebb Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-09 22:24:28 +0300 Reduce boilerplate Fixes: https://bugs.freedesktop.org/34796 commit 060fbf3df71c3f8d2a65588bfab091a52739d716 Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2011-05-10 10:09:09 +0100 Fix coding style to use PEP-8 commit 8b68edfb3ab97464b8e24c77411b9139bd02e800 Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2011-05-09 22:42:45 +0100 Add a test for the Action message type commit 17bed0285ed4bce0b86489d2d84e46a46a7c2f10 Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2011-05-09 22:40:36 +0100 Pass the message type to tp_cm_message_new_text Idle didn't pass the type as parsed to the tp_cm_message_new_text function, causing clients to think all messages were of type normal. Fixes #37038 commit 4eaaa90744d3ba985351743f92fe65551670eb69 Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2011-05-09 22:39:17 +0100 Correct order of arguments to assertEquals commit 8b403f8c2497b6afe0c6650693822f7d21ccbfea Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-06 21:57:12 +0300 Try not to mistake RPL_WHOWAS_TIME as RPL_WHOISLOGGEDIN It seems that some daemons also use the same numeric for RPL_WHOWAS_TIME (http://www.alien.net.au/irc/irc2numerics.html) even though I could not find an actual example. Therefore, to be safe, we only consider a message to be RPL_WHOISLOGGEDIN if the trailing part is "is logged in as". Fixes: https://bugs.freedesktop.org/34796 commit 67574b0adbd6fc92e1435c13ec37d645122504c6 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-18 18:56:28 +0200 Handle RPL_WHOISHOST messages in response to RequestContactInfo The RPL_WHOISHOST message indicates the host name and IP address from which the nick is connected to the server. This message is received only if the nick against which the WHOIS message was sent is the one that sent the it. This is an extension of RFC 2812 implemented by some IRC daemons. eg., ircd-seven (http://ur1.ca/3khrh), ShadowIRCd (http://ur1.ca/3khsr) and UnrealIRCd (http://ur1.ca/43e4r). It seems that some daemons also use the same numeric for RPL_BANEXPIRED (http://www.alien.net.au/irc/irc2numerics.html) even though I could not find an actual example. Therefore, to be safe, we only consider a message to be RPL_WHOISHOST if the trailing part has "is connecting from " as a prefix, followed by some non-whitespace characters. However this will adversely affect some versions of IRC-Hispano's daemon (http://ur1.ca/43e55), which uses Spanish text, but we can live with that. Fixes: https://bugs.freedesktop.org/34796 commit 880dbd2aa36cdaf205104722e2f375f6bcbaf838 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-06 02:10:02 +0300 Handle empty RPL_WHOISCHANNELS in response to RequestContactInfo The message format is defined as "IIIc." as specified in RFC 2812. Therefore, even though IRC daemons (eg., Freenode, GIMPNet and IRCNet) do not seem to be sending empty RPL_WHOISCHANNELS we should be able to deal with them. Fixes: https://bugs.freedesktop.org/34796 commit 771b45b483f643008512b49f16adaffa2038cd2e Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-06 02:05:46 +0300 idletest: return an empty RPL_WHOISCHANNELS in response to WHOIS RFC 2812 defines RPL_WHOISCHANNELS as: "<nick> :*( ( "@" / "+" ) <channel> " " )" Therefore, there is the possibility of an empty message even though preliminary testing with some IRC daemons (eg., Freenode, GIMPNet and IRCNet) did not reveal such a scenario. Nevertheless to maintain strict compliance with the RFC we should test for this as well. Fixes: https://bugs.freedesktop.org/34796 commit 8d9d807fcbfb1078e2a54862f790ff20b2993846 Merge: ad7365d 87985ba Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2011-05-04 10:54:07 +0100 Merge branch 'test-fixes' commit 87985ba346064580468b45b3bb272fac7d6c20d1 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2011-05-03 21:28:42 +0100 idletest: hardcode localhost as 127.0.0.1 fd.o#36814 Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit ad7365d495ac26d640a32a13704138594c7808f1 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-03 02:23:40 +0300 Update NEWS commit 42b2d054148c430d235e761046700e23932b5146 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-22 15:06:56 +0300 Test to cover MUC JOIN initiated by the server Proxies and bouncers usually send a JOIN message to the client for each channel the user is a member of. Fixes: https://bugs.freedesktop.org/28918 commit 90c39d9ae136f5d8b08d4af2b7b6c9b30588be0a Author: Debarshi Ray <rishi@gnu.org> Date: 2011-05-03 02:08:26 +0300 Handle PART messages in our test IRC server commit cf76af82ac3c0829f8a812abc37463f6d48fe3f1 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-22 15:14:37 +0300 Strengthen the MUC JOIN test to forbid duplicate NewChannels commit f0a3b60b50074b86c9b5bd42f276b75e2c00f739 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-19 03:39:30 +0300 Do not emit an extra NewChannels while handling a JOIN message Fixes: https://bugs.freedesktop.org/28918 commit d2bba315c344f2ed9e541198956bb8b9a7f11b83 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-25 22:49:45 +0300 Test to cover RequestContactInfo Fixes: https://bugs.freedesktop.org/34796 commit 85437c2893ebaf978e086eb12ab167ddb57833be Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-25 22:47:07 +0300 constants.py: add SERVICE_BUSY commit 9d33c7071f9d0fb016eafe4996fa26395d56641d Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-25 21:50:10 +0300 Handle WHOIS messages in our test IRC server The following numeric replies are supported: + RPL_WHOISUSER + RPL_WHOISCHANNELS + RPL_WHOISSERVER + RPL_WHOISSECURE + RPL_WHOISHOST + RPL_WHOISIDLE + RPL_WHOISLOGGEDIN + RPL_ENDOFWHOIS + RPL_TRYAGAIN + ERR_NOSUCHSERVER Known problems: + RPL_AWAY is not supported. Fixes: https://bugs.freedesktop.org/34796 commit 448cb5959e99843d81b7c3aa4f249f73cca8177c Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-25 16:32:55 +0300 Handle RPL_TRYAGAIN messages in response to RequestContactInfo This message is received when the server drops our WHOIS query without processing it and wants us to try again later. We convey this to the client by returning a ServiceBusy error. Fixes: https://bugs.freedesktop.org/34796 commit fa92f186c7352d00f87b92fdf150094b5db06832 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-04-23 13:38:15 +0300 Handle RPL_WHOISSERVER messages in response to RequestContactInfo Fixes: https://bugs.freedesktop.org/34796 commit defb7f48129979f2541642c089051ae1afffe084 Author: Ionut Biru <ibiru@archlinux.org> Date: 2011-04-28 04:55:39 -0700 use automake python macro instead of checking for each python binary version. https://bugs.freedesktop.org/show_bug.cgi?id=36624 Signed-off-by: Ionut Biru <ibiru@archlinux.org> Reviewed-by: Will Thompson <will.thompson@collabora.co.uk> commit ab915ef39abf132cc3676f7f2c24c1a90e759189 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-30 03:00:30 +0300 Send keep-alive packets A new TpCMParamSpec called "keepalive-interval" was added to configure the gap between successive PING messages. It has the XChat-GNOME default of 30s. Fixes: https://bugs.freedesktop.org/35058 commit 5c3672d0d66eb9f51ef1c86d287d637b5d9f69d9 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-04-11 16:46:42 +0100 NEWS: ContactInfo \o\ /o/ commit f37e22b61a9bb6512fd166a6c3dc3aa57811f5ae Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-18 18:56:28 +0200 Handle RPL_WHOISLOGGEDIN messages in response to RequestContactInfo The RPL_WHOISLOGGEDIN message indicates the account name of the nick against which the WHOIS message was sent. On Freenode, a user's account name and primary nick are one and the same. This is an extension of RFC 2812 implemented by some IRC daemons. eg., ircd-seven (http://ur1.ca/3khrh) and ShadowIRCd (http://ur1.ca/3khsr). Fixes: https://bugs.freedesktop.org/34796 commit 7641b907ca84705f79c25970c0dac38d54995893 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-18 04:02:29 +0200 Handle RPL_WHOISCHANNELS messages in response to RequestContactInfo Fixes: https://bugs.freedesktop.org/34796 commit ffe55c1c890e2199543143740b58479d24ecfca2 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-22 00:31:18 +0200 Handle ERR_NOSUCHSERVER This error can occur when the nick for which a WHOIS message has been sent disconnects before the request is served. Fixes: https://bugs.freedesktop.org/34796 commit fbd0ecbb407305736e03d1f64ee9aaa4fdda1ea5 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-30 00:07:53 +0300 Implement ContactInfo GetContactInfo, RefreshContactInfo and SetContactInfo are not implemented. RequestContactInfo returns the real name, away message and idle time. Known problems: + ERR_NOSUCHSERVER is not handled. + RPL_TRYAGAIN is not handled. Fixes: https://bugs.freedesktop.org/34796 commit 0ccc07bcc71015c263ae5baebcd5f79496f04548 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-04-11 14:52:31 +0200 set nano version commit 1e45d5d9cbbb823a8ccb5c35ec00e8c8e69a15d8 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-04-11 13:24:24 +0200 prepare 0.1.9 commit 65c67e16c0e8f0dfa090ca3a60fb10804613f179 Author: Thomas Klausner <tk@giga.or.at> Date: 2011-03-28 11:56:25 +0100 Modify netinet/in.h fix to also work on FreeBSD. Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit ce33e28e86f32be4849dc13e7b1010674f44e787 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-03-28 11:35:32 +0100 More NEWS commit 1623929d14c697100dee52c902cdb290fb4c90e8 Author: Hasso Tepper <hasso@netbsd.org> Date: 2011-03-27 23:48:07 +0300 Include <netinet/in.h> to fix build failure on DragonFlyBSD Fixes: https://bugs.freedesktop.org/23352 commit dbc99e7d39fe024e60ce91db0b87f3b44c1df370 Author: Thomas Klausner <wiz@danbala.tuwien.ac.at> Date: 2011-03-28 10:56:23 +0100 Check for strnlen, and define it if missing. It doesn't exist on, for instance, NetBSD-5.1. (Patch modified slightly to add a configure check.) Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit 33cfd01e5832c953ac85c19648988f3cf6bf42a0 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-03-25 17:13:13 +0000 NEWS for fd.o#35239 commit 0e4ca4e807e70446cd14fc112cf4566ee1e7df0f Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-25 16:48:44 +0200 Handle ERROR messages A new MessageSpec was added for it. Fixes: https://bugs.freedesktop.org/35239 Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit f246140fac18edc2975f85933d0203a797244ec4 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-03-25 16:17:12 +0000 Test validating the 'username' parameter. commit 418996606b95598d9392f1ec07d7115fac040580 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-22 00:56:29 +0200 Filter out invalid usernames RFC 2812 defines usernames as: user = 1*( %x01-09 / %x0B-0C / %x0E-1F / %x21-3F / %x41-FF ) ; any octet except NUL, CR, LF, " " and "@" http://tools.ietf.org/html/rfc2812#section-2.3.1 Fixes: https://bugs.freedesktop.org/35239 Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit b1ebb9752de738027883b9544471e5119bc911e1 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-25 16:59:34 +0200 Define idle_server_connection_iface_get_state with the correct spelling Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit fc79095aceba1f77f81db45917f7ab1a93ff1459 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-19 19:49:43 +0200 Update the list of mode prefixes and document them RFC 2811 mentions only @ and +. However, IRC daemons have extended it using the PREFIX parameter to use many more prefixes: http://tools.ietf.org/html/draft-brocklesby-irc-isupport-03 Fixes: https://bugs.freedesktop.org/30635 Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit a0973b79e828e48097b3de3b39b480292ba20be3 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-03-17 10:51:31 +0100 message-iface: check content of received messages commit bf1d7bf5a6e0d5227619ad4639e73553b235177f Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-03-17 10:25:48 +0100 Use tp_cm_message_new_text() It makes the code simpler and set the message-sender-id key (fdo #35362). commit 8681199e058f8abb2c0c0a0a2e477d2d7450a3a0 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-03-17 10:25:19 +0100 bump tp-glib dep to 0.13.10 We need it for tp_cm_message_new_text(). commit 5ba26dc936622ff1a70578833c688983b09a6bfb Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-03-10 15:45:00 +0100 idle.manager add password-prompt commit 2fdd7e862694731aab38d0d56ef038c03b38e1c6 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-03-07 14:19:45 +0000 NEWS for PART colon-quoting commit 67fb3cd96e92a1af8a5409ec352f5ba094dbdd20 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-03-07 14:16:22 +0000 NEWS commit ee7a21b65a4005c62678ce3947ae629986130f5e Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-05 22:28:46 +0200 Use the actual user name instead of the nick in USER messages A valid nick may not be a valid user name on some IRC networks. Using the nick in USER messages will then lead to a network error. Fixes: https://bugs.freedesktop.org/33913 Reviewed-by: Olli Salli <olli.salli@collabora.co.uk> Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit b00a48f27869a28e9f2845739d5d2999e2997cfb Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2011-03-04 12:23:21 +0200 Update NEWS commit 72c31a3aee5272dae218a5f8bc39ab46cccd1013 Author: Debarshi Ray <rishi@gnu.org> Date: 2011-03-04 05:03:28 +0200 IRC channels can have ! in their names, so don't truncate them Fixes: https://bugs.freedesktop.org/28371 Reviewed-by: Olli Salli (oggis) <olli.salli@collabora.co.uk> commit 9482584508a138162558fc454d4cae4db674898e Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-03-02 15:31:51 +0100 add Messages properties to immutable properties commit 3b9477db6c403c8403ec2d4acfc6769f091759ee Author: Danielle Madeley <danielle.madeley@collabora.co.uk> Date: 2011-03-02 09:52:07 +1100 message-received is int64 not uint64 commit 67ec3fb7d0ff1e98514b22ecaf65c3f0a828a484 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-02-28 16:13:18 +0000 MUC: colon-quote kick messages. commit b20eb912a6c37c5b2ecb7c2ff248eea1b8494a5d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-02-28 16:06:39 +0000 MUC: specify Group_Flag_Message_Depart Once we're in a room, we can provide a message when we leave it. commit 19ddca961aa90f67f76dbe96170a1965ab2e7b17 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-02-28 16:05:09 +0000 Add a regression test for quoting part messages commit 248444abb4a9af978e0795da2efbe3de7e15208b Author: Chandni Verma <chandniverma2112@gmail.com> Date: 2011-02-28 10:21:37 +0530 Add missing colon before PART message This is required for trailing messages as per RFC 2812 sections 2.3.1 and 3.2.2 Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=34812 commit e521bae419cb485df241b60864edd842dca3b70d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-02-11 14:34:13 +0000 NEWS for Destroyable fix. commit 02afbf76f9c82202aff0c893b1eccf3150ec2a85 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2011-02-11 14:01:10 +0000 ImChannel: include Destroyable in Channel.Interfaces. I implemented Destroyable over a year ago, but forgot to actually include the interface in the Channel.Interfaces property… Here's a fix, and a test. Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=34166> commit c8223feda96ec38ca0d5accabe4a563c20b7a5e1 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-02-11 10:07:46 +0100 set nano flag commit 7dd680d769780889225ae9e8bcb95155f0910844 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2011-02-11 09:57:22 +0100 prepare 0.1.8 commit 6154178f94d0b9533420715250fa166c734e4d0b Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-12-22 11:25:16 +0100 advertise that channels implement the Messages interface commit 80b458ae148f0759a639ad9ea763a9548b8eabf2 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2010-12-15 16:36:00 +0000 connection: don't return just before the end of the function Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 0594bfd744d38efb11693632a1b1b636694671e8 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2010-12-15 16:32:35 +0000 connection: use G_PARAM_STATIC_STRINGS Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 4e8658f14d5dab978cf74799ba9321f1988f86df Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2010-12-15 16:23:45 +0000 connection: pop up a SASL channel if we have no password and password-prompt=true Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 09cec08785fc738688937befb9cc56536c097abc Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2010-12-15 16:23:22 +0000 connection: add a simple password manager to the channel manager array Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 854fc4bd6ae8d3f38de03e7395d97668b20150b8 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2010-12-15 16:19:27 +0000 connection: don't try and send IRC traffic if not actually connected Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 2e343ceb90433bdd9eb3847d4f803bc5d880720f Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2010-12-15 16:18:44 +0000 protocol: add password-prompt connection parameter We can't have *-password as it'll be stored in the keyring by mission control. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit dc8ed3beab9a09b8b9325a721542da4eb5ec29c6 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2010-12-15 16:17:55 +0000 protocol: implement TpBaseProtocolClass->dup_authentication_types Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 9e3dbf41df38147086cbb1e5a2dac73fbb5d4088 Author: Simon McVittie <smcv@debian.org> Date: 2010-12-10 17:08:07 +0000 Update telepathy.am from telepathy-glib commit 3d83a180df44ae86921d639cb5fd1e835b76feab Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2010-12-07 12:54:08 +0000 Start new development version commit 6367d03fa716833b473547e30ca680b95c116e95 Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2010-12-07 11:45:50 +0000 prepare for a release commit 6fb6b413dc05a349801006533e915b8e7ed36d8a Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2010-12-06 12:14:11 +0000 Also check nothing strange happens when we toggle t and o at a the same time commit ed428e83bed7c2632cb88325afe39693880a6656 Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: 2010-12-05 15:51:28 +0000 Handle (the absence of) the +t channel mode If the channel doesn't have +t set non-ops can also set the channel topic. This changes idle to flag the subject as always writable untill +t is set and we're not an op. For extra brownie points a test was added as well :) commit 174a347d0abcdb99b91eb08f8009326f6799bbdb Merge: bed998e 2ec8db5 b17c9c9 Author: Simon McVittie <smcv@debian.org> Date: 2010-12-01 11:35:26 +0000 Merge branches 'trivia' and 'get-bus' Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=31662 commit bed998e6e87461b7001a07e766323f45444f296f Merge: 2815a34 be85e2d Author: Simon McVittie <smcv@debian.org> Date: 2010-12-01 11:28:16 +0000 Merge branch 'protocol' Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=30536 commit b17c9c93c3f0b4cfd25d5999dc742bf8c2ef4b78 Author: Simon McVittie <smcv@debian.org> Date: 2010-11-17 16:58:18 +0000 fd.o #31662: use TpDBusDaemon to avoid tp_get_bus() commit be85e2d586dbe1bccac66e38da744ce23a357fa1 Author: Simon McVittie <smcv@debian.org> Date: 2010-10-04 19:03:42 +0100 Channel managers: implement type_foreach_channel_class This lets the Protocol export this information. commit 980215d5973ae67a87131585375665c74b97a586 Author: Simon McVittie <smcv@debian.org> Date: 2010-10-04 18:57:47 +0100 Test Protocol objects in a basic way commit 84a18ead14f77f44085cde9cd2c23ee1a65448a4 Author: Simon McVittie <smcv@debian.org> Date: 2010-10-04 18:57:39 +0100 Add Protocol objects commit b56152d15e021de1de5644811ad6b50f97a5cc46 Author: Simon McVittie <smcv@debian.org> Date: 2010-11-17 16:54:21 +0000 Update servicetest from Salut commit 2ec8db5ed92c5cb6af836cba1ba40df7e61664df Author: Simon McVittie <smcv@debian.org> Date: 2010-08-06 15:57:33 +0100 Fix compiler warning commit 6d98494d76e6579e0e0adfe95fa049cdaaa25b03 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-09-11 00:12:13 +0100 Replace if-else if chain with a switch block. commit 2815a343525313ceb1a82c3e602e8988d528e07b Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-09-11 00:10:57 +0100 Delete commented-out connecting and disconnected hooks Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> commit 7651613c6852b7bf913676f468664430baedff7e Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-10-13 15:52:20 +0200 actually implement the D-Bus prop iface on text channels commit 1a28c77af13b9acc0cad232ac9d213afe60de79f Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-10-13 15:52:33 +0200 constants.py: sync with Gabble commit b1d3b2fdeed87c54974bff2a2a60f1988f5d800c Merge: d6f3de7 a541f15 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-10-06 15:19:30 +0200 Merge branch 'messages-29378' commit d6f3de7e29cec9c6a0bc4f48a4a749edcc75b17b Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-09-16 15:12:49 +0200 remove messages/split-msg-sent-signal.py As explained on https://bugs.freedesktop.org/show_bug.cgi?id=29378#c2 we shouldn't split messages when sending. commit a541f155a4c4233e4c58af3be50d37845ce3a5d6 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-09-16 14:40:48 +0200 factor out idle_text_received commit f75dc6fe69b2a81bb1ee640bfa5092b992f06be0 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-09-16 14:31:04 +0200 rename label commit 5a70170c153270160f688b8eddaa21268acc2d0f Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-09-16 14:26:51 +0200 use tp_str_empty() commit e47a0fa6d8333c684039d84a2026e3b43bce6474 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-09-16 14:26:19 +0200 bump tp-glib dep to 0.11.1 We need it for tp_str_empty() commit 5e8bc2c76580a4b018baa4455432943dd806b8fe Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-09-16 14:24:46 +0200 no need to check if content_type is NULL, tp_strdiff does it for us commit 3026439222b19dce8d58f069071eec3055889bf3 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-09-16 14:20:18 +0200 use G_N_ELEMENTS instead of NUM_SUPPORTED_MESSAGE_TYPES commit 8cfa0ce2f08324bb6884d7c1ed533e87074c1338 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-08-16 13:41:37 +0200 test Messages iface commit 5d540a05ac2ccd48e3892bf6fb7ab74420256597 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-08-16 13:40:53 +0200 Implement Messages interface (fdo #29378) commit cab03c25bdfc574aea3bbc510022cc5360d7e339 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-08-16 13:40:28 +0200 make_connection! add Requests commit 643d066c6e5333340b98cfec944e8fd473c3d428 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-08-13 14:14:07 +0200 update constants.py from Gabble commit 9000cd3a1219a859ba570fb5553344a154a74870 Author: Mike Ruprecht <mike.ruprecht@collabora.co.uk> Date: 2010-07-25 00:37:30 -0500 Fix debug-blocks assertion where real size didn't match passed size. This patch fixes an issue where g_slice_free was being called on memory that was allocated with IdleDNSResultReal, but was being freed as IdleDNSResult. These two structures are a difference size. With debug-blocks on it asserts this and aborts. commit ee7e0394843f2633fc93937e0c154f161d66601a Author: Simon McVittie <smcv@debian.org> Date: 2010-05-26 10:49:22 +0100 Update with-session-bus.sh from telepathy-glib, fixing a bashism Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=28258 commit 7108457be830d103347220c656d8d9c90bd8ca0d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2010-04-06 19:16:23 +0100 Fix a buffer overrun in channel name validation. I can't find any coherent specification for this type of channel name (which appear to start with ! and contain five upper-case or numeric chars). All the RFCs just reference other RFCs but it seems to be something to do with safe channels. Anyway... let's not blow up if someone actually tries to use one of these with less than five characters after the bang! commit db0047082c65752e10df22abca683358c15d4bfb Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2010-02-19 14:03:02 +0000 Fix spelling mistake. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 861597aa629703929399edb3e4ced0e9a49fa3dd Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-02-19 13:19:10 +0000 start dev of 0.1.7 commit e4adae82d0f6cd8752768e71b1e47861ed3e883d Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-02-19 12:58:40 +0000 prepare 0.1.6 release commit ce17922d0ed5bbc337c79cc6051fcdc7d78fc362 Author: Simon McVittie <http://smcv.pseudorandom.co.uk/> Date: 2009-10-15 20:28:25 +0100 Fix bug report URL for current bugzilla components commit 38cf99fc56425823b11e486effe3f98c1168a905 Author: Simon McVittie <http://smcv.pseudorandom.co.uk/> Date: 2009-10-15 20:24:58 +0100 fd.o#24559: flag password parameter as secret commit 7e720131e95683bf96f4b4db0e262ea19b5d8479 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-02-19 12:11:12 +0000 Implement Debug interface (fdo #26646) commit c52eeda0d4c7a5a99d35fbbf5db49478f6630ad2 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-02-19 11:46:55 +0000 idle_debug: refactor to use g_strdup_vprintf commit a5b64fe0e33eb6e03eaa05eff4946a12445f76eb Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-02-18 17:40:06 +0000 Add ourself to remote-pending while joining the channel (fd.o #25039) commit b0b127e4c84cc2c0824d971f6bfca030fd8454ea Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-02-18 18:06:23 +0000 Bump tp-glib dep to 0.8.0 We are going to use tp_intset_new_containing which has been added to 0.7.26 but there is no harm to dump to 0.8. commit d2d1f1db61c823124a9eff60ba9746414ac47683 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-02-18 14:59:28 +0000 document IDLE_LOGFILE in man page commit 7e923479272d7ae3d7b66994a5958333fc03b4b0 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2010-02-18 14:52:15 +0000 Add IDLE_LOGFILE support (fd.o #26627) commit 20d7ecf47f5a731b6b5e76c17c896c2415945f73 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-10-06 22:46:23 -0500 Fix two valgrind-reported leaks For some reason, we were strduping the channel name needlessly in _channel_normalize_func() Also, we forgot to free the bodies returned from idle_text_encode_and_split() commit 441f063e26ef604926be1e05a073439d758b35fd Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2009-10-06 20:45:43 +0100 idle-connection-manager: remove unused PARAM enum commit e746d0b0ff520dfb3f41519da7c38bbecc14ff32 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: 2009-10-06 20:44:27 +0100 idle.manager: add username param Param was implemented but has been forget in the manager file for some reason. commit 0da5af160fe1aee19eaa9f33f5b196bc521b4652 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2009-09-14 12:56:58 +0100 Bump to 0.1.5.1. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit ee9c0c816f8bdaa8d4927a365116351b6aad2e48 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2009-09-14 12:20:01 +0100 Version 0.1.5. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit b7a13d8705a41a8f72aab447599ff9bc522548c4 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2009-09-14 12:19:23 +0100 Update NEWS. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 20388f1b00cf6e587bdb3a499458fa52cdf8d8e2 Author: Jonny Lamb <jonny.lamb@collabora.co.uk> Date: 2009-09-14 12:19:13 +0100 Update gitignore. Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk> commit 6a224e80aeba67f85dad46cb805f34662d483dc2 Merge: 524d8bc 2dc074a Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-09-10 23:34:31 +0100 Merge branch 'channel-manager' Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit 2dc074a6fe3f59598d1404933b2c5fafb541b04e Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-30 23:43:39 +0100 Implement Destroyable for IM channels commit 524d8bc287b82cb23ceb9ba619fe342fc10627e2 Author: elaine <elaine.xiong@sun.com> Date: 2009-08-29 15:12:08 +0100 Don't explicitly return void in void functions. Sun's C compiler doesn't support this. This is a slightly modified version of the patch on fd.o #22958, removing redundant returns at the end of functions. Signed-off-by: Will Thompson <will.thompson@collabora.co.uk> commit 1fc2c51de60673f5a568824ddd7fc62349e4f09c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 14:22:33 +0100 Test that Connection.GetInterfaces() includes Requests commit ea054aeec99fc43a09a1896f03544b28c40d52e5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 02:49:33 +0100 Implement respawning for 1-1 channels. commit bddeac559400301194e05bb4250eee2c06cf9a54 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 02:27:26 +0100 Implement more mandatory properties for 1-1 channels commit e9ca7f9a74b03be97af6d4efa72889b7f7b88fe5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 02:27:12 +0100 Use constants.py in requests-create.py commit 0f6efafaeb06612660b9f0e018d934a0063dd5ba Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 02:14:02 +0100 Allow parting MUCs with RemoveMembers. Users of TpGroupMixin have to opt into this working for hysterical raisins, but it works fine in Idle once we turn it on. Also hook up the Group interface's D-Bus properties. commit aa167c5c416023ef912c4db288264c2de68d1522 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 02:01:03 +0100 Test Creating and Ensuring MUCs. commit 56bc2adff9f42d2e614e8f3eb8c50a5c54dacff8 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 02:00:40 +0100 Update test constants from Gabble commit 1e41b6e37c84eef7548a272ae62b20acc0be0ff1 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 01:41:31 +0100 Set Initiator and Requested on new MUC channels commit afdcca3d687805bfbcc75f4e09c311d2e2050a5c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 01:13:32 +0100 Add idle_muc_channel_new() commit 46b003f23be2d157f11fc16210013666f34e73e7 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-29 01:01:10 +0100 Add more mandatory properties to MUC channels commit 6d399432f072117d897936bbb38f809175b16423 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-27 10:17:13 +0100 Tests: Fix a typo in room-joining code commit f5aad064b926ba94e195e563f649ecac1b5fca65 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-23 18:34:49 +0100 Don't emit NewChannels twice when joining Before, as soon as you created the channel CreateChannel would return, and NewChannels would be emitted; later, when you finish joining the channel, it'd be emitted again. This patch restores the currently-considered-correct behaviour whereby the new channel is only announced when you've finished joining it (successfully or not). commit 17d265ec76e917e64f1490222afcde1cdb4c75d0 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-23 18:32:36 +0100 Add "is this channel ready?" accessor commit 60adfcd869db4bee93d108fe4c2c345bb5621c4e Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-08-23 18:11:25 +0100 Quiet build. commit bc1ecfdc0ecf1700a9585d97e7d30b26e714af41 Merge: 6ed3fe2 66d5954 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-07-07 15:26:36 +0100 Merge branch 'master' into channel-manager Conflicts: src/idle-muc-manager.c tests/twisted/Makefile.am commit 66d5954213d167425218a9b977d6b55506e62685 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-06-20 18:22:15 +0100 Define _GNU_SOURCE not __USE_GNU to get strnlen(3). __USE_GNU is a glibc-internal macro that we should not be using; this was causing a build failure in openSUSE, which has a glibc from the future. idle-connection.c doesn't actually use strnlen. Based on a patch by Vincent Untz, which didn't compile for me: it seemed like string.h was getting #included before the #define, and thus strnlen wasn't exposed. Making the #define the first thing in idle-parser.c fixed this. Fixes: fd.o#22291 commit 9f23b67b1173278af4059b757e8cea3a80b19d98 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-28 14:15:16 +0100 bump to 0.1.4.1 commit c860b85b77d51e4061682ba26b7d2029d79af897 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-28 13:38:57 +0100 version 0.1.4 commit 4d0b66c6b88fe5d45b57da9b54d5282899eec8d0 Merge: 855eb8e 85ed21c Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-28 00:28:57 +0100 Merge branch 'sent-signal' Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> commit 855eb8ed03bc8220a407366fda9fe2dc03b538eb Merge: d8d2d91 ea5267d Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-28 00:19:27 +0100 Merge commit 'jonner/username-param' Reviewed-by: Will Thompson <will.thompson@collabora.co.uk> commit d8d2d91424f10b8bfb954651aa0538ed777eb8f8 Merge: 6dfcce7 a50ff8a Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-28 00:07:49 +0100 Merge branch 'quit-message' Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> commit 85ed21cc3ca97811ef23a946077228504e7d68c9 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-28 00:04:48 +0100 Correct the error for unsupported message types commit 29c245a7d938d915834770a91854d4cbd212f8cd Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-28 00:02:36 +0100 Document what idle_text_encode_and_split does It's not obvious at a first glance what it's doing, and why. Also, I rewrapped its argument list, in contravention of the style of other Idle source files, because it was ridiculously unwieldy. commit d1b2bec43a1597c5477041a27bc5d4cbfe4f15f2 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-27 23:54:35 +0100 Don't include "PRIVMSG ..." in Sent signals The previous fix was incorrect, as it emitted the same string in Sent that it sends over the wire. commit 6dfcce7fca726afaeca64e4fbe65faa14b436043 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-27 23:15:05 +0100 Fix error prefix so that tests pass commit a3fef5fc1860f8c20e1a8233c620a80495f5fb5e Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-27 23:13:51 +0100 Make nickname validation a for loop. I think this is clearer; it makes the loop's conditions more obvious. commit a522bed9acfef27e9a21e505e7b39b252a0426a1 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-27 23:04:47 +0100 Correct the description of accept-invalid-nicks commit ba698d41b168e98abe67ec1327829b74eb7c1f06 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-05-27 23:04:37 +0100 Don't spam DEBUG for each char in a nick commit b0dd049e675c1a81a71769ffaae7e2d4e19c2d52 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-18 23:55:43 -0600 Bug #17354 - Emits Send immediately, even if the message is queued Contrary to what the bug implies, it was decided that it's OK to emit the 'Sent' signal immediately even if the message is only queued and is not yet actually sent. But there is still a problem in that if the message was long enough to be split into multiple messages, only one 'Sent' signal is emitted instead of one for each separate message. This patch emits a signal for each individual message. commit a50ff8a325473983d1ffe70e3ee9382bf2b8f797 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-03-27 23:38:00 +0000 Remove spurious 'register' flags from idle.manager commit deb8d8f23912550b2b80190e8dad4a76817bf95a Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-03-27 23:36:06 +0000 Remove obnoxious default Quit message. commit ca441ef2e95230775271a92e76433a859dae2bb4 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2009-03-27 23:35:47 +0000 Cope with Connection::quit-message being NULL. commit 5258ef39b7e24faefd733d30b9abcf8453adb2f2 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-24 15:01:58 -0600 Be strict for what nicks we allow, and liberal for what nicks we accept from others Bip has a nasty habit of sending backlog activity from a fictional '-bip' user. Unfortunately, a nick with a leading '-' character is illegal according to the IRC RFCs, but we have to accept it since people appear to be using it in the wild. This patch adds a flag to the nick validation script that specifies whether we should use strict mode or lenient mode. We use strict mode for validating local nicknames, and lenient mode for validating remote nicknames. commit 1b6f1549a8c66356a9ea2d4a7240be98efb38ec7 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-20 15:49:11 -0600 Bug 17430 Connections' object path etc. should contain uniquifying string Add the hex value of the connection's memory address to the end fo the object path as a uniquifier. commit 79673a760ccd017f21c15de12215fe8a569a4e1e Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-18 23:40:24 -0600 Big test cleanup Use constants rather than strings or magic numbers where it makes sense, remove the duplicate 'irc-privmsg' event and simply use the more general stream-PRIVMSG event everywhere, simplify room-contact-mixup significantly by removing unnecessary setup commit ea5267d4d861db008abe93a33878a6f1f669db31 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-18 14:55:21 -0600 Add a CM param for 'username' This allows clients to specify a username (that will be used by the USER command). This should fix bug #16499. commit ab827a883d49e8f5f813f2e68bcb64a864264271 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-18 14:00:13 -0600 Generate ChangeLog for tarball releases Stole the changelog-generating machinery from gabble. This also gives the maintainer-upload-release target for free as well. commit 320ec658b7d96f5b975439d26948d0a86cc88077 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-18 11:05:32 -0600 bump nano version commit ceaaab52fee088514eb79dba0bf133ee68d1e281 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-18 10:32:18 -0600 version 0.1.3 commit 510dc386b32adc28fc8309c538c083c413b9e09b Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-18 10:15:52 -0600 Fix builddir!=srcdir issues Some of the tests were not running properly in distcheck since I had forgotten a couple of EXTRA_DIST incantations and was trying to load the ssl cert/key files from the current directory rather than the src directory. The latter issue I worked around by setting an env variable for the location of the files since I really didn't want to do something like idletest.py.in to get autoconf to pre-process the python source file to get the correct srcdir location commit 4fb27c730a15b5d37ba6ce9769c71d720896af1b Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-17 23:31:03 -0600 Update the text-encode-and-split test to the new internal API I had added a 'max lenth' parameter to the function but apparently forgot to update this test. commit 9807d0f50e6752f958c1ee071aaeeb1cf536f995 Merge: 619cc9d dbdbbb9 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-17 17:02:30 -0600 Merge branch 'long-message-split' Conflicts: tests/twisted/Makefile.am commit 619cc9d78913d8f0a0d48e5e52aeb404e46884c6 Merge: 98c90f3 8cb7eba Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-17 15:24:30 -0600 Merge branch 'twisted-tests' commit 98c90f34fab760c8207ae0101b79a3f8b6dff7fc Merge: 6933765 57eff23 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-17 15:24:20 -0600 Merge branch 'invalid-nick' Conflicts: tests/twisted/Makefile.am commit 8cb7ebaddd424c08a686edf5b46f71125b3a1945 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-17 14:58:32 -0600 Fix a test crash in connect/server-quit-ignore.py This test was only failing when I ran the full test suite, not when I ran the test by itself. Running under valgrind indicated that my _force_disconnect() timeout function was attempting to use an already-freed object: ==19693== Invalid read of size 8 ==19693== at 0x52B02AC: g_type_check_instance_cast (in /usr/lib/libgobject-2.0.so.0.1800.4) ==19693== by 0x407719: _force_disconnect (idle-connection.c:438) ==19693== by 0x55042BA: (within /usr/lib/libglib-2.0.so.0.1800.4) ==19693== by 0x5503AFA: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.1800.4) ==19693== by 0x55072BC: (within /usr/lib/libglib-2.0.so.0.1800.4) ==19693== by 0x55077EC: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.1800.4) ==19693== by 0x5E0A9C5: tp_run_connection_manager (run.c:264) ==19693== by 0x406504: main (idle.c:38) ==19693== Address 0x6cd3258 is 0 bytes inside a block of size 328 free'd ==19693== at 0x4C2161F: free (vg_replace_malloc.c:323) ==19693== by 0x52B17BA: g_type_free_instance (in /usr/lib/libgobject-2.0.so.0.1800.4) ==19693== by 0x52B45C2: g_value_unset (in /usr/lib/libgobject-2.0.so.0.1800.4) ==19693== by 0x52A7207: g_signal_emit_valist (in /usr/lib/libgobject-2.0.so.0.1800.4) ==19693== by 0x52A76D2: g_signal_emit (in /usr/lib/libgobject-2.0.so.0.1800.4) ==19693== by 0x4076F5: _finish_shutdown_idle_func (idle-connection.c:430) ==19693== by 0x5503AFA: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.1800.4) ==19693== by 0x55072BC: (within /usr/lib/libglib-2.0.so.0.1800.4) ==19693== by 0x55077EC: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.1800.4) ==19693== by 0x5E0A9C5: tp_run_connection_manager (run.c:264) ==19693== by 0x406504: main (idle.c:38) GLib-GObject-WARNING **: invalid unclassed pointer in cast to `IdleConnection' aborting... Cancelling the timeout when shutting down the connection seems to fix it. Now all tests pass again \o/ commit 7ccb8c5ddc04ecaaec12b5a85ccc7a0d828269a9 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-16 22:16:29 -0600 Fix a small leak reported by valgrind Valgrind report was: ==24778== 240 bytes in 2 blocks are definitely lost in loss record 22 of 33 ==24778== at 0x4C2291E: malloc (vg_replace_malloc.c:207) ==24778== by 0x550C272: g_malloc (in /usr/lib/libglib-2.0.so.0.1800.4) ==24778== by 0x5539314: g_io_channel_unix_new (in /usr/lib/libglib-2.0.so.0.1800.4) ==24778== by 0x4100E5: ssl_do_connect (idle-ssl-server-connection.c:480) ==24778== by 0x4101E6: ssl_dns_result_cb (idle-ssl-server-connection.c:504) ==24778== by 0x41136D: _resolve_idle_func (idle-dns-resolver.c:154) ==24778== by 0x5503AFA: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.1800.4) ==24778== by 0x55072BC: (within /usr/lib/libglib-2.0.so.0.1800.4) ==24778== by 0x55077EC: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.1800.4) ==24778== by 0x5E0A9C5: tp_run_connection_manager (in /usr/lib/libtelepathy-glib.so.0.22.1) ==24778== by 0x406504: main (idle.c:38) This was observed while valgrind-ing the connect-ssl-fail.py test commit 9fcc28e7ad38f40c105aaff735b284b738e921a0 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-16 21:32:36 -0600 Fix another infinite loop on connection failure This is similar to the ssl infinite loop that was fixed earlier. I'm not sure if this was introduced in a faulty merge or if I somehow overlooked it before :/ Uncovered by the connect/connect-fail.py test commit 36348b1fae8f1ed454183aa1be93005fde64beaa Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-17 12:06:27 -0600 messages/leading-space.py: simplify this test significantly wjt questioned the need for the subclassed server in his review and eliminating the server actually makes things much simpler. At the same time, I realized that there's really no need for the user to join a chat room in order to test out this behavior, so remove that whole piece and just send a privmsg directly and test whether it is parsed correctly. commit 44e4d1f6e6373213a52a1f5c01b86fa7fe3bdadb Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-17 11:19:44 -0600 Rework join-muc-channel.py test to not depend on object path Yes, this is much much cleaner. Also cleaned it up a lot by using constants from constants.py commit 01fd11cb43fc8890bd3eba69c639a7eeba268dae Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-17 10:53:27 -0600 message-order test: use loop to make this a bit cleaner commit 44ec4723a51a3d9aa9fe0ccb8530a1c91522f147 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-16 22:57:42 -0600 Disconnect in idletest in case the test fails and doesn't disconnect This theoretically should prevent a failing test to affect the following tests Also remove a stray mention of gabble. Findings from wjt's review commit fccb2e9f055b0a539174b4e7f425f1beb93d6442 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-16 22:53:14 -0600 Reduce test chatter when not in verbose mode I was print()ing a lot of things in my BaseIRCServer class, which was cluttering up the test output and making it hard to easily glance and see the results. Modified so that it only prints out when in verbose mode. commit c3649eaad00b88b487d491ce119d65ebcfb01627 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-16 22:39:42 -0600 Add the constants.py file from gabble Use the constants in a few tests commit 57eff2309968c8ac6157194d5183bf384e823db5 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 23:52:16 -0600 Clean up some connections in invalid-nick test Also assert that the dbus exception is the correct one. Changes per wjt's review. commit dbdbbb96349443a48e741f07d175808899bc343f Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 23:20:35 -0600 Assume worst-case relay prefix before we get user info Finding from wjt's review. I wasn't able to find a max limit on userlength, but the 3 IRC servers that I tested (freenode, gimpnet, and ircd-hybrid on localhost as shipped by debian) all had limits between 8-10 characters. I added a little padding and made username worst-case 18 chars. commit 6933765064960d84c71747873851393ed88f4c9b Merge: ad2a004 d471f42 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 19:39:19 -0600 Merge branch 'room-contact-mixup' commit ad2a004f8aa490f756708c42b0d8b1f1759584c1 Merge: fda6247 4a64d98 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 19:37:25 -0600 Merge branch 'gimpnet-quit' Conflicts: src/idle-server-connection.c commit fda62472258ddbb0cb512de5958763ada028e5d1 Merge: 39ee883 ae92668 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 17:38:49 -0600 Merge branch 'leakfix' commit 39ee883cfe3ede415fee8f4ae87636cc2024053c Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-22 11:29:25 -0600 Add documentation for IRC message spec If you haven't worked with it in a little while, it can be a little challenging to remember what the different characters mean for the IRC message spec. This just adds a small comment describing each of the format letters so that it's easier to add new IRC message types in the future. commit efe60c1b62ebf41c2c2f0336d7b5322454744a92 Merge: 18a3cd1 492c891 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 17:31:52 -0600 Merge branch 'fd-double-close' Conflicts: src/idle-ssl-server-connection.c commit 18a3cd12be7976cb00123537b2575d572feedf61 Merge: 7730041 40fa184 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 17:30:24 -0600 Merge branch 'ssl-infinite-loop' commit d471f42675222cce620a219b36791e7f0e69bb5f Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-28 11:27:19 -0600 Re-work the room-contact-mixup test with alban's suggestions use a signal handler on the dbus signal to set a global flag and assert that the flag is false at the end rather than waiting for a signal we don't want to get. I tested that this still failed without the patch and passes after, and it makes the test a bit cleaner (and runs faster). commit a88b5955d95ba5ed1fa7cd23b574883c5a017543 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-27 17:24:59 -0600 Fix Bug #19766: private messages no longer delivered to group chat This could perhaps be a slightly controversial change. The reason that the bug happened was that telepathy-idle's room handle repository normalizer function had some special code to make joining chatrooms more user-friendly. Basically, if the user specified a chatroom 'foo', it would assume you meant '#foo' and automatically prepend the '#' character. The way the parser currently works is that when we get in a privmsg, we try to parse the 'destination' of the privmsg as both a contact and a room. The way we determine if it's a valid room or not is by calling tp_handle_ensure(room_repo, ...) (and same for determining valid contacts). Unfortunately, because of the automatic #-prepending this means that a single privmsg destination can be both a valid contact and a valid channel name, so if the user is in a channel with the same name as their nick (but without the leading #), the privmsg will be handled by both the IMFactory and the MUCFactory commit 919ee9b1448430737f89056209280947ec5ade72 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-27 17:23:12 -0600 Add test for Bug #19766: private messages deliver to group chat This test currently fails because the user joins a channel with the same name as the user, and when a remote contact sends a private message to the user it gets signalled as 'Received' on both the private chat channel and the group chat channel commit 155488bc72498bb1c2acf78cd4a001836e21e54b Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 16:05:51 -0600 Split long messages properly (Bug #17392) Use the newly-added idle_connection_get_max_message_length() API to split long messages so that they allow for the server to add a prefix onto the messages that it relays to others instead of simply using 512 as the max message length I had to modify the test a bit to get it to behave like a real IRC server, but now the test passes fine, and I did quite a bit of manual testing (copy/pasting large chunks of test between two accounts) and have not seen any issues yet. Part of my manual testing included copy/pasting large amounts of unicode text from various wikipedia articles in other languages, so I believe that the utf-8 splitting issue is also fixed properly in this branch. commit 5edc8f54cafe32ac1daf37a9c940ee81b2ce92f8 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 15:20:43 -0600 Store our user host prefix to calculate max msg length After logging in, query information about ourselves so that we know what prefix string will be tacked onto the beginning of our messages by the server when they are relayed on to other users. This will allow us to calculate our max message length properly. This patch also adds a new API method idle_connection_get_max_message_length() that allows others to query this information without knowing anything about the actual host / prefix string. commit c573b2b2cfffd13062dee546a150798ec4356cb3 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-02-13 13:54:36 -0600 Don't split a utf-8 codepoint in half when splitting long message Basic approach: find the place we would normally break the message, and walk back to the previous utf-8 character start. commit 2c8cce859dafdd85d409010c505883a6c24da8a7 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-30 15:47:40 -0600 Add a test for improper splitting of long messages (Bug #17392) See the bug for details, but essentially, telepathy-idle will internally split long messages (those above the IRC max length of 512) and send them in multiple messages. The problem is that the server then has to relay them on to the other members of the channel, and when it does this, it adds a ':nick!server.name here ' prefix onto the message. So if our message was exactly 512 bytes, when this prefix gets added, it needs to chop some of the message off the end to fit under the 512-char limit. It does so silently, unfortunately. So we'll need to either limit our max messages to a value considerably lower than 512 to leave room for the server to add their prefix or we'll need to figure out a way to calculate very closely what the prefix is going to be (for the longest possible nickname) commit dfb5b76c455830428d6481e6318b184a456c2b46 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-30 14:51:37 -0600 Validate nicks per the IRC RFC Previously we were allowing the nick to consist of any unicode alpha or digit characters, but the IRC spec (RFC2812 section 2.3.1) is very explicit about which characters are valid for a nick, and it's only ascii chars. In addition, we weren't disallowing '-' as the first character of a nickname as required by the IRC spec. Added a few additional tests for valid and invalid nicks commit 00ead0bb95daa75de7be57f555f5fa5f05371cb3 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-30 13:45:25 -0600 Expose the nick validation function and use it in the CM Add a filter for the 'account' param of the RequestConnection method so that it can check if the passed nickname is valid for an IRC nick and reject it if not. Previously, telepathy-idle happily accepted invalid nicknames and then didn't provide any decent feedback about what was wrong when the 'login' failed. commit ac268e98767da9a2e4d10155fa612cb5b55bb8ef Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-30 13:43:56 -0600 Add test for invalid nicknames telepathy-idle should not blindly accept invalid nicknames -- it should do a validity check on them and reject them if they're not valid IRC nicks. This test does that. Fix will come soon. commit 6ed3fe28674529814ced37aec1005ccd60846758 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-29 15:19:22 -0600 Advertise the Requests interface, add test Borrow a test from gabble for Requests.CreateChannel and modify it to fit idle. This is just a very cursory test fo the Requests interface. commit 6d197ed30d0f4fb17d316be966206782cbbfe1e3 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-29 12:24:27 -0600 Speed up the tests a bit When I was figuring out the test framework and trying to get things to work, I had bumped up the time out on a bunch of tests to 10s rather than the default 5. This means that a timeout failure takes a lot longer to happen and there's really no need for a full 10s timeout. Also, when testing that messages are sent in the right order, there's no need to send 10 messages, so cut a few of them. Since there's a built-in 2s delay between each sent message, that means the test was always taking *at least* 20s to execute. commit 6ba4f0740bd069e6925dca7cea6e1b465ffc3b42 Author: Jonathon Jongsma <jjongsma@gnome.org> Date: 2009-01-05 15:12:36 -0600 Implement the TpExportableChannel interface To complete the switch from TpChannelFactory to TpChannelManager, the IdleIMChannel and IdleMUCChannel classes must implement the TpExportableChannel interface. This implementation is highly influenced by the Salut implementation commit c90f550bd7840179f78278cb6d36bc63670afed6 Author: Jonathon Jongsma <jjongsma@gnome.org> Date: 2009-01-05 13:40:58 -0600 First pass at porting IdleMUCFactory to IdleMUCManager commit 027f8d666388ddcdb47e99ebed448a519074db04 Author: Jonathon Jongsma <jjongsma@gnome.org> Date: 2009-01-03 14:43:01 -0600 Initial transition from IdleIMFactory to IdleIMManager using new TpChannelManager interface instead of old TpChannelFactory interface commit 4a64d982e41406d7ca738a8025d70566ca7cbbf8 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-27 14:52:21 -0600 Handle buggy servers that don't quit properly This fix kills 2 related bugs at once (and thus fixes both of the tests that I just added on this branch). 1. It disables receiving further messages after we send our QUIT message, so that we don't process a stray "welcome" message and accidentally try to transition to CONNECTED state while we're in the middle of disconnecting. 2. Schedules a forceful server disconnection for 2s after we send our QUIT message in the case that the remote server does not close the socket. This means that we send the dbus method return for Disconnect() at most 2s after receiving it, rather than depending on the remote server to disconnect us before we send the dbus method return. I suppose I could have just disconnected immediately rather than scheduling it for 2s in the future, but I wanted to stay as close to current behavior as possible. commit 438f8edc058ae17998c443c80e01892658eb93fb Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-27 13:52:08 -0600 Add a couple tests for slightly buggy server behavior gimpnet IRC server has a bug where if you QUIT while it's waiting for an ident response (at 'login'), it will totally ignore the QUIT message and go on to send you a welcome message. I've added a test which approximates this behavior. In addition, if you send quit behavior, but the remote server doesn't close the socket, telepathy-idle will never actually quit (or even respond to the Disconnect() dbus method, in fact). So I've added a test for this case. I think we should probably unilaterally close the connection and exit after a certain time if the server is misbehaving in one of these ways commit a6e409abbcd7591e7fd8689b17f1b0074cbad624 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-27 12:11:58 -0600 Make the test server respond to QUIT messages properly Previously I was just closing the connection immediately upon receiving a QUIT message, but I should have been sending an ERROR response and then closing the connection. commit ae926684ebf091e3ecc4dd29761563bb30c5fc14 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-26 15:15:23 -0600 Free a bunch more memory leaks reported by valgrind Many telepathy signals take GPtrArrays of specialized dbus-glib boxed types. The basic pattern for all of these leaks is the same: - create a GValue for the specialized dbus type - call g_value_take_boxed(foo, specialized-dbus-type); - dbus_g_type_struct_set(...) /* set struct props */ - g_ptr_array_add(array, g_value_get_boxed()) - emit tp signal - free ptr array The problem is that even though the pointer array of the boxed types are freed, the boxed types themselves are not properly freed. So you need to go through the list and call g_boxed_free on all of the array elements before freeing the array (or call g_value_unset() after you're done with the ptr array, which will result in the boxed type being freed by the GValue since it was initialized with take_boxed()). In addition, there was a somewhat related/intertwined bug in the topic handlers: - in idle_muc_channel_topic_touch(), where we were calling g_value_get_boxed() and adding it to the GPtrArray, then modifying the GValue, calling g_value_get_boxed(), and adding that to the array again. The intent was to add two different objects to the array, but since we were not copying the boxed type (e.g. g_value_dup_boxed()), the result was that we were adding a pointer to a boxed type in the array, modifying the object and then adding it again, so we ended up with two identical boxed type objects in the array rather than two different objects. I'm not entirely sure what effect this bug had on things, but it should be fixed now regardless. - in idle_muc_channel_topic_full(), we had the same problem as above, but in addition, the 'subject' property was never actually added to the ptr array, so I added this call. commit 10edb283b49d35863cb2345b3fe308ba5ad40180 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-26 10:15:48 -0600 Fix a leak in change_tp_properties() We were leaking all GValue* objects that we got with dbus_g_type_struct_get() every time we called change_tp_properties(). This valgrind error is representative of the leaks: ==2405== 1,348 (280 direct, 1,068 indirect) bytes in 14 blocks are definitely lost in loss record 5 of 15 ==2405== at 0x4023DE2: calloc (vg_replace_malloc.c:397) ==2405== by 0x4389479: g_malloc0 (gmem.c:151) ==2405== by 0x43060A1: value_copy (gboxed.c:94) ==2405== by 0x43069CE: boxed_proxy_lcopy_value (gboxed.c:362) ==2405== by 0x42B08C5: dbus_g_type_struct_get (dbus-gtype-specialized.c:978) ==2405== by 0x805D1EC: change_tp_properties (idle-muc-channel.c:526) ==2405== by 0x805F39D: idle_muc_channel_topic (idle-muc-channel.c:1222) ==2405== by 0x8053969: _numeric_topic_handler (idle-muc-factory.c:184) ==2405== by 0x8055F5D: _parse_and_forward_one (idle-parser.c:399) ==2405== by 0x8055BC7: _parse_message (idle-parser.c:321) ==2405== by 0x8055694: idle_parser_receive (idle-parser.c:214) ==2405== by 0x804EFF6: sconn_received_cb (idle-connection.c:656) After this commit, this particular error message no longer appears, though there is one additional leak that I need to chase down yet. commit 8c87b6e3b219d720038420201382b1b66ab7e789 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-19 16:14:02 -0600 Handle connect()s that return success immediately The documentation on connect() is cryptic about in what situations a non-blocking socket can connect immediately, but in theory it is possible. I had several test failures caused by violating the assumption that the return status from connect() is always -1 on a non-blocking socket. These turned out to be caused by attempting to connect a UDP socket (which apparently is instantaneous even on non-blocking sockets), but it seems wise to handle this case more gracefully anyway, rather than simply asserting. commit 7730041cb68402b8eadafc57d767cf8626638a00 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-19 15:48:41 -0600 Only try to connect to the IRC server over TCP Previously we were not specifying any socket type in our getaddrinfo call, so our address results included both TCP and UDP candidates. When connecting to the TCP one failed, it would try the UDP one, which would lead to some unexpected behavior (for instance, connect() on a UDP socket with O_NONBLOCK set will return 0 rather than -1/EINPROGRESS, which violates some assumptions in the code). If the UDP socket did manage to get connected, it would violate other assumptions (for instance, setting the TCP_NODELAY option doesn't make sense on a non-TCP socket and triggers a warning). So, it doesn't really make sense to connect to a IRC server with UDP anyway, so this patch restricts telepathy-idle to use TCP sockets only commit 40fa1847606e4176432e2177a55a87934450a16b Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-19 15:45:47 -0600 Fix an infinite loop in the SslServerConnection class This failure was triggered by the connect-fail-ssl test. When a ssl connection fails, it just retries the exact same address over an over in an infinite loop. It doesn't move on to the next address as it should. commit fbd509b4e34f0e96fbd2a87e18fbecfdfedaef70 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-19 15:44:48 -0600 Add a little explanation to the connect-fail-ssl test commit d0e9f8ddcb99f3d7b848be81c08ed1594b90b760 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-19 11:39:53 -0600 Add regression test for leading-space messages There was a long-standing bug in telepathy-idle where a received message that had a leading space was not parsed correctly and was dropped silently. This bug has recently been fixed, and this is simply a regression test for it. commit e2f80415081972431eed901679896d0576d99844 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-16 22:30:28 -0600 Add a regression test for messages delivered in proper order There was a bug where messages that were queued in the same message timeout (currently 2s) were not delivered in the order they were received. This bug has been fixed, but I thought it would be useful to add a regression test for it. commit 94d765abc6474d7ec5bd2727b26e420f6518a4c8 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-16 22:07:11 -0600 Add a very basic test for joining an IRC channel I'm not sure whether this test really has a lot of value, but it essentially documents the current behavior commit 480d3cea4b59e8191c4116d12b71abfdafb5101c Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-16 17:16:40 -0600 call Disconnect() asynchronously to prevent false test failures previously, the -success and the -success-ssl tests were failing because they didn't get a dbus method return from the Disconnect() method. I thought that this was a problem with idle not returning the response, but it turns out it was caused by the fact that the test called Disconnect() synchronously. So while the test was waiting for the dbus return, the QUIT handler could not run, so the connection was not getting closed. Apparently idle waits for the connection to be closed before sending the dbus method return. When I change the Disconnect() call to be async, the test irc client is allowed to run and the tests now pass. commit 3fd18659d75157412def057df227e61f4b7aaa6d Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-15 14:23:39 -0600 Ignore a bunch of testing logs commit 507bf2998e7c8b3cbabf5e1254d24926c07af92c Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-15 11:01:24 -0600 Fix some more minor twisted test issues - Use expect_many() rather than expect_racy() (the latter was accidentally committed after I was playing around with it and didn't know exactly what it did). - Fix the signature of BaseIRCServer.connectionLost. - Fix some formatting (tabs vs. spaces) issues - a little more debug information to help me figure out what's going on. commit ba450846d8c0ca445ab9fc6263d70c6b2380b651 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-14 12:23:31 -0600 Add support for testing ssl connections with twisted tests Added a couple ssl connection tests that are just variations of the non-ssl connection tests and really only serve to excercise the IdleSSLServerConnection class a bit. Added a testing-only ssl cert / key just so we're able to start a ssl irc test server and test connections to it. commit d9e38485be510aafdd5cb0d870775f6c1d853cd7 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-13 11:18:50 -0600 Improvements to twisted test IRC server Now at least returns a WELCOME message if it detects a NICK and USER message is sent by the client. This allows the client to finally transition to the CONNECTED state from CONNECTING, so it's progress. The test still seems to hang when attempting to disconnect, though, I'm not sure what is causing that yet. commit e14ecf6c650b3da01f59094c4d7b74d29543d7e1 Author: Jonathon Jongsma <jjongsma@gnome.org> Date: 2009-01-12 14:45:20 -0600 Starting to add twisted test infrastructure The twisted test infrastructure was copied and modified from gabble. I'm still getting familiar with it and figuring out how things work, so it doesn't really do much yet and there are even issues with the few barebones tests I've included here. commit 492c8916e6dc4ce7ed82c3509071edd430dada99 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-14 10:15:21 -0600 Fix the fd double-close in the ssl server connection class as well As in the normal server connection class, there doesn't seem to be any need to carry the fd around in the AsyncConnectData struct or in the class priv struct since we can always retrieve it from the GIOChannel when necessary. In addition, g_io_channel_shutdown closes the fd, so there's no reason to close the fd separately. In fact, closing the fd separately will result in a glib warning about closing an invalid file descriptor if the close() is done before the channel shutdown. commit d37f1b997bb3dc8a303f6459245072bdcfd3a480 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-13 16:48:16 -0600 Fix a warning about closing an invalid file descriptor When running the new test suite for idle (not yet merged upstream), I was getting tests aborted and created core files due to a warning about closing an invalid file descriptor. The actual source of the warning I was seeing was in async_connect_data_destroy() while shutting down the IO channel. I believe this is because a few lines earlier, we close the IOChannel's file descriptor, then glib attempts to close it again in the g_io_channel_shutdown() function. We seem to be doing this many other places, but we don't always get warnings about it because often the close() call comes after the g_io_channel_shutdown() call, and we don't check the return status from close(). It seems to me that since glib will free the file descriptor for us when we shut down the IOChannel, there's not even any reason to carry around the fd separately in _AsyncConnectData (since we can always get it from the IOChannel anyway), so I removed that as well. I haven't changed similar uses in the SSL server connection yet. commit e798493ed8dc4e5d68035a3362da4e29884d9816 Author: Jonathon Jongsma <jjongsma@gnome.org> Date: 2009-01-06 11:47:54 -0600 Handle user renames in muc rooms Previously, tp_group_mixin_change_members() was called with reason NONE, so UI applications had no chance of displaying it as a rename rather than separate quit and join operations. Since idle now depends on a recent-enough tp-glib, we can use the RENAMED reason (and also, use the new set_self_handle() API in the TpGroupMixin as well) commit 022ea3809759d8b1fd92c23b2b8b4e8c1f3b0116 Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-13 11:32:17 -0600 Initialize a couple more GErrors to NULL Missed a couple uninitialized GErrors in the ssl connection class commit 307977a5ca0db466e52ed5be5b1ebcbf4799296c Author: Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> Date: 2009-01-12 16:32:21 -0600 Initialize all GError* vars to NULL We were getting some warnings about an error being set over top of an existing error, because several GError* variables were not initialized properly to NULL. commit 86ca78e69f077861a6149f5d795ddc0d0aae9503 Author: Jonathon Jongsma <jjongsma@gnome.org> Date: 2008-12-31 15:52:47 -0600 Fix parsing error on leading whitespace (bug #17390) The basic problem is as follows: There is an incoming message that looks like the following: ":jonner!n=jonner@jalfrezi.collabora.co.uk PRIVMSG #channelname : foo bar" When this message gets tokenized, we get the following tokens: - :jonner!n=jonner@jalfrezi.collabora.co.uk - PRIVMSG - #channelname - : - foo - bar When we get to parsing the chat message portion, our current token is simply ":". There is a check in the code that was meant to prevent zero-length strings from being added to the parsed arguments, but that check assumes that we'll only be adding the current token to the parsed args. In reality, we want to consume the entire remaining string (which may contain multiple tokens) and add it to args. So instead of checking that the the character immediately after the ':' is non-NULL in the strdup-ed token, we should really check that the character immediately after the ':' is non-NULL in the original message string. Bug was introduced in commit 02cf59fb7b7efebbec39422460ec13ae1e3f5c89 commit f65a516ad01362f834f93cff1f947892c2bce46c Merge: bc09457 1917b5a Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2008-09-25 18:48:40 +0100 Merge branch 'self-handle-changed' commit bc0945793cf918318538e30d46b281b1de14b4aa Author: Florian Steinel <Florian.Steinel@googlemail.com> Date: 2008-09-25 19:32:40 +0200 fix compile on 64bit arch commit 1917b5a0406c614f7b3866b7f90ca2cf4dabe83a Author: Simon McVittie <http://smcv.pseudorandom.co.uk/> Date: 2008-09-24 10:56:27 +0100 Require telepathy-glib 0.7.15 (for tp_base_connection_set_self_handle) commit c1fa7702c628034af76a9c9ebbfe2818f847e069 Merge: bb058c8 5ae7920 Author: Simon McVittie <http://smcv.pseudorandom.co.uk/> Date: 2008-09-24 10:55:58 +0100 Merge commit 'wjt/self-handle-changed' into self-handle-changed Conflicts: configure.ac commit 5ae7920bb0282fa080cff5d2db6191dcdca35769 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-09-09 17:00:21 +0100 Connection: remove unused variable commit bb058c8892a91e012e002cd2e5526e85bc05e86b Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-09-01 12:50:17 +0100 Rewrite idle_text_encode_and_split to be more obviously correct. Fixes an infinite loop for ACTIONs containing newlines. commit 06123a3471a6a248604bc18e71221216b1e771e7 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-09-01 12:47:13 +0100 Add a test that over-long/newlined messages are split correctly. commit 8fae440479816222cf1375b89ea1070292ae308b Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 19:26:18 +0100 Send messages with equal priority in chronological order commit ec8d4ba71c87bab82818bafd4df6bfc5bdacb6f5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 18:27:18 +0100 Extract splitting of long/multiline messages to a function commit e7268ab6601c35939e93ab70619b76327a0e1d7f Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 18:04:44 +0100 Fixed signedness warning in a test commit 7f1faae20c5e8566519fe1e4faa5854a238e3d00 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 17:13:01 +0100 Fix another signedness warning. commit 49d014ee95dfef2d5d56c2565cdd0c2b2030b190 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 16:59:23 +0100 Correct more mismatched signednesses commit e86db64ce63408f00d5bd988545984ebac0c3c91 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 16:47:48 +0100 Don't use an invalid enum value as a failure flag commit 6d2cdaa645d0b626d719aa8edb444eddc602a7e5 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 16:42:28 +0100 Correct the order of "const static" to "static const" commit c52271ba4cf6425b0cf09f98254d35eaeccac372 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 16:41:52 +0100 Use post-0.6.1 tp_debug_set_flags() and tp_debug_set_persistent() commit 59381efdfa8e85ce688190b461159873b8f8b708 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 16:41:41 +0100 Bump telepathy-glib dependency to 0.6.1 commit 667dfdbc78652c667513ce581a76d4e6ef5570f0 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 16:08:58 +0100 Bump telepathy-glib dep to 0.7.3 for the DBusPropertiesMixin commit cefc2b085e80de168abc1e5eef3e867be96dfe5f Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 16:00:28 +0100 Change self-handle using tp_base_connection_set_self_handle commit 4121b3a3ffcb83f1ecd7797b9e764a9898846c0e Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 16:31:28 +0100 Bump automake dependency commit 4a25b1496287a2edffc77b99b78e83fbf24f2ed7 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 15:47:46 +0100 Fix a mismatched signedness warning commit 1bee98f16638f83052ade1213d656b8b87130bed Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 15:47:11 +0100 Enable -Werror and friends on development builds commit 42d9ae1c93b52f0eba9fee38c739d5e4800a734e Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 15:47:58 +0100 Make autogen.sh executable commit 9b09b52959ddfc9cab4b29f2434d09656d2516fa Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 15:46:19 +0100 Remove .git-darcs-dir files commit e2429d549a52c5f7b157688c883b69ac717975e0 Author: Will Thompson <will.thompson@collabora.co.uk> Date: 2008-08-29 15:45:54 +0100 Convert _boring to .gitignore commit 7be13f764bc647755f67e65a24709c36625d16ae Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-01 19:54:42 +0000 Use g_set_error instead of *error = g_error_new where possible to facilitate deliberately ignoring errors 20080101195442-9db4d-234ac21aaee90fe01bbcd0c1069086139c67470c.gz commit fb535cd02fb8baeeb8d0dec46dfe19ce0b87a759 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-16 16:23:19 +0000 Still more coding style unifications, now there should be quite a few less function declarations and calls with a space between the function name and the opening paren. 20080116162319-9db4d-8fe36cffc8d4ae36ce744b987a657771b32c98ed.gz commit 5f954c012af01becad485a8031985c2e2c294582 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-16 16:05:15 +0000 More coding style unifications. This time make sure all control keywords have a space between them and the opening paren. 20080116160515-9db4d-ce4b4f35a86d48a12e6c5647eabd93978a5fd081.gz commit df96afe50ac242e57e5ad2a65ec7839831f8d066 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-15 21:02:32 +0000 Make GInterface init functions conform to the same coding standard 20080115210232-9db4d-31348a0b3c340fb081133117243a61cbdc995f8f.gz commit d6884fde268175fca9afccfad0c36435be5a8bd9 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-15 20:53:29 +0000 Clean up includes 20080115205329-9db4d-6a57ff858a5ce98ae86074e81f3be814e05d6bd3.gz commit 3c20851336897e76c48a76e6681dc1d64e1c03ac Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2008-01-03 16:49:55 +0000 Cope with TpChannelIface channel-type property becoming writeable in telepathy-glib > 0.7.0, avoiding warnings when channels are constructed (fd.o #13896). If telepathy-glib is <= 0.7.0, the added code will never execute, but is harmless. 20080103164955-53eee-b66b94c229995403a3f178753326941d1bfc623f.gz commit c077f7ab1f0d49f1d958fc3a8c7bb9b0a191ccc3 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2008-01-03 16:47:12 +0000 Remove unnecessary reference to an empty variable 20080103164712-53eee-6fe5a4c7cce69a23372eb664a40efce06205ebe0.gz commit 131fe14ec1f3d6013159739b1e5007bdf96d9d94 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-12 21:06:59 +0000 Remove useless send_irc_cmd() from idle-connection.c and rename send_irc_cmd_full to _send_with_priority 20080112210659-9db4d-70b106707c5f33eb0983be516ebf3763ac699523.gz commit 5cecd8a62742c52fe94838dc30a1d27ef0b41be1 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-12 20:53:48 +0000 Coding style, part: Public functions of classes shouldn't have an underscore prefix 20080112205348-9db4d-dfcfe6f9e50d5cfda568b3c074d11b62cd44678c.gz commit aba4d48dc8944a57aadcb5309db8849614c51806 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-12 20:39:37 +0000 Remove GTK_DOC_CHECK from configure.ac, idle doesn't do gtk-doc 20080112203937-9db4d-a750e2d3b01f65f46119523d67fda7ddc6bda8e7.gz commit 0134f85f12fe36f8418488e76d78443ceec5ed5e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-12 20:38:28 +0000 Add -Wno-portability to autoreconf invocation in autogen.sh, we depend on GNU make 20080112203828-9db4d-19de5ecafe13f70ad99cbec4733b8242d73c6459.gz commit 8816b1c4afda68b47d799ce82309f393bd4bd5f4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2008-01-12 12:49:31 +0000 Add HACKING file 20080112124931-9db4d-e97cf76aa09d551c96ef7e543867ddb26aa79340.gz commit b98a43649d25ef349bb73b8934453f984dc41d9e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 22:02:08 +0000 Unify coding style, chapter Six: Binary operators and their operands should have whitespace in between 20071227220208-9db4d-2e018ea7b69ed08e7f17c909b2fa47470c4081e0.gz commit 64af22ce42221f71c19d2e13ab2df67ee09e5ac4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 21:36:51 +0000 Fix too greedy removal of cruft resulting in GValue -> GValu 20071227213651-9db4d-ac07090814d0518310802bb5e974451528c35a20.gz commit 4de1f9c04780edcaecc4247d8fda573b2254d487 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 20:33:00 +0000 Unify coding style, lesson 4: blank lines after each case body in switch statements 20071227203300-9db4d-47a1011afb9c3cd20b58f249b756744115b0b181.gz commit 60ab6f50523cca46a5d5a03211c26a49dc9173e6 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 20:28:31 +0000 Unify coding style, part 3: Return type on the same line with the function name 20071227202831-9db4d-6fc9278dde6e99383986b366dabbf982c8d4a340.gz commit af8e39e88f5541edb9f8aa5ab04bc4ef64caad95 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 20:24:21 +0000 Unify coding style, book II: Thou shalt indent by tabs, and only tabs 20071227202421-9db4d-7fb30eae03df9f5ae881719a257c90f3adcb3430.gz commit 101e2c5b2b5d11491d679e623066dd775b44bcf1 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 20:18:13 +0000 Remove tabs from places other than beginning of lines 20071227201813-9db4d-818203d16e295aa5bd678dd62cccffd76c836f17.gz commit b1bc692f0ca998950d505c3f4a503eb6899b2258 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 20:14:23 +0000 Remove trailing whitespace 20071227201423-9db4d-9747ce7d1faa02cd80ab78daeec4d2abad6af37f.gz commit c460df04d67bbfc39cca7e6bbaa4defaf56e76c2 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 20:10:31 +0000 Remove old not-in-use sofia resolver cruft 20071227201031-9db4d-a075bd3de5fed303ce61ab4431e71c0d9a22e09f.gz commit 0a81e75a123eee5fb4f49d5f9fe7d0590d3571fb Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-12-27 20:02:51 +0000 Unify coding style part 1 (mostly bracing style) 20071227200251-9db4d-5f34b917f7042957c8d441c09d09bfe35619d47f.gz commit 929901419cdf62466ffeec49232a3daf4beb9187 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-29 13:14:26 +0000 Stop checking for dbus-binding-tool - no longer needed 20071129131426-53eee-8859a0c37363c61c56ee56a6d2c4577a0c94cbb3.gz commit 39c65ddf25cf9a8551edb26c84d57528e186f1b6 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-29 13:09:08 +0000 Simplify extensions/Makefile.am now that generated GInterfaces don't need external glue 20071129130908-53eee-66c7d1b9d2d05dba1da8e83308d04569d6a7f34b.gz commit e37b57ae2cc68266d08fc7b7dc5b04317896a17d Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-29 13:08:41 +0000 Update tools from telepathy-glib: generated GInterfaces no longer need external glue 20071129130841-53eee-54a96f08127cfd5508f14a03b102ee563638853f.gz commit d8695095978882927ecf9d58301a1c6ce079f4a5 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-29 13:06:10 +0000 Add missing identity.xsl 20071129130610-53eee-6b56bd3209cb7ab359cdfc90ace747eef9b05d1d.gz commit 9279a0091cdce5b4ca05be6265aeb1120beb6e92 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-29 13:02:20 +0000 Add missing glib-signals-marshal-gen.py in tools/ 20071129130220-53eee-e98ee6ca716440ffdd4fb9168f87eba964c8de31.gz commit 06bc54d3d3a0e10e8ea482cba2a145a90be0a8c8 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-29 13:01:58 +0000 _boring: ignore test binaries 20071129130158-53eee-b1ddfc54ec9823bbb3a5571162515aaf2492577a.gz commit a6b79731b78a40d2edf8f689f29e05289783f88f Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:49:43 +0000 Remove _gen/all.xml in clean 20071123144943-53eee-ee4a67796d1eeb688ed0b5720301cf2458745acf.gz commit 0824ae1319cf55b41c0642ba1874faf85173e85d Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:47:03 +0000 Adjust extensions/Makefile.am: _gen/all.xml should mkdir _gen first 20071123144703-53eee-96fb2aa13569f40abd981b1a80c49caac586a93f.gz commit fbc95d6db68f565680274efa9fd14eee6000d60c Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:43:55 +0000 Update build system to resemble that of telepathy-glib 0.7 20071123144355-53eee-1a7f7c4dd601a2a9e18288222ecd3dda67b22f41.gz commit c866efbadc592b9f3d1f883aab2c4bf7d47f1dad Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:40:27 +0000 Check for, and use, mkdir -p or equivalent 20071123144027-53eee-0d7b50c0ec283047b8d391bc8c6c10ca446f1524.gz commit 4c2af08b47be195a57ac3bb5d9fefe531ea59812 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:17:27 +0000 Sync tools from telepathy-spec 20071123141727-53eee-42fdb5e7b9385290998ffd1c34c8e029dc63dd35.gz commit ea5b4c00414025ad3de2d4d47f23e8240db70370 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:17:21 +0000 Reference external type Contact_Handle (which is in the Tp spec) 20071123141721-53eee-4e1f305adb423a295a890cc5f7b5d3e2ca729b98.gz commit 90e3e3d1cc3cf5583841227fef0c0ecf60571958 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:12:41 +0000 Sync tools from telepathy-glib 20071123141241-53eee-1c5b2e4561b000c91190ac8237ff60243c9d266c.gz commit b2fae91d6a2acf4e7d1ac30cfa61ab529fc15f3d Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:04:02 +0000 Remove update-spec-gen-am.sh 20071123140402-53eee-f7d1a253becb25dc271274bfb389bdea68037e85.gz commit 031607bd26b6cd7b042ff26eaa0b97d3cf387164 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-23 14:01:39 +0000 Move tools directory to top level. Stop using spec-gen.am 20071123140139-53eee-56849a8ae9ca447e90b62de8d14ec6e52f03546c.gz commit c81f69f6db3db739f2c17ad9c0075e19de3c6f62 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-11-05 11:09:42 +0000 Add telepathy-idle.8 man page 20071105110942-53eee-e69976f4df1c66a993b3c7a1c177540ccdf40e51.gz commit e5ad1bc2c7c4010d96550f16ea3f7b7ec1687410 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-10-26 11:04:38 +0000 Move CM executable to $libexecdir, adjust .service accordingly 20071026110438-53eee-867b50d1ec1e62cba39f29b9208beb5e470bde53.gz commit c2d95a4b96eae6f5e692ace9f200589695cc6f6f Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-09-28 13:27:46 +0000 Set nano version 0.1.2.1 20070928132746-53eee-2d8a25cddd9dda524317cc6cf395af50e9818796.gz commit 1561825143322b711164d9c7a218f4f8850724ed Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-09-28 13:08:08 +0000 Bump version to 0.1.2 20070928130808-53eee-012656f35461e90004ccf9afbc6875b1424964ba.gz commit 6a844e340cd74d1fc52d095cf8cc765f5b42ab62 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-09-28 13:06:53 +0000 Clean up build system: don't distribute generated files, do distribute the .list they're generated from, don't put libraries in AM_LDFLAGS (use ALL_LIBS instead like Gabble does, and explicitly reference that variable) 20070928130653-53eee-cb08698e9d62e37e85055819ce138151b1cac643.gz commit 675647d764fd1b6a7d16cb3ef2a4c0ee0f75c2a4 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-09-28 13:05:45 +0000 Add OpenSSL cflags/libs when compiling tests 20070928130545-53eee-73513c89cd07cccac748e5ed15cba97986da09ed.gz commit 59006eb65a19811dcb910ef7a0eb84fd98564b04 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-09-28 13:05:16 +0000 Remove stray references to svc-unstable.h 20070928130516-53eee-f5359f52373deaefb003c72eff30aeb7f00ebe09.gz commit 5cd971ea9c10f712abd841ff44184f465f956bc4 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-09-28 12:47:13 +0000 Add a Darcs _boring file 20070928124713-53eee-bdeedd8e2add23b1a30f3f479cc637662c8ba217.gz commit e13c4d2146bf81f24e22048ed81da17a3abe1452 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-09-25 19:29:11 +0000 Hook up the locally built stubs for Renaming and use them instead of the ones in tp-glib-unstable 20070925192911-53eee-f55246e258e8a2b03262774967fae48504170a6c.gz commit cd911ed48753313a8faf0914cfc280a3379947fe Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-09-25 19:28:41 +0000 Add enough extensions-generating infrastructure to generate stubs for the Renaming interface 20070925192841-53eee-a61557a2cf97d52ca9dfb909cf2659d2ff9a165c.gz commit b9d946038a2420aab9d1669542dcdd1fc8dd42f6 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-06-12 16:25:18 +0000 Bump version to 0.1.1 20070612162518-9db4d-80ed5bb04e21a2cbb5997ab3c2689cbe8a6841c6.gz commit fe9d1cbdef86631a17dcb2ce74f439554d6152ec Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-06-04 11:14:39 +0000 Change IdleMUCChannels's join-ready marshaller to the correct one, should fix fdo #11121 20070604111439-9db4d-acb369a8d884fbf6be948b6442c960ed27d196d3.gz commit 1f323438e60f919153ab5b9dc8fcee0318fcb087 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-06-04 10:59:52 +0000 Check that the channels hash table actually exists before doing anything with it. Should fix fdo #11122 20070604105952-9db4d-d33c41ee81929eb2874a44acaa0f6e6147c28f7f.gz commit 6fdc69c1f6b84baeb1e69218f493826d8a6790f0 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-05-10 10:12:23 +0000 Assume IRC channels with no prefix mean channels with prefix # 20070510101223-9db4d-a50c3ddec233076d28fd9bce763f4d1e5ee59281.gz commit 53cd5666bd2bdaca0badb4d5ce746e04765c2a46 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-05-01 13:02:53 +0000 Remove stale _nick_handler prototype from idle-im-factory.c 20070501130253-9db4d-f7818347b3059072f408c0f4c0be67fb745dee50.gz commit b19f346d2cafe0f2c5a6f45a817cb98bb7f6cef8 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-05-01 12:06:49 +0000 Remove the bogus reasons from MembersChanged signals in IdleMUCChannel 20070501120649-9db4d-abcff2d1c55a47486bc2a36bfcf3f381c5d40227.gz commit a19b8cba196ea11fc199a73a80720d2e4e2883c6 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-30 14:00:13 +0000 Make SetAliases on your self handle work like RequestRename 20070430140013-9db4d-e3bc6fda90a529f06bdad8c732efbe40e2a2c5e7.gz commit d15f70efdc25ae1df48a9d9b6fa7e680a8e6bfc0 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 18:46:16 +0000 Change IdleMUCChannel's namereply aggregation set to TpHandleSet, we need refs to the handles 20070427184616-9db4d-a2bf49801dcdae76e94089d38e0147fa6fd09622.gz commit 53b29a1f2437a24397f6a46cdbc555b712ae769c Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 18:15:27 +0000 Dispose of queued AliasesChanged crack in idle_connection_dispose 20070427181527-9db4d-e6482abae289a74bbf636e9f68788367eaac9f36.gz commit fe6198da9761d622e3fcd88e8dc21df02f92df0e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 17:45:45 +0000 Now that the trigger points are in place, remove emit_queued_aliases_changed from queue_aliases_change in IdleConnection 20070427174545-9db4d-25815e9123b68aafa264f2dcf59993783a46a740.gz commit 64190a03257a0f30ef89d3c49a452357738e879f Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 17:42:24 +0000 Add queued AliasChanged emission to IdleMUCFactory's TOPICSTAMP handler 20070427174224-9db4d-932370e094dccdc72851e2b5902948b79d4af11f.gz commit 5d26721928c3f26a2e421258de95dca39464b2e7 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 17:17:26 +0000 Trigger emitting queued AliasesChanged in IdleConnection's NICK handler 20070427171726-9db4d-16d18ef5181418c3a73fa70d8103605640940dc1.gz commit ac2a49b042f28195da02f82757e25264dab49c37 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 14:30:54 +0000 Add queued AliasesChanged emission trigger in IdleMUCFactory's INVITE handler 20070427143054-9db4d-f12d56800a37b50dd434db223ffdc0147a9cf426.gz commit e2944ef6771203868679ddf92ff72cb8b1bbf3d4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 14:29:36 +0000 Add queued AliasesChanged emission trigger in IdleMUCFactory's JOIN handler 20070427142936-9db4d-d4491ba974c6f46586495c9b47738e2af1a62638.gz commit 7ec3f6dd05372a9329d90202f800b6ee38602015 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 14:27:19 +0000 Add trigger point for emitting AliasesChanged in IdleIMFactory's incoming PRIVMSG/NOTICE handler 20070427142719-9db4d-21a752e3c831cf09604d0b5fe3876a9490f2ac5b.gz commit c72a17684768f37110a73cd988bb61e20964ccd1 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-27 14:20:53 +0000 Aggregate MUCChannel NAMEREPLY MembersChanged signals with IRC RPL_ENDOFNAMES 20070427142053-9db4d-0856f145deaf715730a6f1170649e7648df0470c.gz commit a9d9af5868546f799fe38e16f15e192aee3a2fef Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-26 18:12:32 +0000 Utilize Connection.Interface.Aliasing for representing IRC nicks in their correct case 20070426181232-9db4d-14bd84fba2a43c58f2f0cb400051249e9babdec8.gz commit f37d5de9ebe37b755624ba932a1b22b53962dcab Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-26 17:39:49 +0000 Parse prefixcmds as prefixcmds and non-prefix as such, no mixing up crack 20070426173949-9db4d-1b8d022936474e377d77cc3f69504fa482620f92.gz commit d7ee9b1fdbed575cd159324ce2eefb6f5fbe644f Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-26 10:14:11 +0000 Remove old declarations from idle-connection.h 20070426101411-9db4d-5e00ca95b72c66b177cca3c3e1159a270d45e8fa.gz commit b4fae14eba9f1ddb2888a5752bf158d23f5e5909 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-26 09:57:46 +0000 Restyle idle-handles.[ch] 20070426095746-9db4d-ab40051022f1632a4fcf45d693e9954c92ea4471.gz commit 067ed02b89ecd2506b6de597df67acaeb874a829 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-26 08:59:41 +0000 Forward-declare IdleConnection properly 20070426085941-9db4d-b5182302525f2671ffc25edd8fcb6d186d8a03f7.gz commit 53f6fd7f67661307a61649615b2f5c971395324f Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-05-01 11:29:41 +0000 Use blingbling killer for NOTICE messages as well 20070501112941-9db4d-41a22442ce7b0a04f72770a0de71b1bb6cab3fff.gz commit 84c041c1d23ab37c151100b20fe379e3f4b12400 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-05-01 11:29:23 +0000 Use the blingbling killer in idle_text_decode 20070501112923-9db4d-4c216211000b296687dfb5fab579528d635e8b83.gz commit a2769e39a160412a08a7a6d1020e66b66ba0792f Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-05-01 11:20:28 +0000 Add idle_ctcp_kill_blingbling for removal of mIRC & co formatting tokens 20070501112028-9db4d-9bd10a6ead7027f0ceb78d2072862572978b0279.gz commit c042b96cbd636f9e927dd3aba2898a5428983ea4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-05-01 11:17:01 +0000 Add minimal test for idle_ctcp_kill_blingbling 20070501111701-9db4d-7c0d921bfc5795eef541443157bfdfada0faf1a3.gz commit 4c7b85bda4b14db875193c53bf68e32fc35b1f21 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-05-01 09:55:47 +0000 Proper escaping in _ctcp_send 20070501095547-9db4d-994e8b7c13c8df19bb3ad0254b15ccc7d5ab485c.gz commit 4163528a91b8eb9c2a4a692db8dc99e522344293 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-30 14:26:18 +0000 Use check_programs instead of nst_programs for the tests 20070430142618-9db4d-f30d8bb12f9af221fac50b4b37059816d51e8ff2.gz commit b1faee39e9cba4d4f4eda0b30967ca837904e562 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-30 14:24:13 +0000 Make test-ctcp-tokenize return 1 on failure 20070430142413-9db4d-2f076672218ebde01d4134b3eca22c8556e7652f.gz commit de74238fdc5cf00ca82fbb592fb106f64128c14a Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-30 12:59:48 +0000 Add test for CTCP tokenizer 20070430125948-9db4d-d7e14e47b75573ed1c012f375f693904ce7620ac.gz commit 94de5297c307f1ec57f6b26832634fe8da8ee83a Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-30 12:59:36 +0000 Add CTCP decoding/tokenizing function 20070430125936-9db4d-f1f0b70e9ee12bffd2e620498c4ff8ba0cbe30cd.gz commit ba52bef303a4cd685d598e841174e3d9ff0fac7a Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-28 12:10:55 +0000 Add utility functions for sending CTCP messages 20070428121055-9db4d-eec2e9281a0a913ef2778fb175fa32aed0b0469a.gz commit f2c602af02474ecb294639e97ba227738e2fdb49 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-28 11:59:18 +0000 Use the CTCP helpers for sending VERSION replies 20070428115918-9db4d-0157677ecc9979de09aaea078bdf33c384308b19.gz commit d6e63999b2ff796dfb70efcac432e096cb75d319 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-26 18:41:53 +0000 In conformance to the latest spec semantics, don't do anything for IM channels on rename 20070426184153-9db4d-aaa730bde444a84c7da2f44f9f3076233aade397.gz commit 15f2e020abd89e15d0ca676f7cbdf6e31a923cf4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-26 18:12:02 +0000 Check for old_handle == new_handle in NICK handlers 20070426181202-9db4d-0bd093bfaaa551e0113005e3a1ef4207ff91ea22.gz commit 7bfbbb381972dd3aa178bae670e5c3b94fa2a2cd Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-24 13:32:06 +0000 Handle NICK in IdleIMFactory by creating a new channel for the new handle if we had one for the old handle 20070424133206-9db4d-389cbb67aad03780e702ec5bfb69074127272902.gz commit 8029da63fc6b37e61ff66c1276cf8cf78db24d15 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-24 13:19:50 +0000 Change the group mixin's self handle in _idle_muc_channeL_rename 20070424131950-9db4d-5b002988ad9c99383e553786aed40885bb19e39d.gz commit c4706bd87e05c93bfa9db9df4f13dcf1028bac3f Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-24 13:07:47 +0000 Move emitting Renamed back to IdleConnection's _nick_handler, but attach it with IDLE_PARSER_HANDLER_PRIORITY_FIRST 20070424130747-9db4d-8e4c6b0c813d1b7e047db359683671d87ee6db42.gz commit fd3cc3f1f6819d3e50aecaa9c06c8d45d56af3a6 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-24 12:54:29 +0000 Rename IdleParser's _data_compare_func to be consistent with naming conventions 20070424125429-9db4d-c1b251885e93e7ce7889fd9d619d20737a18a62f.gz commit 2001f649bb46386bf5e8971f9922e75c6d9845cf Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-24 12:53:03 +0000 Add priority to IdleParser message handlers for guaranteed ordering 20070424125303-9db4d-24017917f32c5874166d44b2e43ae45ebc4be919.gz commit 6f876cb0169a53263063ac0782224610055ad547 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-24 11:08:17 +0000 Remove cracky _idle_im_channel_rename 20070424110817-9db4d-ed0f87450c864b4a17861deb2620c6db5bcf3f2b.gz commit dd68c2873debf430451d0fdb669e68eb04d3bcc1 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-24 10:27:15 +0000 Rename text.[ch] to idle-text.[ch] (how incredibly clever to do it in this branch) 20070424102715-9db4d-eb7d543b6c6b0253dfe1708649b46643df7dcfe5.gz commit 90f2a126471ef72313c22deee7d8e8d6648df7d5 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 14:02:04 +0000 Second attempt: use TpHandleSet to keep track of handles reffed while parsing 20070423140204-9db4d-c9f3bfb2bbacb1be7ca2da0d82bf0ccf3a2d3958.gz commit 643a55a3598c5271292628f62fee1fc57d978a15 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 13:08:16 +0000 IDLE_DEBUG in text.c 20070423130816-9db4d-00bdb9dd8563c0ffe65a3e1db6de2c3d9a26860b.gz commit 7e6c4442977a56c3cdabaf0405124deb19003ac5 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 13:07:33 +0000 IDLE_DEBUG in IdleSSLServerConnection 20070423130733-9db4d-4b7ac7d3e5c58a20103bb2fc74c92c93c0f8f6af.gz commit 1ddac0365b0d222985b60673a6ae25c70b5d1775 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 13:06:31 +0000 IDLE_DEBUG in IdleServerConnection 20070423130631-9db4d-b9583f5ef0a8785231fcea56fc87c152f416cfa7.gz commit 453874caeda98e3d227da3d23b7726ec6b149766 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 13:04:49 +0000 IDLE_DEBUG in IdleParser 20070423130449-9db4d-4d5510c945ba861d80de983d75cc08cd64999501.gz commit 198b055df84140840c9c1324562eda86e43d3fcf Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 12:58:58 +0000 Remove debug statements from the unused sofia DNS code to not bugger my greps 20070423125858-9db4d-eabc8e1fb8058b4ae69a416dd0b1aa6697fc7f61.gz commit 1ad54d8b5818157a9f81029dc5097d808211b421 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 12:55:57 +0000 IDLE_DEBUG in IdleMUCChannel 20070423125557-9db4d-7966be562ab4c695d8df5290a5320d0399f2bce4.gz commit 5c7b4ebea7d27bff18b6df2b377f6cb7c1e36b33 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 12:41:00 +0000 IDLE_DEBUG in IdleIMChannel 20070423124100-9db4d-bcaa9c040b8155dfe0986a0991d09060360f4d42.gz commit b42d3bab6569f1696af90537cd11ac2096852b22 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 12:30:54 +0000 IDLE_DEBUG in IdleDNSResolver 20070423123054-9db4d-ba6e5d14327dca879908907b7c091133323db27c.gz commit 53deafda8f9206568295b0d79af1f08caf2c0aba Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 12:20:53 +0000 IDLE_DEBUG in IdleConnection 20070423122053-9db4d-da95fc1915b8813c0a254b1a4978c3b80cd856eb.gz commit 374d32c613fbdcbda3dbb0cb26873523bd54c77d Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 12:14:45 +0000 Make it possible to switch debug flags mid-file 20070423121445-9db4d-615a1838d56d336a618cb97e3093659c58b41157.gz commit 04a6dac114b8ccc9e2b4defc8d06e67fd261b245 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 12:14:31 +0000 Change the debug flag names to be consistent with Gabble 20070423121431-9db4d-e17f4fbf8eca6fa3c834d10bbe896090fef36330.gz commit 256aa73ef472603e21d668954edbb554a79132bd Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-23 11:53:44 +0000 Add Gabble-style debug subsystem (no debug flags used in Idle yet though) 20070423115344-9db4d-84ef684d4383d76051e95989bc631bf4d7504c66.gz commit 90a614364274e9c8011f4fe3ce3b9b78c929285a Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-20 13:53:58 +0000 Plug leaking all incoming messages after charset conversion 20070420135358-9db4d-cef4f691e64da9bbf8e9c066e56ff0c3a996cf0e.gz commit 51226c462ea0919d2c646d630bc94ba12815f5e9 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-20 13:23:18 +0000 Change the reffed handle sets in IdleParser to GSLists instead of TpIntSet, the same handle may be reffed multiple times 20070420132318-9db4d-e94127ac9695434884eb57df0fd18f44bbf8819e.gz commit 0aff110177125fe07023e3c5b0aed29f106a7abb Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-20 11:58:24 +0000 Don't duplicate the default connection parameters in IdleConnection 20070420115824-9db4d-1f35a034b4e42ddd8471793896c0e69ebf2e1063.gz commit 1da1f9b7874cc09996793602bfb589a723b29c92 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-04-19 18:53:11 +0000 Use svc-unstable.h for the Renaming interface - it's not in the shared library as of telepathy-glib 0.5.10 20070419185311-53eee-c3cf8e36a79ddcff230db7df3c670a15ff10c316.gz commit e2fcf87d0a9f84def0d1628b036c0ed0a8762fd0 Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-04-18 16:55:09 +0000 Build against telepathy-glib-unstable static library if telepathy-glib is newer than 0.5.9, to get the Renaming interface 20070418165509-53eee-c9ec0efa1fb27e051d78e8140bd3c162c3d69b02.gz commit 9a4be9ecf6f0cfaec1e0b66c5d1945382f9c430c Author: Simon McVittie <simon.mcvittie@collabora.co.uk> Date: 2007-04-18 16:53:51 +0000 Adapt to telepathy-glib >= 0.5.8 group mixin API 20070418165351-53eee-41ec6d06437033e3e5c497bb17bd1143d1570a8a.gz commit 089e1d656332d58811ec369fc2147194c05e95d3 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-20 10:31:24 +0000 Use run.h 20070420103124-9db4d-ab6879b88a63eb9b95192b1cfb035fbdbfec1848.gz commit c4c688801f262ac92dc2ae7cc44423d6ed5a925f Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-19 13:19:27 +0000 New CTCP VERSION handler 20070419131927-9db4d-1779d09a15ba7431e061334c4692538fd05d6c3e.gz commit 61cbd46e61ec5c6af08172efb7951ceacc87c400 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-19 12:28:31 +0000 Remove my stupid misinformed idle-version.h stuff 20070419122831-9db4d-fc14d370eaafdc3874383feea6b0b77c9d2f8a0c.gz commit 1d79b713ccea5b4c1d869f464d5400377cb5a40e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-19 12:27:30 +0000 Bump version to 0.1.0 20070419122730-9db4d-addf658648bd0d7c59862d3160c4bdf0afb32590.gz commit 395b0da92cce585b76bd67c18e20cdc86c0831bd Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-19 11:59:01 +0000 Remove unused _idle_muc_channel_has_current_member 20070419115901-9db4d-18693cbef979543d5955e92d70b4ca8e116e228a.gz commit 9d8bc7af83f41b81cb7cc45495c6fc4e18a46ca4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-19 11:57:07 +0000 Remove superfluous GetHandleOwners implementation from IdleMUCChannel 20070419115707-9db4d-807b5f250f9e7f7816aa176e9ecb60df3c6bae20.gz commit bfa337f06d57477c7d0c2919773a662ab485000c Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-16 20:47:23 +0000 New MODE/MODEREPLY handler 20070416204723-9db4d-99c1f1c5774bdd57bafa47e25bc19bc2bca691ab.gz commit 90bc13a7f4aaf9bdfa022fe23058c81d0a25d5bd Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-13 15:44:57 +0000 Remove MUC rename handler junk from #if 0 20070413154457-9db4d-a06b09e279feda5b2ae7957cc1a0f77d3f9bc604.gz commit e71e2018342999ed908e14316f3b5e1744a88ccd Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-13 15:42:50 +0000 New NICK handler. The MUC factory now emits Renamed even for the connection's self handle so that however the handlers are connected, Renamed always precedes MembersChanged on MUC channels the handle is a member on. 20070413154250-9db4d-663c03f5a2ab1978726ca9ac8da4208f42e97379.gz commit 9295694c16efd5f1a1c2d6cbf9c8616b3becb57e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 21:16:40 +0000 Remove the stupid and needlessly braindead copy of the connection's self handle from IdleMUCChannel 20070412211640-9db4d-d43c845fe91801ea98156119006d17759b6e5ece.gz commit 0b15c47b25f8f357552bba7e7e7778b39ef3e8f3 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 21:07:47 +0000 New TOPIC prefixcmd handler 20070412210747-9db4d-78b4a1744238fb4a78dd16659023ecca164837bc.gz commit 0795a1fff5be0ae3d5313cb6061650cd6a919660 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 19:55:27 +0000 New TOPIC_STAMP handler 20070412195527-9db4d-5bb34ebb2b212fd5c36a4ab129b60687e294f510.gz commit acac21dde1b20ada34bac03bbddb8c814aac88fa Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 19:38:14 +0000 New KICK handler 20070412193814-9db4d-ed4d04bc0bf72199a64a96f2db656b22b4f34034.gz commit 8662f5518c12f32e5e50b247aa3b88b06efde827 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 19:13:33 +0000 New handler for the TOPIC numeric 20070412191333-9db4d-0952d81bd99091fd810c129fe54a6620a4d37ec9.gz commit 4b1fb31d3372fc06ccc42aa04ad2a67b244f53d0 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 18:23:48 +0000 New QUIT handler for MUC 20070412182348-9db4d-3d9b6ab856e87ef0e01e2003b7dc4dc9abd75b86.gz commit e53736fc28a9c95dfb6d9992563d0ff8768bf3f4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 17:38:04 +0000 Remove some more replaced stuff from the if 0'd "todo list" section 20070412173804-9db4d-340ef5b4faf9aa9600dac6ca7d161ab8e7b6d0e8.gz commit 8f36eb2be65739c952996a7712342ef770b830ba Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 17:25:34 +0000 New INVITE handler 20070412172534-9db4d-af2f1d4420c4a2f1fdc09475572bfa55b3ab4e03.gz commit 33f949ea8db7d4aee8380bc18b3c203cd9936e18 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 16:38:47 +0000 Fix IdleParser cutting continuation lines one char short 20070412163847-9db4d-45d62a82768a50109a663adce1aaaff8b1b68d73.gz commit 170b957a4d87ec1d279035189ec20dfcc378932c Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 14:54:13 +0000 Add numeric channel join error handlers and remove the old ones from the if 0 part 20070412145413-9db4d-c5c94dcc56d911edf073c6e49d4d427776bc38d6.gz commit a77e59a60d467aad0cd4fbf9f024938d9ab25420 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 12:21:54 +0000 Remove the old namereply handler from the if 0'd part now that we have a new one 20070412122154-9db4d-9f7cc181b8a1c096e19446d43403094453dcb5bf.gz commit 6d3b1d6ca98d5a724ea1c20227b78da8cd5059a4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-12 11:58:02 +0000 Add new NAMEREPLY handler 20070412115802-9db4d-cdff138e5fab10ad84d3f0834d5894a8765484a0.gz commit bd9d6470b4254402d12c2301de68c04f702cd382 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 21:27:36 +0000 Set modechar '\0' for channel members with no modechar on RPL_NAMEREPLY so that we have at least some modechar for all members in the arg array 20070411212736-9db4d-3a0fa3cfa2af68113b7ab644dcbe147c8c6aa95f.gz commit 25f3935e89706c6586214e69905aa78f17365600 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 21:26:51 +0000 Fix tokenizing of lines with trailing whitespace sent by borken ircd 20070411212651-9db4d-cd1599519e10eac9430833762b0c951d1acc70da.gz commit 943374e8e052f616813564f5c6480e641ae47be5 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 19:09:21 +0000 Add IdleMUCFactory and update IdleMUCChannel for rudimentary MUC support 20070411190921-9db4d-963037ddc197acd17e4535539a916d57bd170b3b.gz commit 02cf59fb7b7efebbec39422460ec13ae1e3f5c89 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 18:44:10 +0000 Don't add zero-length strings to args while parsing 20070411184410-9db4d-5f56753f3d11b592c32be38da3340d2e32089598.gz commit 6b2457a5cca14b47b69bdaa66664a287f63125a2 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 14:10:41 +0000 Make IdleMUCChannel compile with the new Connection and handles related stuff and readd it to Makefile.am (a lot of it will change eventually though) 20070411141041-9db4d-242f601ba90597b18bc906055468a015e2fcb1c0.gz commit 26a0e913e9292f9b2829633fa8d0d1caa10df6bd Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 13:01:53 +0000 Because nothing is generated anymore, remove the generate/ junk 20070411130153-9db4d-d8c0fb0e2c3f743a2aaeaa057a07a7a0db9d47ba.gz commit 669c1508df64716aa598d0e0fb5b16746d44a8c2 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 12:59:23 +0000 Use TpBaseConnectionManager for IdleConnectionManager 20070411125923-9db4d-6de001a0ef2e86b4ef8db09e16d41a52ccf8166c.gz commit 89a77651232b9cb7bde363e5c76cf55f9404b097 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 13:21:24 +0000 Change the license header copyright statements also in .h files, which I stupidly overlooked :D 20070411132124-9db4d-f4cc2d395302fcd5435f2e2ee01ab6855b4bc5f9.gz commit a316e6cfbd6b410f007ee0aa44f64b89f453ed54 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-10 21:49:15 +0000 Fix the license header copyright statements in all .c files 20070410214915-9db4d-1fcb3dcb0f4873f0fba7ec08f32b32a110463dd3.gz commit fab56665781a954ffb3d3a8dcbfc4840b838570e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-11 10:23:42 +0000 Include sys/types.h and netdb.h with __USE_POSIX to get the addrinfo funcs even with C99 on 20070411102342-9db4d-8aba96244dfbb2da433b2f21994bc00c5e51ac3d.gz commit 0c54079424d097145879c671b956456f2d230a70 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-10 22:26:29 +0000 Make RequestRename work 20070410222629-9db4d-145b10619336db956be4f22cd019d16c6a019382.gz commit f7b027cd1efaa93c2a227d4e03ea736e7684ea55 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-10 21:26:47 +0000 Use TpBaseConnection in IdleConnection (with no MUC factory, we temporarily lose MUC though) 20070410212647-9db4d-797a9f937dd925a75ffc5e7c1f4c73e703e599ea.gz commit f4073990800ea7d7bc256c1661577380c81c85e0 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-07 07:21:13 +0000 Use C99 20070407072113-9db4d-db35bc7abf92de1d89def14cf1e2374750a9d8b4.gz commit 259e34fa5aa97d55f48f25e8b2d45216a8635828 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-05 18:05:31 +0000 Remove the TOTAL CRACKALL implementation of Presence 20070405180531-9db4d-a38a8379863a578a13288c31cf62518761ab47d1.gz commit ac9084f75e502815ce05bb39593df88cd27d79ea Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-05 17:36:16 +0000 Add IdleIMFactory 20070405173616-9db4d-de445179606d56237e9f4faaa51a8bc34e31aed4.gz commit 6c1a17603d684152a4c6c34a7d78db9f8bb58dad Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-04 13:43:10 +0000 Make object_path public in IdleConnection 20070404134310-9db4d-db739c7ea1a31c24f098a471bfd825cb1321458f.gz commit 63cef52eccac3bd057ca4d299a5cab1c846f37ea Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-01 10:45:02 +0000 Make the parser public in IdleConnection 20070401104502-9db4d-8faa6ede54f4aede19184f32e36f8d8b50ec56f9.gz commit 744c51c0cc3ca75b594f0fcec1587e7fcddc4cf7 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-01 00:27:12 +0000 Add handler for IDLE_PARSER_NUMERIC_WELCOME 20070401002712-9db4d-e24230c986374bd2e0ec53e03f5fa405c73c80ba.gz commit 8ccbb19080c193aa611fd77a4580e5ecb69422f3 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-31 23:35:17 +0000 Add handlers for IDLE_PARSER_NUMERIC_{ERRONEOUSNICKNAME,NICKNAMEINUSE} 20070331233517-9db4d-97781976ee60eff21e295c6adc8045918ed4ff70.gz commit 8fb24c79263755130a5890e0f00730ebe8820af4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-31 19:18:59 +0000 Add _ping_handler, the first IdleParserMessageHandler, and remove cmd_parse from IdleConnection 20070331191859-9db4d-a5fa60f9e9d83c370965a2a5f0249c07f7bbcead.gz commit f7055562d68397aef0077f0804dd960fbb46e1a8 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-01 00:34:30 +0000 Fix the "fixed" pending_msg_compare to preserve FIFOness of the output queue 20070401003430-9db4d-f0cc5b4c9524f6d0ea7f56c559729649c557d010.gz commit 0e000ee16e384c76d09df4d6fb54c1fa799209c4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-31 22:44:40 +0000 For not being braindead out loud, put the message formats to the MessageSpec structs 20070331224440-9db4d-9e1a22c8b5be63f920095884aa733a8e4dd7779d.gz commit 4675a1ba1c270b0fdd003f99e6a60dfb8e869a16 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-31 19:24:46 +0000 Do g_slice_free instead of g_free for MessageHandlerClosures in idle_parser_finalize 20070331192446-9db4d-e614f7a00acfbd898b51506298f84e552bcbdb7d.gz commit b45f6bd4ad20bf0a082095d7c0bc1dde400cec0e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-31 18:46:18 +0000 Add actual parsing to IdleParser, it now seems to parse stuff correctly 20070331184618-9db4d-266d19b78932da09df53b3b21dc8b9d8ee328e7e.gz commit 788cc118e89ae5bcdcba81c534f60df9438bd2e2 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-29 20:04:08 +0000 Add IRC message format strings to IdleParser (whew, reading those RFCs sure is slow) 20070329200408-9db4d-3644eec4bac4a1b327ea3bd70accedca3a2535c2.gz commit 7b0bcf849a037418ab3b7b6ba1b347cb52361017 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-29 17:51:14 +0000 Add message handlers to IdleParser (no actual parsing yet though) 20070329175114-9db4d-5cf0a4e5b14a3473069b23eb1207ddf7a83c2646.gz commit 5a1f46211ddcd022172284ab7a073eae79285616 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-29 17:00:10 +0000 Actually add idle_parser.[ch] 20070329170010-9db4d-ab6a1e805efc9505ddf684fb0f1e9b5ea5497356.gz commit 04f1bb6884c051b7327af7caf89c59f775e2bfa3 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-29 14:20:26 +0000 Start building up the new non-crappy parser, starting with msg_split 20070329142026-9db4d-b0b277996d110ba07253e1eb971b7b900598128d.gz commit cd904ef5deb69e1778c8e8fbea0d52ecb4875249 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-29 11:04:57 +0000 Only set original ID qdata if the id was valid 20070329110457-9db4d-3b2383fb5f7978a015c2ef8f03ba212466d7dda1.gz commit d00bb0905874463251a2e81779f541de6e8fa81a Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-29 10:08:02 +0000 Only set error in the normalization callbacks if error was provided 20070329100802-9db4d-14c99284f6798e076ac351561bc6eeccac09d951.gz commit cbbdc79e2a71afee0e025597e21532bc75fd870d Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-28 15:26:24 +0000 add TELEPATHY_LIBS to telepathy_idle_LDADD to link properly against the static cmlib 20070328152624-9db4d-1795fdfe9fcec21b4062e42acfc3c6904fec9615.gz commit 2e0657f3f84ade2e24e6327e27befa983d5c8875 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-28 15:21:36 +0000 Port to new handle repo API 20070328152136-9db4d-4b0c241a38a6cab149f9af00bd5b243f39644048.gz commit 05b15bd32a8d3253e99f92307f18b28ded44ac7d Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-22 17:25:41 +0000 Don't set idle_contact_presence_free for null ContactPresences - may prevent a segfault 20070322172541-9db4d-8257aef413ac2393f9b8c034fd8d46af70efbbef.gz commit 8e7e524e5eed6a7db99280997f6d38ba1c85d869 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-22 17:34:54 +0000 Make IdleConnection use TpSvcConnectionInterfaceRenaming 20070322173454-9db4d-878711115effad0525ebbb89abf4d793de58716f.gz commit 6c75a40a6d5c2083919d37f772b65d59890ddfa7 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-22 16:39:47 +0000 Drop the nowadays extraneous param to tp_text_mixin_init 20070322163947-9db4d-741eefb2051916270e5abf2c2cd5eceff89dcfb6.gz commit 1f4c1e3954d64a82f2d390d37dcd720403b803ec Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-22 15:53:31 +0000 Merge RPL_WELCOME renaming 20070322155331-9db4d-fc88a7341656b4e8847a54c3690ee566b36647d7.gz commit 62e07ecd6fa91bf04539bac89201353cd4e13a8e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 20:19:06 +0000 Make IdleMUCChannel use TpGroupMixin and TpSvcChannelInterfaceGroup 20070319201906-9db4d-36515ca229f6a3dc7360dd03b8463d35a87169a2.gz commit 83954ad2109f4d822355e93d09d03d9b8bd17f3d Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 12:32:36 +0000 Make IdleMUCChannel use TpSvcPropertiesInterface 20070319123236-9db4d-e167e5886a2a17bd126bf186931a50c4188b2bdd.gz commit 78d77aa05bbaa72f23ca8fe317a7f20dc557b8f8 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 12:32:08 +0000 Do tp_svc_channel_return_from_close in idle_muc_channel_close 20070319123208-9db4d-fa0cb315d3a4a9685058b7146e6386ad77de43c1.gz commit 67ba24e4ae01f709a2dfd7691528880cb623a046 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 06:50:31 +0000 Make IdleMUCChannel use TpSvcChannelInterfacePassword 20070319065031-9db4d-36fb1d9db921279c0df0867e76d71d878ad1e876.gz commit 561ae9505ff530f76129bee27d7a49167b9cfad4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 06:37:38 +0000 Include svc-channel.h directly from Idle{IM,MUC}Channel 20070319063738-9db4d-5798f1c9722cf31f396f6f88cd12dbda3c281669.gz commit aa562367eb949e4ff83d4e2b7206a4cb5db3fe12 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 06:28:31 +0000 Make IdleMUCChannel use the channel interface 20070319062831-9db4d-c25b549cd267b1b798ec0f244baa02526644e46a.gz commit af878a89f3041c979ed4c6e5dd7861670a05463a Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 05:56:17 +0000 Remove now non-existant text channel type stuff from idle-muc-channel.h 20070319055617-9db4d-e17403103372ed4b028ff98ccf31c929e1cd0fe2.gz commit 0f458301eba46a9a6726afd220df83955ef7f425 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 05:46:47 +0000 Remove unused variable from idle_text_send 20070319054647-9db4d-05b54b2025157334fa86e8c76509e578ebf7a551.gz commit c829d85567ee914fa41fd7542e9a36e68d990293 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-19 05:46:23 +0000 Remove redundant DBUS_API_SUBJECT_TO_CHANGE 20070319054623-9db4d-d6775e0444eddae0f1f71da58230459c8f6cd20c.gz commit 010ac1568b5c43f91140d5e52687159a53b62574 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-15 18:27:41 +0000 Make IdleIMChannel use TpSvcChannel and ChannelIface 20070315182741-9db4d-ee62ab47ffc1d769a6caa724f8cc08327e18a19e.gz commit cfbf3b5afdd5961929dc6ba39e3524e69b52bdb9 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-15 17:12:37 +0000 Make IdleMUCChannel use TpTextMixin 20070315171237-9db4d-4082c00805601eb5934d1c278853b3c44259b358.gz commit 54650650764e359abda686aec1a0704f8ea9aa8c Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-15 17:12:07 +0000 do tp_text_mixin_class_init in idle_im_channel_class_init, though due to redundancy in telepathy-glib it'd work withouth 20070315171207-9db4d-dcf649efa4245e325e6804044d7083dec99e814a.gz commit c0825128b651d0471616d94a7acbd4146ee7af37 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-12 08:38:12 +0000 Finalize the TpTextMixin in idle_im_channel_finalize() 20070312083812-9db4d-cf9a5edec1aefa41c89b890b9a6cc9fe49453b73.gz commit b8d4aa47ae122c0bbc13c2c0e7a7f698785856f7 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-12 08:26:24 +0000 Move the message send implementation of IdleIMChannel to text.[ch], soon to be used by both IdleIMChannel and IdleMUCChannel 20070312082624-9db4d-e0626e71da6782778ae2abe1c7c734e198915a06.gz commit 2c1dc5d66ce024212f73d1e0e68f482c33cfff6a Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-12 07:58:32 +0000 Make IdleIMChannel use TpTextMixin 20070312075832-9db4d-161d0e11ae959fda398bcf0febfb04954df213a5.gz commit e865e660350ae6162a65242d9f3caab685f22c3f Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-02-04 23:30:29 +0000 Plug dbus_g_method_get_sender memory leaks 20070204233029-9db4d-3f5d46999e8f66254fb90c0b9d3d10291c88faee.gz commit 846e9bb531ba210c9aca15f57dae89edcd6e1d04 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-02-04 23:22:14 +0000 Migrate to telepathy-glib HoldHandles/ReleaseHandles 20070204232214-9db4d-0dba3dc8ffd92db1d9d7f86166eb294d8cc1c795.gz commit 5a6fd3d9c9932c839232d1268586f04bc562f0af Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-02-04 23:21:47 +0000 Remove idle-handles-private.h from Makefile.am, since it is history 20070204232147-9db4d-786b7d0af7c1ce51df930f5f6acedcc470ecb0e5.gz commit 7980b19cad03351a5ce659cf3137e06e1db7460c Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-02-04 22:50:14 +0000 Remove some dead code from IdleMUCChannel 20070204225014-9db4d-749ff31fc15f5cd1da748d0841a72536556c8d36.gz commit 9e7e082ca9dbd96b957e56ac7539c71971cf70c0 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-02-04 22:37:14 +0000 Remove some more dead code from IdleConnection 20070204223714-9db4d-33dd074e3880531e0e2022025eb39743cc0c0cb4.gz commit 24c105919db0e9865a7aa8b304f789df1ce9d168 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-02-04 22:30:35 +0000 Migrate to the handle repos and sets in telepathy-glib 20070204223035-9db4d-eb01a394b0a783b0647d11c1a33d4dc8d15e1c7a.gz commit 559e01e2c8e978fce73ef98556fd0b5fdff09975 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 22:42:28 +0000 Migrate to the DBus helpers in telepathy-glib 20070131224228-9db4d-f1f3ec8bca9fd840de59726147797dd2ceecf092.gz commit 39ae94843e3a1ca64404d1b8b9d93d6f5cf1d315 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 22:41:17 +0000 Remove some totally dead and dried up vintage code 20070131224117-9db4d-967a4bc0fa6d9e13bb8fd09d893bf9f7b5c2a1f8.gz commit ef9c9793f47d1afae380d71c058f0a969290d7a4 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 22:33:19 +0000 Migrate to telepathy-glib Telepathy error definitions 20070131223319-9db4d-bef2d99f66ed9e6cc241c3bf9ce5d1c8b443b328.gz commit 1dfa412e373fcc3dcc1bb98a9fef305c1ee02319 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 22:13:55 +0000 Remove stale crap from CORE_SOURCES 20070131221355-9db4d-6d62c58c6c35e78f1b8436fd3305f9365be0e0e5.gz commit 1ebf83ae5cc7e97cc0262bba481b10fedc8adec1 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 22:08:41 +0000 Migrate to the telepathy interface name constants in telepathy-glib 20070131220841-9db4d-e84362b548774a50a531537c90c964a5a0e3f95d.gz commit 486bbf3270127441c94fe97bc23d4264de77d336 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 21:55:42 +0000 Migrate from local copy of the telepathy constants to telepathy-glib/enums.h 20070131215542-9db4d-826ca31b6697d67fc994fa9fbfc811a19f27bdcd.gz commit 8c7b81219052e8b15f474fc49710f82712135899 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 21:20:13 +0000 Migrate from G(IntSet,Heap) to the versions in telepathy-glib 20070131212013-9db4d-99121c1bfd2ddc080836012d11bfde0710ee811b.gz commit f9485c420e63ed152f2305f9b6aff59b5a01b685 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 21:18:43 +0000 Add telepathy-glib to include and link 20070131211843-9db4d-77ccf79046a7fc578d91aae8378ced8b9c553087.gz commit b4bcc969dcea01e1f2fde4b7ada8ef7c195f9e02 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-04-01 00:35:11 +0000 Only send PASS if the password has length > 0 and send it with higher priority 20070401003511-9db4d-a2509586959892cd1cbd45ecb646bfc274f50213.gz commit d13f90ea458f51c3906521cc83b2bb407a288be1 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-22 15:42:20 +0000 Disable clipping the nickname to 9 chars and instead let the IRC server canon it 20070322154220-9db4d-bf5ebd5ba71e4254eb306c0f861bd1790bb5feb0.gz commit 0ea399e0e5d8018e26c4a6183de5227bfdf3baeb Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-03-22 14:29:51 +0000 Create new MUCChannel on JOIN for an unknown channel to work with irssi-proxy 20070322142951-9db4d-45d9c2ed8fd05cf083db20f5ce1e03e65bdb7fa8.gz commit 2a14a432d9751b6a7a8aacfb823a5387d5bef48c Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-02-04 22:53:11 +0000 Get rid of the advertisement default of IRC realname and get it from (in decreasing priority) 1) the user 2) g_get_realname 3) chosen IRC nickname 20070204225311-9db4d-dd45f0e95707e106db8d10f0ca267f32ed1e2b10.gz commit 32f4d65e1628a8ba89b8891b712ef18fbe862e86 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 14:57:20 +0000 Bump version to 0.0.5 20070131145720-9db4d-650a763e85856e9605906bb209301f56e4820647.gz commit e1b80d8c41aab7bb1ce61b7c28fec3dea655df0e Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 14:49:01 +0000 Change some checks to not abort the whole process when connect() obscurily fails 20070131144901-9db4d-2405bc0ea21613aedce174f5c801de4d8f283d1c.gz commit c848146268825bdc0e8e9091c9c477485972f21a Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-31 14:37:22 +0000 Defer freeing the addrinfo linked list to when the client calls idle_dns_result_destroy() 20070131143722-9db4d-edb35f1c390f891c7b8df273acdf7fd7051c4ca2.gz commit 7a897b917168505139de0c726e96663e2c7ed977 Author: Olli Salli <olli.salli@collabora.co.uk> Date: 2007-01-29 15:47:36 +0000 Initial import (migration from SF.net SVN) 20070129154736-9db4d-be80727a61507e6581870228122d0d2a7c12995e.gz commit 36e7ba52d4397763aca609c368bc6f2472b644a1 Author: git-darcs-import <> Date: 1970-01-01 00:00:00 +0000 New empty repository
Generated by dwww version 1.15 on Fri Jun 21 07:36:11 CEST 2024.